svn commit: r341224 - stable/12/stand/libsa

Author: tsoome Date: Thu Nov 29 12:12:42 2018 New Revision: 341224 URL: https://svnweb.freebsd.org/changeset/base/341224 Log: MFC r339651,339992-339993,340026 libsa: re-send ACK for older data packets in tftp libsa: tftp should not read past file end libsa: tftp should use calloc

svn commit: r340240 - head/stand/common

Author: tsoome Date: Wed Nov 7 21:36:52 2018 New Revision: 340240 URL: https://svnweb.freebsd.org/changeset/base/340240 Log: loader: ptable_open() check for ptable_cd9660read result is wrong The ptable_*read() functions return NULL on read errors (and partition table closed as an side

svn commit: r340215 - in head/stand: common i386/libi386

Author: tsoome Date: Wed Nov 7 11:14:22 2018 New Revision: 340215 URL: https://svnweb.freebsd.org/changeset/base/340215 Log: loader: always set media size from partition. The disk access is validated by using partition table definitions, therefore we have no need for if statements, just

svn commit: r340049 - head/stand/i386/libi386

Author: tsoome Date: Fri Nov 2 11:41:58 2018 New Revision: 340049 URL: https://svnweb.freebsd.org/changeset/base/340049 Log: loader: biosdisk should check if the media is present The bd_print/bd_open/bd_strategy need to make sure the device does have media, before getting into

svn commit: r340047 - head/stand/i386/loader

Author: tsoome Date: Fri Nov 2 09:47:18 2018 New Revision: 340047 URL: https://svnweb.freebsd.org/changeset/base/340047 Log: loader: do not probe floppy devices for zfs The subject is telling it all. Modified: head/stand/i386/loader/main.c Modified: head/stand/i386/loader/main.c

svn commit: r340026 - head/stand/libsa

Author: tsoome Date: Thu Nov 1 22:13:18 2018 New Revision: 340026 URL: https://svnweb.freebsd.org/changeset/base/340026 Log: libsa: cstyle cleanup tftp.c No functinal changes intended. Modified: head/stand/libsa/tftp.c Modified: head/stand/libsa/tftp.c

svn commit: r339993 - head/stand/libsa

Author: tsoome Date: Thu Nov 1 13:29:55 2018 New Revision: 339993 URL: https://svnweb.freebsd.org/changeset/base/339993 Log: libsa: tftp should use calloc instead of malloc() memset(), use calloc(). Modified: head/stand/libsa/tftp.c Modified: head/stand/libsa/tftp.c

svn commit: r339992 - head/stand/libsa

Author: tsoome Date: Thu Nov 1 13:12:05 2018 New Revision: 339992 URL: https://svnweb.freebsd.org/changeset/base/339992 Log: libsa: tftp should not read past file end When we have the file size via tsize option, use it to make sure we will not attempt to read past file end. Modified:

Re: svn commit: r339959 - head/stand/i386/libi386

I forgot to note imp, sorry… rgds, toomas > On 31 Oct 2018, at 18:42, Toomas Soome wrote: > > Author: tsoome > Date: Wed Oct 31 16:42:40 2018 > New Revision: 339959 > URL: https://svnweb.freebsd.org/changeset/base/339959 > > Log: > loader: issue edd probe bef

svn commit: r339959 - head/stand/i386/libi386

Author: tsoome Date: Wed Oct 31 16:42:40 2018 New Revision: 339959 URL: https://svnweb.freebsd.org/changeset/base/339959 Log: loader: issue edd probe before legacy ah=08 and detect no media while probing for drives, use int13 extended info before standard one and provide workaround for

Re: svn commit: r339673 - head/stand/libsa

> On 24 Oct 2018, at 02:11, Konstantin Belousov wrote: > > Author: kib > Date: Tue Oct 23 23:11:38 2018 > New Revision: 339673 > URL: https://svnweb.freebsd.org/changeset/base/339673 > > Log: > Fix stand/ build after r339671. > > ffs_subr.c requires calculate_crc32c() from libkern.

svn commit: r339658 - head/stand/i386/libi386

Author: tsoome Date: Tue Oct 23 14:44:32 2018 New Revision: 339658 URL: https://svnweb.freebsd.org/changeset/base/339658 Log: loader: biosdisk interface should be able to cope with 4k sectors The 4kn support in current bios specific biosdisk.c is broken, as the code is only implementing

svn commit: r339651 - head/stand/libsa

Author: tsoome Date: Tue Oct 23 13:38:39 2018 New Revision: 339651 URL: https://svnweb.freebsd.org/changeset/base/339651 Log: libsa: re-send ACK for older data packets in tftp In current tftp code we drop out-of-order packets; however, we should play nice and re-send ACK for older data

svn commit: r339334 - head/stand/efi/loader

Author: tsoome Date: Fri Oct 12 16:24:49 2018 New Revision: 339334 URL: https://svnweb.freebsd.org/changeset/base/339334 Log: loader.efi: add poweroff command Add poweroff command to make life a bit easier. Reviewed by: imp, allanjude Approved by: re (kib) Differential Revision:

svn commit: r338540 - head/stand/libsa

Author: tsoome Date: Sun Sep 9 06:30:15 2018 New Revision: 338540 URL: https://svnweb.freebsd.org/changeset/base/338540 Log: libsa: validate tftp_makereq() after we did reset the read The name check referred in the comment is not the only possible error source, we need to validate the

svn commit: r338535 - head/stand/libsa

Author: tsoome Date: Sat Sep 8 19:17:22 2018 New Revision: 338535 URL: https://svnweb.freebsd.org/changeset/base/338535 Log: libsa: memory leak in tftp_open() tftpfile is allocated just above and needs to be freed. Reviewed by: imp Approved by: re (kib) Differential Revision:

svn commit: r338188 - head/stand/i386/loader

Author: tsoome Date: Wed Aug 22 10:04:42 2018 New Revision: 338188 URL: https://svnweb.freebsd.org/changeset/base/338188 Log: loader: bios loader should allow to chain load a file The current chain command does accept only device, allow also a file to be used, such as /boot/pmbr or

Re: svn commit: r337878 - head/stand/i386/libi386

> On 16 Aug 2018, at 16:03, Warner Losh wrote: > > > > On Thu, Aug 16, 2018 at 1:10 AM, Toomas Soome <mailto:tso...@me.com>> wrote: > > > > On 16 Aug 2018, at 09:59, John Baldwin wrote: > > > > On 8/15/18 11:59 PM, Warner Losh wrote:

svn commit: r337891 - head/stand/i386/libi386

Author: tsoome Date: Thu Aug 16 07:13:36 2018 New Revision: 337891 URL: https://svnweb.freebsd.org/changeset/base/337891 Log: libi386: bd_io_workaround() is to be called for reads only bd_io() can perform either reads or writes, we only need bd_io_workaround() for reads. Modified:

Re: svn commit: r337878 - head/stand/i386/libi386

> On 16 Aug 2018, at 09:59, John Baldwin wrote: > > On 8/15/18 11:59 PM, Warner Losh wrote: >> >> >> On Wed, Aug 15, 2018 at 4:28 PM, Ian Lepore > <mailto:i...@freebsd.org>> wrote: >> >>On Wed, 2018-08-15 at 22:25 +, Toomas Soome w

svn commit: r337890 - head/stand/i386/libi386

Author: tsoome Date: Thu Aug 16 06:50:53 2018 New Revision: 337890 URL: https://svnweb.freebsd.org/changeset/base/337890 Log: libi386: small style updates in biosdisk Use break instead of return in for loop, as done earlier. Insert and remove some blank lines. No functional changes

svn commit: r337881 - head/stand/i386/libi386

Author: tsoome Date: Wed Aug 15 22:40:09 2018 New Revision: 337881 URL: https://svnweb.freebsd.org/changeset/base/337881 Log: libi386: use BD_RD and BR_WR constants Use BD_RD and BD_WR instead of 0 and 1. Reported by: ian Modified: head/stand/i386/libi386/biosdisk.c Modified:

svn commit: r337878 - head/stand/i386/libi386

Author: tsoome Date: Wed Aug 15 22:25:05 2018 New Revision: 337878 URL: https://svnweb.freebsd.org/changeset/base/337878 Log: libi386: remove bd_read() and bd_write() wrappers Those wroappers are nice, but do not really add much value. Modified: head/stand/i386/libi386/biosdisk.c

svn commit: r337874 - head/stand/libsa/zfs

Author: tsoome Date: Wed Aug 15 21:38:06 2018 New Revision: 337874 URL: https://svnweb.freebsd.org/changeset/base/337874 Log: libsa: zfs_probe() needs to set spa to NULL Silence the warning about possibly uninitialized use of spa. Modified: head/stand/libsa/zfs/zfs.c Modified:

svn commit: r337872 - head/stand/i386/libi386

Author: tsoome Date: Wed Aug 15 21:21:16 2018 New Revision: 337872 URL: https://svnweb.freebsd.org/changeset/base/337872 Log: libi386: remove BD_SUPPORT_FRAGS BD_SUPPORT_FRAGS is preprocessor knob to allow partial reads in bioscd/biosdisk level. However, we already have support for

svn commit: r337833 - head/sys/fs/cd9660

Author: tsoome Date: Wed Aug 15 06:42:31 2018 New Revision: 337833 URL: https://svnweb.freebsd.org/changeset/base/337833 Log: cd9660 pointer sign issues and missing __packed attribute The isonum_* functions are defined to take unsigend char* as an argument, but the structure fields are

svn commit: r337413 - head/stand/libsa

Author: tsoome Date: Tue Aug 7 10:53:51 2018 New Revision: 337413 URL: https://svnweb.freebsd.org/changeset/base/337413 Log: libsa: gzipfs.c converts pointers to integer types with different sign Signed versus unsigned char. Modified: head/stand/libsa/gzipfs.c Modified:

svn commit: r337412 - head/stand/libsa

Author: tsoome Date: Tue Aug 7 10:48:36 2018 New Revision: 337412 URL: https://svnweb.freebsd.org/changeset/base/337412 Log: libsa: dos_checksum() should take unsigned chars Fix pointers to integers with different sign issue. Modified: head/stand/libsa/dosfs.c Modified:

svn commit: r337356 - head/stand/i386/libi386

Author: tsoome Date: Sun Aug 5 19:17:07 2018 New Revision: 337356 URL: https://svnweb.freebsd.org/changeset/base/337356 Log: loader: bd_open() should cleanup from disk_open() error Since bd_open() does early increment for reference counter and bcache allocation, it also should undo

svn commit: r337354 - head/stand/i386/libi386

Author: tsoome Date: Sun Aug 5 18:24:35 2018 New Revision: 337354 URL: https://svnweb.freebsd.org/changeset/base/337354 Log: loader: 337353 did miss to rename 2 write instances 2 write instances got somehow missed. Modified: head/stand/i386/libi386/biosdisk.c Modified:

svn commit: r337353 - head/stand/i386/libi386

Author: tsoome Date: Sun Aug 5 18:19:40 2018 New Revision: 337353 URL: https://svnweb.freebsd.org/changeset/base/337353 Log: loader: cstyle cleanup for biosdisk.c Also switch u_int to uint32_t. Also replace "write" by "dowrite". No functional changes intended. Modified:

svn commit: r337326 - head/stand/i386/libi386

Author: tsoome Date: Sat Aug 4 20:04:40 2018 New Revision: 337326 URL: https://svnweb.freebsd.org/changeset/base/337326 Log: loader: biosdisk.c has leftover geli header. A small cleanup, remove unneeded #include. Modified: head/stand/i386/libi386/biosdisk.c Modified:

Re: svn commit: r337271 - head/stand/i386/libi386

> On 4 Aug 2018, at 11:54, Xin Li wrote: > > Hi, Cy, > > On 8/3/18 12:11, Cy Schubert wrote: >> Author: cy >> Date: Fri Aug 3 19:11:00 2018 >> New Revision: 337271 >> URL: https://svnweb.freebsd.org/changeset/base/337271 >> >> Log: >> Some drives report a geometry that is inconsisetent

Re: svn commit: r337231 - head/stand/efi/loader

un is with out of memory — at that stage (we even haven't started to probe for disks, so we do not have even interpreter) it basically means loader.efi failure. rgds, toomas > > On Fri, Aug 3, 2018 at 1:59 AM, Toomas Soome <mailto:tso...@freebsd.org>> wrote: > Author: tso

svn commit: r337231 - head/stand/efi/loader

Author: tsoome Date: Fri Aug 3 07:59:29 2018 New Revision: 337231 URL: https://svnweb.freebsd.org/changeset/base/337231 Log: loader.efi: clean up misleading noise from missing block devices If there are no block devices, there is no need to printout error (ENOENT). In case of

svn commit: r337131 - head/stand/efi/loader

Author: tsoome Date: Thu Aug 2 12:43:40 2018 New Revision: 337131 URL: https://svnweb.freebsd.org/changeset/base/337131 Log: loader.efi: efipart_inithandles() failure should not prevent devsw initialization The efipart_inithandles() can return error code when there are no block devices,

svn commit: r337065 - head/stand/libsa

Author: tsoome Date: Thu Aug 2 06:22:10 2018 New Revision: 337065 URL: https://svnweb.freebsd.org/changeset/base/337065 Log: libsa: dereferencing type-punned pointer in cd9660 The warning is given by gcc build, but it is good to fix anyhow. use bcopy instead of direct assignment.

svn commit: r337039 - head/stand/libsa

Author: tsoome Date: Wed Aug 1 12:14:10 2018 New Revision: 337039 URL: https://svnweb.freebsd.org/changeset/base/337039 Log: libsa: assignment to char * from u_char * Cast to char * instead of u_char * Modified: head/stand/libsa/nfs.c Modified: head/stand/libsa/nfs.c

svn commit: r337038 - head/stand/libsa

Author: tsoome Date: Wed Aug 1 12:06:39 2018 New Revision: 337038 URL: https://svnweb.freebsd.org/changeset/base/337038 Log: libsa: bootp is using pointers with different sign Just change bp_file to char and same for variable s. Modified: head/stand/libsa/bootp.c

svn commit: r337037 - head/stand/libsa

Author: tsoome Date: Wed Aug 1 11:40:52 2018 New Revision: 337037 URL: https://svnweb.freebsd.org/changeset/base/337037 Log: libsa: pointer differs in signedness A small cleanup, fix the argument type and while there, replace (char *)0 with NULL. Modified: head/stand/libsa/net.c

Re: svn commit: r336532 - in head/stand: . common i386 i386/loader i386/zfsboot i386/zfsloader sparc64 sparc64/loader sparc64/zfsloader

> On 20 Jul 2018, at 11:00, Andriy Gapon wrote: > > On 20/07/2018 08:17, Warner Losh wrote: >> Provide a symbolic link from zfsloader >> to loader so people who have not upgraded their boot blocks are not >> affected > > I am not sure that ZFS boot blocks can handle symbolic links... > I

svn commit: r336274 - head/lib/libc/regex

Author: tsoome Date: Sat Jul 14 09:29:45 2018 New Revision: 336274 URL: https://svnweb.freebsd.org/changeset/base/336274 Log: regex/engine.c: error: variable 'dp' set but not used The issue found with gcc6 build (originally on illumos, confirmed on FreeBSD). Mark it __unused.

Re: svn commit: r336017 - in head: include/rpcsvc lib/libutil libexec/rpc.rquotad sys/cddl/contrib/opensolaris/uts/common/fs/zfs usr.bin/quota

Hi! Unfortunately this patch is not quite correct regarding how you define the RPC interfaces. The versioning in RPC is to specify the interface, much like versioning in shared library. If you have RPC program version 1, exposing functions get_quota() and get_active_quota(), and you want to

svn commit: r335148 - head/stand/libsa

Author: tsoome Date: Thu Jun 14 16:11:50 2018 New Revision: 335148 URL: https://svnweb.freebsd.org/changeset/base/335148 Log: libsa: open() should use NULL instead of typecasted 0 Modified: head/stand/libsa/open.c Modified: head/stand/libsa/open.c

svn commit: r335127 - head/stand/libsa

Author: tsoome Date: Thu Jun 14 09:10:34 2018 New Revision: 335127 URL: https://svnweb.freebsd.org/changeset/base/335127 Log: libsa: remobe unneeded check before free() free() is checking for NULL, remove duplicate check. Modified: head/stand/libsa/close.c Modified:

svn commit: r335126 - head/stand/libsa

Author: tsoome Date: Thu Jun 14 09:06:53 2018 New Revision: 335126 URL: https://svnweb.freebsd.org/changeset/base/335126 Log: libsa: f_rabuf could be NULL It is possible that we will not get RA buffer from open(), therefore we must validate RA. Modified: head/stand/libsa/read.c

svn commit: r335125 - head/stand/libsa

Author: tsoome Date: Thu Jun 14 08:58:10 2018 New Revision: 335125 URL: https://svnweb.freebsd.org/changeset/base/335125 Log: libsa: cstyle cleanup for open/close/read/write sources Modified: head/stand/libsa/close.c head/stand/libsa/open.c head/stand/libsa/read.c

svn commit: r332565 - head/stand/common

Author: tsoome Date: Mon Apr 16 14:10:19 2018 New Revision: 332565 URL: https://svnweb.freebsd.org/changeset/base/332565 Log: loader: cstyle cleanup of command.c just clean it up. no functional changes intended. Reviewed by: imp Differential Revision:

svn commit: r332560 - head/stand/common

Author: tsoome Date: Mon Apr 16 12:46:14 2018 New Revision: 332560 URL: https://svnweb.freebsd.org/changeset/base/332560 Log: loader: make sure we do not return garbage from help_getnext Since we do free subtopic and desc in help_getnext(), we need to set them also NULL, so we make sure

svn commit: r332558 - head/stand/common

Author: tsoome Date: Mon Apr 16 08:41:44 2018 New Revision: 332558 URL: https://svnweb.freebsd.org/changeset/base/332558 Log: loader: command_errmsg should be const Use const char * for command_errmsg. Modified: head/stand/common/bootstrap.h head/stand/common/commands.c Modified:

svn commit: r332557 - head/stand/common

Author: tsoome Date: Mon Apr 16 08:15:50 2018 New Revision: 332557 URL: https://svnweb.freebsd.org/changeset/base/332557 Log: loader: make sure we use snprintf() in commands.c Safeguard against memory corruptions. Modified: head/stand/common/commands.c Modified:

svn commit: r332555 - head/stand/common

Author: tsoome Date: Mon Apr 16 07:26:23 2018 New Revision: 332555 URL: https://svnweb.freebsd.org/changeset/base/332555 Log: loader: provide values in help_getnext() With r328289 we attempt to make sure we free the resources allocated in help_getnext(), however, it is possible that we

Re: svn commit: r332272 - head/stand/forth

> On 8 Apr 2018, at 17:23, O. Hartmann <ohartm...@walstatt.org> wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Am Sun, 8 Apr 2018 11:55:27 +0000 (UTC) > Toomas Soome <tso...@freebsd.org> schrieb: > >> Author: tsoome >> Date:

svn commit: r332275 - head/stand/i386/loader

Author: tsoome Date: Sun Apr 8 13:40:38 2018 New Revision: 332275 URL: https://svnweb.freebsd.org/changeset/base/332275 Log: loader: 332270 did left out stand/i386/loader/loader.rc we have 2 instances of loader.rc... Modified: head/stand/i386/loader/loader.rc Modified:

svn commit: r332272 - head/stand/forth

Author: tsoome Date: Sun Apr 8 11:55:27 2018 New Revision: 332272 URL: https://svnweb.freebsd.org/changeset/base/332272 Log: loader: 332270 did use wrong path for efi.4th The correct path is still /boot/efi.4th Modified: head/stand/forth/loader.4th Modified:

svn commit: r332270 - head/stand/forth

Author: tsoome Date: Sun Apr 8 11:39:27 2018 New Revision: 332270 URL: https://svnweb.freebsd.org/changeset/base/332270 Log: loader: include efi.4th only if we do have uefi Also simplify efi.4th. Modified: head/stand/forth/efi.4th head/stand/forth/loader.4th

svn commit: r332173 - head/stand/libsa

Author: tsoome Date: Sat Apr 7 14:42:47 2018 New Revision: 332173 URL: https://svnweb.freebsd.org/changeset/base/332173 Log: libsa: name is not used in dirmatch() Seems like variable 'name' is leftover. Modified: head/stand/libsa/cd9660read.c Modified: head/stand/libsa/cd9660read.c

svn commit: r332170 - head/stand/libsa

Author: tsoome Date: Sat Apr 7 14:40:09 2018 New Revision: 332170 URL: https://svnweb.freebsd.org/changeset/base/332170 Log: libsa: cd9660: warning: 'lenskip' may be used uninitialized in this function We better provide value for lenskip in both instances. Modified:

svn commit: r330970 - in head/stand/efi: include libefi

Author: tsoome Date: Thu Mar 15 05:58:35 2018 New Revision: 330970 URL: https://svnweb.freebsd.org/changeset/base/330970 Log: libefi: UEFI_BOOT_VAR_GUID duplicates EFI_GLOBAL_VARIABLE Drop UEFI_BOOT_VAR_GUID and use EFI_GLOBAL_VARIABLE. Reviewed by: imp Differential Revision:

svn commit: r330837 - head/stand/i386/libi386

Author: tsoome Date: Tue Mar 13 09:58:29 2018 New Revision: 330837 URL: https://svnweb.freebsd.org/changeset/base/330837 Log: biosdisk.c should not set d_opendata. Same as 330807, d_opendata is owned by open_disk and we should not set it. Mstand/i386/libi386/biosdisk.c

svn commit: r330803 - head/sys/dev/e1000

Author: tsoome Date: Mon Mar 12 17:05:53 2018 New Revision: 330803 URL: https://svnweb.freebsd.org/changeset/base/330803 Log: e1000g: this statement may fall through The gcc 7 does check for switch statement fall through cases, and if legit, such complaint can besilenced by /*

svn commit: r330056 - head/stand/libsa

Author: tsoome Date: Tue Feb 27 12:53:25 2018 New Revision: 330056 URL: https://svnweb.freebsd.org/changeset/base/330056 Log: libsa: replace remaining _write callbacks by null_write There are some _write callbacks left only returning EROFS, replace them by null_write. return EROFS from

Re: svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua

nkov <yur...@yuripv.net> >>> Reviewed by: Andy Fiddaman <omn...@citrus-it.co.uk> >>> Reviewed by: Matthew Ahrens <mahr...@delphix.com> >>> Approved by: Dan McDonald <dan...@joyent.com> >>> Author: Toomas Soome <tso...@me.com> >>

svn commit: r328061 - head/stand/efi/libefi

Author: tsoome Date: Tue Jan 16 20:35:54 2018 New Revision: 328061 URL: https://svnweb.freebsd.org/changeset/base/328061 Log: utf8_to_ucs2() should check for malloc failure utf8_to_ucs2() is calling malloc() without checking the result. Reviewed by: imp Differential Revision:

svn commit: r326854 - in head/stand/efi: boot1 include libefi

Author: tsoome Date: Thu Dec 14 16:41:52 2017 New Revision: 326854 URL: https://svnweb.freebsd.org/changeset/base/326854 Log: libefi: make efichar.h more usable in stand code Use _STANDALONE for guard expression in efichar.[ch] and add efi_char typedef. clean up boot1.c, and replace for

svn commit: r326616 - head/stand/libsa

Author: tsoome Date: Wed Dec 6 06:49:53 2017 New Revision: 326616 URL: https://svnweb.freebsd.org/changeset/base/326616 Log: dhcp_try_rfc1048() is not used any more Remove unused function. Reviewed by: imp Differential Revision:https://reviews.freebsd.org/D13382 Modified:

svn commit: r326509 - head/stand/efi/libefi

Author: tsoome Date: Mon Dec 4 08:50:00 2017 New Revision: 326509 URL: https://svnweb.freebsd.org/changeset/base/326509 Log: loader.efi: add note about iPXE into the efipart.c Commant update. Modified: head/stand/efi/libefi/efipart.c Modified: head/stand/efi/libefi/efipart.c

svn commit: r326421 - head/stand/efi/libefi

Author: tsoome Date: Fri Dec 1 06:37:12 2017 New Revision: 326421 URL: https://svnweb.freebsd.org/changeset/base/326421 Log: loader.efi: efipart should exclude iPXE stub block protocol iPXE does insert stub BLOCK IO protocol handle to rework other issues, this handle is not usable as

svn commit: r326090 - head/stand/common

Author: tsoome Date: Wed Nov 22 10:04:09 2017 New Revision: 326090 URL: https://svnweb.freebsd.org/changeset/base/326090 Log: net_parse_rootpath() has no parameters Add void for parameter list. Modified: head/stand/common/dev_net.c Modified: head/stand/common/dev_net.c

svn commit: r326089 - head/stand/efi/libefi

Author: tsoome Date: Wed Nov 22 08:48:00 2017 New Revision: 326089 URL: https://svnweb.freebsd.org/changeset/base/326089 Log: loader.efi: efipart does not recognize partitionless disks Rework the block device handle check to allow more robust device classification. This is mostly

svn commit: r325641 - in head/sys/boot/efi: include libefi

Author: tsoome Date: Fri Nov 10 12:07:56 2017 New Revision: 325641 URL: https://svnweb.freebsd.org/changeset/base/325641 Log: loader.efi: efi_devpath_is_prefix should return bool efi_devpath_is_prefix() is currently returning values 0 or 1, which means it really should return bool.

svn commit: r325310 - head/sys/boot/zfs

Author: tsoome Date: Thu Nov 2 08:47:03 2017 New Revision: 325310 URL: https://svnweb.freebsd.org/changeset/base/325310 Log: zfs.c:vdev_read() needs to be careful about large sectors Using the same implementation as done in efi/boot1. We must handle smaller than sector size IO etc.

svn commit: r325286 - head/sys/boot/efi/libefi

Author: tsoome Date: Wed Nov 1 18:49:45 2017 New Revision: 325286 URL: https://svnweb.freebsd.org/changeset/base/325286 Log: efipart_strategy is using wrong offset with >512B sectors The strategy() calls are assuming 512B sectors, so we need to adjust the offset accordingly.

svn commit: r325248 - head/sys/boot/common

Author: tsoome Date: Tue Oct 31 20:29:31 2017 New Revision: 325248 URL: https://svnweb.freebsd.org/changeset/base/325248 Log: loader ptblread() is broken with >512B sectors The loader strategy() function is assuming 512B blocks, so we need to adjust ptblread() for other sector sizes.

svn commit: r324719 - head/sys/boot/libsa

Author: tsoome Date: Wed Oct 18 08:06:05 2017 New Revision: 324719 URL: https://svnweb.freebsd.org/changeset/base/324719 Log: libsa/ip: stop read loop on bad fragments Lets try to clear out from case of overlapping etc fragments and stop read. Reported by: Dan McDonald Modified:

svn commit: r324717 - head/sys/boot/libsa

Author: tsoome Date: Wed Oct 18 07:39:21 2017 New Revision: 324717 URL: https://svnweb.freebsd.org/changeset/base/324717 Log: libsa/ip.c: misplaced comment, ip_v is half char, not ip_p The comment should be at previous line. Reported by: Dan McDonald Modified:

Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader

The arm (uboot) has a bit different approach on block device(s), see efipart_hdinfo_add_filepath() in efipart.c; the code needs to check for MEDIA_FILEPATH_DP, I think. rgds, toomas > On 16 Oct 2017, at 19:07, Andrew Turner wrote: > > Correct, it is aarch64. It runs a

svn commit: r323991 - head/sys/boot/efi/libefi

Author: tsoome Date: Mon Sep 25 19:49:56 2017 New Revision: 323991 URL: https://svnweb.freebsd.org/changeset/base/323991 Log: libefi: efipart_floppy() will should not pass acpi pointer if the HID test fails The current efipart_floppy() implementation is leaking the acpi pointer.

svn commit: r323909 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 07:44:36 2017 New Revision: 323909 URL: https://svnweb.freebsd.org/changeset/base/323909 Log: libefi: define EISA PNP constants Define EISA PNP constants and use them, also fix ID for 0x701 Modified: head/sys/boot/efi/libefi/efipart.c Modified:

svn commit: r323908 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 07:40:05 2017 New Revision: 323908 URL: https://svnweb.freebsd.org/changeset/base/323908 Log: libefi: efipart_hdinfo_add_filepath should check strtol result Use errno for error checking. Modified: head/sys/boot/efi/libefi/efipart.c Modified:

svn commit: r323907 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 07:37:42 2017 New Revision: 323907 URL: https://svnweb.freebsd.org/changeset/base/323907 Log: libefi: efipart.c cstyle fix for efipart_print_common() The else statement should have { } Modified: head/sys/boot/efi/libefi/efipart.c Modified:

svn commit: r323906 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 07:34:08 2017 New Revision: 323906 URL: https://svnweb.freebsd.org/changeset/base/323906 Log: libefi: efipart_strategy() should return ENXIO when there is no media We should return ENXIO to indicate the situation with device present, but no media.

svn commit: r323905 - in head/sys/boot/efi: include loader

Author: tsoome Date: Fri Sep 22 07:29:26 2017 New Revision: 323905 URL: https://svnweb.freebsd.org/changeset/base/323905 Log: libefi: pdinfo_t pd_unit and pd_open should be unsigned The device index, partition index and reference counter are all positive numbers. However, since our

svn commit: r323897 - head/sys/boot/efi/include

Author: tsoome Date: Fri Sep 22 02:58:47 2017 New Revision: 323897 URL: https://svnweb.freebsd.org/changeset/base/323897 Log: efilib.h: typo in structure member description The link should be replaced by list. Modified: head/sys/boot/efi/include/efilib.h Modified:

svn commit: r323896 - head/sys/boot/efi/include

Author: tsoome Date: Fri Sep 22 02:56:26 2017 New Revision: 323896 URL: https://svnweb.freebsd.org/changeset/base/323896 Log: r323885 did miss efilib.h update The efilib.h update was left out from r323885 by mistake. Modified: head/sys/boot/efi/include/efilib.h Modified:

svn commit: r323895 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Sep 22 02:53:01 2017 New Revision: 323895 URL: https://svnweb.freebsd.org/changeset/base/323895 Log: libefi: efi_devpath_match local len should be unsigned DevicePathNodeLength() will always return unsigned value. Modified: head/sys/boot/efi/libefi/devpath.c

svn commit: r323886 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 23:22:18 2017 New Revision: 323886 URL: https://svnweb.freebsd.org/changeset/base/323886 Log: libefi: efipart.c should use calloc() The device specific *_add functions are using malloc() + memset, should use calloc instead. Modified:

svn commit: r323885 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 23:14:07 2017 New Revision: 323885 URL: https://svnweb.freebsd.org/changeset/base/323885 Log: libefi: efi_devpath_match() should return bool The current implementation of efi_devpath_match() is returning values 0 or 1, so it should be updated to return

svn commit: r323867 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Sep 21 15:30:20 2017 New Revision: 323867 URL: https://svnweb.freebsd.org/changeset/base/323867 Log: libefi: devicename.c cleanups Remove duplicated free()+return statements, default unit to 0 and improve strtol error processing. Modified:

svn commit: r323707 - head/sys/boot/i386/libi386

Author: tsoome Date: Mon Sep 18 15:17:01 2017 New Revision: 323707 URL: https://svnweb.freebsd.org/changeset/base/323707 Log: loader: biosmem allocate heap just below 4GB The current biosmem code is walking bios smap entries and looking for smap entry just below 4GB line, if there is

svn commit: r323589 - head/sys/boot/i386/libi386

Author: tsoome Date: Thu Sep 14 16:42:29 2017 New Revision: 323589 URL: https://svnweb.freebsd.org/changeset/base/323589 Log: loader: biosmem.c cstyle cleanup No functional changes, just cleanup. Reviewed by: allanjude, imp Differential Revision:

svn commit: r323541 - head/sys/boot/efi/libefi

Author: tsoome Date: Wed Sep 13 14:27:13 2017 New Revision: 323541 URL: https://svnweb.freebsd.org/changeset/base/323541 Log: libefi: efipart_realstrategy rsize pointer may be NULL Need to check rsize before dereferencing it. Modified: head/sys/boot/efi/libefi/efipart.c Modified:

svn commit: r323497 - head/sys/boot/efi/libefi

Author: tsoome Date: Tue Sep 12 14:18:45 2017 New Revision: 323497 URL: https://svnweb.freebsd.org/changeset/base/323497 Log: libefi: efipart_open should check the status from disk_open In case of error from disk_open(), we should clean up properly. Reviewed by: allanjude, imp

svn commit: r323496 - head/lib/libstand

Author: tsoome Date: Tue Sep 12 13:51:18 2017 New Revision: 323496 URL: https://svnweb.freebsd.org/changeset/base/323496 Log: libstand: tftp_open() can leak pkt on error The memory can be leaked if we will have pkt set and will get an error during tftp_open() processing.

svn commit: r323494 - in head/sys: boot/zfs cddl/boot/zfs

Author: tsoome Date: Tue Sep 12 13:45:04 2017 New Revision: 323494 URL: https://svnweb.freebsd.org/changeset/base/323494 Log: loader should support large_dnode The zfsonlinux feature large_dnode is not yet supported by the loader. Reviewed by: avg, allanjude Differential Revision:

svn commit: r323428 - head/sys/boot/efi/loader

Author: tsoome Date: Mon Sep 11 07:38:53 2017 New Revision: 323428 URL: https://svnweb.freebsd.org/changeset/base/323428 Log: r323389 breaks the kernel build when WITHOUT_ZFS is defined in src.conf Need to add #ifdef EFI_ZFS_BOOT guard into efi/loader/main.c PR: 15

svn commit: r323389 - in head/sys/boot/efi: include libefi loader

Author: tsoome Date: Sun Sep 10 13:53:42 2017 New Revision: 323389 URL: https://svnweb.freebsd.org/changeset/base/323389 Log: loader.efi: chain loader should provide proper device handle Since the efipart rewrite, the chain command was looking for device handle using interface applicable

svn commit: r323100 - head/lib/libstand

Author: tsoome Date: Fri Sep 1 16:40:12 2017 New Revision: 323100 URL: https://svnweb.freebsd.org/changeset/base/323100 Log: libstand: nfs_readlink() should return proper return code The nfs_readlink() is returning constant 0 instead of variable. Reviewed by: avg Differential

svn commit: r322542 - head/sys/boot/efi/loader/arch/amd64

Author: tsoome Date: Tue Aug 15 14:03:26 2017 New Revision: 322542 URL: https://svnweb.freebsd.org/changeset/base/322542 Log: loader.efi: repace XXX with real comments in trap.c There are two missing comments marked as XXX in trap.c, fix this. Reviewed by: kib Differential

svn commit: r322074 - head/sys/boot/efi/libefi

Author: tsoome Date: Sat Aug 5 05:20:03 2017 New Revision: 322074 URL: https://svnweb.freebsd.org/changeset/base/322074 Log: libefi/time.c cstyle cleanup libefi/time.c is mix of different styles, this update does cleanup. Also fix 0 versus NULL, and zero the tv structure for case we get

<    1   2   3   4   5   6   >