Mateusz,
On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote:
A> I do the upstream sync between the Netflix tree and
A> FreeBSD-current about every 3 weeks (unless glebius beats
A> me to the punch and does it first :). I anticipate that
A> this blank line sweep will cause lots of
On Sat, Sep 5, 2020 at 1:42 PM Ed Maste wrote:
> On Fri, 4 Sep 2020 at 23:11, Kevin Bowling
> wrote:
> >
> > An arbitrary formater may leave a
> > little bit of annoyance to each person's taste, but that is a tiny
> > drop in the bucket compared to never having to discuss and especially
> >
On Fri, 4 Sep 2020 at 23:11, Kevin Bowling wrote:
>
> An arbitrary formater may leave a
> little bit of annoyance to each person's taste, but that is a tiny
> drop in the bucket compared to never having to discuss and especially
> correct (which may /seem/ helpful but is pretty offputting to
>
> From: Ed Maste
> Date: Sat, 5 Sep 2020 17:26:47 -0400
> Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route
> net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu
> netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...
> On Sat, 5 Sep
On Sat, 5 Sep 2020 at 16:41, Warner Losh wrote:
>
>> Fixed:
>> - *_FOREACH now has a space before (, equivalent to for (;;)
>
> Except pretty much everywhere we don't have a space there...
Why not? Why should TAILQ_FOREACH have a different style from a for loop?
> broke all alignment of
On Sat, Sep 5, 2020 at 12:00 AM Kevin Bowling
wrote:
> On Fri, Sep 4, 2020 at 10:30 PM Warner Losh wrote:
> >
> >
> >
> > On Fri, Sep 4, 2020, 11:24 PM Kevin Bowling
> wrote:
> >>
> >> It's happening right now, and a few times a year at minimum from my
> >> memory.
> >
> >
> > Can I get a
On Fri, Sep 4, 2020 at 10:30 PM Warner Losh wrote:
>
>
>
> On Fri, Sep 4, 2020, 11:24 PM Kevin Bowling wrote:
>>
>> It's happening right now, and a few times a year at minimum from my
>> memory.
>
>
> Can I get a pointer?
>From recent lossy memory, intel networking drivers (multiply), and the
On Fri, Sep 4, 2020, 9:11 PM Kevin Bowling wrote:
> I disagree that the problem is intractable. It's just a decision and
> it has a one time cost with long term benefits like paying off a high
> interest loan. The intractability opinion seemed justifiable for a
> long time but it's been proven
It's happening right now, and a few times a year at minimum from my
memory. Any time someone proposes a formatter they are thrown shade,
so the lack of progress there isn't surprising since the current
culture would require a flame proof suit to make progress. It's kind
of tautological that the
I disagree that the problem is intractable. It's just a decision and
it has a one time cost with long term benefits like paying off a high
interest loan. The intractability opinion seemed justifiable for a
long time but it's been proven false by other communities,
particularly Go and Rust and
On Fri, Sep 4, 2020, 7:05 PM Mark Linimon wrote:
> On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote:
> > and I also anticipate it will cause problems with MFCs
>
> And existing PRs and DRs.
>
Or we could just not bother we these changes at all. It's a pipe dream we
will ever be
On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote:
> and I also anticipate it will cause problems with MFCs
And existing PRs and DRs.
mcl
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To
On 9/4/20, Andrew Gallatin wrote:
> On 2020-09-02 22:42, Alexey Dokuchaev wrote:
>
>>> I want to understand which rules have to be followed (and why).
>>
>> In general, FreeBSD code we write should follow style(9); it specifically
>> mentions "do not add whitespace at the end of a line" and "...
On Fri, Sep 4, 2020, at 1:15 PM, Andrew Gallatin wrote:
> Rather than doing more sweeps like this, is it possible to
> come up with a clang-format rule that's 95% of style(9), do
> just one more sweep of the tree to apply that rule, add that
> rule as a pre-commit hook, and be done forever with
On 2020-09-02 22:42, Alexey Dokuchaev wrote:
I want to understand which rules have to be followed (and why).
In general, FreeBSD code we write should follow style(9); it specifically
mentions "do not add whitespace at the end of a line" and "... followed by
one blank line" but doesn't go as
On Wed, Sep 02, 2020 at 11:39:51PM +0200, Michael Tuexen wrote:
> > On 2. Sep 2020, at 20:28, Pedro Giffuni wrote:
> > On 02/09/2020 13:06, Alexey Dokuchaev wrote:
> >> On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
> >>> On 01/09/2020 21:05, Alexey Dokuchaev wrote:
> ...
>
> On 2. Sep 2020, at 20:28, Pedro Giffuni wrote:
>
>
> On 02/09/2020 13:06, Alexey Dokuchaev wrote:
>> On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
>>> On 01/09/2020 21:05, Alexey Dokuchaev wrote:
...
This is common sense. I can't count how often I wanted to hack on
On 02/09/2020 13:06, Alexey Dokuchaev wrote:
On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
On 01/09/2020 21:05, Alexey Dokuchaev wrote:
...
This is common sense. I can't count how often I wanted to hack on
something in the base/kernel and was turned away by this atrocious
On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
> On 01/09/2020 21:05, Alexey Dokuchaev wrote:
> > ...
> > This is common sense. I can't count how often I wanted to hack on
> > something in the base/kernel and was turned away by this atrocious
> > excessive whitespace mess.
> >
> >
On 01/09/2020 21:05, Alexey Dokuchaev wrote:
On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote:
On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
Author: mjg
Date: Tue Sep 1 21:19:14 2020
New Revision: 365071
URL: https://svnweb.freebsd.org/changeset/base/365071
Log:
net: clean
> On 2. Sep 2020, at 04:05, Alexey Dokuchaev wrote:
>
> On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote:
>>> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
>>> Author: mjg
>>> Date: Tue Sep 1 21:19:14 2020
>>> New Revision: 365071
>>> URL:
On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote:
> > On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
> > Author: mjg
> > Date: Tue Sep 1 21:19:14 2020
> > New Revision: 365071
> > URL: https://svnweb.freebsd.org/changeset/base/365071
> >
> > Log:
> > net: clean up empty lines in
> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
>
> Author: mjg
> Date: Tue Sep 1 21:19:14 2020
> New Revision: 365071
> URL: https://svnweb.freebsd.org/changeset/base/365071
>
> Log:
> net: clean up empty lines in .c and .h files
Hi Mateusz,
which rules are enforced? Why?
Best regards
23 matches
Mail list logo
