[tcpdump-workers] Re: [tcpdump] About struct in_addr / struct in6_addr

2023-02-20 Thread Guy Harris
On Feb 20, 2023, at 2:20 AM, Guy Harris wrote: > So the code is correct, but could easily be misintrpreted. Perhaps it'd be > better if we used the values from af.h rather than using AF_INET and > AF_INET6. Done in 0dc32a024773968cb1ae00729758e61b7418564a I'll see whether anything else

[tcpdump-workers] Re: [tcpdump] About struct in_addr / struct in6_addr

2023-02-20 Thread Guy Harris
On Feb 20, 2023, at 12:17 AM, Denis Ovsienko wrote: > AF_INET6 looks a bit more convoluted. There is some code that uses > AF_INET6 to dissect wire encoding, which is usually a wrong idea. For > example, pimv2_addr_print() switches on AF_INET and AF_INET6, and the > PIMv2 header encoding (RFC

[tcpdump-workers] Re: [tcpdump] About struct in_addr / struct in6_addr

2023-02-20 Thread Denis Ovsienko
On Sun, 17 Jul 2022 15:29:39 -0700 Guy Harris via tcpdump-workers wrote: > On Jul 17, 2022, at 11:09 AM, Francois-Xavier Le Bail > wrote: > > > Remain some stuff about 'struct in6_addr'. Any need to keep them? > > > > $ git grep -l 'struct in6_addr' > > CMakeLists.txt > > cmakeconfig.h.in > >

[tcpdump-workers] Re: [tcpdump] About struct in_addr / struct in6_addr

2023-02-18 Thread Guy Harris
On Feb 18, 2023, at 10:27 AM, Denis Ovsienko wrote: > OS IPv6 support would be a very reasonable requirement for tcpdump 5. Which would, among other things, let us remove the tests for various add-on IPv6 stacks in configure.ac. ___ tcpdump-workers

[tcpdump-workers] Re: [tcpdump] About struct in_addr / struct in6_addr

2023-02-18 Thread Denis Ovsienko
On Sun, 17 Jul 2022 16:11:01 -0700 Guy Harris via tcpdump-workers wrote: > On Jul 17, 2022, at 3:39 PM, Bill Fenner wrote: > > > IMO it is safe to drop support for OSes lacking native IPv6 > > support. > > Yeah. Back when IPv6 support was added to tcpdump, it was an > experimental new