Push solock() down to sogetopt()

It is not required for the most cases. Also, some cases could be protected with solock_shared(). Index: sys/kern/uipc_socket.c === RCS file: /cvs/src/sys/kern/uipc_socket.c,v retrieving revision 1.297 diff -u -p -r1.297 uipc_socket.c

Re: bgpd adjust ASPA validation for non-transparent RS

On Wed, Jan 25, 2023 at 12:20:29PM +0100, Claudio Jeker wrote: > This diff is a result of a longer discussion with Sriram from NIST about > ASPA validation behaviour on route-servers and especially non-transparent RS. > > Handling transparent route-servers (which is the default) requires no >

amd64, i386: set lapic timer mode, mask, divisor once

mlarkin@ noted about a month or so ago that setting the lapic timer mode, mask, and divisor every time we rearm it is unnecessary. We only need to configure those registers once during lapic_timer_trigger(). After that, it is sufficient to set the ICR when rearming the timer. While here, add

Re: refactor mbuf parsing on driver level

Vitaliy Makkoveev: > The ether_extract_headers() diff was reverted, because is wrong for the > cases other than tcp/udp/icmp. We need to fix it and recommit again > before continue. I think (TCP or) UDP fragments are the problem. Fragments don't have the protocol header but will still end up

Re: Replace selinfo structure by klist in sockbuf

On Thu, Jan 26, 2023 at 09:51:14PM +0300, Vitaliy Makkoveev wrote: > No reason to keep it, selinfo is just wrapper to klist. netstat(1) and > libkvm use socket structure, but don't touch > so_{snd,rcv}.sb_sel.si_note. OK visa@ > Index: sys/kern/uipc_socket.c >

lastcomm pid

Hi, Some time ago the process id was aded to process accounting. It would be useful to have the pid in lastcomm(1) output for post mortem analysis. I put it in brackets after the command, like syslogd does it in log files. Without additional column, existing parsers should not be too confused.

Remove pre netlock era rudiments from sosplice() and somove()

Since these paths became netlock serialized, we don't need to handle side effects caused by context switch. somove() return type changed to the type of void because we can't have concurrent somove() while we sleep. SB_SPLICE bits we set before somove() call will be cleared within somove() if

Re: Push solock() down to sogetopt()

On Fri, Jan 27, 2023 at 11:59:15AM +0300, Vitaliy Makkoveev wrote: > It is not required for the most cases. Also, some cases could be > protected with solock_shared(). OK bluhm@ > Index: sys/kern/uipc_socket.c > === > RCS file:

Re: dmtimer(4), macppc, powerpc64, riscv64: init stathz, profhz like other platforms

> Date: Thu, 26 Jan 2023 21:29:29 -0600 > From: Scott Cheloha > > Almost every platform initializes stathz and profhz like this: > > stathz = hz; > profhz = stathz * 10; > > This patch brings a few stragglers in line with everyone else. > > This does not change stathz and profhz

Re: sshd reorder fails when comp72.tgz not installed

Resolved in the latest snapshot, thank you. Brian On Thu, Jan 26, 2023, at 8:48 PM, Theo de Raadt wrote: > Ah of course. I will move the missing files into base. > > Brian Conway wrote: > >> Just a heads up, I was trying a few install variations of -current and >> noticed sshd reorder failing

Re: amd64, i386: set lapic timer mode, mask, divisor once

On Fri, Jan 27, 2023 at 08:07:26AM -0600, Scott Cheloha wrote: > mlarkin@ noted about a month or so ago that setting the lapic timer > mode, mask, and divisor every time we rearm it is unnecessary. We > only need to configure those registers once during > lapic_timer_trigger(). After that, it is

Check SB_SPLICE flag within isspliced() and issplicedback() macros

While doing isspliced() and issplicedback() we need to perform two checks of so_sp pointer and so_sp->ssp_socket or so_sp->ssp_soback pointers. But we always set SB_SPLICE flag on sockets buffer flags together with ssp_socket and ssp_soback. Therefore the conditions "so_rcv.sb_flags & SB_SPLICE)"