Supprt FTDI FT232R

2022-12-28 Thread Kevin Lo
The diff below makes the serial interface of the Genio 1200 demo board (FT232R) work. The upper 2 bits encode the fractional component of the FT232R is either 0 or 0.125. uftdi0 at uhub0 port 3 configuration 1 interface 0 "FTDI FT232R USB UART" rev 2.00/6.00 addr 2 ucom0 at uftdi0 portno 1

Re: clang 15 and zlib

2022-12-28 Thread Damien Miller
On Wed, 28 Dec 2022, Todd C. Miller wrote: > OK millert@ as well. There is no point in trying to fix this locally > when upstream zlib will be changing it in the near(?) future. He committed to removing the K function declarations when C23 is finalised:

Re: Use `ps_mtx' mutex(9) to protect `ps_ucred' and unlock setuid(2), ...

2022-12-28 Thread Vitaliy Makkoveev
The latest diff iteration after guenther@'s feedback. - The lock grabbing in ddb(4) is wrong, so don't grab it within db_show_all_procs(). - In the dorefreshcreds() grab the lock only if uc != pr->ps_ucred. Also move crfree() out of the lock. - In the pgsigio() store call CANSIGIO() with

Re: [patch(es)] fix a few typos in /src

2022-12-28 Thread Paul Tagliamonte
On Wed, Dec 28, 2022 at 09:35:52PM +, Jason McIntyre wrote: > i've finished with this diff. the usr.sbin parts i didn;t take are > listed below, along with any explanation. I *think* by my count and by watching the logs this is all of the diffs on this thread! Kudos for your steadfast review,

Re: clang 15 and zlib

2022-12-28 Thread Todd C . Miller
OK millert@ as well. There is no point in trying to fix this locally when upstream zlib will be changing it in the near(?) future. - todd

Re: [patch(es)] fix a few typos in /src

2022-12-28 Thread Jason McIntyre
On Fri, Dec 23, 2022 at 10:33:43AM -0500, Paul Tagliamonte wrote: i've finished with this diff. the usr.sbin parts i didn;t take are listed below, along with any explanation. jmc Index: usr.sbin/smtpd/crypto.c === RCS file:

ESRT support for the amd64 bootloader

2022-12-28 Thread Mark Kettenis
Dear Sergii, Sorry for the delay, but I have finally found the time to work on the EFI variable and ESRT support for OpenBSD. As a first step, here is a diff that adds support for copying the ESRT in the bootloader and passing it on to the kernel. I adjusted your diff a bit. It now adds the

Re: clang 15 and zlib

2022-12-28 Thread Theo Buehler
On Wed, Dec 28, 2022 at 07:48:29PM +0100, Jeremie Courreges-Anglas wrote: > > To build src cleanly with clang-15 you'd need the diff below. The > alternative would be to patch our three zlib copies and wait for > upstream to fix it. A more comfortable alternative is to just neuter > the

clang 15 and zlib

2022-12-28 Thread Jeremie Courreges-Anglas
To build src cleanly with clang-15 you'd need the diff below. The alternative would be to patch our three zlib copies and wait for upstream to fix it. A more comfortable alternative is to just neuter the warning. -Wno-unknown-warning-option prevents llvm 13 from complaining that it doesn't

crunchgen and llvm 15

2022-12-28 Thread Jeremie Courreges-Anglas
At first it looked like a fluke when building a release. What's this "ld -dc" command-line? Well -dc is short for --define-common, an option that has been dropped by upstream llvm(lld). IIUC this ld(1) behavior is somewhat similar to -fno-common for cc(1). base-clang already does -fno-common

[patch] arp.c spaces nested between tabs

2022-12-28 Thread Paul Tagliamonte
Hello, tech@! Minor patch for `arp(8)`. It uses some spaces between two tabs that are hard to notice. I have a syntax highlighting rule that shows such spaces[1] so I saw it while reviewing the arp.c source. I've learned my lesson trying to patch the monorepo across folder lines, so here's a

Re: iostat(8): implement periodic display with setitimer(2)

2022-12-28 Thread Todd C . Miller
On Wed, 28 Dec 2022 11:15:50 -0500, Scott Cheloha wrote: > Neither are arbitrary. > > The current maximum of one hundred million seconds is based on the old > nanosleep(2) limit prior to the 6.5 release. It was a documented > limit; see the manpage from the 6.4 release: > >

Re: iostat(8): implement periodic display with setitimer(2)

2022-12-28 Thread Scott Cheloha
On Wed, Dec 28, 2022 at 08:23:57AM -0700, Todd C. Miller wrote: > On Wed, 28 Dec 2022 06:51:52 -0600, Scott Cheloha wrote: > > > On Sat, Dec 10, 2022 at 08:09:15AM -0600, Scott Cheloha wrote: > > > As with e.g. kstat(1), implementing a periodic display with > > > nanosleep(2) causes the display

Re: iostat(8): implement periodic display with setitimer(2)

2022-12-28 Thread Todd C . Miller
On Wed, 28 Dec 2022 06:51:52 -0600, Scott Cheloha wrote: > On Sat, Dec 10, 2022 at 08:09:15AM -0600, Scott Cheloha wrote: > > As with e.g. kstat(1), implementing a periodic display with > > nanosleep(2) causes the display interval to drift. Doing it with > > setitimer(2) prevents drift. > > > >

Re: systat(1): vmstat: use actual elapsed time in dinfo()

2022-12-28 Thread Todd C . Miller
On Tue, 13 Dec 2022 11:20:46 -0600, Scott Cheloha wrote: > In systat(1)'s vmstat view, dinfo() uses the global "naptime" as an > elapsed time when computing rates. > > The problem is that naptime isn't the actual elapsed time. For > example, if you force a view update by hitting the spacebar,

Re: iostat(8): implement periodic display with setitimer(2)

2022-12-28 Thread Scott Cheloha
On Sat, Dec 10, 2022 at 08:09:15AM -0600, Scott Cheloha wrote: > As with e.g. kstat(1), implementing a periodic display with > nanosleep(2) causes the display interval to drift. Doing it with > setitimer(2) prevents drift. > > ok? Two week ping. Index: iostat.c

Re: systat(1): vmstat: use actual elapsed time in dinfo()

2022-12-28 Thread Scott Cheloha
On Tue, Dec 13, 2022 at 11:20:46AM -0600, Scott Cheloha wrote: > In systat(1)'s vmstat view, dinfo() uses the global "naptime" as an > elapsed time when computing rates. > > The problem is that naptime isn't the actual elapsed time. For > example, if you force a view update by hitting the

Re: rpki-client: small geofeed parsing bug

2022-12-28 Thread Theo Buehler
On Thu, Dec 22, 2022 at 11:26:30AM +0100, Theo Buehler wrote: > If the line contains no location info and a comma in a comment, what > follows the comma will be interpreted as location info. Actually ignore > what's in comments by adjusting the line length. It's probably better to remove any