[Telepathy] [Bug 17116] Non-null-terminated TpConnectionManager::protocols ?
http://bugs.freedesktop.org/show_bug.cgi?id=17116 --- Comment #1 from Sjoerd Simons [EMAIL PROTECTED] 2008-08-18 02:30:04 PST --- Created an attachment (id=18353) -- (http://bugs.freedesktop.org/attachment.cgi?id=18353) Fixed version of example.c Your example was slightly wrong, which caused the crash. Attached a fixed version -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
[Telepathy] [Bug 17116] Non-null-terminated TpConnectionManager::protocols ?
http://bugs.freedesktop.org/show_bug.cgi?id=17116 Murray Cumming [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #2 from Murray Cumming [EMAIL PROTECTED] 2008-08-18 03:07:47 PST --- Yes, it was silly to test the pointer for NULL after doing ++ on it. Thanks for the help. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
[Telepathy] [Bug 17130] can't connect to jabber with telepathy-gabble-0.7.7
http://bugs.freedesktop.org/show_bug.cgi?id=17130 Simon McVittie [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Simon McVittie [EMAIL PROTECTED] 2008-08-18 05:46:49 PST --- Already fixed upstream and in Debian, then. I'll leave this bug open until we do a release with the fix. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
[Telepathy] ANNOUNCE: telepathy-haze 0.2.1
Hi, telepathy-haze 0.2.1 – “DUM DE DUM DE DIDDLE IDDLE DE DUM‼” – is available from the usual locations: tarball: http://telepathy.freedesktop.org/releases/telepathy-haze/telepathy-haze-0.2.1.tar.gz signature: http://telepathy.freedesktop.org/releases/telepathy-haze/telepathy-haze-0.2.1.tar.gz.asc gitweb: http://git.collabora.co.uk/?p=telepathy-haze.git NEWS for this version: * A publish channel now exists, which allows you to accept or decline incoming subscription requests (but nothing else yet; it's not possible to later remove someone from the list, for instance). * Add support for setting your avatar (fd.o #13123). * Stop your accounts auto-awaying themselves (fd.o #14335). * Don't crash when the UI passes an empty or otherwise invalid host name as the server parameter for a new connection (fd.o #14445). * Don't sporadically crash on connection errors, such as an incorrect password (fd.o #14933). * Debugging output from Haze and libpurple is now silenced unless you set HAZE_DEBUG appropriately (haze and purple, respectively). * Haze now requires telepathy-glib = 0.7.0. Thanks, -- Will signature.asc Description: OpenPGP digital signature ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
[Telepathy] Review of telepathy-salut.git/tubes
This is a first review of http://monkey.collabora.co.uk/telepathy-salut.git_tubes/ tubes.txt = what's the status of 1-1 D-Bus tubes? We should clarify it before merging. We shouldn't ignore the ack of the SI offer. Please explain the IP policy when a new tube stream is established. Tube closing should have examples. gibber-bytestream-direct Maybe bytestream-direct-tcp or bytestream-raw-tcp would be a better name? header file: args should be 4 spaces aligned case PROP_PROTOCOL: g_value_set_string (value, (const gchar *)); we should define and use a name for this priv-stream_init_id doesn't make sense anymore Please wrap 80 chars lines args of the getter/setter/constructor are miss aligned args of g_signal_new should be 4 spaces aligned static void transport_buffer_empty_cb (GibberTransport *transport, add a space before this function gibber_bytestream_direct_initiate: we should store the SalutContact of the remote peer and use it to get his IP. Do we still need to store the XMPP connection ? gibber-iq-helper Why remove the if (!NULL) check when disposing? We always check that in dispose functions. salut-bytestream-manager.h wasn't removed salut-direct-bytestream-manager === /* guint id - guint listener_watch * When used by stream tubes, the id is the tube_id */ GHashTable *listeners; That's a lie, this hashtable contains SalutDirectBytestreamManagerListener objects. Humm actually, the key doesn't seem to be a guint either but a tube ptr. I'm not sure this kind of mapping make sense. We just need a way for the bytestream user to stop listening right? Maybe we could pass the port to salut_direct_bytestream_manager_stop_listen and store listeners in a GSList ? Or maybe having a real listener object could make sense? priv-listeners = g_hash_table_new (NULL, NULL); you should_use g_hash_table_new_full and pass a listener_free function as value_destroy_func salut_direct_bytestream_manager_stop_listen: shouldn't remove the listener from the hashtable? They are never removed. You don't seem to need priv-host_name_fqdn anymore. listener_io_in_cb shouldn't it return TRUE to continue listening? listener_io_in_cb you should check if the connection is coming from the right contact salut_direct_bytestream_manager_stop_listen: I think you could just use g_source_remove (id) I'm wondering if, finally, that make sense to have 2 distinct bytestream mgrs. I think the plan is to factor out most of salut-direct-bytestream-manager to a GibberTcpListenner object (or something similar) that could be used by GibberXmppConnection and probably stream tubes too (to watch connections on the local tube socket). Maybe then we could use it directly in a unified bytestream-mgr ? Or maybe if the API of this GibberTcpListenner is easy enough, the direct-bytestream-mgr won't make sense anymore and we could use it directly from the stream tube module? salut-tubes-channel === function declarations at the begin of the .c file should have the static void on their own line struct _SalutTubesChannelPrivate Please distinct clearly which variables are only used for muc tubes (as the muc_connection) and the one only used for 1-1 tubes. Maybe we should create 2 subclass at some point. _initialise_connection useless double blank lines priv-xmpp_connection = conn; g_object_ref (priv-xmpp_connection); _initialise_connection (self); I'd make _initalise_connection (self, conn) and move the assignment/refing to it tubes_message_received seems this function is misnamed and its only purpose is to create the tube +void tubes_message_close_received (SalutTubesChannel *self, the void should be on its own line DEBUG (received a tube close message on a non existant tube); s/existant/existent tubes_muc_message_received, tubes_message_received and tubes_message_close_received should be prefixed with salut_tubes_channel On a style node, I never understood the point to prefix static method with _. They are static and don't have the module prefix so I think that's enough to distinct them from public methods. _send_channel_iq_tube please group declarations in the if block gchar *tube_id_str = g_strdup_printf (%d, tube_id); I'd separate the assignment from the declaration salut-tubes-manager === _close = close_node != NULL; please add ( ) Could be worth to do an early return if (_close) to simplify code tube_type = gibber_xmpp_node_get_attribute (tube_node, type); if (g_str_equal (tube_type, stream)) Is it NULL safe? Why not use tp_strdiff as we always do? DEBUG (The iqtube does not have a correct type=.); remove the =. and display the bugged type iq_tube_request_cb: TpTubeType tube_type = TP_TUBE_TYPE_DBUS; why this type by default? DEBUG (received a tube request, tube_id %d, tube_id); s/tube_id/tube id priv-contact_manager and
[Telepathy] ANNOUNCE: Empathy 2.23.90
Empathy 2.23.90 is now available for download from: http://download.gnome.org/sources/empathy/2.23/ ef68277f289d614346b4244262594bf7 empathy-2.23.90.tar.gz 9bd5b3aef85262f8ae3efdbe87a7dbf8 empathy-2.23.90.tar.bz2 What is it? === Empathy consists of a rich set of reusable instant messaging widgets, and a GNOME client using those widgets. It uses Telepathy and Nokia's Mission Control, and reuses Gossip's UI. The main goal is to permit desktop integration by providing libempathy and libempathy-gtk libraries. libempathy-gtk is a set of powerful widgets that can be embeded into any GNOME application. You can visit the project web site: http://live.gnome.org/Empathy What's New? === - Do not display MSN Haze if butterfly is installed (Xavier Claessens). - If display name of the selected account changes, update the label. (Xavier Claessens). - If there is no account configured, accounts dialog directly propose to add an account (Xavier Claessens). - Add QQ profile and icons (Xavier Claessens). - Add gadugadu profile and icons (Xavier Claessens). - Show the main window by default on first run. (Xavier Claessens). - Use a GtkMessageDialog instead of GtkDialog for remove confirmation diaog of contact/group. (Xavier Claessens). Bugs fixed: - Fixed #529084, going offline then coming back leaves chat text input unsensitive (Xavier Claessens) - Fixed #540356, Problem with NetworkManager interaction (Xavier Claessens) - Fixed #547326, A sentence is too big without pauses (fpeters) Translations: - Updated the kn translations (sprasad). - Updated Norwegian bokmål translation. (kmaraas). - Updated pl translation (Tomasz Dominikowski). - Updated pt_BR translation (Djavan Fagundes). - Updated Finnish translation (ituohela). - Updated Spanish translation (jorgegonz). - Updated Galician translation (icq). - Updated Marathi Translations (sandeeps). - Updated pt translation (Duarte Loreto). - Updated fr translation (Claude Paroz). - updated he translation (yairhr). - Updated Arabic Translation by Youssef Chahibi. (djihed). - Updated sv translation (Daniel Nylander). 18 August 2008 Empathy team ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
[Telepathy] unsubscribe
unsubscribe ___ Telepathy mailing list Telepathy@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/telepathy
