[jira] Updated: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-115: - Attachment: thrift-115-v3.patch Ok, there was a bug in the last version. Also, this version

[jira] Updated: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-115: - Patch Info: [Patch Available] Isset structure has a large memory footprint

[jira] Assigned: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury reassigned THRIFT-547: Assignee: Bryan Duxbury Thrift deserializer hangs when deserializing empty string

[jira] Updated: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-547: - Remaining Estimate: (was: 2h) Original Estimate: (was: 2h) Thrift deserializer

[jira] Updated: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-547: - Attachment: thrift-547.patch This patch solves the problem. If the MemoryBuffer can't return the

[jira] Updated: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-547: - Patch Info: [Patch Available] Thrift deserializer hangs when deserializing empty string

[jira] Updated: (THRIFT-552) gem requires exactly rubygems 1.2.0

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-552: - Attachment: thrift-552.patch This appears to be all it takes. gem requires exactly rubygems

[jira] Updated: (THRIFT-552) gem requires exactly rubygems 1.2.0

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-552: - Patch Info: [Patch Available] gem requires exactly rubygems 1.2.0

[jira] Created: (THRIFT-552) gem requires exactly rubygems 1.2.0

2009-07-29 Thread Bryan Duxbury (JIRA)
gem requires exactly rubygems 1.2.0 --- Key: THRIFT-552 URL: https://issues.apache.org/jira/browse/THRIFT-552 Project: Thrift Issue Type: Bug Components: Library (Ruby) Affects Versions: 0.1

[jira] Updated: (THRIFT-409) Add union to Thrift

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-409: - Attachment: thrift-409-v2.patch Ok, here is an incremental improvement on the patch I put up so

[jira] Commented: (THRIFT-409) Add union to Thrift

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736738#action_12736738 ] David Reiss commented on THRIFT-409: You added some whitespace to a blank line at the

[jira] Updated: (THRIFT-409) Add union to Thrift

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-409: - Attachment: thrift-409-v3.patch OK, I removed some of the unnecessary parser changes. I also

[jira] Commented: (THRIFT-523) ax_lib_event.m4 doesn't work properly with newer versions of libevent

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736753#action_12736753 ] David Reiss commented on THRIFT-523: Anyone mind if I commit these? ax_lib_event.m4

[jira] Commented: (THRIFT-523) ax_lib_event.m4 doesn't work properly with newer versions of libevent

2009-07-29 Thread Michael Greene (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736754#action_12736754 ] Michael Greene commented on THRIFT-523: --- Go for it, +1 ax_lib_event.m4 doesn't work

Autoconf versions

2009-07-29 Thread David Reiss
Currently, if someone runs bootstrap.sh (not required for releases or instant releases) and has Autoconf 2.59 installed, it works fine (as long as the environment is sane), but generates some scary and potentially confusing error messages. We could update the AC_PREREQ to 2.61, which would change

[jira] Updated: (THRIFT-540) Have set methods return reference to self

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-540: - Attachment: thrift-540.patch I think this should do the trick. What do you think? Have set

[jira] Updated: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-115: Attachment: thrift-115-v4.patch This patch is a slightly modified version of Bryan's v3.

[jira] Updated: (THRIFT-529) Change generated constructors so that application code evolves better

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-529: - Patch Info: [Patch Available] Fix Version/s: 0.2 Assignee: Bryan Duxbury Change

[jira] Updated: (THRIFT-529) Change generated constructors so that application code evolves better

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-529: - Attachment: thrift-529.patch This patch creates a new additional constructor with nothing but

[jira] Commented: (THRIFT-540) Have set methods return reference to self

2009-07-29 Thread Nathan Marz (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736819#action_12736819 ] Nathan Marz commented on THRIFT-540: +1 Have set methods return reference to self

[jira] Updated: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-479: - Patch Info: [Patch Available] Fix Version/s: 0.2 Assignee: Bryan Duxbury Add

[jira] Updated: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-479: - Attachment: thrift-479.patch This should do it. Comments? Add javadocs for enum types

[jira] Commented: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736824#action_12736824 ] David Reiss commented on THRIFT-479: Why do you have to cast it? Add javadocs for

[jira] Commented: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736823#action_12736823 ] David Reiss commented on THRIFT-115: FWIW, I prefer not to have Thrift reimplement

[jira] Updated: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-479: - Attachment: thrift-479-v2.patch Good call, that was some unnecessary cruft. Add javadocs for

[jira] Created: (THRIFT-553) thrift structs should be comparable (=)

2009-07-29 Thread Bryan Duxbury (JIRA)
thrift structs should be comparable (=) - Key: THRIFT-553 URL: https://issues.apache.org/jira/browse/THRIFT-553 Project: Thrift Issue Type: New Feature Components: Compiler (Ruby), Library

[jira] Commented: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736837#action_12736837 ] Mathias Herberts commented on THRIFT-115: - This could be one way of doing it. The

[jira] Closed: (THRIFT-31) More validation during serialization

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-31. --- Resolution: Won't Fix No one seemed particularly interested in maintaining this issue, so I'm closing

[jira] Commented: (THRIFT-452) Gotcha with Java enums not having a zero value

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736842#action_12736842 ] Bryan Duxbury commented on THRIFT-452: -- Is this still an issue, or should I close it?

[jira] Commented: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736844#action_12736844 ] David Reiss commented on THRIFT-479: Seems fine. Does the output actually match Ben's

[jira] Commented: (THRIFT-551) Enumeration doesn't generate real enum in Java

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736846#action_12736846 ] Bryan Duxbury commented on THRIFT-551: -- It looks like this would indeed be a very cool

[jira] Commented: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736849#action_12736849 ] Todd Lipcon commented on THRIFT-115: I'm with David here, especially since the GWT

[jira] Commented: (THRIFT-115) Isset structure has a large memory footprint

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736853#action_12736853 ] Bryan Duxbury commented on THRIFT-115: -- Ok, so how do people feel about the last

[jira] Updated: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-479: - Attachment: thrift-479-v3.patch You are absolutely right. How's this? Add javadocs for enum

[jira] Commented: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736876#action_12736876 ] David Reiss commented on THRIFT-479: I didn't run it, but it looks fine. Add javadocs

[jira] Created: (THRIFT-554) Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls

2009-07-29 Thread Eric Waters (JIRA)
Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls --- Key: THRIFT-554 URL:

[jira] Updated: (THRIFT-554) Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls

2009-07-29 Thread Eric Waters (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Waters updated THRIFT-554: --- Attachment: thrift-554.diff Perl improper namespace check for exception handling and

[jira] Resolved: (THRIFT-479) Add javadocs for enum types

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury resolved THRIFT-479. -- Resolution: Fixed I just committed this. Add javadocs for enum types

[jira] Resolved: (THRIFT-540) Have set methods return reference to self

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury resolved THRIFT-540. -- Resolution: Fixed I just committed this. Have set methods return reference to self

[jira] Updated: (THRIFT-144) Generated classes should implement Comparable

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-144: - Attachment: thrift-144.patch This patch makes thrift structs comparable if and only if none of

[jira] Updated: (THRIFT-144) Generated classes should implement Comparable

2009-07-29 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-144: - Patch Info: [Patch Available] Assignee: Bryan Duxbury Generated classes should implement

[jira] Commented: (THRIFT-552) gem requires exactly rubygems 1.2.0

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736983#action_12736983 ] Kevin Clark commented on THRIFT-552: Looks good. +1 gem requires exactly rubygems

[jira] Commented: (THRIFT-144) Generated classes should implement Comparable

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736984#action_12736984 ] David Reiss commented on THRIFT-144: FWIW, the C++ set and map classes are sorted

[jira] Commented: (THRIFT-144) Generated classes should implement Comparable

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736986#action_12736986 ] David Reiss commented on THRIFT-144: Didn't run it. Code looks sensible. LG.

[jira] Issue Comment Edited: (THRIFT-144) Generated classes should implement Comparable

2009-07-29 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12736985#action_12736985 ] David Reiss edited comment on THRIFT-144 at 7/29/09 9:21 PM: -

[jira] Commented: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737007#action_12737007 ] Kevin Clark commented on THRIFT-547: There's a ruby-debug require in

[jira] Issue Comment Edited: (THRIFT-547) Thrift deserializer hangs when deserializing empty string

2009-07-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737007#action_12737007 ] Kevin Clark edited comment on THRIFT-547 at 7/29/09 10:52 PM: --