[jira] Commented: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Greg Stein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775450#action_12775450 ] Greg Stein commented on THRIFT-622: --- * I don't think that we can distribute *any* LGPL

Re: THRIFT-622 ping?

2009-11-10 Thread Greg Stein
I just reviewed it and will add these comments in a bit, but several things stand out: * I don't think that we can distribute *any* LGPL software, even if it is optional. the ruby stuff needs to be removed, or we need to find another solution * it would be nice if David Reiss did not ask for his

Re: THRIFT-622 ping?

2009-11-10 Thread Greg Stein
On Tue, Nov 10, 2009 at 13:06, David Reiss dre...@facebook.com wrote: * it would be nice if David Reiss did not ask for his name in there * likewise for Facebook What?  Where? The proposed NOTICE file lists yourself and Facebook. It would be nice to remove those sections. * the contributions

Re: THRIFT-622 ping?

2009-11-10 Thread Greg Stein
On Tue, Nov 10, 2009 at 13:20, Greg Stein gst...@gmail.com wrote: On Tue, Nov 10, 2009 at 13:06, David Reiss dre...@facebook.com wrote: * it would be nice if David Reiss did not ask for his name in there * likewise for Facebook What?  Where? The proposed NOTICE file lists yourself and

Re: THRIFT-622 ping?

2009-11-10 Thread David Reiss
Oh, that's fine then. Consider it waived. Greg Stein wrote: On Tue, Nov 10, 2009 at 13:20, Greg Stein gst...@gmail.com wrote: On Tue, Nov 10, 2009 at 13:06, David Reiss dre...@facebook.com wrote: * it would be nice if David Reiss did not ask for his name in there * likewise for Facebook

[jira] Updated: (THRIFT-601) sending random data crashes thrift service

2009-11-10 Thread Esteve Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Esteve Fernandez updated THRIFT-601: Attachment: thrift-601.patch This is a very simple patch which just closes an incoming

[jira] Commented: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776024#action_12776024 ] Todd Lipcon commented on THRIFT-622: bq. I don't think that we can distribute any LGPL

[jira] Commented: (THRIFT-601) sending random data crashes thrift service

2009-11-10 Thread Brandon Williams (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776066#action_12776066 ] Brandon Williams commented on THRIFT-601: - +1, this patch works for me if I tweak

[jira] Commented: (THRIFT-601) sending random data crashes thrift service

2009-11-10 Thread Jonathan Ellis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776072#action_12776072 ] Jonathan Ellis commented on THRIFT-601: --- I don't know how valuable this is, though...

[jira] Commented: (THRIFT-601) sending random data crashes thrift service

2009-11-10 Thread Esteve Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776195#action_12776195 ] Esteve Fernandez commented on THRIFT-601: - You're right Jonathan, maybe the framed

[jira] Commented: (THRIFT-210) Add support for TFramedTransport

2009-11-10 Thread Esteve Fernandez (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776200#action_12776200 ] Esteve Fernandez commented on THRIFT-210: - Michael gave his approval (thanks!),

[jira] Updated: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated THRIFT-622: --- Attachment: thrift-622.txt I went to add the top notice you asked for, and found it's already there:

Re: THRIFT-622 ping?

2009-11-10 Thread Todd Lipcon
Updated the JIRA (sorry for the dup for those of you who subscribe to the JIRA edits as well) On Tue, Nov 10, 2009 at 7:31 AM, Greg Stein gst...@gmail.com wrote: I just reviewed it and will add these comments in a bit, but several things stand out: * I don't think that we can distribute

Re: THRIFT-622 ping?

2009-11-10 Thread Upayavira
On Tue, 2009-11-10 at 10:06 -0800, David Reiss wrote: * it would be nice if David Reiss did not ask for his name in there * likewise for Facebook What? Where? * the contributions made under the TSL: by FB employees, or third-parties before the relicensing? Not sure what the question

[jira] Commented: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Joe Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776221#action_12776221 ] Joe Schaefer commented on THRIFT-622: - Technically the stuff Todd has added to the

[jira] Commented: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776225#action_12776225 ] Todd Lipcon commented on THRIFT-622: bq. Technically the stuff Todd has added to the

[jira] Commented: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Joe Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776230#action_12776230 ] Joe Schaefer commented on THRIFT-622: -

[jira] Updated: (THRIFT-622) Update NOTICE to call out all non-Apache2 contributions

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated THRIFT-622: --- Attachment: thrift-622.txt This new diff has the following changes: - rewrote OCaml build process

[jira] Closed: (THRIFT-618) Add license headers where missing

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon closed THRIFT-618. -- Resolution: Duplicate Marking dup with THRIFT-622 Add license headers where missing

[jira] Updated: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated THRIFT-622: --- Summary: Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc) (was: Update

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776275#action_12776275 ] Todd Lipcon commented on THRIFT-622: JIRA is displaying the patches with incorrect

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776283#action_12776283 ] David Reiss commented on THRIFT-622: bq. IMO, this is a 0.1 release of Thrift. If the

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Greg Stein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776280#action_12776280 ] Greg Stein commented on THRIFT-622: --- IMO, this is a 0.1 release of Thrift. If the Ruby

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776286#action_12776286 ] Todd Lipcon commented on THRIFT-622: bq. I don't see it that way. If we have a

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Greg Stein (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776291#action_12776291 ] Greg Stein commented on THRIFT-622: --- @David: that's fine. Just saying that from my

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776293#action_12776293 ] David Reiss commented on THRIFT-622: bq. so all that stuff has to disappear at some

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776300#action_12776300 ] Bryan Duxbury commented on THRIFT-622: -- As a Ruby user, I personally won't miss the

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776305#action_12776305 ] Todd Lipcon commented on THRIFT-622: Bryan: do you have some time to verify the

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776306#action_12776306 ] David Reiss commented on THRIFT-622: He's working on a pretty high-priority project

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776309#action_12776309 ] Todd Lipcon commented on THRIFT-622: OK, another angle for the ocaml stuff: do you guys

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776313#action_12776313 ] David Reiss commented on THRIFT-622: It is not actively used within Facebook. Get

[jira] Commented: (THRIFT-622) Get Thrift into releasable form (eliminate dependencies, tidy licenses, etc)

2009-11-10 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776343#action_12776343 ] Kevin Clark commented on THRIFT-622: I don't think the Ruby bindings will be severely