Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
Works fine on CentOS 5.5. On Snow Leopard, make check was returning this: libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o -Wl,-bind_at_load ./.libs/libtestgencpp.a

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Kevin Clark
We used to do it at Powerset. If you're installing thrift for 4 languages it's nice to use the same technique for the 5th. Though I don't recall if the Ruby make target was changed to just generate the gem these days, in which case it probably doesn't matter. Bryan - I can probably give you

Re: time for a reboot?

2010-08-13 Thread Rajesh Malepati
On Fri, Aug 13, 2010 at 6:46 PM, James King james_...@dell.com wrote: I'm not a committer on the project, but here's my two cents. There is a fine balance between opening the flood gates and having a potentially constantly broken trunk, and having a trunk where folks know that once they have

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Bryan Duxbury
On Fri, Aug 13, 2010 at 8:18 AM, David Reiss dre...@facebook.com wrote: +1 There are a few ._BLAH files in there that would be nice to remove, but not critical. Do you feel like opening a ticket for this cleanup? We can tackle it in the next release. As an aside... Does anyone use

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Bryan Duxbury
On Fri, Aug 13, 2010 at 8:34 AM, Kevin Clark kevin.cl...@gmail.com wrote: Bryan - I can probably give you appropriate credentials, though it'd have to wait til I'm back in civilization (start of September). Sounds good.

Re: time for a reboot?

2010-08-13 Thread uncle mantis
I want to appologize about the Mac comment. I thought that this was a different e-mail list when I wrote =( Regards, Michael On Fri, Aug 13, 2010 at 11:11 AM, Rajesh Malepati chitt...@gmail.comwrote: On Fri, Aug 13, 2010 at 6:46 PM, James King james_...@dell.com wrote: I'm not a committer

[jira] Created: (THRIFT-848) MAC OS files in release candidates

2010-08-13 Thread David Reiss (JIRA)
MAC OS files in release candidates -- Key: THRIFT-848 URL: https://issues.apache.org/jira/browse/THRIFT-848 Project: Thrift Issue Type: Bug Reporter: David Reiss The latest release candidate

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Anthony Molinaro
On Fri, Aug 13, 2010 at 09:15:50AM -0700, Bryan Duxbury wrote: On Fri, Aug 13, 2010 at 8:18 AM, David Reiss dre...@facebook.com wrote: As an aside... Does anyone use configure and make to build the ruby stuff? If not, can we just delete Ruby support from the configure script? It's

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread James Clarke
I cannot get this to build on Mac OS X 10.6.4. It appears the cpp library is failing. boost @1.43.0_0 zlib @1.2.5_0 libevent @1.4.14b_0 Here is where it fails. Making all in cpp /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src

[jira] Commented: (THRIFT-247) THttpServer Transport

2010-08-13 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898367#action_12898367 ] Roger Meier commented on THRIFT-247: Up and running! Thanks! THttpServer Transport

Enumeration for protocol, transport and server types

2010-08-13 Thread roger
Hi all I would love to have Enumeration's for protocol, transport and server types as described in https://issues.apache.org/jira/browse/THRIFT-819 this would be helpful for unit tests, multi protocol servers etc. what do you think? should i proceed using that approach ? .. or define these

[jira] Commented: (THRIFT-819) add Enumeration for protocol, transport and server types

2010-08-13 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898383#action_12898383 ] David Reiss commented on THRIFT-819: I think it wold be better to just put these enums

[jira] Commented: (THRIFT-819) add Enumeration for protocol, transport and server types

2010-08-13 Thread Mark Slee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898393#action_12898393 ] Mark Slee commented on THRIFT-819: -- I tend to agree with David here. One of the main ideas

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Doug Cutting
+1 Checksum, signature, RAT output all look good. Doug On 08/12/2010 09:40 PM, Bryan Duxbury wrote: Hi all, As discussed, in all the time it took for us to finally release Thrift 0.3, we've accumulated enough changes for Thrift 0.4! I propose we accept

[jira] Created: (THRIFT-849) HTML Generator: sorting of Services and Data Types is wrong within TOC

2010-08-13 Thread Roger Meier (JIRA)
HTML Generator: sorting of Services and Data Types is wrong within TOC -- Key: THRIFT-849 URL: https://issues.apache.org/jira/browse/THRIFT-849 Project: Thrift Issue Type:

[jira] Updated: (THRIFT-849) HTML Generator: sorting of Services and Data Types is wrong within TOC

2010-08-13 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-849: --- Attachment: THRIFT-849_Services_Datatypes_Order__Datatypes_with_Key.patch HTML Generator: sorting

RE: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Mark Slee
+1 from me. Looks sane. -Original Message- From: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove, but not

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
Hi Everyone Anybody else having issues with the configure script ? I break on ./configure: line 20618: syntax error near unexpected token `thrift,' ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift, 0.4.0)' On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee ms...@facebook.com

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
Sorry, some details Running GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu) Copyright (C) 2005 Free Software Foundation, Inc. on Red Hat Enterprise Linux Server release 5.3 (Tikanga) On Fri, Aug 13, 2010 at 4:28 PM, George Godik ggo...@gmail.com wrote: Hi Everyone Anybody

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote: Hi all, As discussed, in all the time it took for us to finally release Thrift 0.3, we've accumulated enough changes for Thrift 0.4! I propose we accept

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread David Reiss
did you re-run ./bootstrap.sh? You aren't supposed to do that for release tarballs. On 08/13/2010 01:30 PM, George Godik wrote: Sorry, some details Running GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu) Copyright (C) 2005 Free Software Foundation, Inc. on Red Hat

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
David - I assume you're addressing me and not Rush It seems I did run bootstrap.sh - clean dir helped Thanks On Fri, Aug 13, 2010 at 4:44 PM, David Reiss dre...@facebook.com wrote: did you re-run ./bootstrap.sh? You aren't supposed to do that for release tarballs. On 08/13/2010 01:30 PM,

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Joe Schaefer
Upayavira is currently travelling and probably won't have time to vote on the release, so the sooner you pass this vote along to gene...@incubator asking for votes from IPMC members, the better.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
On 8/13/2010 1:28 PM, George Godik wrote: Hi Everyone Anybody else having issues with the configure script ? I break on ./configure: line 20618: syntax error near unexpected token `thrift,' ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift, 0.4.0)' This happens on

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time. --- configure.ac.orig 2010-08-13 14:31:33.0 -0700 +++

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct? I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included,

[jira] Closed: (THRIFT-819) add Enumeration for protocol, transport and server types

2010-08-13 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier closed THRIFT-819. -- Resolution: Not A Problem I agree, it isn't realistic to align such enumerations across all languages.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as well as the Makefile.PL, so it appears to be a runtime dependency, not just a test one. The other way to do this is to not build the Thrift perl libraries if the module detection fails, by tweaking the WITH_PERL variable.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
Well, if it's a runtime requirement, then the configure should check for it, but only if --with-perl=yes, and fail if it's not installed. Then if I don't want to install it I can just configure with --with-perl=no. HOWEVER, I started fresh and configured like this: ./configure

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
Sure, I could submit a configure.ac patch to do the perl checks. The make check fails because UnitTests_LDADD in the test/Makefile.am doesn't include $(BOOST_LDFLAGS), so if boost is in a non-standard location (for example MacPorts puts it in /opt/local), the Makefile can't find it at link