Re: [VOTE] Thrift 0.4.0 RC0

2010-08-26 Thread Todd Lipcon
Anyone have any fix for this? Trying to run java unit tests for first time in a long time and seeing it as well. ulimit is 1024 here. Sun java 6_20 -Todd On Mon, Aug 16, 2010 at 10:14 AM, Anthony Molinaro antho...@alumni.caltech.edu wrote: Yeah, actually they pass for me as well in Mac with

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-26 Thread Todd Lipcon
On Thu, Aug 26, 2010 at 10:37 PM, Todd Lipcon t...@cloudera.com wrote: Anyone have any fix for this? Trying to run java unit tests for first time in a long time and seeing it as well. ulimit is 1024 here. Sun java 6_20 Never mind - filed THRIFT-873, will commit when my coworker confirms the

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-16 Thread Anthony Molinaro
Okay, so I got it to pass the tests. I started playing with the number of threads in the async test since that was the first that failed, and that works, but seemed odd. 100 works fine, 400 works fine, 490 causes a test several past the async test to fail. This makes me think somehow junit is

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-16 Thread Anthony Molinaro
Yeah, actually they pass for me as well in Mac with only 256. So I'm thinking it could somehow be vmware, or maybe I have some bad network config, do the tests open a lot of sockets? The java versions are almost identical CentOS % java -version java version 1.6.0_20 Java(TM) SE Runtime

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-16 Thread Bryan Duxbury
I'm going to -1 this tarball myself due to issues with the PHP extension building. I'll post another RC momentarily. On Mon, Aug 16, 2010 at 10:14 AM, Anthony Molinaro antho...@alumni.caltech.edu wrote: Yeah, actually they pass for me as well in Mac with only 256. So I'm thinking it could

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-15 Thread Bryan Duxbury
br...@rapleaf.com To: thrift-dev@incubator.apache.org Sent: Fri, August 13, 2010 12:40:59 AM Subject: [VOTE] Thrift 0.4.0 RC0 Hi all, As discussed, in all the time it took for us to finally release Thrift 0.3, we've accumulated enough changes for Thrift 0.4! I propose we

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-15 Thread Bryan Duxbury
On my local machine, the java library tests cleanly. The errors in your build output seem to be related to available file handles, which should never be an issue. I'm not sure this is a real bug or not, but could you please open a ticket for us to investigate? On Sat, Aug 14, 2010 at 1:37 PM,

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
Works fine on CentOS 5.5. On Snow Leopard, make check was returning this: libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o -Wl,-bind_at_load ./.libs/libtestgencpp.a

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Kevin Clark
We used to do it at Powerset. If you're installing thrift for 4 languages it's nice to use the same technique for the 5th. Though I don't recall if the Ruby make target was changed to just generate the gem these days, in which case it probably doesn't matter. Bryan - I can probably give you

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Bryan Duxbury
On Fri, Aug 13, 2010 at 8:18 AM, David Reiss dre...@facebook.com wrote: +1 There are a few ._BLAH files in there that would be nice to remove, but not critical. Do you feel like opening a ticket for this cleanup? We can tackle it in the next release. As an aside... Does anyone use

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Bryan Duxbury
On Fri, Aug 13, 2010 at 8:34 AM, Kevin Clark kevin.cl...@gmail.com wrote: Bryan - I can probably give you appropriate credentials, though it'd have to wait til I'm back in civilization (start of September). Sounds good.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Anthony Molinaro
On Fri, Aug 13, 2010 at 09:15:50AM -0700, Bryan Duxbury wrote: On Fri, Aug 13, 2010 at 8:18 AM, David Reiss dre...@facebook.com wrote: As an aside... Does anyone use configure and make to build the ruby stuff? If not, can we just delete Ruby support from the configure script? It's

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread James Clarke
I cannot get this to build on Mac OS X 10.6.4. It appears the cpp library is failing. boost @1.43.0_0 zlib @1.2.5_0 libevent @1.4.14b_0 Here is where it fails. Making all in cpp /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Doug Cutting
+1 Checksum, signature, RAT output all look good. Doug On 08/12/2010 09:40 PM, Bryan Duxbury wrote: Hi all, As discussed, in all the time it took for us to finally release Thrift 0.3, we've accumulated enough changes for Thrift 0.4! I propose we accept

RE: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Mark Slee
+1 from me. Looks sane. -Original Message- From: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
wrote: +1 from me. Looks sane. -Original Message- From: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
. Looks sane. -Original Message- From: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove, but not critical

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote: Hi all, As discussed, in all the time it took for us to finally release Thrift 0.3, we've accumulated enough changes for Thrift 0.4! I propose we accept

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread David Reiss
@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove, but not critical. As an aside... Does anyone use configure and make to build the ruby stuff? If not, can we just delete Ruby support from the configure script? It's gotten

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread George Godik
, Mark Slee ms...@facebook.com wrote: +1 from me. Looks sane. -Original Message- From: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Joe Schaefer
Upayavira is currently travelling and probably won't have time to vote on the release, so the sooner you pass this vote along to gene...@incubator asking for votes from IPMC members, the better.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
: David Reiss [mailto:dre...@facebook.com] Sent: Friday, August 13, 2010 8:19 AM To: thrift-dev@incubator.apache.org Subject: Re: [VOTE] Thrift 0.4.0 RC0 +1 There are a few ._BLAH files in there that would be nice to remove, but not critical. As an aside... Does anyone use configure and make

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time. --- configure.ac.orig 2010-08-13 14:31:33.0 -0700 +++

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct? I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included,

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as well as the Makefile.PL, so it appears to be a runtime dependency, not just a test one. The other way to do this is to not build the Thrift perl libraries if the module detection fails, by tweaking the WITH_PERL variable.

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Rush Manbert
Well, if it's a runtime requirement, then the configure should check for it, but only if --with-perl=yes, and fail if it's not installed. Then if I don't want to install it I can just configure with --with-perl=no. HOWEVER, I started fresh and configured like this: ./configure

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-13 Thread Michael Lum
Sure, I could submit a configure.ac patch to do the perl checks. The make check fails because UnitTests_LDADD in the test/Makefile.am doesn't include $(BOOST_LDFLAGS), so if boost is in a non-standard location (for example MacPorts puts it in /opt/local), the Makefile can't find it at link

Re: [VOTE] Thrift 0.4.0 RC0

2010-08-12 Thread Joe Schaefer
I plan to take a look at this over the weekend, but I'd again like to suggest that you add your apache.org address to your pgp key and put your key in /x1/www/www.apache.org/dist/incubator/thrift/KEYS on people.apache.org. Both Todd's key and mine are already there. You might want to