svn commit: r535591 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/Criteria.java runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java site/trunk/xdocs/changes.xml

2007-05-06 Thread tfischer
Author: tfischer Date: Sun May 6 03:05:04 2007 New Revision: 535591 URL: http://svn.apache.org/viewvc?view=revrev=535591 Log: Fixed Null Pointer Exceptions in Criteria.equals() and Criteria.hashCode() if joins are null. Thanks to Sean Gilligan. Fixes TORQUE-90. Modified:

[jira] Closed: (TORQUE-90) NPE in Criteria.equals when joins is null

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Fischer closed TORQUE-90. Resolution: Fixed Fix Version/s: 3.3-RC3 NPE in Criteria.equals when joins is null

upgrading dependencies

2007-05-06 Thread Thomas Fischer
generator: componentcurrent new ant 1.6.5 1.7.0 (new features) commons-collections 3.1 3.2 (bugfix release, binary compatible) commons-lang 2.1 2.3 (mostly bugfix) commons-logging 1.0.4 1.1 (compatible for callers) velocity

[jira] Commented: (TORQUE-74) Targets sql and datasql can't find required files

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493918 ] Thomas Fischer commented on TORQUE-74: -- Does Greg's suggestion fix this issue? Please let us know if this has

Re: svn commit: r535591 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/Criteria.java runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java site/trunk/xdocs/changes.xml

2007-05-06 Thread Thomas Vandahl
[EMAIL PROTECTED] wrote: asColumns.equals(criteria.getAsColumns()) - joins.equals(criteria.getJoins()) + ObjectUtils.equals(joins, criteria.getJoins()) Actually, I had a look at that code and I asked myself why the list of joins is

Re: upgrading dependencies

2007-05-06 Thread Thomas Vandahl
Thomas Fischer wrote: commons-pool 1.3 1.2 (needed by dbcp 1.2.2) This should probably read commons-pool 1.2 1.3 (needed by dbcp 1.2.2) Right? I have no opinion about velocity, Thomas V knows mora about the circumstances than I do (if you want to upgrade, please

svn commit: r535596 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/SQLBuilder.java site/trunk/xdocs/changes.xml

2007-05-06 Thread tfischer
Author: tfischer Date: Sun May 6 03:47:39 2007 New Revision: 535596 URL: http://svn.apache.org/viewvc?view=revrev=535596 Log: OrderBy now accepts column names without a dot. No additional processing is made for these. Partially fixes TORQUE-89. Thanks to Stefan Birrer for proposing the change.

[jira] Commented: (TORQUE-89) OrderByColumn for COUNT, SUM

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493919 ] Thomas Fischer commented on TORQUE-89: -- I did not understand that the change in processOrderBy was the main

Re: upgrading dependencies

2007-05-06 Thread Thomas Fischer
You are correct. 1.2 is the current version, and 1.3 is the proposed new version. Thomas On Sun, 6 May 2007, Thomas Vandahl wrote: Thomas Fischer wrote: commons-pool 1.3 1.2 (needed by dbcp 1.2.2) This should probably read commons-pool 1.2 1.3 (needed by

Re: svn commit: r535591 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/Criteria.java runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java site/trunk/xdocs/changes.xml

2007-05-06 Thread Thomas Fischer
The transient was added by Scott when he tried to serialize the Criteria. Somehow the default serialisation mechanism did not work for the Criteria.Join object; no idea why. There is no particular reason why the joins are initialized as null and not as empty list. If you want to change that,

[jira] Assigned: (TORQUE-89) OrderByColumn for COUNT, SUM

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Fischer reassigned TORQUE-89: Assignee: Thomas Fischer OrderByColumn for COUNT, SUM

[jira] Commented: (TORQUE-91) Index-column size attribute is documented but does not work

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493921 ] Thomas Fischer commented on TORQUE-91: -- If the size attribute is a quasi-standard, then we should keep it. A

[jira] Commented: (TORQUE-84) Limit/Offset solution for MSSQL Server

2007-05-06 Thread Thomas Fischer (JIRA)
[ https://issues.apache.org/jira/browse/TORQUE-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493922 ] Thomas Fischer commented on TORQUE-84: -- - PLEASE give an example what the limit/offset patch is for. I have

Re: svn commit: r535591 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/Criteria.java runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java site/trunk/xdocs/changes.xml

2007-05-06 Thread Thomas Vandahl
Thomas Fischer wrote: There is no particular reason why the joins are initialized as null and not as empty list. If you want to change that, please go ahead. Ok, I'll do that. This would also mean to roll back the stuff to fix TORQUE-90, because joins would never be null, agreed? Looks somehow

svn commit: r535615 - in /db/torque/runtime/trunk/src/java/org/apache/torque/util: BasePeer.java Criteria.java JoinBuilder.java

2007-05-06 Thread tv
Author: tv Date: Sun May 6 07:11:05 2007 New Revision: 535615 URL: http://svn.apache.org/viewvc?view=revrev=535615 Log: Make joins and aliases to behave like all other lists and maps in Criteria. This makes a couple of null-checks obsolete. Modified:

Fwd: [ANNOUNCEMENT] release of Anakia 1.0 and Texen 1.0

2007-05-06 Thread Will Glass-Husain
Dear Torque-Developing Colleagues, Wanted to call your attention to the following announcement. We've just spun Texen off into its own release, with a new package: org.apache.texen (instead of org.apache.velocity.texen). The 1.0 release is essentially identical to what was in Velocity 1.5.

Re: Avalon-Test complains about not being able to close a DataSource

2007-05-06 Thread Thomas Vandahl
Thomas Fischer wrote: When I build the runtime and the org.apache.torque.avalon.AvalonTest is run, an exception stacktrace is printed about a NuLlPointerException at org.apache.commons.dbcp.datasources.SharedPoolDataSource.close(SharedPoolDataSource.java:64) However, the test case succeeds.

svn commit: r535621 - in /db/torque: generator/trunk/ generator/trunk/src/java/org/apache/torque/task/ maven-plugin/trunk/ maven2-plugin/trunk/src/main/java/org/apache/torque/mojo/

2007-05-06 Thread tv
Author: tv Date: Sun May 6 08:18:41 2007 New Revision: 535621 URL: http://svn.apache.org/viewvc?view=revrev=535621 Log: Added the dependency on velocity/texen and changed the related places to use the new package. Updated dependendcy to velocity 1.5. This includes my very first line of Jelly!

svn commit: r535622 - in /db/torque: common/trunk/ generator/trunk/src/conf/ generator/trunk/xdocs/ site/trunk/xdocs/ tutorial/trunk/xdocs/

2007-05-06 Thread tv
Author: tv Date: Sun May 6 08:20:54 2007 New Revision: 535622 URL: http://svn.apache.org/viewvc?view=revrev=535622 Log: Changed version number to 3.3-RC3 at all places. Modified: db/torque/common/trunk/project.xml db/torque/generator/trunk/src/conf/build-torque.xml