[tryton-dev] tryton-rietveld: Add new rss feed, remove cc to ML and google-analytics (issue 947002)

2013-06-25 Thread cedric . krier
Reviewers: , Description: tryton-rietveld: Add new rss feed, remove cc to ML and google-analytics Please review this at http://codereview.tryton.org/947002/ Affected files: M codereview/feeds.py M codereview/urls.py M codereview/views.py M index.yaml M templates/base.html A

[tryton-dev] account_dunning: New module (issue 939002)

2013-06-21 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/939002/ Affected files: A COPYRIGHT A INSTALL A LICENSE A MANIFEST.in A README A __init__.py A account.py A account.xml A doc/index.rst A dunning.py A dunning.xml A party.py A party.xml A setup.py A

[tryton-dev] trytond: Correctly compute missing dependencies (issue 935002)

2013-06-19 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/935002/ Affected files: M trytond/modules/__init__.py Index: trytond/modules/__init__.py === --- a/trytond/modules/__init__.py +++ b/trytond/modules/__init__.py

[tryton-dev] account: Better domain for balance sheet and income statement (issue 933002)

2013-06-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/933002/ Affected files: M account.xml Index: account.xml === --- a/account.xml +++ b/account.xml @@ -618,7 +618,7 @@ record model=ir.action.act_window

[tryton-dev] account_fr: Add missing income_statement and fix balance_sheet (issue 929003)

2013-06-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/929003/ Affected files: M account_fr.xml

[tryton-dev] trytond: Reduce IN_MAX by number of columns in UNIQUE validation (issue 934002)

2013-06-17 Thread cedric . krier
Reviewers: , Description: trytond: Reduce IN_MAX by number of columns in UNIQUE validation Please review this at http://codereview.tryton.org/934002/ Affected files: trytond/model/modelsql.py Index: trytond/model/modelsql.py

[tryton-dev] account_payment: New module (issue 926002)

2013-06-11 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/926002/ Affected files: A COPYRIGHT A INSTALL A LICENSE A MANIFEST.in A README A __init__.py A account.py A account.xml A journal.py A journal.xml A payment.py A payment.xml A tryton.cfg A

[tryton-dev] production: Add calendar view (issue 924002)

2013-06-08 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/924002/ Affected files: M CHANGELOG M production.xml A view/production_calendar.xml Index: CHANGELOG === --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,5 @@ +*

[tryton-dev] wiki: New proposal for payment (issue 923002)

2013-06-07 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/923002/ Affected files: M PaymentOrder.wiki

[tryton-dev] fix create_leveling issue3246 (issue 919002)

2013-06-06 Thread cedric . krier
NOT LGTM you must search for root sibling Also prefix the title with the name of the module. http://codereview.tryton.org/919002/

[tryton-dev] project_plan: Fix wrong parent test in create_leveling (issue 920002)

2013-06-06 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/920002/ Affected files: M work.py Index: work.py === --- a/work.py +++ b/work.py @@ -522,9 +522,8 @@ yield sibling, delay -parent =

[tryton-dev] trytond: Check read access for Attachment models (issue 921002)

2013-06-06 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/921002/ Affected files: M trytond/ir/attachment.py Index: trytond/ir/attachment.py === --- a/trytond/ir/attachment.py +++ b/trytond/ir/attachment.py @@ -96,10

[tryton-dev] tryton: Don't send not loaded value for on_change (issue 919003)

2013-06-06 Thread cedric . krier
Reviewers: , Description: tryton: Don't send not loaded value for on_change Please review this at http://codereview.tryton.org/919003/ Affected files: M tryton/gui/window/view_form/model/record.py Index: tryton/gui/window/view_form/model/record.py

[tryton-dev] stock_product_location: Add missing ondelete CASCADE (issue 922002)

2013-06-06 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/922002/ Affected files: M location.py Index: location.py === --- a/location.py +++ b/location.py @@ -17,11 +17,12 @@ ''' __name__ =

[tryton-dev] tryton: del editabletree_entry on remove-widget instead of quit_cell (issue 918002)

2013-06-05 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/918002/ Affected files: M tryton/gui/window/view_form/view/list_gtk/editabletree.py Index: tryton/gui/window/view_form/view/list_gtk/editabletree.py === ---

[tryton-dev] wiki: More generic Dunning design (issue 916002)

2013-06-04 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/916002/ Affected files: M DunningModule.wiki Index: DunningModule.wiki === --- a/DunningModule.wiki +++ b/DunningModule.wiki @@ -7,71 +7,66 @@ = Objectives

[tryton-dev] stock_supply: Prevent delete of purchased request (issue 907003)

2013-05-29 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/907003/ Affected files: M purchase_request.py Index: purchase_request.py === --- a/purchase_request.py +++ b/purchase_request.py @@ -73,6 +73,8 @@

[tryton-dev] stock: Add effective_date on move list view (issue 907002)

2013-05-28 Thread cedric . krier
Reviewers: , Description: stock: Add effective_date on move list view Please review this at http://codereview.tryton.org/907002/ Affected files: M view/move_tree.xml Index: view/move_tree.xml === --- a/view/move_tree.xml +++

[tryton-dev] purchase: Add missing process call on purchase when invoice's posted (issue 905002)

2013-05-27 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/905002/ Affected files: M invoice.py M tests/scenario_purchase.rst Index: invoice.py === --- a/invoice.py +++ b/invoice.py @@ -1,5 +1,7 @@ #This file is part

[tryton-dev] stock: Add products_by_location test on period test (issue 897003)

2013-05-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/897003/ Affected files: M tests/test_stock.py Index: tests/test_stock.py === --- a/tests/test_stock.py +++ b/tests/test_stock.py @@ -377,7 +377,8 @@

[tryton-dev] account_invoice: Hide payment_lines when paid or empty (issue 900003)

2013-05-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/93/ Affected files: M invoice.py Index: invoice.py === --- a/invoice.py +++ b/invoice.py @@ -140,7 +140,11 @@ lines_to_pay =

[tryton-dev] trytond: Use one getter for all amounts in Sale, Purchase and Invoice (issue 897002)

2013-05-23 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/897002/ Affected files: M trytond/modules/account_invoice/invoice.py M trytond/modules/purchase/purchase.py M trytond/modules/sale/sale.py

[tryton-dev] trytond: Fix Pool.setup to re-allow extra_depends behavior (issue 898002)

2013-05-23 Thread cedric . krier
Reviewers: , Description: trytond: Fix Pool.setup to re-allow extra_depends behavior Please review this at http://codereview.tryton.org/898002/ Affected files: M trytond/pool.py Index: trytond/pool.py === --- a/trytond/pool.py

[tryton-dev] trytond: Add doc about type of PYSON (issue 901002)

2013-05-23 Thread cedric . krier
Reviewers: , Description: trytond: Add doc about type of PYSON Please review this at http://codereview.tryton.org/901002/ Affected files: M doc/ref/pyson.rst M doc/topics/pyson.rst Index: doc/ref/pyson.rst === ---

[tryton-dev] trytond: Use stock move worklow instead of overriding create/write (issue 902002)

2013-05-23 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/902002/ Affected files: M trytond/modules/purchase/purchase.py M trytond/modules/sale/sale.py M trytond/modules/stock_lot/stock.py Index: trytond/modules/purchase/purchase.py

[tryton-dev] trytond: Set correct instanciate for selection_change_with (issue 886002)

2013-05-22 Thread cedric . krier
Reviewers: , Description: trytond: Set correct instanciate for selection_change_with Please review this at http://codereview.tryton.org/886002/ Affected files: M trytond/model/model.py Index: trytond/model/model.py === ---

[tryton-dev] trytond: Remove purchasable/salable from context (issue 887002)

2013-05-22 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/887002/ Affected files: M trytond/modules/purchase/purchase.py M trytond/modules/sale/sale.py Index: trytond/modules/purchase/purchase.py === ---

[tryton-dev] stock: Add shipment on Move form view (issue 888002)

2013-05-22 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/888002/ Affected files: M shipment.py M view/move_form.xml Index: shipment.py === --- a/shipment.py +++ b/shipment.py @@ -79,7 +79,7 @@ warehouse_storage

[tryton-dev] trytond: Clean old str date in format_lang (issue 893002)

2013-05-22 Thread cedric . krier
Reviewers: , Description: trytond: Clean old str date in format_lang Please review this at http://codereview.tryton.org/893002/ Affected files: M trytond/report/report.py Index: trytond/report/report.py === ---

[tryton-dev] stock_supply: Add read access to purchase and purchase line to purchase request group (issue 876002)

2013-05-17 Thread cedric . krier
Reviewers: , Description: stock_supply: Add read access to purchase and purchase line to purchase request group Please review this at http://codereview.tryton.org/876002/ Affected files: M purchase_request.xml Index: purchase_request.xml

[tryton-dev] product: Add searcher to default_uom_category (issue 877002)

2013-05-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/877002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -49,7 +49,8 @@ default_uom_category = fields.Function(

[tryton-dev] project_revenue: Add domain for uom category on product (issue 878002)

2013-05-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/878002/ Affected files: M work.py Index: work.py === --- a/work.py +++ b/work.py @@ -2,7 +2,7 @@ #this repository contains the full copyright notices and

[tryton-dev] project_invoice: Prevent modify invoiced timesheet line (issue 879002)

2013-05-17 Thread cedric . krier
Reviewers: , Description: project_invoice: Prevent modify invoiced timesheet line Please review this at http://codereview.tryton.org/879002/ Affected files: M timesheet.py Index: timesheet.py === --- a/timesheet.py +++

[tryton-dev] project_invoice: Test scenario with non-admin user (issue 880002)

2013-05-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/880002/ Affected files: M tests/scenario_project_invoice_effort.rst M tests/scenario_project_invoice_timesheet.rst A timesheet.xml M tryton.cfg Index: tests/scenario_project_invoice_effort.rst

[tryton-dev] tryton: Fix creation of export_fields (issue 874002)

2013-05-16 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/874002/ Affected files: tryton/gui/window/win_export.py Index: tryton/gui/window/win_export.py === --- a/tryton/gui/window/win_export.py +++

[tryton-dev] www.tryton.org: Add news about last maintenance release 1.8 (issue 869002)

2013-05-14 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/869002/ Affected files: A posts/last-maintenance-releases-for-series-18.txt Index: posts/last-maintenance-releases-for-series-18.txt === new file mode 100644

[tryton-dev] trytond: Autoreconcile posted move with one line of zero (issue 867002)

2013-05-13 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/867002/ Affected files: M trytond/modules/account/move.py M trytond/modules/account_invoice/invoice.py M trytond/modules/account_invoice/tests/scenario_invoice.rst Index: trytond/modules/account/move.py

[tryton-dev] tryton: Remove unused focus test on WinForm (issue 868002)

2013-05-13 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/868002/ Affected files: M tryton/gui/window/win_form.py Index: tryton/gui/window/win_form.py === --- a/tryton/gui/window/win_form.py +++

[tryton-dev] sale=_supply: Don't create duplicate move (issue 857002)

2013-05-08 Thread cedric . krier
Reviewers: , Description: sale=_supply: Don't create duplicate move Please review this at http://codereview.tryton.org/857002/ Affected files: M sale.py Index: sale.py === --- a/sale.py +++ b/sale.py @@ -82,7 +82,8 @@ def

[tryton-dev] sale_supply: Process sale also when processing purchase (issue 858002)

2013-05-08 Thread cedric . krier
Reviewers: , Description: sale_supply: Process sale also when processing purchase Please review this at http://codereview.tryton.org/858002/ Affected files: M purchase.py Index: purchase.py === --- a/purchase.py +++

[tryton-dev] www.tryton.org: Add Gittip (issue 850004)

2013-05-07 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/850004/ Affected files: M stories/foundation/donations.txt M stories/foundation/donations.txt.ca M stories/foundation/donations.txt.es Index: stories/foundation/donations.txt

[tryton-dev] trytond: Always sleep on login and use session timeout as limit to count fail attempt (issue 852002)

2013-05-04 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/852002/ Affected files: M trytond/res/user.py Index: trytond/res/user.py === --- a/trytond/res/user.py +++ b/trytond/res/user.py @@ -460,11 +460,11 @@

[tryton-dev] trytond: Extend Lot Management (issue 845002)

2013-04-30 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/845002/ Affected files: M trytond/modules/stock/CHANGELOG M trytond/modules/stock/inventory.py M trytond/modules/stock/location.py M trytond/modules/stock/move.py M trytond/modules/stock/period.py M

[tryton-dev] project_plan: Make leveling_delay and back_leveling_delay required (issue 838002)

2013-04-29 Thread cedric . krier
http://codereview.tryton.org/838002/diff/1/work.py File work.py (right): http://codereview.tryton.org/838002/diff/1/work.py#newcode82 work.py:82: table.not_null_action('leveling_delay', action='add') Not needed. http://codereview.tryton.org/838002/

[tryton-dev] project_invoice: Typo in customer_tax_rule test (issue 843002)

2013-04-29 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/843002/ Affected files: M work.py Index: work.py === --- a/work.py +++ b/work.py @@ -308,7 +308,7 @@ pattern = invoice_line._get_tax_rule_pattern()

[tryton-dev] trytond: Allow None in child_of operator (issue 844002)

2013-04-29 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/844002/ Affected files: M trytond/model/modelsql.py Index: trytond/model/modelsql.py === --- a/trytond/model/modelsql.py +++ b/trytond/model/modelsql.py @@

[tryton-dev] Factorise selection shortcuts (issue 836002)

2013-04-27 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/836002/ Affected files: M tryton/common/cellrenderercombo.py M tryton/common/selection.py M tryton/gui/window/view_form/view/form_gtk/dictionary.py M tryton/gui/window/view_form/view/form_gtk/selection.py Index:

[tryton-dev] stock_supply: Add warning for late supplier moves when creating purchase request (issue 821002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/821002/ Affected files: M CHANGELOG M purchase_request.py Index: CHANGELOG === --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,5 @@ +* Add warning for late

[tryton-dev] trytond: Store selection tree state (issue 822002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/822002/ Affected files: M CHANGELOG M trytond/ir/__init__.py M trytond/ir/ui/view.py M trytond/ir/ui/view.xml A trytond/ir/view/ui_view_tree_state_form.xml A trytond/ir/view/ui_view_tree_state_list.xml M

[tryton-dev] tryton: Manage selection tree state (issue 823002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/823002/ Affected files: M tryton/config.py M tryton/gui/main.py M tryton/gui/window/view_form/screen/screen.py M tryton/gui/window/view_form/view/list.py M tryton/gui/window/view_form/view/list_gtk/parser.py M

[tryton-dev] trytond: Add factor on number fields (issue 824002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/824002/ Affected files: M CHANGELOG M doc/topics/views/index.rst M trytond/ir/ui/form.rnc M trytond/ir/ui/form.rng M trytond/ir/ui/tree.rnc M trytond/ir/ui/tree.rng M trytond/modules/account/CHANGELOG M

[tryton-dev] tryton: Add factor on number widgets (issue 825002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/825002/ Affected files: M CHANGELOG M tryton/gui/window/view_form/model/field.py M tryton/gui/window/view_form/view/form_gtk/float.py M tryton/gui/window/view_form/view/form_gtk/integer.py M

[tryton-dev] tryton: Add Ctrl-Space shortcut for selection field in treeview (issue 826002)

2013-04-24 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/826002/ Affected files: M tryton/common/cellrenderercombo.py Index: tryton/common/cellrenderercombo.py === --- a/tryton/common/cellrenderercombo.py +++

[tryton-dev] trytond: Fix encoding of __file__ for windows (issue 816002)

2013-04-22 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/816002/ Affected files: M trytond/ir/ui/view.py M trytond/tools/misc.py Index: trytond/ir/ui/view.py === --- a/trytond/ir/ui/view.py +++

[tryton-dev] Better test for quoting empty string (issue 811002)

2013-04-18 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/811002/ Affected files: M tryton/common/domain_parser.py Index: tryton/common/domain_parser.py === --- a/tryton/common/domain_parser.py +++

[tryton-dev] www.tryton.org: New Tryton release 2.8 (issue 812002)

2013-04-18 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/812002/ Affected files: files/images/tryton_act_window_domain.png files/images/tryton_bookmark.png files/images/tryton_completion.png files/images/tryton_contact_mechanisms_url.png files/images/tryton_global_search.png

[tryton-dev] account: Fix tax_code usage as it can be None (issue 813002)

2013-04-18 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/813002/ Affected files: M move.py Index: move.py === --- a/move.py +++ b/move.py @@ -808,7 +808,9 @@ line.debit or line.credit, 1):

[tryton-dev] account: Set company in context in wizard CreateChart (issue 804002)

2013-04-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/804002/ Affected files: M account.py Index: account.py === --- a/account.py +++ b/account.py @@ -1659,7 +1659,8 @@

[tryton-dev] trytond: Fix ir_translation clause on res_id (issue 805002)

2013-04-17 Thread cedric . krier
Reviewers: , Description: trytond: Fix ir_translation clause on res_id Please review this at http://codereview.tryton.org/805002/ Affected files: M trytond/model/modelsql.py Index: trytond/model/modelsql.py === ---

[tryton-dev] sao: Add wizard (issue 806002)

2013-04-17 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/806002/ Affected files: M Gruntfile.js M src/action.js M src/common.js M src/screen.js A src/wizard.js

[tryton-dev] stock: Sync planned date of supplier shipment only for later (issue 797002)

2013-04-16 Thread cedric . krier
Reviewers: , Description: stock: Sync planned date of supplier shipment only for later Please review this at http://codereview.tryton.org/797002/ Affected files: M shipment.py Index: shipment.py === --- a/shipment.py +++

[tryton-dev] trytond: Set _order_name to ActionMixin (issue 799002)

2013-04-16 Thread cedric . krier
Reviewers: , Description: trytond: Set _order_name to ActionMixin Please review this at http://codereview.tryton.org/799002/ Affected files: M trytond/ir/action.py Index: trytond/ir/action.py === --- a/trytond/ir/action.py +++

[tryton-dev] trytond: Improve domain doc about deferencing to related models (issue 800002)

2013-04-16 Thread cedric . krier
Reviewers: , Description: trytond: Improve domain doc about deferencing to related models Please review this at http://codereview.tryton.org/82/ Affected files: M doc/topics/domain.rst Index: doc/topics/domain.rst === ---

[tryton-dev] tryton: Manage differently None and empty string in domain_parser (issue 803002)

2013-04-16 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/803002/ Affected files: M tryton/common/domain_parser.py Index: tryton/common/domain_parser.py === --- a/tryton/common/domain_parser.py +++

[tryton-dev] trytond: adding schema_model attribute in model.fields_get export list (issue 792002)

2013-04-15 Thread cedric . krier
http://codereview.tryton.org/792002/diff/1/trytond/model/model.py File trytond/model/model.py (right): http://codereview.tryton.org/792002/diff/1/trytond/model/model.py#newcode447 trytond/model/model.py:447: if isinstance(cls._fields[field], fields.Dict): I would prefer to test here if field

[tryton-dev] trytond: SUBSTR doesn't allow negative length (issue 793002)

2013-04-15 Thread cedric . krier
Reviewers: , Description: trytond: SUBSTR doesn't allow negative length Please review this at http://codereview.tryton.org/793002/ Affected files: trytond/ir/translation.py Index: trytond/ir/translation.py === ---

[tryton-dev] purchase: Don't set delivery_date for negative quantity (issue 788002)

2013-04-13 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/788002/ Affected files: M purchase.py Index: purchase.py === --- a/purchase.py +++ b/purchase.py @@ -885,8 +885,14 @@ to_location =

[tryton-dev] sale: Don't set delivery_date for negative quantity (issue 789002)

2013-04-13 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/789002/ Affected files: M sale.py Index: sale.py === --- a/sale.py +++ b/sale.py @@ -971,11 +971,13 @@ to_location =

[tryton-dev] stock: Include NULL planned_date with datetime.date.max (issue 790002)

2013-04-13 Thread cedric . krier
Reviewers: , Description: stock: Include NULL planned_date with datetime.date.max Please review this at http://codereview.tryton.org/790002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py

[tryton-dev] stock: Unit price should also be required for move to supplier (issue 791002)

2013-04-13 Thread cedric . krier
Reviewers: , Description: stock: Unit price should also be required for move to supplier Please review this at http://codereview.tryton.org/791002/ Affected files: M move.py Index: move.py === --- a/move.py +++ b/move.py @@

[tryton-dev] tryton: No need to manage copy of one2many (issue 786002)

2013-04-12 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/786002/ Affected files: M party.py Index: party.py === --- a/party.py +++ b/party.py @@ -176,17 +176,7 @@ default = {} default =

[tryton-dev] account_stock_continental: Pool needs to be instanciated. (issue 787002)

2013-04-12 Thread cedric . krier
http://codereview.tryton.org/787002/diff/3001/product.py File product.py (right): http://codereview.tryton.org/787002/diff/3001/product.py#newcode339 product.py:339: self.ask_price.product.save() not for this patch. http://codereview.tryton.org/787002/

[tryton-dev] project_plan: Don't mix parent object and its id (issue 785002)

2013-04-12 Thread cedric . krier
Indeed I think back_leveling_delay and leveling_delay should be required with an default value to 0. http://codereview.tryton.org/785002/

[tryton-dev] trytond: Replace SPLIT_PART by SUBSTR and POSITION (issue 784002)

2013-04-11 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/784002/ Affected files: M trytond/backend/sqlite/database.py M trytond/ir/translation.py M trytond/model/fields/property.py M trytond/model/modelsql.py Index: trytond/backend/sqlite/database.py

[tryton-dev] product_cost_fifo: Update cost price according to product quantity selected (issue 781002)

2013-04-10 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/781002/

[tryton-dev] trytond 2.4: Fix clean _language_cache (issue 782002)

2013-04-10 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/782002/ Affected files: M trytond/model/modelstorage.py Index: trytond/model/modelstorage.py === --- a/trytond/model/modelstorage.py +++

[tryton-dev] PATCH: sale_supply_drop_shipment: Fix search and read for moves from drop shipment (issue 778002)

2013-04-09 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/778002/ Affected files: M sale.py Index: sale.py === --- a/sale.py +++ b/sale.py @@ -6,6 +6,7 @@ from trytond.pyson import Eval from trytond.pool import Pool,

[tryton-dev] PATCH: product: Fix Product convert domain for relate clause (issue 777003)

2013-04-09 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/777003/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -206,9 +206,9 @@ and isinstance(arg[1],

[tryton-dev] PATCH: purchase: Avoid showing max date as delivery date (issue 769002)

2013-04-07 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/769002/ Affected files: M purchase.py Index: purchase.py === --- a/purchase.py +++ b/purchase.py @@ -1096,7 +1096,11 @@ date =

[tryton-dev] tryton: Fix focus chain of Calendar widget (issue 766002)

2013-04-06 Thread cedric . krier
Reviewers: , Description: tryton: Fix focus chain of Calendar widget Please review this at http://codereview.tryton.org/766002/ Affected files: M tryton/gui/window/view_form/view/form_gtk/calendar.py Index: tryton/gui/window/view_form/view/form_gtk/calendar.py

[tryton-dev] Use value instead of record instance on import_data (issue 767002)

2013-04-06 Thread cedric . krier
Can not read the patch http://codereview.tryton.org/767002/

[tryton-dev] tryton: Hide search box on focus-out (issue 762002)

2013-04-05 Thread cedric . krier
Reviewers: , Description: tryton: Hide search box on focus-out Please review this at http://codereview.tryton.org/762002/ Affected files: M tryton/gui/window/view_form/view/screen_container.py Index: tryton/gui/window/view_form/view/screen_container.py

[tryton-dev] PATCH: sale_supply: Ensure to process sale only once (issue 763002)

2013-04-05 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/763002/ Affected files: M purchase.py Index: purchase.py === --- a/purchase.py +++ b/purchase.py @@ -30,8 +30,8 @@ SaleLine = pool.get('sale.line')

[tryton-dev] PATCH: trytond: Fix search on tree rec_name (issue 757002)

2013-04-04 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/757002/ Affected files: M trytond/ir/ui/menu.py M trytond/modules/product/category.py M trytond/modules/timesheet/work.py Index: trytond/ir/ui/menu.py ===

[tryton-dev] PATCH: tryton: Fix Calendar.get_value to not set text on entry (issue 759002)

2013-04-04 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/759002/ Affected files: M tryton/common/date_widget.py M tryton/gui/window/view_form/view/form_gtk/calendar.py Index: tryton/common/date_widget.py === ---

[tryton-dev] PATCH: trytond: Catch OverflowError when appending timedelta (issue 761002)

2013-04-04 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/761002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -668,7 +668,10 @@ quantities[date] =

[tryton-dev] product: Fix product order to at least group same products (issue 756002)

2013-04-03 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/756002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -106,7 +106,7 @@ class Product(ModelSQL, ModelView):

[tryton-dev] sale_supply_drop_shipment: Fix missing unique shipment migration (issue 754002)

2013-04-02 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/754002/

[tryton-dev] trytond 2.4: Fix process for cache management of browse record (issue 755002)

2013-04-02 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/755002/ Affected files: M trytond/modules/purchase/purchase.py M trytond/modules/sale/sale.py Index: trytond/modules/purchase/purchase.py === ---

[tryton-dev] trytond: Fix shipment cost with account stock anglo-saxon (issue 752002)

2013-04-01 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/752002/ Affected files: M trytond/modules/account_stock_anglo_saxon/stock.py M trytond/modules/purchase_shipment_cost/stock.py A

[tryton-dev] party_vcarddav: Fix get_data to return str instead of buffer (issue 753002)

2013-04-01 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/753002/ Affected files: M webdav.py Index: webdav.py === --- a/webdav.py +++ b/webdav.py @@ -262,7 +262,7 @@ if party_id: val =

[tryton-dev] product: No need to prevent copying variants as they are explicit now (issue 747002)

2013-03-27 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/747002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -102,14 +102,6 @@ if self.default_uom:

[tryton-dev] production: Don't copy boms when copying product as the domain will be wrong (issue 748002)

2013-03-27 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/748002/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -44,6 +44,14 @@ or

[tryton-dev] purchase_shipment_cost: Use unit_shipment_cost converted to write on move (issue 741003)

2013-03-27 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/741003/ Affected files: stock.py Index: stock.py === --- a/stock.py +++ b/stock.py @@ -128,8 +128,8 @@ unit_shipment_cost =

[tryton-dev] product: Add Function field type on product as some fields could depend on (issue 743003)

2013-03-26 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/743003/ Affected files: M product.py Index: product.py === --- a/product.py +++ b/product.py @@ -13,6 +13,11 @@ 'readonly': ~Eval('active', True), }

[tryton-dev] trytond: Add test for unknown fields in test_depends (issue 745002)

2013-03-26 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/745002/ Affected files: M trytond/tests/test_tryton.py Index: trytond/tests/test_tryton.py === --- a/trytond/tests/test_tryton.py +++

[tryton-dev] tryton: o2m-records changed by on_change (issue 744002)

2013-03-26 Thread cedric . krier
LGTM http://codereview.tryton.org/744002/

[tryton-dev] tryton: Fix group loading when using '*' (issue 744003)

2013-03-26 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/744003/ Affected files: M tryton/gui/window/view_form/model/record.py Index: tryton/gui/window/view_form/model/record.py === ---

[tryton-dev] Update to tip (issue 729002)

2013-03-23 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/729002/ Affected files: M trytond/modules/account_invoice/CHANGELOG M trytond/modules/account_invoice/invoice.py M trytond/modules/account_stock_anglo_saxon/invoice.py M trytond/modules/purchase/CHANGELOG M

[tryton-dev] proteus: class name must be string and not unicode (issue 724002)

2013-03-21 Thread cedric . krier
Reviewers: , Please review this at http://codereview.tryton.org/724002/

  1   2   3   4   5   6   7   8   9   >