Re: [Re: [PATCH]Database stuff]

2000-06-03 Thread Jeff Brekke
Sean Legassick [EMAIL PROTECTED] wrote: SNIP As an aside I noticed that there's some formatting cleanups in there too. Although these do improve the code's readability, my opinion is that they shouldn't be mixed with real code changes as it made it difficult for me to pick out your real

Re: [PATCH]Database stuff

2000-06-03 Thread Rafal Krzewski
I reviewed and tested your patch. On my installation, it works fine with MySQL, Sybase ASE and WebLogic pool driver running on top of the other two. It's good that the .properties file values are used properly now. You have a +1 from me. While testing this stuff on WebLogic 5.1 I made a

Re: [PATCH]Database stuff

2000-06-03 Thread Christopher Elkins
On Tue, Jul 08, 2036 at 08:20:45PM -0500, Jeff Brekke wrote: I have a patch for the database pooling stuff. It is on http://sites.netscape.com/ekkerbj/patches/pool.patch I'll throw in my +1 +1 from me, too. I looked over this and it looked fine to me. I think it's definitely right

Inconsistent JDBC URL in DBInstantDB

2000-06-03 Thread Christopher Elkins
Hi, all. For some reason unbeknownst to me, DBInstantDB was originally coded to handle JDBC URLs in a manner inconsistent with other classes in the same package. Currently, it concatenates the url specified in TurbineResources to the static string "jdbc:idb=". Here's the relevant code:

Turbine and Hypersonic SQL

2000-06-03 Thread Christopher Elkins
Hi, all. Just a quick message to say that I've finished adding support for Hypersonic SQL http://hsql.oron.ch/ using the current DB adapter model. I plan to re-test and commit my code after Jeff commits his DB adapter changes. This now gives us support for two light-weight Java RDBMS

Re: Turbine and Hypersonic SQL

2000-06-03 Thread dave bryson
On Sun, 04 Jun 2000, you wrote: Hi, all. Just a quick message to say that I've finished adding support for Hypersonic SQL http://hsql.oron.ch/ using the current DB adapter model. I plan to re-test and commit my code after Jeff commits his DB adapter changes. Great! I plan on using