[PATCH] clk: sunxi: Add an A31/A23/A33 legacy PRCM MFD driver

2022-11-18 Thread Samuel Holland
When the CCU binding and driver for the PRCM were written, it seems the intention was to convert the A31 and A23/A33 devicetrees to use them. However, that never happened, so those SoCs still use the old binding, with an MFD for the PRCM, and separate DT nodes for clocks and resets. The specifier

Re: Boot Loader Specification (UAPI Group)

2022-11-18 Thread Tom Rini
On Wed, Nov 16, 2022 at 10:50:57AM +, Sebastian Veit wrote: > Dear devs of U-Boot, > > I'd like to know if there's already a work in progress > on the support of the "fairly new" Boot Loader Specification [1]. No, as I don't think anyone here had heard of that project until now. Hopefully

Re: Boot Loader Specification (UAPI Group)

2022-11-18 Thread Mark Kettenis
> Date: Wed, 16 Nov 2022 10:50:57 + > From: Sebastian Veit > > Dear devs of U-Boot, > > I'd like to know if there's already a work in progress > on the support of the "fairly new" Boot Loader Specification [1]. > > Summary of the new spec: Defines a set of file formats and > naming

Re: Boot Loader Specification (UAPI Group)

2022-11-18 Thread Heinrich Schuchardt
On 11/16/22 11:50, Sebastian Veit wrote: Dear devs of U-Boot, I'd like to know if there's already a work in progress on the support of the "fairly new" Boot Loader Specification [1]. Summary of the new spec: Defines a set of file formats and naming conventions to allow distribution independent

Re: problem with reading the NV memory index of TPM slb9670

2022-11-18 Thread Simon Glass
+Ilias Apalodimas On Tue, 15 Nov 2022 at 23:12, Tasos Terzidis wrote: > > Hello, > > I tried to use a tpm2 command for reading the NV memory index of an slb9670 > TPM. > > I noticed in file cmd/tpm-v2.c, that the command tpm2 nv_read_value (as tpm > nv_read_value) > > is not implemented. In

Re: [PATCH v3 3/4] arm_ffa: introduce Arm FF-A low-level driver

2022-11-18 Thread Simon Glass
Hi, On Wed, 16 Nov 2022 at 06:03, Abdellatif El Khlifi wrote: > > On Tue, Nov 15, 2022 at 08:24:24AM -0700, Simon Glass wrote: > > Hi, > > > > On Mon, 1 Aug 2022 at 11:21, Abdellatif El Khlifi > > wrote: > > > > > > Add the driver implementing Arm Firmware Framework for Armv8-A v1.0 > > > > > >

Re: Boot Loader Specification (UAPI Group)

2022-11-18 Thread Simon Glass
+Tom Hi Sebastian, On Wed, 16 Nov 2022 at 05:08, Sebastian Veit wrote: > > Dear devs of U-Boot, > > I'd like to know if there's already a work in progress > on the support of the "fairly new" Boot Loader Specification [1]. > > Summary of the new spec: Defines a set of file formats and > naming

Re: [PATCH 1/3] binman: add sign option for binman

2022-11-18 Thread Simon Glass
Hi Ivan, On Thu, 15 Sept 2022 at 13:44, Ivan Mikhaylov wrote: > > On Wed, 2022-09-07 at 15:10 -0600, Simon Glass wrote: > > Hi Ivan, > > > > Section data comes from the BuildSectionData() method, so you could > > try calling that. > > > > See also collect_contents_to_file() > > > > Regards, > >

Re: U-Boot SPL not getting generated

2022-11-18 Thread Simon Glass
Hi Venkatakrishnan, On Wed, 16 Nov 2022 at 16:56, Venkatakrishnan S ic11539 wrote: > > Hi, > > I am trying to generate u-boot spl for a custom processor based out of > risc-v arch. I have done the defconfig for u-boot proper and is > working now. I am able to use that alone with opensbi. I am

Re: [PATCH] image: fit: Fix not verifying data configuration

2022-11-18 Thread Simon Glass
Hi Sean, On Thu, 13 Oct 2022 at 09:41, Sean Anderson wrote: > > > > On 10/13/22 3:14 AM, Rasmus Villemoes wrote: > > On 12/10/2022 18.28, Sean Anderson wrote: > >> On 10/12/22 08:59, Simon Glass wrote: > >>> Hi Sean, > >>> > >>> On Tue, 11 Oct 2022 at 17:25, Sean Anderson > >>> wrote: > >

Re: [PATCH] fdt: Fix bounds check in devfdt_get_addr_index

2022-11-18 Thread Simon Glass
Hi Samuel, On Thu, 17 Nov 2022 at 21:00, Samuel Holland wrote: > > Hi Simon, > > On 11/7/22 17:35, Simon Glass wrote: > > Hi Samuel, > > > > On Mon, 31 Oct 2022 at 13:27, Simon Glass wrote: > >> > >> On Sun, 30 Oct 2022 at 21:41, Samuel Holland wrote: > >>> > >>> reg must contain enough cells

Re: [PATCH v2020.01] tool: ifwitool: The function localtime() can return NULL.

2022-11-18 Thread Simon Glass
On Fri, 18 Nov 2022 at 05:36, Mikhail Ilin wrote: > > This will cause the local_time pointer is passed as the 4th argument > to function strftime() to also point to NULL. This result in a > segmentation fault. Thus, it's necessary to add a check of the local_time > pointer to NULL. > > Found

Re: [PATCH] tool: ifwitool: Fix buffer overflow

2022-11-18 Thread Simon Glass
On Fri, 18 Nov 2022 at 05:37, Mikhail Ilin wrote: > > An incorrect 1st parameter is passed to the fix_member() > function. Should use a pointer to the beginning of the parent structure > (bpdt or subpart_dir, because are boxed), not to their fields. Otherwise, > this leads to an overrun of

Re: [PATCH v9 4/5] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-11-18 Thread Heinrich Schuchardt
On 11/18/22 10:37, Masahisa Kojima wrote: Hi Heinrhch, On Fri, 18 Nov 2022 at 08:07, Heinrich Schuchardt wrote: On 11/16/22 11:28, Masahisa Kojima wrote: This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll PK, KEK, db and dbx by selecting file. Only

Re: [PATCH 2/2] rockchip: mkimage: make RC4 key const

2022-11-18 Thread Philipp Tomsich
On Fri, 18 Nov 2022 at 17:13, John Keeping wrote: > > This is read-only data, so mark it as such. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

Re: [PATCH 1/2] rc4: mark key as const

2022-11-18 Thread Philipp Tomsich
On Fri, 18 Nov 2022 at 17:13, John Keeping wrote: > > Key data is never written so the parameter can be const, which allows > putting fixed keys in .rodata. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

[PATCH 1/2] rc4: mark key as const

2022-11-18 Thread John Keeping
Key data is never written so the parameter can be const, which allows putting fixed keys in .rodata. Signed-off-by: John Keeping --- include/rc4.h | 2 +- lib/rc4.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/rc4.h b/include/rc4.h index

[PATCH 2/2] rockchip: mkimage: make RC4 key const

2022-11-18 Thread John Keeping
This is read-only data, so mark it as such. Signed-off-by: John Keeping --- tools/rkcommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 0db45c2d41..fab61949e1 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -154,7 +154,7

Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2022-11-18 Thread Sean Anderson
On 11/18/22 07:13, Gary Bisson wrote: > This reverts commit 62649165cb02ab95b57360bb362886935f524f26. > > The patch decreased the write performance quite a bit. > Here is an example on an i.MX 8M Quad platform. > - Before the revert: > Sending sparse 'vendor' 1/2 (516436 KB)OKAY [

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-18 Thread Fabio Estevam
Hi Oliver, On Fri, Nov 18, 2022 at 10:48 AM Oliver Graute wrote: > Ok, I can confirm it builds without the binary blobs with this changes. > I'll change it in patches accordingly Your series has already landed in master. Please send any incremental patches to address Marcel's feedback on top

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-18 Thread Oliver Graute
On 11/11/22, Fabio Estevam wrote: > On Fri, Nov 11, 2022 at 2:40 PM Fabio Estevam wrote: > > > I removed SPL support, which does not seems to be needed as the scufw > > handles DDR init. > > > > I don't have access to an imx8qm/qxp board here. > > > > Could you try removing SPL support from your

Re: [PATCH v2 0/8] imx8: switch missing boards to binman

2022-11-18 Thread Oliver Graute
On 11/11/22, Fabio Estevam wrote: > Hi Oliver, > > On Fri, Nov 11, 2022 at 9:54 AM Oliver Graute wrote: > > > imx8mm_evk_defconfig > > apalis-imx8_defconfig > > > > But where is the difference here? > > With the change below, the imx8qm_mek_defconfig builds without errors > in the absence of

[PATCH] tool: ifwitool: Fix buffer overflow

2022-11-18 Thread Mikhail Ilin
An incorrect 1st parameter is passed to the fix_member() function. Should use a pointer to the beginning of the parent structure (bpdt or subpart_dir, because are boxed), not to their fields. Otherwise, this leads to an overrun of the structure boundary, since in the fix_member() function, an

[PATCH v2020.01] tool: ifwitool: The function localtime() can return NULL.

2022-11-18 Thread Mikhail Ilin
This will cause the local_time pointer is passed as the 4th argument to function strftime() to also point to NULL. This result in a segmentation fault. Thus, it's necessary to add a check of the local_time pointer to NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE.

[PATCH] distro/pxeboot: Handle prompt variable

2022-11-18 Thread Manuel Traut
Regarding the documentation found here: https://github.com/u-boot/u-boot/blob/master/common/menu.c#L347 If both timeout and prompt is set to 0 the default entry shall be booted immediately. However the current behaviour is that the prompt is shown (tested with distroboot) until the user selects

[PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned"

2022-11-18 Thread Gary Bisson
This reverts commit 62649165cb02ab95b57360bb362886935f524f26. The patch decreased the write performance quite a bit. Here is an example on an i.MX 8M Quad platform. - Before the revert: Sending sparse 'vendor' 1/2 (516436 KB)OKAY [ 5.113s] Writing 'vendor'

Re: [v1] spl: nand: allow partial nand page reads during nand_spl_load_image

2022-11-18 Thread Dario Binacchi
Hi Colin, On Tue, Nov 15, 2022 at 5:35 PM Colin Foster wrote: > > The nand_spl_load_image function was guaranteed to read an entire block > into RAM, regardless of how many bytes were to be read. This is > particularly problematic when spl_load_legacy_image is called, as this > function attempts

[PATCH] cli_hush: fix 'exit' cmd that was not exiting scripts

2022-11-18 Thread Hector Palacios
Commit 8c4e3b79bd0bb76eea16869e9666e19047c0d005 supposedly passed one-level up the argument passed to 'exit' but it also broke 'exit' purpose of stopping a script. In reality, even if 'do_exit()' is capable of returning any integer, the cli only admits '1' or '0' as return values. This commit

Re: [PATCH v9 4/5] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-11-18 Thread Masahisa Kojima
Hi Heinrhch, On Fri, 18 Nov 2022 at 08:07, Heinrich Schuchardt wrote: > > On 11/16/22 11:28, Masahisa Kojima wrote: > > This commit adds the menu-driven UEFI Secure Boot Key > > enrollment interface. User can enroll PK, KEK, db > > and dbx by selecting file. > > Only the signed EFI Signature