Re: [PATCH 2/2] configs: am62x_evm_a53: Enable ethernet

2022-12-19 Thread Sjoerd Simons
On Tue, 2022-12-20 at 10:17 +0530, Dhruva Gole wrote: > > > On 19/12/22 21:45, Sjoerd Simons wrote: > > Enable configuration ethernet for u-boot on am62x; Some unrelated > > things > > also got moved around due to running through savedefconfig. > > > > Signed-off-by: Sjoerd Simons > > > > ---

Pull request for tpm-20122022

2022-12-19 Thread Ilias Apalodimas
Hi Tom, The following changes since commit 2243922edca9f56a9d5519b9d6e36f5d7a18434d: Prepare v2023.01-rc4 (2022-12-19 08:45:26 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-20122022 for you to fetch changes up to

Re: [ANN] U-Boot v2023.01-rc4 released

2022-12-19 Thread Jagan Teki
Hi Kever, On Tue, 20 Dec 2022 at 12:37, Kever Yang wrote: > > Hi Jagan, > > On 2022/12/20 14:41, Jagan Teki wrote: > > On Mon, 19 Dec 2022 at 19:16, Tom Rini wrote: > >> Hey all, > >> > >> Here's -rc4, on schedule. I believe this should resolve the case Fedora > >> showed where some binaries

Re: [ANN] U-Boot v2023.01-rc4 released

2022-12-19 Thread Kever Yang
Hi Jagan, On 2022/12/20 14:41, Jagan Teki wrote: On Mon, 19 Dec 2022 at 19:16, Tom Rini wrote: Hey all, Here's -rc4, on schedule. I believe this should resolve the case Fedora showed where some binaries are allowed to be missing, IF a flag is also passed to make. We've got one more patch to

Re: [PATCH] eficonfig: EFI_VARIABLE_APPEND_WRITE is not set for null key

2022-12-19 Thread Ilias Apalodimas
On Tue, Dec 20, 2022 at 12:12:56AM +0900, Masahisa Kojima wrote: > The signed null key with authenticated header is used to clear > the PK, KEK, db and dbx. When CONFIG_EFI_MM_COMM_TEE is enabled > (StMM and OP-TEE based RPMB storage is used as the EFI variable > storage), clearing KEK, db and dbx

Re: [PATCH v2 2/2] eficonfig: avoid SetVariable between GetNextVariableName calls

2022-12-19 Thread Ilias Apalodimas
On Mon, Dec 19, 2022 at 11:33:13AM +0900, Masahisa Kojima wrote: > The current code calls efi_set_variable_int() to delete the > invalid boot option between calls to efi_get_next_variable_name_int(), > it may produce unpredictable results. > > This commit moves removal of the invalid boot option

Re: [PATCH v2 1/2] eficonfig: carve out efi_get_next_variable_name_int calls

2022-12-19 Thread Ilias Apalodimas
On Mon, Dec 19, 2022 at 11:33:12AM +0900, Masahisa Kojima wrote: > To retrieve the EFI variable name by efi_get_next_variable_name_int(), > the sequence of alloc -> efi_get_next_variable_name_int -> > realloc -> efi_get_next_variable_name_int is required. > In current code, this sequence

Re: [ANN] U-Boot v2023.01-rc4 released

2022-12-19 Thread Jagan Teki
On Mon, 19 Dec 2022 at 19:16, Tom Rini wrote: > > Hey all, > > Here's -rc4, on schedule. I believe this should resolve the case Fedora > showed where some binaries are allowed to be missing, IF a flag is also > passed to make. We've got one more patch to make external optional > binaries be more

[PATCH v2 2/2] test: cmd: exit: Add unit test for exit and partly run commands

2022-12-19 Thread Marek Vasut
Add a test which validates that exit from environment script works as expected, including return value propagation and clipping to positive integers. Reviewed-by: Simon Glass Signed-off-by: Marek Vasut --- Cc: Adrian Vovk Cc: Hector Palacios Cc: Pantelis Antoniou Cc: Simon Glass Cc: Tom

[PATCH v2 1/2] cmd: exit: Fix return value propagation out of environment scripts

2022-12-19 Thread Marek Vasut
Make sure the 'exit' command as well as 'exit $val' command exits from environment scripts immediately and propagates return value out of those scripts fully. That means the following behavior is expected: " => setenv foo 'echo bar ; exit 1' ; run foo ; echo $? bar 1 => setenv foo 'echo bar ;

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-19 Thread Stefan Roese
Hi Tony, On 12/20/22 02:36, Tony Dinh wrote: Hi Stefan, On Mon, Dec 19, 2022 at 4:06 PM Tony Dinh wrote: Hi Stefan, On Mon, Dec 19, 2022 at 1:22 PM Tony Dinh wrote: Hi Stefan, On Sun, Dec 18, 2022 at 11:29 PM Stefan Roese wrote: Hi Tony, On 12/19/22 07:17, Stefan Roese wrote:

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-19 Thread Stefan Roese
Hi Tony, On 12/19/22 22:22, Tony Dinh wrote: Hi Stefan, On Sun, Dec 18, 2022 at 11:29 PM Stefan Roese wrote: Hi Tony, On 12/19/22 07:17, Stefan Roese wrote: git checkout 37bb396669b27aa62fe8bc5eeb6bfde92e09c2d3 Previous HEAD position was 3b44b3fdf2 arm: mvebu: Add support for

[PATCH v5 6/6] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
This enables versioning a project specific patman configuration file. It also makes it possible to declare the project name, which is not a useful thing to do in $HOME/.patman. A new test is added, along updated documentation. Signed-off-by: Maxim Cournoyer --- Changes in v5: - Use try/finally

[PATCH v5 5/6] patman: fail early in Setup when provided config file does not exist

2022-12-19 Thread Maxim Cournoyer
Rationale: if the user explicitly provide this argument, they probably intend for it to be used. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py

[PATCH v5 4/6] patman: set the default config_fname argument value to None

2022-12-19 Thread Maxim Cournoyer
This better matches Python conventions, allowing to easily test whether the optional argument is provided. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 2 +- tools/patman/settings.py | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff

[PATCH v5 3/6] patman: import gitutil module where it is needed

2022-12-19 Thread Maxim Cournoyer
Instead of propagating it from the module entry point (main script). Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 3 +-- tools/patman/settings.py | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/patman/__main__.py

[PATCH v5 2/6] patman: replace deprecated SafeConfigParser with ConfigParser

2022-12-19 Thread Maxim Cournoyer
The SafeConfigParser class has been renamed in Python 3.2 to ConfigParser, and the old alias has been deprecated since. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v5 1/6] patman: fix pep8 warnings in settings module

2022-12-19 Thread Maxim Cournoyer
Remove extraneous imports, variables and comply to PEP 8 maximum line width, among other PEP 8 changes suggested by Pyflake. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 38 +- 1 file changed, 21 insertions(+), 17

[PATCH v5 0/6] add support for repository-local .patman config file

2022-12-19 Thread Maxim Cournoyer
This series is based on top of series #45. It adds support for a .patman config file local to the git repository. A new test 'test_settings.py' test module is added; it is automatically discovered and run via pytest, e.g.: 'cd tools/patman && pytest'. Changes in v5: - Use try/finally in

Re: [PATCH] patman: add '--get-maintainer-script' argument

2022-12-19 Thread Maxim Cournoyer
Hi Simon, Simon Glass writes: > Hi Maxim, > > On Mon, 19 Dec 2022 at 15:12, Maxim Cournoyer > wrote: >> >> This makes it possible to configure a project to use some other >> location or script than the default scripts/get_maintainer.pl one >> used in the U-Boot and Linux projects. It can be

[PATCH v2] patman: add '--get-maintainer-script' argument

2022-12-19 Thread Maxim Cournoyer
This makes it possible to configure a project to use some other location or script than the default scripts/get_maintainer.pl one used in the U-Boot and Linux projects. It can be configured via a .patman configuration file and accepts arguments, as documented. Reviewed-by: Simon Glass

Re: [PATCH 2/2] configs: am62x_evm_a53: Enable ethernet

2022-12-19 Thread Dhruva Gole
On 19/12/22 21:45, Sjoerd Simons wrote: Enable configuration ethernet for u-boot on am62x; Some unrelated things also got moved around due to running through savedefconfig. Signed-off-by: Sjoerd Simons --- configs/am62x_evm_a53_defconfig | 11 --- 1 file changed, 8

Re: [PATCH 6/6] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
Hi Simon, Simon Glass writes: > Hi Maxim, > > On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer > wrote: >> >> This enables versioning a project specific patman configuration file. >> It also makes it possible to declare the the project name is, >> which is not a useful thing to do in

[PATCH v4 6/6] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
This enables versioning a project specific patman configuration file. It also makes it possible to declare the project name, which is not a useful thing to do in $HOME/.patman. A new test is added, along updated documentation. Signed-off-by: Maxim Cournoyer --- Changes in v4: - Use tools.run

[PATCH v4 5/6] patman: fail early in Setup when provided config file does not exist

2022-12-19 Thread Maxim Cournoyer
Rationale: if the user explicitly provide this argument, they probably intend for it to be used. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py

[PATCH v4 4/6] patman: set the default config_fname argument value to None

2022-12-19 Thread Maxim Cournoyer
This better matches Python conventions, allowing to easily test whether the optional argument is provided. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 2 +- tools/patman/settings.py | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff

[PATCH v4 3/6] patman: import gitutil module where it is needed

2022-12-19 Thread Maxim Cournoyer
Instead of propagating it from the module entry point (main script). Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 3 +-- tools/patman/settings.py | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/patman/__main__.py

[PATCH v4 2/6] patman: replace deprecated SafeConfigParser with ConfigParser

2022-12-19 Thread Maxim Cournoyer
The SafeConfigParser class has been renamed in Python 3.2 to ConfigParser, and the old alias has been deprecated since. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v4 1/6] patman: fix pep8 warnings in settings module

2022-12-19 Thread Maxim Cournoyer
Remove extraneous imports, variables and comply to PEP 8 maximum line width, among other PEP 8 changes suggested by Pyflake. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/settings.py | 38 +- 1 file changed, 21 insertions(+), 17

[PATCH v4 0/6] add support for repository-local .patman config file

2022-12-19 Thread Maxim Cournoyer
This series is based on top of series #45. It adds support for a .patman config file local to the git repository. A new test 'test_settings.py' test module is added; it is automatically discovered and run via pytest, e.g.: 'cd tools/patman && pytest'. Changes in v4: - Use tools.run to

Re: [PATCH v4 5/5] rockchip: add support for PX30 Ringneck SoM on Haikou Devkit

2022-12-19 Thread Kever Yang
Hi Quentin,     For this board:        aarch64:  w+   ringneck-px30 +  static struct px30_cru * const cru = (void *)CRU_BASE; + ^~~ +  static struct px30_grf * const grf = (void *)GRF_BASE; w+arch/arm/mach-rockchip/px30/px30.c: In function

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-19 Thread Tony Dinh
Hi Stefan, On Mon, Dec 19, 2022 at 4:06 PM Tony Dinh wrote: > > Hi Stefan, > > On Mon, Dec 19, 2022 at 1:22 PM Tony Dinh wrote: > > > > Hi Stefan, > > > > On Sun, Dec 18, 2022 at 11:29 PM Stefan Roese wrote: > > > > > > Hi Tony, > > > > > > On 12/19/22 07:17, Stefan Roese wrote: > > > > > > >

Re: [PATCH] patman: add '--get-maintainer-script' argument

2022-12-19 Thread Simon Glass
Hi Maxim, On Mon, 19 Dec 2022 at 15:12, Maxim Cournoyer wrote: > > This makes it possible to configure a project to use some other > location or script than the default scripts/get_maintainer.pl one > used in the U-Boot and Linux projects. It can be configured via a > .patman configuration file

Re: [u-boot][master][PATCH 1/3] pico-imx7d: add support for 2GB memory SoMs

2022-12-19 Thread Fabio Estevam
On Mon, Dec 19, 2022 at 9:12 PM Szőke Kálmán Benjamin wrote: > > Technexion did that renaming, it is better to keep in synchronized. > https://github.com/TechNexion/u-boot-tn-imx/tree/tn-imx_v2021.04_5.10.72_2.2.0-stable/board/technexion/pico-imx7d Sorry, that's not a good justification. Just

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-19 Thread Tony Dinh
Hi Stefan, On Mon, Dec 19, 2022 at 1:22 PM Tony Dinh wrote: > > Hi Stefan, > > On Sun, Dec 18, 2022 at 11:29 PM Stefan Roese wrote: > > > > Hi Tony, > > > > On 12/19/22 07:17, Stefan Roese wrote: > > > > > > > > >> git checkout 37bb396669b27aa62fe8bc5eeb6bfde92e09c2d3 > > >> Previous HEAD

[PATCH v3 8/8] patman: document default 'send' command

2022-12-19 Thread Maxim Cournoyer
Document that this command is the default and what it's intended for. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/__main__.py

[PATCH v3 7/8] patman: document how to run test suite via pytest

2022-12-19 Thread Maxim Cournoyer
Pytest offers useful features such as selecting tests by means of a regular expression, or running the pdb debugger upon encountering a test failure. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/patman.rst | 6 ++ 1 file changed, 6

[PATCH v3 6/8] patman: hide the 'test' command unless test data is available

2022-12-19 Thread Maxim Cournoyer
Some tests would fail when the test data is not available, so it doesn't make much sense to expose the action when patman is running outside of the u-boot git checkout. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- Changes in v3: - Mention the test command is hidden unless run

[PATCH v3 4/8] patman: rename main script to __main__.py

2022-12-19 Thread Maxim Cournoyer
This allows running the package as a Python module, like e.g.: $ python -m patman It also prevents Pytest from attempting to parse main.py, which would cause errors. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/{main.py => __main__.py}

[PATCH v3 5/8] patman: add pytest configuration file

2022-12-19 Thread Maxim Cournoyer
With this change, a user can run the patman test suite using Pytest the same as when using 'patman test': $ cd tools/patman && pytest [...] 44 passed, 8 warnings in 8.87s $ ./patman test Ran 44 tests in 8.460s Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer ---

[PATCH v3 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'

2022-12-19 Thread Maxim Cournoyer
This resolves 10 out of 11 test failures seen when running './patman test' from the 'tools/patman' subdirectory. This was caused by the .checkpatch.conf configuration file at the root of the project not being picked up. Make the test suite of patman independent from it by always invoking the

[PATCH v3 2/8] patman: locate test data files via __file__ and pathlib

2022-12-19 Thread Maxim Cournoyer
Previously it would rely on the executing script location, which could break for example when running the tests via 'pytest'. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/func_test.py | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v3 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module.

2022-12-19 Thread Maxim Cournoyer
This patch fixes all the PEP 8 warnings reported by Pyflake for the gitutil module. Reviewed-by: Simon Glass Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/gitutil.py | 106 1 file changed, 65 insertions(+), 41 deletions(-)

[PATCH] patman: add '--get-maintainer-script' argument

2022-12-19 Thread Maxim Cournoyer
This makes it possible to configure a project to use some other location or script than the default scripts/get_maintainer.pl one used in the U-Boot and Linux projects. It can be configured via a .patman configuration file and accepts arguments, as documented. Signed-off-by: Maxim Cournoyer ---

[PATCH u-boot] powerpc/mpc85xx: Disable AltiVec and VSX instructions

2022-12-19 Thread Pali Rohár
All vector instructions on powerpc mpc85xx must not be used because U-Boot does not enable them. Usage cause random crashes. SPE vector instructions are already disabled by compiler flags, so disable also AltiVec and VSX vector instructions. Linux kernel disables AltiVec and VSX instructions too.

[PATCH v2] powerpc/mpc85xx: Pass correct cpu compiler flags

2022-12-19 Thread Pali Rohár
When gcc's default cpu (selected by --with-cpu= during gcc's configure phase) does not match target U-Boot board cpu then U-Boot binary does not have to be compiled correctly. Lot of distributions sets gcc's default cpu to generic powerpc variant which works fine. U-Boot already pass -Wa,-me500

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-19 Thread Tony Dinh
Hi Stefan, On Sun, Dec 18, 2022 at 11:29 PM Stefan Roese wrote: > > Hi Tony, > > On 12/19/22 07:17, Stefan Roese wrote: > > > > >> git checkout 37bb396669b27aa62fe8bc5eeb6bfde92e09c2d3 > >> Previous HEAD position was 3b44b3fdf2 arm: mvebu: Add support for > >> programming LD0 and LD1 eFuse > >>

Re: [PATCH v2 2/2] eficonfig: avoid SetVariable between GetNextVariableName calls

2022-12-19 Thread Heinrich Schuchardt
On 12/19/22 02:33, Masahisa Kojima wrote: The current code calls efi_set_variable_int() to delete the invalid boot option between calls to efi_get_next_variable_name_int(), it may produce unpredictable results. This commit moves removal of the invalid boot option outside of the

Re: [PATCH v2 1/2] eficonfig: carve out efi_get_next_variable_name_int calls

2022-12-19 Thread Heinrich Schuchardt
On 12/19/22 02:33, Masahisa Kojima wrote: To retrieve the EFI variable name by efi_get_next_variable_name_int(), the sequence of alloc -> efi_get_next_variable_name_int -> realloc -> efi_get_next_variable_name_int is required. In current code, this sequence repeatedly appears in the several

[PATCH 1/2] doc: ti: reorganize existing ti docs

2022-12-19 Thread Bryan Brattlof
Texas Instruments produces quite a lot of SoCs based upon a common architecture 'generation'. (eg: OMAP, K3) TI's existing documentation layout makes noticing this generation jump rather difficult. To make navigation easier, split the existing documentation into individual SoC families so we may

[PATCH 2/2] doc: ti: add the K3 generation page

2022-12-19 Thread Bryan Brattlof
Texas Instrument's entire K3 generation of SoCs use much of the same frameworks and boot flow, especially at the uboot level. Though there are small differences introduced as each new K3 based SoC is developed and as the K3 generation matures that will also need to be documented. Rather than

[PATCH 0/2] TI's K3 documentation updates

2022-12-19 Thread Bryan Brattlof
Hello everyone! Before the holidays get started, I wanted to improve the documentation for TI's K3 generation of SoCs. Specifically I wanted to collect all the similarities into one file called 'K3' in doc/board/ti/ and leave the details to each SoC specific sub-page. My goal is to eliminate the

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-19 Thread Filip Žaludek
Hi Simon, On 12/19/22 20:20, Simon Glass wrote: Hi Filip, On Mon, 19 Dec 2022 at 02:29, Filip Žaludek wrote: Hi Simon, is your testing framework connected to HDMI? Only notable discrepancy from generic config is enabled 'efidebug' command. Tested more (cycled 'U-Boot>' and

Re: [PATCH] Prevent buffer overflow on USB control endpoint

2022-12-19 Thread Marek Vasut
On 12/19/22 19:52, Szymon Heidrich wrote: On 16/12/2022 04:22, Marek Vasut wrote: On 11/20/22 18:42, Szymon Heidrich wrote: On 20/11/2022 18:25, Marek Vasut wrote: On 11/20/22 16:29, Szymon Heidrich wrote: On 20/11/2022 15:43, Marek Vasut wrote: On 11/17/22 12:50, Fabio Estevam wrote:

Re: [PATCH v2] imxtract: specify max gunzip size

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 01:05, Nikita Shubin wrote: > > From: Nikita Shubin > > Specify max gunzip size from config to override SYS_XIMG_LEN > default value wich is 0x80. In case we have a large portion of FIT > image, for example gzipped kernel with decompressed size large than > 0x80 we

Re: [PATCH 4/6] patman: set the default config_fname argument value to None

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > This better matches Python conventions, allowing to easily test > whether the optional argument is provided. > > Signed-off-by: Maxim Cournoyer > --- > > tools/patman/__main__.py | 2 +- > tools/patman/settings.py | 9 + > 2 files

Re: [PATCH v2 5/8] patman: add pytest configuration file

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > With this change, a user can run the patman test suite using Pytest > the same as when using 'patman test': > > $ cd tools/patman && pytest > [...] > 44 passed, 8 warnings in 8.87s > > $ ./patman test > Ran 44 tests in

Re: [PATCH 6/6] patman: additionally honor a local .patman config file

2022-12-19 Thread Simon Glass
Hi Maxim, On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > This enables versioning a project specific patman configuration file. > It also makes it possible to declare the the project name is, > which is not a useful thing to do in $HOME/.patman. A new test is > added, along updated

Re: [PATCH v2 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module.

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > This patch fixes all the PEP 8 warnings reported by Pyflake for the > gitutil module. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes since v1) > > tools/patman/gitutil.py | 106 > 1 file

Re: [External] : Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-19 Thread Simon Glass
Hi Filip, On Mon, 19 Dec 2022 at 02:29, Filip Žaludek wrote: > > > > Hi Simon, > > is your testing framework connected to HDMI? Only notable discrepancy > from generic config is enabled 'efidebug' command. > > > Tested more (cycled 'U-Boot>' and 'reset'), both RPi3B and RPi3B+.. > USB Keyboard

Re: [PATCH v2 6/8] patman: hide the 'test' action unless test data is available

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > Some tests would fail when the test data is not available, so it > doesn't make much sense to expose the action when patman is running > outside of the u-boot git checkout. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes since v1)

Re: [PATCH 2/2] test: cmd: exit: Add unit test for exit and partly run commands

2022-12-19 Thread Simon Glass
On Sun, 18 Dec 2022 at 13:47, Marek Vasut wrote: > > Add a test which validates that exit from environment script works as > expected, including return value propagation and clipping to positive > integers. > > Signed-off-by: Marek Vasut > --- > Cc: Adrian Vovk > Cc: Hector Palacios > Cc:

Re: [PATCH v2 8/8] patman: document default 'send' command

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > Document that this command is the default and what it's intended for. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes since v1) > > tools/patman/__main__.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

Re: [RESEND RFC PATCH 2/2] video: ti: am335x: drop pre-driver-model code

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 04:35, Dario Binacchi wrote: > > The patch removes the pre-driver-model implementation and keeps the > code with driver model support. > > Signed-off-by: Dario Binacchi > > --- > > arch/arm/mach-omap2/am33xx/clock_am33xx.c | 4 - > board/bosch/guardian/board.c

Re: [PATCH v2 7/8] patman: document how to run test suite via pytest

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > Pytest offers useful features such as selecting tests by means of a > regular expression, or running the pdb debugger upon encountering a > test failure. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes since v1) > >

Re: [PATCH 1/6] patman: fix pep8 warnings in settings module

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > Remove extraneous imports, variables and comply to PEP 8 maximum line > width, among other PEP 8 changes suggested by Pyflake. > > Signed-off-by: Maxim Cournoyer > --- > > tools/patman/settings.py | 38

Re: [PATCH] rockchip: Only call binman when TPL available

2022-12-19 Thread Simon Glass
Hi Kever, On Sun, 18 Dec 2022 at 05:50, Kever Yang wrote: > > Rockchip platform use TPL to do the DRAM initialize for all the SoCs, > if TPL is not available, means no available DRAM init program, and the > u-boot-rockchip.bin is not functionable. > > Signed-off-by: Kever Yang > --- > >

Re: [PATCH 2/6] patman: replace deprecated SafeConfigParser with ConfigParser

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > The SafeConfigParser class has been renamed in Python 3.2 to > ConfigParser, and the old alias has been deprecated since. > > Signed-off-by: Maxim Cournoyer > --- > > tools/patman/settings.py | 28 ++-- > 1 file

Re: [PATCH 5/6] patman: fail early in Setup when provided config file does not exist

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > Rationale: if the user explicitly provide this argument, they probably > intend for it to be used. > > Signed-off-by: Maxim Cournoyer > --- > > tools/patman/settings.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v2 2/8] patman: locate test data files via __file__ and pathlib

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > Previously it would rely on the executing script location, which could > break for example when running the tests via 'pytest'. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes since v1) > > tools/patman/func_test.py | 8 ++--

Re: [PATCH 3/6] patman: import gitutil module where it is needed

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer wrote: > > Instead of propagating it from the module entry point (main script). > > Signed-off-by: Maxim Cournoyer > --- > > tools/patman/__main__.py | 3 +-- > tools/patman/settings.py | 8 +--- > 2 files changed, 6 insertions(+), 5

Re: [PATCH v8 03/10] arm_ffa: introduce Arm FF-A low-level driver

2022-12-19 Thread Simon Glass
Hi Abdellatif, On Mon, 19 Dec 2022 at 04:12, Abdellatif El Khlifi wrote: > > On Mon, Dec 05, 2022 at 09:49:30AM -0600, Rob Herring wrote: > > On Sun, Dec 4, 2022 at 1:22 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Tue, 29 Nov 2022 at 05:22, Rob Herring wrote: > > > > > > > > On

Re: [PATCH v2 4/8] patman: rename main script to __main__.py

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > This allows running the package as a Python module, like e.g.: > > $ python -m patman > > It also prevents Pytest from attempting to parse main.py, which > would cause errors. > > Signed-off-by: Maxim Cournoyer > --- > > (no changes

Re: [PATCH v2 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'

2022-12-19 Thread Simon Glass
On Mon, 19 Dec 2022 at 07:53, Maxim Cournoyer wrote: > > This resolves 10 out of 11 test failures seen when running './patman > test' from the 'tools/patman' subdirectory. This was caused by the > .checkpatch.conf configuration file at the root of the project not > being picked up. Make the test

Re: [RESEND RFC PATCH 1/2] Revert "video: Drop CONFIG_AM335X_LCD"

2022-12-19 Thread Simon Glass
Hi Dario, On Mon, 19 Dec 2022 at 04:35, Dario Binacchi wrote: > > This reverts commit 82f7b869f5d7aad246a4621a18a5ad04475815ba. > > It also removed code with driver model support. > The commit [1], as described in its message, was also designed to make > it easy to remove pre-driver-model code

Re: [PATCH] Prevent buffer overflow on USB control endpoint

2022-12-19 Thread Szymon Heidrich
On 16/12/2022 04:22, Marek Vasut wrote: > On 11/20/22 18:42, Szymon Heidrich wrote: >> On 20/11/2022 18:25, Marek Vasut wrote: >>> On 11/20/22 16:29, Szymon Heidrich wrote: On 20/11/2022 15:43, Marek Vasut wrote: > On 11/17/22 12:50, Fabio Estevam wrote: >> [Adding Lukasz and Marek]

[PATCH v3 1/1] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
This enables versioning a project specific patman configuration file. It also makes it possible to declare the project name, which is not a useful thing to do in $HOME/.patman. A new test is added, along updated documentation. Signed-off-by: Maxim Cournoyer --- Changes in v3: - Clear command

[PATCH v2 1/1] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
This enables versioning a project specific patman configuration file. It also makes it possible to declare the project name, which is not a useful thing to do in $HOME/.patman. A new test is added, along updated documentation. Signed-off-by: Maxim Cournoyer --- Changes in v2: - Explicitly

[PATCH v2 0/1] add support for repository-local .patman config file

2022-12-19 Thread Maxim Cournoyer
This series is based on top of series #45. It adds support for a .patman config file local to the git repository. A new test 'test_settings.py' test module is added; it is automatically discovered and run via pytest, e.g.: 'cd tools/patman && pytest'. Changes in v2: - Explicitly provide an

Re: [u-boot][master][PATCH 2/3] pico-imx7d: add baseboard SD card boot detect

2022-12-19 Thread Fabio Estevam
On Sun, Dec 18, 2022 at 9:53 AM wrote: > + for (index = 0; index < CONFIG_SYS_FSL_USDHC_NUM; ++index) { > + ret = fsl_esdhc_initialize(bis, _cfg[index]); > + if (ret) > + return ret; In patch 3/3, CONFIG_SPL_DM_MMC=y, so can't the driver

[PATCH 1/2] arm: dts: k3-am625-sk: Enable first ethernet port

2022-12-19 Thread Sjoerd Simons
The K3 am625 sk EVM has two ethernet ports; Enable the first one for usage in u-boot. Signed-off-by: Sjoerd Simons --- arch/arm/dts/k3-am625-sk-u-boot.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi

[PATCH 2/2] configs: am62x_evm_a53: Enable ethernet

2022-12-19 Thread Sjoerd Simons
Enable configuration ethernet for u-boot on am62x; Some unrelated things also got moved around due to running through savedefconfig. Signed-off-by: Sjoerd Simons --- configs/am62x_evm_a53_defconfig | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] Enable ethernet for ti am62x

2022-12-19 Thread Sjoerd Simons
These patches enable ethernet from u-boot on the ti am62x EVM. They are based on the u-boot next branch (9c955393) to take advantage of recent dts sync of these boards with linux Sjoerd Simons (2): arm: dts: k3-am625-sk: Enable first ethernet port configs: am62x_evm_a53: Enable ethernet

[PATCH 6/6] patman: additionally honor a local .patman config file

2022-12-19 Thread Maxim Cournoyer
This enables versioning a project specific patman configuration file. It also makes it possible to declare the the project name is, which is not a useful thing to do in $HOME/.patman. A new test is added, along updated documentation. Signed-off-by: Maxim Cournoyer --- tools/patman/patman.rst

[PATCH 5/6] patman: fail early in Setup when provided config file does not exist

2022-12-19 Thread Maxim Cournoyer
Rationale: if the user explicitly provide this argument, they probably intend for it to be used. Signed-off-by: Maxim Cournoyer --- tools/patman/settings.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py b/tools/patman/settings.py index

[PATCH 4/6] patman: set the default config_fname argument value to None

2022-12-19 Thread Maxim Cournoyer
This better matches Python conventions, allowing to easily test whether the optional argument is provided. Signed-off-by: Maxim Cournoyer --- tools/patman/__main__.py | 2 +- tools/patman/settings.py | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 3/6] patman: import gitutil module where it is needed

2022-12-19 Thread Maxim Cournoyer
Instead of propagating it from the module entry point (main script). Signed-off-by: Maxim Cournoyer --- tools/patman/__main__.py | 3 +-- tools/patman/settings.py | 8 +--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/patman/__main__.py b/tools/patman/__main__.py

[PATCH 2/6] patman: replace deprecated SafeConfigParser with ConfigParser

2022-12-19 Thread Maxim Cournoyer
The SafeConfigParser class has been renamed in Python 3.2 to ConfigParser, and the old alias has been deprecated since. Signed-off-by: Maxim Cournoyer --- tools/patman/settings.py | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH 1/6] patman: fix pep8 warnings in settings module

2022-12-19 Thread Maxim Cournoyer
Remove extraneous imports, variables and comply to PEP 8 maximum line width, among other PEP 8 changes suggested by Pyflake. Signed-off-by: Maxim Cournoyer --- tools/patman/settings.py | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git

[PATCH 0/6] add support for repository-local .patman config file

2022-12-19 Thread Maxim Cournoyer
This series is based on top of series #45. It adds support for a .patman config file local to the git repository. A new test 'test_settings.py' test module is added; it is automatically discovered and run via pytest, e.g.: 'cd tools/patman && pytest'. Maxim Cournoyer (6): patman: fix

[PATCH] board: presidio-asic: Remove CONFIG_TARGET_VENUS

2022-12-19 Thread Michal Simek
Symbol is not defined anywhere that's why remove it. Signed-off-by: Michal Simek --- board/cortina/presidio-asic/lowlevel_init.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/cortina/presidio-asic/lowlevel_init.S b/board/cortina/presidio-asic/lowlevel_init.S index

[PATCH] eficonfig: EFI_VARIABLE_APPEND_WRITE is not set for null key

2022-12-19 Thread Masahisa Kojima
The signed null key with authenticated header is used to clear the PK, KEK, db and dbx. When CONFIG_EFI_MM_COMM_TEE is enabled (StMM and OP-TEE based RPMB storage is used as the EFI variable storage), clearing KEK, db and dbx by enrolling a signed null key does not work as expected if

[PATCH v2 8/8] patman: document default 'send' command

2022-12-19 Thread Maxim Cournoyer
Document that this command is the default and what it's intended for. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/__main__.py b/tools/patman/__main__.py index

[PATCH v2 7/8] patman: document how to run test suite via pytest

2022-12-19 Thread Maxim Cournoyer
Pytest offers useful features such as selecting tests by means of a regular expression, or running the pdb debugger upon encountering a test failure. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/patman.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 5/8] patman: add pytest configuration file

2022-12-19 Thread Maxim Cournoyer
With this change, a user can run the patman test suite using Pytest the same as when using 'patman test': $ cd tools/patman && pytest [...] 44 passed, 8 warnings in 8.87s $ ./patman test Ran 44 tests in 8.460s Signed-off-by: Maxim Cournoyer --- (no changes since v1)

[PATCH v2 6/8] patman: hide the 'test' action unless test data is available

2022-12-19 Thread Maxim Cournoyer
Some tests would fail when the test data is not available, so it doesn't make much sense to expose the action when patman is running outside of the u-boot git checkout. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/__main__.py | 9 ++--- 1 file changed, 6

[PATCH v2 4/8] patman: rename main script to __main__.py

2022-12-19 Thread Maxim Cournoyer
This allows running the package as a Python module, like e.g.: $ python -m patman It also prevents Pytest from attempting to parse main.py, which would cause errors. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/{main.py => __main__.py} | 0 tools/patman/patman

[PATCH v2 3/8] patman: invoke the checkpatch.pl script with '--u-boot' and '--strict'

2022-12-19 Thread Maxim Cournoyer
This resolves 10 out of 11 test failures seen when running './patman test' from the 'tools/patman' subdirectory. This was caused by the .checkpatch.conf configuration file at the root of the project not being picked up. Make the test suite of patman independant from it by always invoking the

[PATCH v2 2/8] patman: locate test data files via __file__ and pathlib

2022-12-19 Thread Maxim Cournoyer
Previously it would rely on the executing script location, which could break for example when running the tests via 'pytest'. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/func_test.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/8] patman: cosmetic: Fix PEP 8 warnings for the gitutil module.

2022-12-19 Thread Maxim Cournoyer
This patch fixes all the PEP 8 warnings reported by Pyflake for the gitutil module. Signed-off-by: Maxim Cournoyer --- (no changes since v1) tools/patman/gitutil.py | 106 1 file changed, 65 insertions(+), 41 deletions(-) diff --git

  1   2   >