Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Chris Packham
Hi Tom, On Fri, 27 Oct 2023, 1:54 pm Tom Rini, wrote: > On Fri, Oct 27, 2023 at 01:44:11PM +1300, Chris Packham wrote: > > > The ATF implementation for AC5/AC5X ends up with bl31 living in some > > internal SRAM. This is in the middle of the large MMIO region that we > > were using. Adjust this

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Ilias Apalodimas
On Fri, 27 Oct 2023 at 03:21, Masahisa Kojima wrote: > > Hi Ilias, > > On Fri, 27 Oct 2023 at 03:58, Ilias Apalodimas > wrote: > > > > On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima > > wrote: > > > > > > There are two kinds of NOR flash layout for the Developerbox. > > > Capsule update for the

[PATCH] arm64: versal-net: enable CONFIG_MMC_SDHCI_ADMA

2023-10-26 Thread Venkatesh Yadav Abbarapu
The Standard Host Controller Interface (SDHCI) specification version 3.00 adds support for Advanced DMA (ADMA) for both 64 and 32 bit widths of DMA. This significantly improves read and write throughput. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/xilinx_versal_net_virt_defconfig | 1 +

Re: [PATCH 3/3] arm: rmobile: rzg2_beacon: Auto select Linux device tree by SoC

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 8:44 PM Marek Vasut wrote: > > On 10/26/23 01:13, Adam Ford wrote: > > There is a function inside the board file to autodetect which device > > tree is needed by U-Boot to properly load its own device tree, but > > it currently defaults to always loading RZ/G2M for Linux.

Re: [PATCH 1/3] configs: rzg2_beacon: Disable the ability to remove devices

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 8:44 PM Marek Vasut wrote: > > On 10/26/23 01:13, Adam Ford wrote: > > In order to save some space, disable the ability to dynamically > > remove devices. Without this, U-Boot is too large to load without > > recompiling TF-A. > > Did you enable LTO yet ? Yes. > >

Re: [PATCH 1/3] configs: rzg2_beacon: Disable the ability to remove devices

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: In order to save some space, disable the ability to dynamically remove devices. Without this, U-Boot is too large to load without recompiling TF-A. Did you enable LTO yet ? Striping DM_REMOVE seems like a really bad idea, doesn't that break 'usb reset'

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Marek Vasut
On 10/27/23 01:26, Hector Martin wrote: Gah, I should've paid more attention to that rebase. Here's a dumb fixup for this patch. I'll squash it into a v2 if needed alongside any other changes, or if it looks good feel free to apply/squash it in directly. --- drivers/usb/host/xhci-ring.c | 1 +

Re: [PATCH 3/3] arm: rmobile: rzg2_beacon: Auto select Linux device tree by SoC

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: There is a function inside the board file to autodetect which device tree is needed by U-Boot to properly load its own device tree, but it currently defaults to always loading RZ/G2M for Linux. This is not correct for other SoC variants. Add board_late_init

Re: [PATCH 2/8] usb: xhci: Better error handling in abort_td()

2023-10-26 Thread Marek Vasut
On 10/27/23 01:16, Hector Martin wrote: If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. Right now we still BUG() on the error code, but at least we

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:59:02AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > > > > Am

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > > On 10/26/23 07:30, AKASHI Takahiro wrote: > > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > > refactor work. > > > > > >

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro > > > : > > > >Now it

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:44:11PM +1300, Chris Packham wrote: > The ATF implementation for AC5/AC5X ends up with bl31 living in some > internal SRAM. This is in the middle of the large MMIO region that we > were using. Adjust this to be finer grained blocks based on the address > map from the

[PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Chris Packham
The ATF implementation for AC5/AC5X ends up with bl31 living in some internal SRAM. This is in the middle of the large MMIO region that we were using. Adjust this to be finer grained blocks based on the address map from the AC5X Family Control and Management Subsystem Functional Datasheet.

Re: [RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 12:44:00PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Decompose and re-organize do_bootefi_image() into three parts for > > the succeeding refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/Kconfig | 15

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/bootefi.c | 101

[PATCH 3/3] Revert "arm64: Use FEAT_HAFDBS to track dirty pages when available"

2023-10-26 Thread Chris Packham
This reverts commit 6cdf6b7a340db4ddd008516181de7e08e3f8c213. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting

[PATCH 2/3] Revert "arm64: Use level-2 for largest block mappings when FEAT_HAFDBS is present"

2023-10-26 Thread Chris Packham
This reverts commit 836b8d4b205d2175b57cb9ef271e638b0c116e89. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting

[PATCH 1/3] Revert "armv8: enable HAFDBS for other ELx when FEAT_HAFDBS is present"

2023-10-26 Thread Chris Packham
This reverts commit c1da6fdb5c239b432440721772d993e63cfdeb20. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting

[PATCH 0/3] Revert HAFDBS changes

2023-10-26 Thread Chris Packham
As discussed this series reverts the HAFDBS changes that caused an issue on AC5/AC5X. I think there are some improvements that can be made to the initial memory map for the AC5/AC5X but so far nothing I've found makes it compatible with the HAFDBS changes. Chris Packham (3): Revert "armv8:

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Masahisa Kojima
Hi Ilias, On Fri, 27 Oct 2023 at 03:58, Ilias Apalodimas wrote: > > On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima > wrote: > > > > There are two kinds of NOR flash layout for the Developerbox. > > Capsule update for the old layout is no longer available since > > it has small capacity for

[PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Hector Martin
Gah, I should've paid more attention to that rebase. Here's a dumb fixup for this patch. I'll squash it into a v2 if needed alongside any other changes, or if it looks good feel free to apply/squash it in directly. --- drivers/usb/host/xhci-ring.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 8/8] usb: xhci: Add more debugging

2023-10-26 Thread Hector Martin
A bunch of miscellaneous debug messages to aid in working out USB issues. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c

[PATCH 6/8] usb: xhci: Do not panic on event timeouts

2023-10-26 Thread Hector Martin
Now that we always check the return value, just return NULL on timeouts. We can still log the error since this is a problem, but it's not reason to panic. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 7/8] usb: xhci: Fix DMA address calculation in queue_trb

2023-10-26 Thread Hector Martin
We need to get the DMA address before incrementing the pointer, as that might move us onto another segment. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 4/8] usb: xhci: Recover from halted non-control endpoints

2023-10-26 Thread Hector Martin
There is currently no codepath to recover from this case. In principle we could require that the upper layer do this explicitly, but let's just do it in xHCI when the next bulk transfer is started, since that reasonably implies whatever caused the problem has been dealt with. Signed-off-by:

[PATCH 5/8] usb: xhci: Fail on attempt to queue TRBs to a halted endpoint

2023-10-26 Thread Hector Martin
This isn't going to work, don't pretend it will and then end up timing out. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[PATCH 3/8] usb: xhci: Allow context state errors when halting an endpoint

2023-10-26 Thread Hector Martin
There is a race where an endpoint may halt by itself while we are trying to halt it, which results in a context state error. See xHCI 4.6.9 which mentions this case. This also avoids BUGging when we attempt to stop an endpoint which was already stopped to begin with, which is probably a bug

[PATCH 2/8] usb: xhci: Better error handling in abort_td()

2023-10-26 Thread Hector Martin
If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. Right now we still BUG() on the error code, but at least we don't end up timing out on the event and

[PATCH 1/8] usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Hector Martin
xhci_wait_for_event returns NULL on timeout, so the caller always has to check for that. This addresses the immediate explosions in this part of the code, but not the original cause. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 15 ++- drivers/usb/host/xhci.c

[PATCH 0/8] USB fixes: xHCI error handling

2023-10-26 Thread Hector Martin
This series is the first of a few bundles of USB fixes we have been carrying downstream on the Asahi U-Boot branch for a few months. Most importantly, this related set of patches makes xHCI error/stall recovery more robust (or work at all in some cases). There are also a couple patches fixing

Re: [PATCH v2] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

2023-10-26 Thread Nishanth Menon
On 17:54-20231026, Prasanth Babu Mantena wrote: > EEPROM detection logic in ti_i2c_eeprom_get() involves reading the total > size followed by reading 1-byte size with an offset 1. This commit fixes > the header matching issue in commit 9f393a2d7af8 ("board: ti: common: > board_d

[PATCH] pico-pi-imx7d: Convert to watchdog driver model

2023-10-26 Thread Fabio Estevam
From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset

[PATCH] tools: gitignore: Fix tools/generated path

2023-10-26 Thread Sam Protsenko
'git status' shows 'tools/generated/' after running the build, which is wrong. The corresponding .gitignore rule was already added in commit c623642d29be ("Adjust gitignore for tools/generated/"), but because of superfluous 'tools/' part it wasn't in effect. Remove incorrect 'tools/' part to fix

[PATCH] boot: Fix syntax in fdt_overlay_apply_verbose() error message

2023-10-26 Thread Hugo Villeneuve
From: Hugo Villeneuve Remove superfluous "did". Signed-off-by: Hugo Villeneuve --- boot/fdt_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/fdt_support.c b/boot/fdt_support.c index 5e49078f8c3..b15d07765fe 100644 --- a/boot/fdt_support.c +++

Re: [PATCH v2] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

2023-10-26 Thread Matwey V. Kornilov
чт, 26 окт. 2023 г. в 15:24, Prasanth Babu Mantena : > > EEPROM detection logic in ti_i2c_eeprom_get() involves reading the total > size followed by reading 1-byte size with an offset 1. This commit fixes > the header matching issue in commit 9f393a2d7af8 ("board: ti: common: > board_detect: Fix

Re: [PATCH v8 5/7] efi_loader: support boot from URI device path

2023-10-26 Thread Ilias Apalodimas
Kojima-san, Thanks the device path handling seems saner in this version. On Wed, 25 Oct 2023 at 09:30, Masahisa Kojima wrote: > > This supports to boot from the URI device path. > When user selects the URI device path, bootmgr downloads > the file using wget into the address specified by

Re: [PATCH v8 6/7] cmd: efidebug: add uri device path

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:30, Masahisa Kojima wrote: > > This adds the URI device path option for 'boot add' subcommand. > User can add the URI load option for downloading ISO image file > or EFI application through network. Currently HTTP is only supported. > > Signed-off-by: Masahisa Kojima >

Re: [PATCH 3/3] board: developerbox: update flash rawwrite binary size

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > Current documentation limits the firmware size to 1.5MB. > When the fTPM and StandaloneMM-based RPMB secure storage is > enabled, firmware size is bigger than that size. > Let's specify the A/B update bank size(4MB) for flash > rawwrite

Re: [PATCH 2/3] board: developerbox: update old NOR flash layout build instruction

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > v2023.07 is the last version supporting old NOR flash layout > by default. The later versions of U-Boot, Developerbox is > configured to enable A/B update and new NOR Flash layout > by default. > This commit updates the documentation to pin

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > There are two kinds of NOR flash layout for the Developerbox. > Capsule update for the old layout is no longer available since > it has small capacity for secure world images and can not > house the TA such as fTPM. > This commit removes

Re: quick question about TPM

2023-10-26 Thread Ilias Apalodimas
Hi all On Thu, 26 Oct 2023 at 20:44, Simon Glass wrote: > > +Ilias Apalodimas as well > > On Thu, 26 Oct 2023 at 02:22, niek.nooij...@omron.com > wrote: > > > > Hi Simon > > > > Yes that fixes it! Thanks! > > Maybe an Idea to add a dedicated TPM page to the docs with information like > > this?

[v5 30/30] CI, pytest: Add a test for sandbox without LTO

2023-10-26 Thread Tom Rini
The primary motivation for having a sandbox without LTO build in CI is to ensure that we don't have that option break. We now have the ability to run tests of specific options being enabled/disabled, so drop the parts of CI that build and test that configuration specifically and add a build test

[v5 29/30] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Now that everything is working, add a test to make sure that this builds correctly. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/py/tests/test_sandbox_opts.py | 20 1 file changed, 20 insertions(+) create mode 100644

[v5 28/30] clk_k210.c: Clean up how we handle nop

2023-10-26 Thread Tom Rini
Now that sandbox has and defines nop() there we should include that in our driver for clarity and then remove our local nop() from . Signed-off-by: Tom Rini Reviewed-by: Sean Anderson --- Changes in v5: - Add Sean's RB, drop explanation portion --- drivers/clk/clk_k210.c | 1 +

[v5 27/30] sandbox: Add

2023-10-26 Thread Tom Rini
Add a mostly empty asm/barrier.h file for sandbox where we define nop() to be an empty function. Signed-off-by: Tom Rini Reviewed-by: Sean Anderson --- arch/sandbox/include/asm/barrier.h | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 arch/sandbox/include/asm/barrier.h diff --git

[v5 26/30] sandbox: Avoid requiring CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Add some dependencies on features that we had been selecting so that we can still disable CMDLINE. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes in v4: - Reword the commit slightly (Tom) - Rework overall to select if CMDLINE Changes in v3: - Reorder the

[v5 25/30] sandbox: Disable CONFIG_DISTRO_DEFAULTS

2023-10-26 Thread Tom Rini
From: Simon Glass This is not used for sandbox, so drop it. Enable the things that it controls to avoid dstrastic changes in the config settings for sandbox builds. The end result is that these are enabled: BOOTMETH_DISTRO BOOTSTD_DEFAULTS and these are disabled: USE_BOOTCOMMAND

[v5 24/30] block: rkmtd: select CONFIG_RANDOM_UUID explicitly

2023-10-26 Thread Tom Rini
From: AKASHI Takahiro This option is necessary to compile any way. Signed-off-by: AKASHI Takahiro --- Changes in v5: - Take AKASHI Takahiro's RFC and switch to select per my feedback on the ML --- drivers/block/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[v5 23/30] lib: uuid: move CONFIG_RANDOM_UUID

2023-10-26 Thread Tom Rini
From: AKASHI Takahiro This option is independent from any commands and should be managed under lib. For instance, drivers/block/rkmtd.c is a user. It would be better to remove this configuration. Signed-off-by: AKASHI Takahiro Reviewed-by: Tom Rini --- Changes in v5: - Take AKASHI Takahiro's

[v5 22/30] fastboot: Depend on CMDLINE

2023-10-26 Thread Tom Rini
Much of the functionality of fastboot relies on being able to run commands as defined in the environment. This means it does depend on CMDLINE being enabled. Signed-off-by: Tom Rini --- Changes in v5: - New patch --- drivers/fastboot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[v5 21/30] cmd: Make most commands depend on CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass If we disable CMDLINE then we should not ask about enabling the hush parser nor any of the commands that would be run on the command line as it is no longer available. Convert the CMDLINE option into a menuconfig and make every command referenced under cmd/Kconfig depend on it.

[v5 19/30] bootmeth_script: Depend on CMDLINE

2023-10-26 Thread Tom Rini
As this particular bootmeth requires the command line and assorted commands to function, make sure we have CMDLINE enabled. Signed-off-by: Tom Rini --- boot/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/boot/Kconfig b/boot/Kconfig index 7c92e0974c5f..40a04f43ee3d

[v5 20/30] boot: Make preboot and bootcmd require CMDLINE

2023-10-26 Thread Tom Rini
In order for a predefined "preboot" or "bootcmd" to be executed by the running system we must have a command line. Add CMDLINE as a dependency. Signed-off-by: Tom Rini --- boot/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfig index

[v5 18/30] bootmeth_cros: Require bootm.o and bootm_os.o

2023-10-26 Thread Tom Rini
In order to use bootmeth_cros, at least on non-X86, we need to be able to start any type of kernel that the "bootm" code paths can handle. Add these objects to the required list for this option. Signed-off-by: Tom Rini --- Cc: Simon Glass --- boot/Makefile | 2 +- 1 file changed, 1

[v5 17/30] boot: Move SYS_BOOTM_LEN to be by LEGACY_IMAGE_FORMAT

2023-10-26 Thread Tom Rini
This particular option is required for booting all image types, regardless of if we are starting an OS via command line or something else. Move the question for SYS_BOOTM_LEN to be by the question for LEGACY_IMAGE_FORMAT, as that's where our generic OS questions start. Signed-off-by: Tom Rini

[v5 15/30] boot: Make DISTRO_DEFAULTS select CMDLINE

2023-10-26 Thread Tom Rini
The implementation of DISTRO_DEFAULTS is done in environment scripts and requires the command line in order to work. Because of this, select CMDLINE here. Signed-off-by: Tom Rini --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig index

[v5 16/30] boot: Rework BOOT_DEFAULTS to allow for CMDLINE to be disabled

2023-10-26 Thread Tom Rini
We split BOOT_DEFAULTS to have BOOT_DEFAULTS_FEATURES and BOOT_DEFAULTS_CMDS that in turn list general features or commands that we want enabled when BOOT_DEFAULTS is selected. We only select BOOT_DEFAULTS_CMDS if CMDLINE is set. Signed-off-by: Tom Rini --- boot/Kconfig | 23

[v5 14/30] autoboot: Correct dependencies on CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Make AUTOBOOT depend on CMDLINE since it is mostly meaningless without it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- boot/Kconfig | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index

[v5 13/30] bootmeth: Make BOOTMETH_EFILOADER depend on CMD_BOOTEFI

2023-10-26 Thread Tom Rini
Today, the bootmeth for using the EFI loader via bootefi depends on calling the bootefi command directly, so make this in turn depend on CMD_BOOTEFI. Signed-off-by: Tom Rini --- boot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig

[v5 12/30] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-26 Thread Tom Rini
From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Cc:

[v5 10/30] video: Don't require the font command

2023-10-26 Thread Tom Rini
From: Simon Glass While it is nice to have the font command, using 'select' makes it impossible to build the console code without it. Stop using 'select' and make it default if CONSOLE_TRUETYPE is enabled when asking the command. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes

[v5 11/30] cli_simple: Rework this support slightly

2023-10-26 Thread Tom Rini
The interactive portion of our non-HUSH 'simple' parser is guarded by CONFIG_CMDLINE already. Much of the code behind this simple parser is also used as "input" parser, such as from menu interfaces and so forth and not strictly command line input. To support this, always build the assorted cli

[v5 09/30] test: Make UNIT_TEST depend on CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Many tests make some use of the command line, so require it for all test code. This could be teased apart, perhaps with a test flag indicating that it uses the command line. Leave that for later. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/Kconfig | 1 + 1

[v5 08/30] env: Move env_set() out of cmd/nvedit.c and in to env/common.c

2023-10-26 Thread Tom Rini
Inside of env/common.c we already have our helper env_set_xxx functions, and even have a comment that explains why env_set() itself wasn't moved. We now handle that move. This requires that we rename the previous _do_env_set() to env_do_env_set() and note it as an internal env function. Add

[v5 06/30] qemu: Correct CMD_QFW dependencies in Kconfig

2023-10-26 Thread Tom Rini
Rather than selecting CMD_QFW, we should make the option itself by enabled by default on these platforms. Then in the board-specific Kconfig we should select the appropriate back-end as needed if the command is enabled. Signed-off-by: Tom Rini --- Cc: Tuomas Tynkkynen Cc: Bin Meng ---

[v5 07/30] Kconfig: Move CONFIG_SYS_[CP]BSIZE to common/Kconfig

2023-10-26 Thread Tom Rini
Move CONFIG_SYS_CBSIZE (console buffer size) and CONFIG_SYS_PBSIZE (console print buffer size) out of cmd/Kconfig and in to common/Kconfig. Create help entries for both which explain their usage and why they are both not entirely command centric. Signed-off-by: Tom Rini --- cmd/Kconfig| 14

[v5 05/30] version: Separate our version string from the version command

2023-10-26 Thread Tom Rini
In order to be able to disable all commands we need to construct our version string in a common file, and have the version command reference that string, like the other users of it do. Create common/version.c with just the strings. Signed-off-by: Tom Rini --- cmd/version.c| 9 -

[v5 04/30] dfu: Make DFU_TFTP depend on NETDEVICES

2023-10-26 Thread Tom Rini
In order to do a DFU update over TFTP we need to have some network device available, so make this depend on NETDEVICES Signed-off-by: Tom Rini --- drivers/dfu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig index 4e80e85d10d7..8771678ca5a0

[v5 03/30] virtio: Make VIRTIO_NET depend on NETDEVICES

2023-10-26 Thread Tom Rini
As VIRTIO_NET is the symbol for enabling network devices, make this depend on NETDEVICES Signed-off-by: Tom Rini --- Cc: Bin Meng --- drivers/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index

[v5 02/30] buildman: Use oldconfig when adjusting the config

2023-10-26 Thread Tom Rini
From: Simon Glass We cannot be sure that the new config is consistent, particularly when changing a major item like CONFIG_CMDLINE. Use 'make oldconfig' to check that and avoid any such problems. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 2 +-

[v5 01/30] sandbox: eliminate unused functions from binaries

2023-10-26 Thread Tom Rini
From: Heinrich Schuchardt The sandbox should closely mimic other architectures. Place each function or data in a separate section and let the linker eliminate unused ones. This will reduce the binary size. In the linker script mark that u_boot_sandbox_getopt are to be kept. Signed-off-by:

Re: quick question about TPM

2023-10-26 Thread Simon Glass
+Ilias Apalodimas as well On Thu, 26 Oct 2023 at 02:22, niek.nooij...@omron.com wrote: > > Hi Simon > > Yes that fixes it! Thanks! > Maybe an Idea to add a dedicated TPM page to the docs with information like > this? > (https://u-boot.readthedocs.io/en/latest/index.html) Cause I wouldn't have

Re: [PATCH v8 3/8] power: pmic: add the base MAX77663 PMIC support

2023-10-26 Thread Tom Rini
On Thu, Oct 26, 2023 at 05:49:01PM +0300, Svyatoslav Ryhel wrote: > > > 25 жовтня 2023 р. 16:37:12 GMT+03:00, Tom Rini > написав(-ла): > >On Wed, Oct 25, 2023 at 09:10:12AM +0300, Svyatoslav Ryhel wrote: > >> вт, 24 жовт. 2023 р. о 22:18 Tom Rini пише: > >> > > >> > On Tue, Oct 24, 2023 at

Re: [PATCH v3 1/1] efi_loader: expose the device-tree file name

2023-10-26 Thread Rob Herring
On Sun, Oct 22, 2023 at 4:32 PM Heinrich Schuchardt wrote: > > On 10/22/23 19:08, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 06:34:08PM +0200, Heinrich Schuchardt wrote: > >> On 10/22/23 17:55, Tom Rini wrote: > >>> On Sun, Oct 22, 2023 at 10:47:33AM +0200, Heinrich Schuchardt wrote: > >>> >

Re: [PATCH v2 0/2] ARM: amlogic: Add A1 SPIFC support

2023-10-26 Thread Neil Armstrong
Hi, On Wed, 25 Oct 2023 01:51:38 +0300, Igor Prusov wrote: > A1 family boards have new version of SPIFC controller, that is > incompatible with meson_spifc driver. This series ports A1 SPIFC driver > from Linux and enables it for ad401 board. > > Changes in V2: > - more details in Kconfig help

Re: [PATCH 0/4] ARM: meson: Add boot over DFU RAM as an USB boot step

2023-10-26 Thread Neil Armstrong
Hi, On Mon, 23 Oct 2023 14:41:33 +0200, Neil Armstrong wrote: > Add boot over DFU RAM as an alternate to running script at > a fixed address like done today. > > The main culprit is that it's not possible to do that > on G12A/SM1 platforms due to changes in the USB boot protocol. > > With this,

Re: [PATCH] configs: khadas-vim3*_android: fix environment saving

2023-10-26 Thread Neil Armstrong
Hi, On Thu, 26 Oct 2023 15:41:31 +0200, Mattijs Korpershoek wrote: > The environment is used to configure some additional boot features such as: > * extra boot arguments > * enable AVB (Android Verified Boot) verification > > Right now, we cannot store it in eMMC: > > Loading Environment from

Re: [PATCH] configs: khadas-vim3*_android: fix environment saving

2023-10-26 Thread Neil Armstrong
_SARADC_MESON=y CONFIG_BUTTON=y --- base-commit: 14a21f1a80afc58d52dc72e35f27d3a47d36c082 change-id: 20231026-fix-saveenv-eb5484622282 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v8 3/8] power: pmic: add the base MAX77663 PMIC support

2023-10-26 Thread Svyatoslav Ryhel
25 жовтня 2023 р. 16:37:12 GMT+03:00, Tom Rini написав(-ла): >On Wed, Oct 25, 2023 at 09:10:12AM +0300, Svyatoslav Ryhel wrote: >> вт, 24 жовт. 2023 р. о 22:18 Tom Rini пише: >> > >> > On Tue, Oct 24, 2023 at 10:41:05AM +0300, Svyatoslav Ryhel wrote: >> > >> > > Add support to bind the

Re: [PATCH] MAINTAINERS: Remove non-working address from MAINTAINERS

2023-10-26 Thread Fabio Estevam
Hi Hugo, On Thu, Oct 26, 2023 at 11:38 AM Hugo Villeneuve wrote: > Hi Fabio, > since the change concerns two different boards, that is why I didn't > indicate it. If required, I could send it as two separate patches. Ok, got it. Let's keep it as is then. Thanks

Re: [PATCH] MAINTAINERS: Remove non-working address from MAINTAINERS

2023-10-26 Thread Hugo Villeneuve
On Thu, 26 Oct 2023 11:25:19 -0300 Fabio Estevam wrote: > On Mon, Oct 23, 2023 at 1:45 PM Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve > > The Subject does indicate which board it refers to. > > It would be better to have it like: > > imx8mn_smm_s2: Remove non-working address from

Re: [PATCH v2 1/4] net: dwc_eth_qos: add i.MX93 support

2023-10-26 Thread Fabio Estevam
On Tue, Oct 17, 2023 at 6:45 AM Sébastien Szymanski wrote: > > Add support for DWC EQoS MAC on i.MX93. > > Signed-off-by: Sébastien Szymanski For the series: Reviewed-by: Fabio Estevam

Re: [PATCH] arm: dts: imx8mn-var-som: Fix broken EEPROM read

2023-10-26 Thread Fabio Estevam
On Tue, Oct 17, 2023 at 5:58 PM Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > On branch WIP/17Oct2023, the EEPROM can no longer be read: > > U-Boot 2023.10-latest (Oct 17 2023 - 15:53:43 -0400) > CPU: Freescale i.MX8MNano Quad rev1.0 at 1200 MHz > Reset cause: POR >

Re: [PATCH] MAINTAINERS: Remove non-working address from MAINTAINERS

2023-10-26 Thread Fabio Estevam
On Mon, Oct 23, 2023 at 1:45 PM Hugo Villeneuve wrote: > > From: Hugo Villeneuve The Subject does indicate which board it refers to. It would be better to have it like: imx8mn_smm_s2: Remove non-working address from MAINTAINERS Reviewed-by: Fabio Estevam

Re: [PATCH v1] apalis-imx8: add USBH_EN gpio hog

2023-10-26 Thread Fabio Estevam
On Fri, Oct 20, 2023 at 12:25 PM Andrejs Cainikovs wrote: > > From: Andrejs Cainikovs > > USB host interface is not working on some Apalis Toradex carrier > boards with Apalis iMX8 SoM. This is due to USBH_EN pin, which > powers USB peripherals, having a strong pull-down on some boards, > and a

Re: [PATCH] imx8mn-var-som: Simplify FEC initialization

2023-10-26 Thread Fabio Estevam
On Thu, Oct 19, 2023 at 4:43 PM Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > With DM enabled, there is no need for board code to initialize > the FEC interface. > > The ethernet PHYs on the symphony carrier board have a dedicated > crystal/oscillator. If the SOM has the EC configuration

Re: [PATCH 1/5] configs: imx8mp_beacon: Do not set SYS_CONSOLE_IS_IN_ENV

2023-10-26 Thread Fabio Estevam
On Wed, Oct 25, 2023 at 8:05 PM Adam Ford wrote: > > The hardware only supports a specific console port, so remove the > option to change the console location in the environment. > > Signed-off-by: Adam Ford For the series: Reviewed-by: Fabio Estevam

Re: [PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

2023-10-26 Thread Fabio Estevam
On Thu, Oct 26, 2023 at 4:32 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > This fixes a regression in the eMMC fast boot mode case where the buffer > was missing 464 bytes. > > The code figures out how many bytes must at least be fetched to honor > the current read, rounds that up to

Re: [PATCH v1 1/2] imx: spl_imx_romapi: fix comment about stream(usb) download failure

2023-10-26 Thread Fabio Estevam
On Thu, Oct 26, 2023 at 4:32 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Fix comment about Stream(USB) download failure. > > Fixes: 1cbebc786276 ("imx: add rom api support") > Signed-off-by: Marcel Ziswiler Reviewed-by: Fabio Estevam

[PATCH] xilinx: versal: Setup 30MHz as default spi frequency

2023-10-26 Thread Michal Simek
Align default SPI configuration with ZynqMP/Versal NET. There is no reason to run on lower frequencies. Signed-off-by: Michal Simek --- configs/xilinx_versal_virt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_versal_virt_defconfig

Re: [PATCH 1/1] [u-boot][master][PATCH v5] pico-imx7d: add baseboard SD card boot detect

2023-10-26 Thread Fabio Estevam
On Sat, Oct 21, 2023 at 9:40 AM wrote: > > From: Benjamin Szőke > > Technexion PICO-IMX7 SoM is supporting USDHC3 (eMMC or micro SD on SoM) > and USDHC1 (SD on carrier board) to use on any carrier board like > PICO-NYMPH. This pacth is intend to take over codes from Technexion Typo in "pacth is

[PATCH 4/4] arm64: versal-net: Add DTSes for mini qspi/ospi configuration

2023-10-26 Thread Michal Simek
Mini U-Boot is running out of OCM and it's only purpose is to program non volatile memories. There are different configurations which ospi/qspi can be that's why describe them via DT. DT binding is already approved that's why there is no reason not to add it. Signed-off-by: Michal Simek ---

[PATCH 3/4] arm64: versal: Add DTSes for mini qspi/ospi configuration

2023-10-26 Thread Michal Simek
Mini U-Boot is running out of OCM and it's only purpose is to program non volatile memories. There are different configurations which ospi/qspi can be that's why describe them via DT. DT binding is already approved that's why there is no reason not to add it. Signed-off-by: Michal Simek ---

[PATCH 2/4] ARM: zynq: Add DTSes for mini qspi configurations

2023-10-26 Thread Michal Simek
Mini U-Boot is running out of OCM and it's only purpose is to program non volatile memories. There are different configurations which qspi can be that's why describe them via DT. DT binding is already approved that's why there is no reason not to add it. Signed-off-by: Michal Simek --- Core

[PATCH 1/4] ARM: zynq: Add DTSes for mini qspi configurations

2023-10-26 Thread Michal Simek
Mini U-Boot is running out of OCM and it's only purpose is to program non volatile memories. There are different configurations which qspi can be that's why describe them via DT. DT binding is already approved that's why there is no reason not to add it. Signed-off-by: Michal Simek --- Core

[PATCH 0/4] xilinx: Add DTSes for mini qspi/ospi configuration

2023-10-26 Thread Michal Simek
Hi, we are using U-Boot mini configurations for years. We already upstream configurations for mtest, single qspi/ospi or emmcs for all Xilinx SOCs. But we didn't push configuration for different qspi/ospi configurations which were missing upstream dt description. This has changed some time ago

[PATCH] configs: khadas-vim3*_android: fix environment saving

2023-10-26 Thread Mattijs Korpershoek
AVB=y CONFIG_OF_CONTROL=y +CONFIG_ENV_IS_IN_MMC=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y +CONFIG_SYS_MMC_ENV_DEV=2 +CONFIG_SYS_MMC_ENV_PART=2 CONFIG_ADC=y CONFIG_SARADC_MESON=y CONFIG_BUTTON=y --- base-commit: 14a21f1a80afc58d52dc72e35f27d3a47d36c082 change-id: 20231026-fix-saveenv-eb5484622282 Best regards, -- Mattijs Korpershoek

Re: [RFC PATCH 1/5] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-10-26 Thread Tom Rini
On Mon, Oct 23, 2023 at 05:41:10PM +0530, Devarsh Thakkar wrote: > Hi Simon, > > Thanks for the review. > > On 19/10/23 19:26, Simon Glass wrote: > > Hi Devarsh, > > > > On Mon, 16 Oct 2023 at 10:06, Devarsh Thakkar wrote: > >> > >> Move the function to setup video memory before page table >

Re: [PATCH 3/3] arm64: boot: Support Flat Image Tree

2023-10-26 Thread Masahiro Yamada
On Thu, Oct 26, 2023 at 4:28 PM Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > containing the built kernel and associated devicetree files. > Compression defaults to gzip which gives a good balance of size and > performance. > > The files compress from

  1   2   >