Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-02-04 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Sun, 4 Feb 2024 05:07:38 -0700: > Hi Rob, > > On Wed, 17 Jan 2024 at 08:56, Rob Herring wrote: > > > > On Thu, Jan 4, 2024 at 3:54 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Thu, Dec 14, 2023 at 2:09 PM Simon Glass wrote: > > > > > > > >

Re: [PATCH] net: macb: Add support for fixed link

2024-02-04 Thread Dan Carpenter
On Sat, Feb 03, 2024 at 07:06:52PM +0100, belouargamoha...@gmail.com wrote: > @@ -1276,6 +1297,30 @@ int __weak macb_late_eth_of_to_plat(struct udevice > *dev) > static int macb_eth_of_to_plat(struct udevice *dev) > { > struct eth_pdata *pdata = dev_get_plat(dev); > + struct

Re: [PATCH 1/3] usb: dwc3: handle return value of clk_get_rate() correctly

2024-02-04 Thread Dan Carpenter
On Sat, Feb 03, 2024 at 07:01:54AM +0800, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > clk_get_rate() return -ve on error, not 0. Fix it by replacing judging > NULL with IS_ERR_VALUE(). s/NULL/zero/. I'd be surprised if clk_get_rate() *never* returns zero. The Linux kernel's

Re: [PATCH v2] mtd: rawnand: Meson NAND controller support

2024-02-04 Thread Arseniy Krasnov
On 05.02.2024 10:00, Michael Nazzareno Trimarchi wrote: > Hi > > Il lun 5 feb 2024, 07:43 Arseniy Krasnov ha > scritto: > >> Hi, sorry, but pls, ping :) >> >> On 15.01.2024 09:01, Arseniy Krasnov wrote: >>> Hi, thanks for review! Two questions below... >>> >>> On 09.01.2024 11:42, Michael

Re: [PATCH] rockchip: rk3568-generic: Enable eMMC HS200 mode

2024-02-04 Thread Kever Yang
On 2024/2/1 06:07, Jonas Karlman wrote: Writing to eMMC using HS200 mode work more reliably then other modes on RK356x boards. Add device tree props and enable Kconfig options for eMMC HS200 mode on the generic RK3566/RK3568 board. Also enable the pinctrl driver in SPL and add missing

Re: [PATCH] board: rockchip: Add Pine64 PineTab2

2024-02-04 Thread Kever Yang
Hi Jonas, On 2024/2/5 01:30, Jonas Karlman wrote: The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566 SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage. Features tested on a Pine64 PineTab2 8GB v2.0: - SD-card boot - eMMC boot - SPI Flash boot - USB host

Re: [PATCH] rockchip: rk3588-evb: Enable USB support

2024-02-04 Thread Kever Yang
On 2024/2/3 19:31, Andy Yan wrote: From: Andy Yan Enable USB releated config to support boot from usb. Signed-off-by: Andy Yan Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3588_defconfig | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH v2] mtd: rawnand: Meson NAND controller support

2024-02-04 Thread Arseniy Krasnov
Hi, sorry, but pls, ping :) On 15.01.2024 09:01, Arseniy Krasnov wrote: > Hi, thanks for review! Two questions below... > > On 09.01.2024 11:42, Michael Nazzareno Trimarchi wrote: >> Hi Arseniy >> >> >> On Fri, Dec 15, 2023 at 1:32 PM Arseniy Krasnov >> wrote: >>> >>> Basic support for Amlogic

Re: [PATCH v2 3/3] mmc: rockchip_sdhci: Fix HS400 mode write on RK3568

2024-02-04 Thread Kever Yang
On 2024/2/5 04:53, Jonas Karlman wrote: Testing has shown that writing to eMMC using HS400 modes on RK3568 result in an ERROR. Change the tap number for transmit clock to fix this. Also stop DLL when config_dll() is called to disable DLL. Signed-off-by: Jonas Karlman Reviewed-by: Kever

Re: [PATCH v2 2/3] rockchip: rk35xx: Enable eMMC HS200 mode by default

2024-02-04 Thread Kever Yang
On 2024/2/5 04:53, Jonas Karlman wrote: Testing has shown that writing to eMMC using a slower mode then HS200 typically generate an ERROR on first attempt on RK3588. # Rescan using MMC legacy mode => mmc rescan 0 # Write a single block to sector 0x4000 fails with ERROR => mmc

Re: [PATCH v2 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-02-04 Thread Kever Yang
On 2024/2/5 04:53, Jonas Karlman wrote: Testing has shown that writing to eMMC using DDR52 mode does not seem to work on RK356x and RK3588 boards. A simple test of writing a single block to e.g. sector 0x4000 fails: # Rescan using DDR52 mode => mmc rescan 4 # Write a single block

[PATCH v2 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

2024-02-04 Thread wan . yee . lau
From: Wan Yee Lau Add socfpga_dtreg driver enablement for Intel SoCFPGA. Signed-off-by: Wan Yee Lau --- Changes for v2: - Rearranged header file in socfpga_drteg.c, moved lower. arch/arm/Kconfig | 2 + .../misc/socfpga_dtreg.txt| 74

Re: [PATCH v3] rockchip: spl: Enable caches to speed up checksum validation

2024-02-04 Thread Kever Yang
Hi Jonas,     This patch fail to build with armv7 platform: +arch/arm/mach-rockchip/spl.c: In function 'board_init_f': +arch/arm/mach-rockchip/spl.c:143:17: error: implicit declaration of function 'enable_caches' [-Werror=implicit-function-declaration] +  143 |

[PATCH v2 3/3] mmc: rockchip_sdhci: Fix HS400 mode write on RK3568

2024-02-04 Thread Jonas Karlman
Testing has shown that writing to eMMC using HS400 modes on RK3568 result in an ERROR. Change the tap number for transmit clock to fix this. Also stop DLL when config_dll() is called to disable DLL. Signed-off-by: Jonas Karlman --- Changes in v2: - New patch to fix HS400 mode write on RK3568

[PATCH v2 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-02-04 Thread Jonas Karlman
Testing has shown that writing to eMMC using DDR52 mode does not seem to work on RK356x and RK3588 boards. A simple test of writing a single block to e.g. sector 0x4000 fails: # Rescan using DDR52 mode => mmc rescan 4 # Write a single block to sector 0x4000 fails with ERROR => mmc write

[PATCH v2 2/3] rockchip: rk35xx: Enable eMMC HS200 mode by default

2024-02-04 Thread Jonas Karlman
Testing has shown that writing to eMMC using a slower mode then HS200 typically generate an ERROR on first attempt on RK3588. # Rescan using MMC legacy mode => mmc rescan 0 # Write a single block to sector 0x4000 fails with ERROR => mmc write 2000 4000 1 # Write a single block to

[PATCH v2 0/3] rockchip: rk35xx: Fix writing to eMMC

2024-02-04 Thread Jonas Karlman
Testing has shown that writing to eMMC using DDR52 mode does not seem to work on RK356x and RK3588 boards. This series fixes this issue by changing RK356x and RK3588 boards to prefer use of the more reliably HS200 mode. Changes in v2: - Update commit messages - Imply MMC_HS200_SUPPORT and

Re: [PATCH 1/1] docker: build QEMU v8.2.1

2024-02-04 Thread Tom Rini
On Sun, Feb 04, 2024 at 08:13:57PM +0100, Heinrich Schuchardt wrote: > Upgrade the used QEMU to v8.2.1. This avoids patching the source. > > Signed-off-by: Heinrich Schuchardt > --- > tools/docker/Dockerfile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[PATCH 1/1] docker: build QEMU v8.2.1

2024-02-04 Thread Heinrich Schuchardt
Upgrade the used QEMU to v8.2.1. This avoids patching the source. Signed-off-by: Heinrich Schuchardt --- tools/docker/Dockerfile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile index 6122776bc6..7df68d9c9c 100644 ---

[PATCH] board: rockchip: Add Pine64 PineTab2

2024-02-04 Thread Jonas Karlman
The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566 SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage. Features tested on a Pine64 PineTab2 8GB v2.0: - SD-card boot - eMMC boot - SPI Flash boot - USB host Device tree is imported from linux maintainer branch

RE: [PATCH] efi_loader : Suppress error print message

2024-02-04 Thread Bhumkar, Tejas Arvind
[AMD Official Use Only - General] Hi Heinrich, > -Original Message- > From: Heinrich Schuchardt > Sent: Monday, January 29, 2024 4:09 AM > To: Bhumkar, Tejas Arvind > Cc: Ilias Apalodimas ; U-Boot Mailing List b...@lists.denx.de>; Tom Rini > Subject: Re: [PATCH] efi_loader : Suppress

I'm trying to create a new nv_uboot-snow-usb.kpart file changing some parameters inside the file snow.h file, but the modifications I made aren't detected.

2024-02-04 Thread Mario Marietto
Hello. My ARM Chromebook SNOW model has the mmc slot broken,but I've realized that I can boot Linux using the USB port ! To enable the booting of Linux via USB I have modified this file :

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-02-04 Thread Simon Glass
Hi Rob, On Wed, 17 Jan 2024 at 08:56, Rob Herring wrote: > > On Thu, Jan 4, 2024 at 3:54 PM Simon Glass wrote: > > > > Hi Rob, > > > > On Thu, Dec 14, 2023 at 2:09 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Thu, 14 Dec 2023 at 10:27, Rob Herring wrote: > > > > > > > > On Fri,

Re: [PATCH v5 1/6] rockchip: rk3399: simplify logic for getting SPL boot medium DT node

2024-02-04 Thread Kever Yang
Hi  Quentin,     Could you help to rebase and send this patch again?     I can't see the version v5 on patchwork. Thanks, - Kever On 2024/1/18 21:55, Quentin Schulz wrote: From: Quentin Schulz In preparation of moving spl_perform_fixups to spl-boot-order.c, let's simplify the logic

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-04 Thread Dragan Simic
Hello Jonas, On 2024-02-04 10:46, Jonas Karlman wrote: On 2024-02-04 05:21, Dragan Simic wrote: On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: We should add more ifdef guards to rockchip_setup_macaddr(), to prevent

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-04 Thread Jonas Karlman
On 2024-02-04 05:21, Dragan Simic wrote: > On 2024-02-03 16:18, Dragan Simic wrote: >> On 2024-02-03 15:18, Jonas Karlman wrote: >>> On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: > From: Quentin Schulz >