Re: [PATCH v2] usb: check for companion controller in uclass

On 9/4/23 15:54, Marek Vasut wrote: > On 9/4/23 14:34, Fabrice Gasnier wrote: >> On 9/1/23 18:00, Marek Vasut wrote: >>> On 9/1/23 14:12, Fabrice Gasnier wrote: >>>> On 9/1/23 12:48, Marek Vasut wrote: >>>>> On 9/1/23 11:52, Fabrice Gasnier wrot

Re: [PATCH v2] usb: check for companion controller in uclass

On 9/1/23 18:00, Marek Vasut wrote: > On 9/1/23 14:12, Fabrice Gasnier wrote: >> On 9/1/23 12:48, Marek Vasut wrote: >>> On 9/1/23 11:52, Fabrice Gasnier wrote: >>>> EHCI is usually used with companion controller (like OHCI) as companion >>>> con

[PATCH v2] usb: host: ohci-generic: Make usage of clock/reset bulk() API

Make usage of clock and reset bulk API in order to simplify the code Reviewed-by: Marek Vasut Signed-off-by: Fabrice Gasnier --- Changes in v2: - fix copy/paste on dev_err message since Marek's review comment - add Marek's review tag --- drivers/usb/host/ohci-generic.c | 92

Re: [PATCH] usb: host: ohci-generic: Make usage of clock/reset bulk() API

On 9/2/23 11:06, Xavier Drudis Ferran wrote: > Is the change of behaviour intended when a clock or reset is not found ? > (see below) Hi Xavier, I'd say yes, although I haven't seen that... please find my answers below. > > El Wed, Aug 30, 2023 at 10:01:49AM +0200, Fabrice

Re: [PATCH v2] usb: check for companion controller in uclass

On 9/1/23 12:48, Marek Vasut wrote: > On 9/1/23 11:52, Fabrice Gasnier wrote: >> EHCI is usually used with companion controller (like OHCI) as companion >> controller. This information on the companion is missing currently in >> companion drivers. >> So, if the usb-ucla

Re: [PATCH] usb: host: ohci-generic: Make usage of clock/reset bulk() API

On 8/30/23 17:18, Marek Vasut wrote: > On 8/30/23 10:01, Fabrice Gasnier wrote: >> Make usage of clock and reset bulk API in order to simplify the code >> >> Signed-off-by: Fabrice Gasnier >> --- >> >>   drivers/usb/host/ohci-generic.c | 92 +++---

[PATCH v2] usb: check for companion controller in uclass

0mA) SanDisk Cruzer Blade 03003432021922011407 Signed-off-by: Fabrice Gasnier --- Changes in v2: - move companion probing from generic ehci driver to usb-uclass, after Marek's questions on design choice. - rename commit title to follow this change --- drivers/usb/host/usb-uclass.c | 36 +++

Re: [PATCH] usb: host: ehci-generic: check for companion controller

On 8/30/23 17:12, Marek Vasut wrote: > On 8/30/23 10:00, Fabrice Gasnier wrote: >> EHCI is usually used with companion controller (like OHCI) as companion >> controller. This information on the companion is missing currently in >> companion drivers. >> So, if the usb

[PATCH] usb: host: ohci-generic: Make usage of clock/reset bulk() API

Make usage of clock and reset bulk API in order to simplify the code Signed-off-by: Fabrice Gasnier --- drivers/usb/host/ohci-generic.c | 92 +++-- 1 file changed, 29 insertions(+), 63 deletions(-) diff --git a/drivers/usb/host/ohci-generic.c b/drivers/usb/host

[PATCH] usb: host: ehci-generic: check for companion controller

ass Storage (480 Mb/s, 200mA) SanDisk Cruzer Blade 03003432021922011407 Signed-off-by: Fabrice Gasnier --- drivers/usb/host/ehci-generic.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c index a765a

[PATCH 3/3] ARM: dts: stm32: add support for USB2514B onboard hub on stm32mp157c-ev1

Add support for USB2514B onboard hub on stm32mp157c EV1 board. The HUB is supplied by a 3v3 PMIC regulator. [backport from linux ad9591b01d24] Signed-off-by: Fabrice Gasnier --- arch/arm/dts/stm32mp157c-ev1.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts

[PATCH 0/3] Add support for USB onboard HUB, used on stm32 boards

an always-on regulator. It aligns the relevant DT part from emerging Linux v6.2. It also adds the relevant default configuration on stm32mp15. Fabrice Gasnier (3): usb: onboard-hub: add driver to manage onboard hub supplies configs: stm32: enable USB onboard HUB driver ARM: dts: stm32: add support

[PATCH 2/3] configs: stm32: enable USB onboard HUB driver

Activate the USB onboard HUB driver, that is used to enable the HUB supply on STM32MP15 EVAL, DK1 and DK2 boards. This avoids marking the 3v3 corresponding regulator as always-on. Signed-off-by: Fabrice Gasnier --- configs/stm32mp15_basic_defconfig | 1 + configs/stm32mp15_defconfig

[PATCH 1/3] usb: onboard-hub: add driver to manage onboard hub supplies

Hub (480 Mb/s, 0mA) | u-boot EHCI Host Controller | +-2 Hub (480 Mb/s, 2mA) Signed-off-by: Fabrice Gasnier --- common/Makefile | 1 + common/usb_onboard_hub.c | 62 +++ drivers/usb/Kconfig | 10 ++ drivers/usb/host/usb-uclass.c

[PATCH] ARM: dts: stm32: update vbus-supply of usbphyc_port0 on stm32mp157c-ev1

phy-stm32-usbphyc bindings uses a connector node with vbus-supply property. [backport from linux 43e55d778a6b] Signed-off-by: Fabrice Gasnier --- arch/arm/dts/stm32mp157c-ev1.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/stm32mp157c-ev1.dts b/arch/arm/dts/stm32mp157c

Re: [U-Boot] [PATCH 07/20] adc: stm32: Fix warnings when compiling with W=1

> Signed-off-by: Patrick Delaunay Hi Patrick, Acked-by: Fabrice Gasnier Thanks, Fabrice > --- > > drivers/adc/stm32-adc-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/adc/stm32-adc-core.c b/drivers/adc/stm32-adc-core.c > index

Re: [U-Boot] [PATCH 06/20] adc: stm32-adc: Fix warnings when compiling with W=1

dc->cfg->max_channels) { >^ > Signed-off-by: Patrice Chotard > > Signed-off-by: Patrick Delaunay Hi Patrick, Acked-by: Fabrice Gasnier Thanks, Fabrice > --- > > drivers/adc/stm32-adc.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 delet

[U-Boot] [PATCH] usb: dwc2: fix gadget disconnect

dwc2 driver. Signed-off-by: Fabrice Gasnier --- drivers/usb/gadget/dwc2_udc_otg_regs.h | 6 +- drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 14 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/dwc2_udc_otg_regs.h b/drivers/usb/gadget/dwc2

[U-Boot] [PATCH v2 4/4] cmd: adc: add an option to scan some or all available channels

Add new option to 'adc' command to do a single scan of: - some channel(s), using mask argument - all channels available on an ADC device (when optional mask is omitted). Signed-off-by: Fabrice Gasnier --- Changes in v2: None cmd/adc.c | 55

[U-Boot] [PATCH v2 0/4] Add adc uclass's channel mask and conversion helpers and enhance adc cmd

to scan once several or all channels Changes in v2: - Add calls to the new functions in test/dm/adc.c as suggested by Simon Fabrice Gasnier (4): dm: adc: add uclass's mask and conversion helpers cmd: adc: add info on channel mask cmd: adc: print single conversion also in uV cmd: adc: add

[U-Boot] [PATCH v2 2/4] cmd: adc: add info on channel mask

Enhance adc info command to report also the channel mask. Signed-off-by: Fabrice Gasnier --- Changes in v2: None cmd/adc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/adc.c b/cmd/adc.c index c8857ed..39f61c1 100644 --- a/cmd/adc.c +++ b/cmd/adc.c @@ -35,7

[U-Boot] [PATCH v2 1/4] dm: adc: add uclass's mask and conversion helpers

Add two functions to ADC uclass's: - adc_raw_to_uV() to ease ADC raw value conversion to microvolts - adc_channel_mask() to get channels on consumer side Signed-off-by: Fabrice Gasnier --- Changes in v2: - Add calls to the new functions in test/dm/adc.c as suggested by Simon drivers/adc/adc

[U-Boot] [PATCH v2 3/4] cmd: adc: print single conversion also in uV

Use newly introduced adc_raw_to_uV() API to print conversion result both as raw value and micro-volts by default. Signed-off-by: Fabrice Gasnier --- Changes in v2: None cmd/adc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/cmd/adc.c b/cmd/adc.c index 39f61c1

Re: [U-Boot] [PATCH 2/4] cmd: adc: add info on channel mask

On 10/19/2018 05:25 AM, Simon Glass wrote: > Hi Fabrice, > > On 11 October 2018 at 10:00, Fabrice Gasnier wrote: >> Enhance adc info command to report also the channel mask. >> >> Signed-off-by: Fabrice Gasnier >> --- >> >> cmd/adc.c | 6 +- &g

[U-Boot] [PATCH 3/4] cmd: adc: print single conversion also in uV

Use newly introduced adc_raw_to_uV() API to print conversion result both as raw value and micro-volts by default. Signed-off-by: Fabrice Gasnier --- cmd/adc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/cmd/adc.c b/cmd/adc.c index 39f61c1..7360a96 100644

[U-Boot] [PATCH 4/4] cmd: adc: add an option to scan some or all available channels

Add new option to 'adc' command to do a single scan of: - some channel(s), using mask argument - all channels available on an ADC device (when optional mask is omitted). Signed-off-by: Fabrice Gasnier --- cmd/adc.c | 55 ++- 1 file changed

[U-Boot] [PATCH 0/4] Add adc uclass's channel mask and conversion helpers and enhance adc cmd

to scan once several or all channels Fabrice Gasnier (4): dm: adc: add uclass's mask and conversion helpers cmd: adc: add info on channel mask cmd: adc: print single conversion also in uV cmd: adc: add an option to scan some or all available channels cmd/adc.c| 70

[U-Boot] [PATCH 2/4] cmd: adc: add info on channel mask

Enhance adc info command to report also the channel mask. Signed-off-by: Fabrice Gasnier --- cmd/adc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/adc.c b/cmd/adc.c index c8857ed..39f61c1 100644 --- a/cmd/adc.c +++ b/cmd/adc.c @@ -35,7 +35,7 @@ static int

[U-Boot] [PATCH 1/4] dm: adc: add uclass's mask and conversion helpers

Add two functions to ADC uclass's: - adc_raw_to_uV() to ease ADC raw value conversion to microvolts - adc_channel_mask() to get channels on consumer side Signed-off-by: Fabrice Gasnier --- drivers/adc/adc-uclass.c | 37 + include/adc.h| 21

[U-Boot] [PATCH v2 0/6] Add support for STM32 ADC

config and DT on stm32mp15 Changes in v2: - add test case for 'clk_valid()', e.g. in test/dm/clk.c and sandbox. - Update TRUE/FALSE comments to lower case: true/false - move device_get_supply_regulator() call to pre_probe() routine Fabrice Gasnier (6): clk: add clk_valid() dm: adc: uclass: get

Re: [U-Boot] [PATCH 2/6] dm: adc: uclass: get reference regulator once

On 07/24/2018 01:48 AM, Simon Glass wrote: > Hi Fabrice, > > On 23 July 2018 at 06:35, Fabrice Gasnier wrote: >> device_get_supply_regulator() only needs to be called once. >> But each time there's call to adc_vxx_value() for instance, it calls >&

[U-Boot] [PATCH v2 6/6] ARM: dts: stm32mp157: Add ADC DT node

Add ADC device tree node. This allows to get analog conversions on stm32mp157. Signed-off-by: Fabrice Gasnier --- Changes in v2: None --- arch/arm/dts/stm32mp157.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/stm32mp157.dtsi b/arch/arm

[U-Boot] [PATCH v2 4/6] adc: Add driver for STM32 ADC

ADC, channels and handle conversions. This driver currently supports STM32H7 and STM32MP1 ADC. Signed-off-by: Fabrice Gasnier Reviewed-by: Simon Glass --- Changes in v2: None drivers/adc/Kconfig | 16 +++ drivers/adc/Makefile | 1 + drivers/adc/stm32-adc-core.c | 209

[U-Boot] [PATCH v2 5/6] configs: stm32mp15: enable ADC

Enable ADC on stm32mp15. - CONFIG_CMD_ADC - CONFIG_STM32_ADC Signed-off-by: Fabrice Gasnier Reviewed-by: Simon Glass --- Changes in v2: None configs/stm32mp15_basic_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/stm32mp15_basic_defconfig b/configs

[U-Boot] [PATCH v2 1/6] clk: add clk_valid()

Add clk_valid() to check for optional clocks are valid. Call clk_valid() in test/dm/clk.c and add relevant test routine to sandbox clk tests. Signed-off-by: Fabrice Gasnier --- Changes in v2: - add test case for 'clk_valid()', e.g. in test/dm/clk.c and sandbox. - Update TRUE/FALSE comments

[U-Boot] [PATCH v2 3/6] dt-bindings: Document STM32 ADC DT bindings

This patch adds documentation of device tree bindings for the STM32 ADC. It's based on linux-v4.18-rc* dt-bindings, at the time of writing: - Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt Signed-off-by: Fabrice Gasnier Reviewed-by: Simon Glass --- Changes in v2: None doc/device

[U-Boot] [PATCH v2 2/6] dm: adc: uclass: get reference regulator once

ply to be provided directly from uc_pdata, e.g dt-binding variant like stm32-adc provide its own 'vref-supply'. Signed-off-by: Fabrice Gasnier --- Changes in v2: - move device_get_supply_regulator() call to pre_probe() routine --- drivers/adc/adc-uclass.c | 35 +-- 1 f

[U-Boot] [PATCH 4/6] adc: Add driver for STM32 ADC

ADC, channels and handle conversions. This driver currently supports STM32H7 and STM32MP1 ADC. Signed-off-by: Fabrice Gasnier --- drivers/adc/Kconfig | 16 +++ drivers/adc/Makefile | 1 + drivers/adc/stm32-adc-core.c | 209 +++ drivers/adc

[U-Boot] [PATCH 6/6] ARM: dts: stm32mp157: Add ADC DT node

Add ADC device tree node. This allows to get analog conversions on stm32mp157. Signed-off-by: Fabrice Gasnier --- arch/arm/dts/stm32mp157.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/stm32mp157.dtsi b/arch/arm/dts/stm32mp157.dtsi index

[U-Boot] [PATCH 1/6] clk: add clk_valid()

add clk_valid() to check for optional clocks are valid. Signed-off-by: Fabrice Gasnier --- include/clk.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/clk.h b/include/clk.h index 9a35764..71679a9 100644 --- a/include/clk.h +++ b/include/clk.h @@ -294,4 +294,14 @@ int

[U-Boot] [PATCH 3/6] dt-bindings: Document STM32 ADC DT bindings

This patch adds documentation of device tree bindings for the STM32 ADC. It's based on linux-v4.18-rc* dt-bindings, at the time of writing: - Documentation/devicetree/bindings/iio/adc/st,stm32-adc.txt Signed-off-by: Fabrice Gasnier --- doc/device-tree-bindings/adc/st,stm32-adc.txt | 141

[U-Boot] [PATCH 5/6] configs: stm32mp15: enable ADC

Enable ADC on stm32mp15. - CONFIG_CMD_ADC - CONFIG_STM32_ADC Signed-off-by: Fabrice Gasnier --- configs/stm32mp15_basic_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig index 3a94db5..bbb65b5

[U-Boot] [PATCH 2/6] dm: adc: uclass: get reference regulator once

ike stm32-adc provide its own 'vref-supply'. Signed-off-by: Fabrice Gasnier --- drivers/adc/adc-uclass.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/adc/adc-uclass.c b/drivers/adc/adc-uclass.c index 17c1a4e..70f4cde 100644 --- a/drivers/adc/