Re: obscure microsd detection issue between U-Boot and kernel

2024-06-04 Thread Michael Walle
On Tue Jun 4, 2024 at 9:47 AM CEST, Christian Loehle wrote: > On 6/3/24 22:28, Tim Harvey wrote: > > On Mon, Jun 3, 2024 at 1:18 AM Christian Loehle > > wrote: > >> > >> On 5/31/24 21:47, Tim Harvey wrote: > >>> Greetings, > >>> > >>> I'm seeing an issue on an imx8mm board (imx8mm-venice-gw73xx)

[PATCH] sunxi: SPL SPI: add support for the V3s SoC

2024-05-13 Thread Michael Walle
The V3s is identical regarding register layout, clocks and resets to the sun6i variants. Therefore, we can just add the MACH_SUN8I_V3S to the sun6i compatible ones. SPI boot was tested on a custom board with a Gigadevice GD25Q64 8MiB SPI flash. Signed-off-by: Michael Walle --- arch/arm/mach

[PATCH 2/2] net: sun8i_emac: add support for the V3s

2024-05-13 Thread Michael Walle
Add the compatible string for the emac found on the V3s SoC. The SoC only supports the internal PHY. There are no (R)MII signals on any pins. Signed-off-by: Michael Walle --- drivers/net/sun8i_emac.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/sun8i_emac.c b/drivers

[PATCH 1/2] clk: sunxi: add EMAC and EPHY clocks and resets for the V3s SoC

2024-05-13 Thread Michael Walle
Add the clock gate registers as well as the reset register bits for the EMAC and EPHY for the V3s. These are needed by the sun8i network driver. Signed-off-by: Michael Walle --- drivers/clk/sunxi/clk_v3s.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/sunxi/clk_v3s.c b

[PATCH 0/2] sunxi: v3s: add network support

2024-05-13 Thread Michael Walle
on a custom board. Michael Walle (2): clk: sunxi: add EMAC and EPHY clocks and resets for the V3s SoC net: sun8i_emac: add support for the V3s drivers/clk/sunxi/clk_v3s.c | 6 ++ drivers/net/sun8i_emac.c| 7 +++ 2 files changed, 13 insertions(+) -- 2.39.2

Re: [PATCH 032/149] board: buffalo: Remove and add needed includes

2024-05-02 Thread Michael Walle
On Wed May 1, 2024 at 4:41 AM CEST, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Acked-by: Michael Walle

Re: [PATCH 080/149] board: kontron: Remove and add needed includes

2024-05-02 Thread Michael Walle
On Wed May 1, 2024 at 4:42 AM CEST, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Acked-by: Michael Walle

Re: Capsule GUIDs and LVFS

2024-04-25 Thread Michael Walle
Hi, On Thu Apr 25, 2024 at 8:19 AM CEST, Ilias Apalodimas wrote: > I've cc'ed all the people I could find in board specific MAINTAINER files. > Can you respond to Richard with the proper company name & board name > so we can bind the following GUIDs to a vendor properly? > Richard any guidance on

Re: [PATCH] board: sl28: move to OF_UPSTREAM

2024-04-15 Thread Michael Walle
On Wed Mar 6, 2024 at 5:19 PM CET, Michael Walle wrote: > Use the new device devicetree files in dts/upstream/ and delete the old > ones. Still keep the -u-boot.dtsi with all u-boot specifics around. > > There is one catch and that is fsl-ls1028a-kontron-sl28-var3.dts which > i

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-12 Thread Michael Walle
Hi, On Fri Apr 12, 2024 at 5:03 AM CEST, Neha Malcom Francis wrote: > On 05/04/24 13:12, Michael Walle wrote: > > On Thu Apr 4, 2024 at 11:10 AM CEST, Neha Malcom Francis wrote: > >> But again in the interest of time... this would mean this cleaning up > >> effort be &

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-05 Thread Michael Walle
Hi, On Thu Apr 4, 2024 at 11:10 AM CEST, Neha Malcom Francis wrote: > But again in the interest of time... this would mean this cleaning up effort > be > kept on hold. If we can agree to move to using the generator later as the > final > solution, can we pick up this series for now? Agreed.

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-03 Thread Michael Walle
Hi, > > > > > And on top of that, it will just be a base board and there will > > > > > likely be some carrier device trees (overlay? I'm not sure yet). > > > > > > > > > > As far as I can tell, you've put the memory configuration into the > > > > > device tree, so I'll probably need to switch

[PATCH] net: ti: am65-cpsw: Fix buffer overflow

2024-04-03 Thread Michael Walle
size. Fixes: 38922b1f4acc ("net: ti: am65-cpsw: Add support for multi port independent MAC mode") Signed-off-by: Michael Walle --- drivers/net/ti/am65-cpsw-nuss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti

Re: [PATCH] net: phy: broadcom: Configure LEDs on BCM54210E

2024-04-02 Thread Michael Walle
On Thu Mar 28, 2024 at 4:09 PM CET, Tom Rini wrote: > On Mon, Jan 01, 2024 at 10:07:47PM +0100, Marek Vasut wrote: > > > Configure LEDs on BCM54210E so they would blink on activity > > and indicate link speed. Without this the LEDs are always on > > if cable is plugged in. > > > > Signed-off-by:

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-28 Thread Michael Walle
Hi, On Thu Mar 28, 2024 at 12:18 PM CET, Neha Malcom Francis wrote: > On 27-Mar-24 8:03 PM, Michael Walle wrote: > > On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: > >> On 26/03/24 19:18, Michael Walle wrote: > >>> On Fri Mar 22, 2024 at 2:10 PM

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Michael Walle
such > file or directory ... Are you sure you want to have all this text in the commit log? You seem to have forgotten my tag: Tested-by: Michael Walle # on lschv2

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-27 Thread Michael Walle
Hi, On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: > On 26/03/24 19:18, Michael Walle wrote: > > On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: > >> Clean up templatized boot binaries for all K3 boards. This includes > >> modifyin

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-26 Thread Michael Walle
Hi, On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: > Clean up templatized boot binaries for all K3 boards. This includes > modifying the k3-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and > UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse > code. > >

[PATCH] tools: binman: ti_board_cfg: improve error message

2024-03-26 Thread Michael Walle
. Signed-off-by: Michael Walle --- tools/binman/etype/ti_board_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/etype/ti_board_config.py b/tools/binman/etype/ti_board_config.py index 2c3bb8f7b56..c10d66edcb1 100644 --- a/tools/binman/etype

Re: [PATCH] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-22 Thread Michael Walle
rom arch/arm/dts/ directory. Thanks for taking care. > Signed-off-by: Tony Dinh Tested-by: Michael Walle # on lschlv2 lsxl should work too as it is just different in memory and cpu frequency settings. > --- > > arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi | 6 -- > ar

[PATCH] board: sl28: move to OF_UPSTREAM

2024-03-06 Thread Michael Walle
as this only differ in the compatible and the (human readable) model name. Signed-off-by: Michael Walle --- I'll send a patch to linux to add the var3.dts, then I'll add the correct var3 dts again. --- .../arm/dts/fsl-ls1028a-kontron-sl28-var1.dts | 59 .../arm/dts/fsl-ls1028a-kontron-sl28-var2

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-06 Thread Michael Walle
Hi, On Wed Mar 6, 2024 at 3:56 AM CET, Marek Vasut wrote: > > I'd argue if one wants to use the locking at all, you have to set > > UNLOCK_ALL=n. Otherwise, the bootloader might come alone and just > > clear your locking bits again. Clearing the WPS bit there is just > > one more thing which IMHO

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 7:54 PM CET, Marek Vasut wrote: > On 3/5/24 5:55 PM, Michael Walle wrote: > > [...] > > >>>>>> Clearing this SR3 WPS bit fixes that problem, both in U-Boot and in > >>>>>> Linux, since Linux that is booted afterwa

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 5:28 PM CET, Marek Vasut wrote: > On 3/5/24 4:53 PM, Michael Walle wrote: > > On Tue Mar 5, 2024 at 4:37 PM CET, Marek Vasut wrote: > >> On 3/5/24 1:50 PM, Michael Walle wrote: > >>> On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > >

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 4:37 PM CET, Marek Vasut wrote: > On 3/5/24 1:50 PM, Michael Walle wrote: > > Hi Marek, > > Hi, > > > On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > >> On 3/5/24 9:55 AM, Michael Walle wrote: > >>> On Mon Mar 4, 2024 a

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
Hi Marek, On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > On 3/5/24 9:55 AM, Michael Walle wrote: > > On Mon Mar 4, 2024 at 5:16 PM CET, Marek Vasut wrote: > >> Some Winbond SPI NORs have special SR3 register which is > >> used among other things to c

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
[+ linux-mtd ] Hi Marek, On Mon Mar 4, 2024 at 5:16 PM CET, Marek Vasut wrote: > Some Winbond SPI NORs have special SR3 register which is > used among other things to control whether non-standard > "Individual Block/Sector Write Protection" (WPS bit) > locking scheme is activated. This

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Michael Walle
Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if the user

Re: [PATCH v2] boot: add support for button commands

2024-01-17 Thread Michael Walle
Hi, Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if

Re: [PATCH v2] boot: add support for button commands

2024-01-11 Thread Michael Walle
>> This is simply awesome, but I see one possible issue -- the need to have >> proper environment variables defined for a particular board or device, >> to make the buttons work as expected.  Obviously, those environment >> variables can be absent or can become missing for numerous reasons. > >

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-19 Thread Michael Walle
Hi Mark, > Any runtime device drivers for variable storage should not be in the > U-Boot runtime but live in the secure world (e.g. OP-TEE) FF-A is the > new ARM protocol for talking to the secure world and hence fits into > the picture. What if I just want a simple embedded boot stack where I

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-19 Thread Michael Walle
Hi Heinrich, > Any runtime device drivers for variable storage should not be in the > U-Boot runtime but live in the secure world (e.g. OP-TEE) FF-A is the > new ARM protocol for talking to the secure world and hence fits into > the picture. What if I just want a simple embedded boot stack where

Re: [PATCH v1] cmd: mtd: OTP access support

2023-12-01 Thread Michael Walle
Hi, +static int do_mtd_otp_write(struct cmd_tbl *cmdtp, int flag, int argc, +    char *const argv[]) +{ .. +    printf("Caution! OTP data bits can't be erased! Continue (y/n)?\n"); Please note, that with current SPI-NOR flashes this is not true and there is usually some kind

Re: [PATCH v1] cmd: mtd: OTP access support

2023-11-30 Thread Michael Walle
+static int do_mtd_otp_write(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ .. + printf("Caution! OTP data bits can't be erased! Continue (y/n)?\n"); Please note, that with current SPI-NOR flashes this is not true and there is usually some

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-06 Thread Michael Walle
Hi, I'm still not sure why that compatible is needed. Also I'd need to change the label which might break user space apps looking for that specific name. Also, our board might have u-boot/spl or u-boot/spl/bl31/bl32, right now that's something which depends on an u-boot configuration

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-05 Thread Michael Walle
Hi, >> >> Add a compatible string for binman, so we can extend fixed-partitions >> >> in various ways. >> > >> > I've been thinking at the proper way to describe the binman partitions. >> > I am wondering if we should really extend the fixed-partitions >> > schema. This description is really

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Michael Walle
Hi, >> Add a compatible string for binman, so we can extend fixed-partitions >> in various ways. > > I've been thinking at the proper way to describe the binman partitions. > I am wondering if we should really extend the fixed-partitions > schema. This description is really basic and kind of

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Michael Walle
Hi, >> Add a compatible string for binman, so we can extend fixed-partitions >> in various ways. > > I've been thinking at the proper way to describe the binman partitions. > I am wondering if we should really extend the fixed-partitions > schema. This description is really basic and kind of

Re: [PATCH] MAINTAINERS: remove Vikas Manocha

2023-08-24 Thread Michael Walle
Hi, The mails are bouncing with 550 5.1.1 User Unknown (in reply to RCPT TO command) Remove the entry and mark the ARM STM STV0991 arch as Orphan. Signed-off-by: Michael Walle Cc: Patrick Delaunay Cc: Patrice Chotard --- CCing other ST people, maybe someone want to take over instead

Re: [PATCH 0/6] Attempt to enforce standard extensions for build output

2023-08-24 Thread Michael Walle
Hi, > This series adjusts binman to enforce just 4 extensions for output > images: > >.bin >.rom >.itb >.img > > Other extensions will produce an error. With this rule observed, > buildman > can keep the required files. How does this work? I didn't get all the patches from this

[PATCH] MAINTAINERS: remove Vikas Manocha

2023-08-24 Thread Michael Walle
The mails are bouncing with 550 5.1.1 User Unknown (in reply to RCPT TO command) Remove the entry and mark the ARM STM STV0991 arch as Orphan. Signed-off-by: Michael Walle Cc: Patrick Delaunay Cc: Patrice Chotard --- CCing other ST people, maybe someone want to take over instead

Re: [PATCH 5/6] kontron_sl28: Use u-boot-update.bin instead of u-boot.update

2023-08-24 Thread Michael Walle
Am 2023-08-24 05:02, schrieb Simon Glass: A '.update' extension is not allowed anymore, so change it. Signed-off-by: Simon Glass Looks good to me, as it is just an intermediate binary. Acked-by: Michael Walle

Re: [PATCH 0/6] Attempt to enforce standard extensions for build output

2023-08-24 Thread Michael Walle
Hi, This series adjusts binman to enforce just 4 extensions for output images: .bin .rom .itb .img Other extensions will produce an error. With this rule observed, buildman can keep the required files. How does this work? I didn't get all the patches from this series, which

Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board

2023-08-07 Thread Michael Walle
Hi, > + printf("Disabling WDT\n"); > + writel(0, 0x10007000); Please don't use magic numbers. Also, I guess this should be a real watchdog driver and u-boot will take care of disabling it if the user wants to. > + > + printf("Enabling SCP SRAM\n"); > + for (unsigned int val =

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
If the use of MTD is restricted to passive serial, this is OK with me. Yeah, but that is not how upstream things work. You need to also think of any other use cases. These are the things I want to achieve. * transfer data using the SPI driver and not use board files. For that, the FPGA

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
Sorry, I didn't follow this too closely. Do you have some pointers? I just saw your latest mail. Thanks. -michael

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
Am 2023-02-21 11:42, schrieb Ulf Samuelsson: Den 2023-02-21 kl. 10:08, skrev Michael Walle: If it is right or wrong to use that as an MTD is a matter of opinion. I am still hoping the MTD maintainer would provide input here. I might be missing something, but what is the reasoning here, to add

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
>> If it is right or wrong to use that as an MTD is a matter of opinion. > > I am still hoping the MTD maintainer would provide input here. I might be missing something, but what is the reasoning here, to add this to the mtd subsystem? One is saving space, but I agree with Marek, this isn't a

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board

2023-02-13 Thread Michael Walle
Am 2023-02-13 09:43, schrieb Stefan Roese: On 2/10/23 22:08, Tony Dinh wrote: When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is required for this board to boot over UART with kwboot. Enable this in kirkwood-pogoplug-series-4-u-boot.dtsi. Signed-off-by: Tony Dinh

Re: [PATCH v1] RFC: rtc: rv8803: avoid bootloop on low voltage of button cell

2023-02-08 Thread Michael Walle
Am 2023-02-08 12:29, schrieb Oliver Graute: Am 08.02.2023 um 09:32 schrieb Michael Walle : Am 2023-02-08 08:38, schrieb Oliver Graute: if the rtc button cell is on low voltage this can result in a permanent bootloop in u-boot because V2F Register is permanent set. ### Warning: temperature

Re: [PATCH v1] RFC: rtc: rv8803: avoid bootloop on low voltage of button cell

2023-02-08 Thread Michael Walle
Am 2023-02-08 08:38, schrieb Oliver Graute: if the rtc button cell is on low voltage this can result in a permanent bootloop in u-boot because V2F Register is permanent set. ### Warning: temperature compensation has stopped ### Warning: Voltage low, data is invalid resetting ... With this

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
Basically I want the following: (1) board boots with watchdog enabled (2) u-boot services watchdog (3a) booting embedded linux with booti (watchdog enabled) or (3b) booting generic OS with bootefi (watchdog disabled) The missing case is booting an embedded linux with bootefi, which would be

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
Honestly, not really? Some good number of SoCs will start the watchdog in ROM and these are also the ones that don't allow you to turn it off. I hope not, that sounds really risky. How would you debug such a platform? _Every single_ custom piece of industrial (as opposed to consumer-grade)

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
>>> Honestly, not really? Some good number of SoCs will start the watchdog >>> in ROM and these are also the ones that don't allow you to turn it off. >> >> I hope not, that sounds really risky. How would you debug such a platform? > > _Every single_ custom piece of industrial (as opposed to

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-01 Thread Michael Walle
> When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is > required to boot over UART with kwboot. Enable this in a Kirkwood > common u-boot dtsi. My (dev) board unfortunately, have a bootloader which can't boot over serial. This is feature of Marvell BootROM and does not require

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-01-31 Thread Michael Walle
Hi Tony, Am 2023-02-01 02:11, schrieb Tony Dinh: When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is required to boot over UART with kwboot. Enable this in a Kirkwood common u-boot dtsi. My (dev) board unfortunately, have a bootloader which can't boot over serial. Could you

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 14:08, schrieb Marek Vasut: On 1/18/23 13:43, Michael Walle wrote: Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev) } /* - * If set_state callback is set, we assume this pinctrl driver is the - * full implementation

[PATCH 3/3] pinctrl: fix docstring

2023-01-18 Thread Michael Walle
Fix the copy and paste error. Signed-off-by: Michael Walle --- drivers/pinctrl/pinctrl-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index e6cd0889b0..23a1504716 100644 --- a/drivers/pinctrl

[PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Don't define an empty version for pinconfig_post_bind(). Just guard the call and let the linker garbage collection do the rest. This way, we also don't have to do any guesswork. Signed-off-by: Michael Walle --- drivers/pinctrl/pinctrl-uclass.c | 17 + 1 file changed, 5

[PATCH 1/3] pinctrl: don't fall back to pinctrl_select_state_simple()

2023-01-18 Thread Michael Walle
was ignored before) to -ENOSYS. Signed-off-by: Michael Walle --- The real underlying problem is that the pinctrl_select_state_simple() doesn't really work before relocation. This implementation calls uclass_get_device() which will try to probe the pinctrl, but that device might not be ready yet

Re: [PATCH 6/6] nvmem: u-boot-env: post process "ethaddr" env variable

2023-01-10 Thread Michael Walle
Hi, Am 2023-01-10 11:54, schrieb Rafał Miłecki: From: Rafał Miłecki U-Boot environment variables are stored in ASCII format so "ethaddr" requires parsing into binary to make it work with Ethernet interfaces. This includes support for indexes to support #nvmem-cell-cells = <1>.

Re: [PATCH 2/3] nvmem: core: allow .read_post_process() callbacks to adjust data length

2023-01-05 Thread Michael Walle
Hi, Am 2023-01-05 18:10, schrieb Rafał Miłecki: From: Rafał Miłecki Sometimes reading NVMEM cell value involves some data reformatting. It requires passing updated size value to the caller. Support that. Wouldn't it make more sense to convert that driver to proper nvmem layouts, where (1)

Re: Rockchip RK3328 4-byte addressing problem in SPI

2023-01-03 Thread Michael Walle
So leaving 4-byte switched by UBoot SPI chip made it unusable to RockChip Bootrom. I found this by dumping Bootrom and decompiling it. >> >> Sync with engineer working on these area, and get below: >> >> Yes, this "4-byte addressing problem in SPI" issue is in SoCs including >> rk3328,

[PATCH 2/2] cmd: net: wget: fix Kconfig dependency

2022-12-28 Thread Michael Walle
The wget command uses TCP, but fails to select PROT_TCP in Kconfig. Instead it selects the non-existing symbol TCP. Fix the typo. Signed-off-by: Michael Walle --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index d93731f2af

[PATCH 1/2] net: wget: fix implicit declaration

2022-12-28 Thread Michael Walle
The compiler complains about the missing declaration of print_size(): net/wget.c:415:3: warning: implicit declaration of function ‘print_size’ [-Wimplicit-function-declaration] Fix it. Signed-off-by: Michael Walle --- net/wget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wget.c b

Re: Converting to DM SERIAL for Kirkwood boards

2022-12-12 Thread Michael Walle
>> On 12/9/22 04:55, Tony Dinh wrote: >> > Hi Simon et al, >> > >> > (Resend to include u-boot mailing list) >> > >> > I'm in the process of converting Kirkwood boards to use DM SERIAL. I >> > could not seem to get it to work, having tried adding >> > CONFIG_DM_SERIAL, and also playing with

Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices

2022-12-08 Thread Michael Walle
Hi, >> I'm not really happy with this approach. It's not that upstream doesn't >> have aliases now, it's that it has different aliases, right? That's why >> they won't accept these? > > imx6q.dtsi does have the default mmc aliases: > > mmc0 = > mmc1 = > mmc2 = > mmc3 = > > Upstream does

Re: [PATCH V2 1/2] nvmem: core: refactor .cell_post_process() CB arguments

2022-11-27 Thread Michael Walle
Am 2022-11-28 07:59, schrieb Rafał Miłecki: From: Rafał Miłecki Pass whole NVMEM cell struct and length pointer as arguments to callback functions. This allows: 1. Cells content to be modified based on more info Some cells (identified by their names) contain specific data that needs

Re: Setting MAC address from I2C EEPROM - debug / commands? (Xilinx)

2022-11-23 Thread Michael Walle
>> ethernet { >> nvmem-cells = <_address>; >> nvmem-cell-names = "mac-address"; >> }; >> >> You'll need 2022.07 for this I think. This is the same method which >> Linux uses. I added this specificly to be able to load MAC addresses >> from EEPROMs without needing to hard code stuff into

Re: [PATCH v2 3/8] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-09-04 Thread Michael Walle
Am 2022-09-04 02:02, schrieb Tony Dinh: Hi Stefan, Sorry, that message was prematurely sent (fat finger). Please see the continuation below. On Sat, Sep 3, 2022 at 4:43 PM Tony Dinh wrote: Hi Stefan, On Sat, Sep 3, 2022 at 3:44 AM Stefan Roese wrote: > > Hi Tony, > > On 03.09.22 11:44,

Re: [PATCH v2 1/8] timer: orion-timer: Use timer_conv_64() to fix timer wrap around

2022-09-02 Thread Michael Walle
Am 2022-09-02 08:25, schrieb Stefan Roese: While testing on some Kirkwood platforms it was noticed that the timer did not function correctly all the time. The driver did not correctly handle 32bit timer value wrap arounds. Using the timer_conv_64() conversion function fixes this issue. Fixes:

Re: [PATCH] arm: orion5: Completely remove Orion5 platform support

2022-09-01 Thread Michael Walle
Am 2022-09-01 10:53, schrieb Stefan Roese: As there is no Orion5 based target in mainline U-Boot any more, let's completely remove the support for this pretty old Marvell platform. Signed-off-by: Stefan Roese Cc: Tony Dinh Cc: Pali Rohár Cc: Michael Walle --- a/drivers/net/Kconfig +++ b

Re: [PATCH 3/6] arm: mvebu: Use CONFIG_TIMER on all MVEBU & KIRKWOOD platforms

2022-08-30 Thread Michael Walle
Am 2022-08-30 13:53, schrieb Stefan Roese: Now that the new timer support is available for these platforms, let's select this IF for all these platforms. This way it's not necessary that each board changes it's config header. Signed-off-by: Stefan Roese --- arch/arm/Kconfig

Re: [PATCH 2/6] timer: orion-timer: Add timer_get_boot_us() for BOOTSTAGE support

2022-08-30 Thread Michael Walle
Am 2022-08-30 13:53, schrieb Stefan Roese: Add timer_get_boot_us() to support boards, that have CONFIG_BOOTSTAGE enabled, like pogo_v4. Signed-off-by: Stefan Roese --- drivers/timer/orion-timer.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: mvebu - switch to orion-timer

2022-08-24 Thread Michael Walle
Hi, >On 24.08.22 00:33, Pali Rohár wrote: >> Hello Stefan! Now when U-Boot contains new orion-timer.c driver, which >> Michael wrote, I think that it mvebu platform should switch to use it. >> Because build process for armada boards prints deprecation warning that >> new timer is not being used.

Re: [PATCH 00/22] board: lsxl: major update and DM conversion

2022-08-23 Thread Michael Walle
Am 2022-08-23 17:01, schrieb Stefan Roese: Applied to u-boot-marvell/master, with my small fix for the ds109 board Great! Thanks, Stefan. -michael

[PATCH v3 3/5] board: sl28: add user friendly names for the boot sources

2022-08-23 Thread Michael Walle
During startup the SPL will print where the u-boot proper is read from. Instead of using the default names, provide more user friendly names. Signed-off-by: Michael Walle --- board/kontron/sl28/spl.c | 16 1 file changed, 16 insertions(+) diff --git a/board/kontron/sl28/spl.c

[PATCH v3 5/5] board: sl28: remove COUNTER_FREQUENCY_REAL

2022-08-23 Thread Michael Walle
The frequency of the system counter is static which is given by the COUNTER_FREQUENCY option. Remove COUNTER_FREQUENCY_REAL. Signed-off-by: Michael Walle --- include/configs/kontron_sl28.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/kontron_sl28.h b/include/configs

[PATCH v3 4/5] board: sl28: support dynamic prompts

2022-08-23 Thread Michael Walle
Depending on the boot source, set different CLI prompts. This will help the user to figure out in which mode the bootloader was started. There are two special modes: failsafe and SDHC boot. Signed-off-by: Michael Walle --- board/kontron/sl28/sl28.c | 20 configs

[PATCH v3 2/5] board: sl28: implement additional bootsources

2022-08-23 Thread Michael Walle
The board is able to boot from the following source: - user-updateble SPI flash - write-protected part of the same SPI flash - eMMC - SD card Implement the needed function hooks to support all of these boot sources. Signed-off-by: Michael Walle --- board/kontron/sl28/common.c| 22

[PATCH v3 1/5] armv8: layerscape: spl: mark OCRAM as non-secure

2022-08-23 Thread Michael Walle
By default the OCRAM is marked as secure. While the SPL runs in EL3 and thus can access it, DMA devices cannot. Mark the whole OCRAM as non-secure. This will fix MMC and SD card boot on LS1028A when using SPL instead of TF-A. Signed-off-by: Michael Walle --- arch/arm/cpu/armv8/fsl-layerscape

[PATCH v3 0/5] board: sl28: various updates

2022-08-23 Thread Michael Walle
- dynamic prompts - various cleanups changes since v2: - only mark secure ram on layerscape SoCs which actually have it. changes since v1: - rebased onto the latest master Michael Walle (5): armv8: layerscape: spl: mark OCRAM as non-secure board: sl28: implement additional bootsources board

Re: [GIT PULL] please pull fsl-qoriq-2022-8-17

2022-08-19 Thread Michael Walle
>On 8/18/2022 6:40 AM, Tom Rini wrote: >> On Wed, Aug 17, 2022 at 02:26:32AM +, Peng Fan (OSS) wrote: >> >>> Hi Tom, >>> >>> Please pull fsl-qoriq-2022-8-17 >>> >>> CI: >>> https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq/-/pipelines/13155 >> >> First, applied to u-boot/master,

[PATCH 14/22] board: lsxl: use proper *_r variables

2022-08-17 Thread Michael Walle
Use the common kernel_addr_r, ramdisk_addr_r and fdt_addr_r variable names. Signed-off-by: Michael Walle --- include/configs/lsxl.h | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h

[PATCH 18/22] board: lsxl: convert to DM_ETH

2022-08-17 Thread Michael Walle
Just enabling the Kconfig option for DM_ETH and DM_MDIO is enough. Additionally, we can remove the old hardcoded config. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 2 ++ configs/lsxhl_defconfig | 2 ++ include/configs/lsxl.h| 8 3 files changed, 4 insertions

[PATCH 17/22] board: lsxl: convert to DM_GPIO

2022-08-17 Thread Michael Walle
makes debugging a bit harder. Also, there is no GPIO fan driver for now. Signed-off-by: Michael Walle --- arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi | 9 ++ arch/arm/dts/kirkwood-lsxhl-u-boot.dtsi | 9 ++ board/buffalo/lsxl/lsxl.c | 140 +- configs

[PATCH 16/22] board: lsxl: make last resort recovery more reliable

2022-08-17 Thread Michael Walle
the environment. Instead the network console is only enabled when the push button is pressed during boot. Signed-off-by: Michael Walle --- arch/arm/mach-kirkwood/Kconfig | 1 + board/buffalo/lsxl/lsxl.c | 14 -- configs/lschlv2_defconfig | 1 - configs/lsxhl_defconfig| 1

[PATCH 15/22] board: lsxl: enable ATAGS support

2022-08-17 Thread Michael Walle
We still need to be able to boot legacy images. Esp. the debian installer will have a kernel with an appended DTB. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 3 +++ configs/lsxhl_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/lschlv2_defconfig b

[PATCH 22/22] board: lsxl: update the README

2022-08-17 Thread Michael Walle
Update the board's README to reflect all the recent changes. Signed-off-by: Michael Walle --- board/buffalo/lsxl/README | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/board/buffalo/lsxl/README b/board/buffalo/lsxl/README index fffb1ce8ec

[PATCH 21/22] board: lsxl: disable eth0

2022-08-17 Thread Michael Walle
-boot.dtsi. Signed-off-by: Michael Walle --- arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi | 4 arch/arm/dts/kirkwood-lsxhl-u-boot.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi b/arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi index 208b02c9da

[PATCH 20/22] board: lsxl: convert to CONFIG_TIMER

2022-08-17 Thread Michael Walle
Enable the orion timer driver and we are good. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 2 ++ configs/lsxhl_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig index 57e54130d2..e9cc632696 100644

[PATCH 19/22] board: lsxl: convert to DM_SERIAL

2022-08-17 Thread Michael Walle
early malloc size. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 4 ++-- configs/lsxhl_defconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig index 4e356fb150..57e54130d2 100644 --- a/configs

[PATCH 13/22] board: lsxl: reorder image loading and remove ramdisk_len

2022-08-17 Thread Michael Walle
We can load the ramdisk as the last step. This way we don't have to set the intermediate variable 'ramdisk_len' and can remove it. Signed-off-by: Michael Walle --- include/configs/lsxl.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/include/configs/lsxl.h b

[PATCH 12/22] board: lsxl: use CONFIG_DEFAULT_FDT_FILE

2022-08-17 Thread Michael Walle
Drop our own CONFIG_FDTFILE handling in favor of the generic CONFIG_DEFAULT_FDT_FILE one. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 1 + configs/lsxhl_defconfig | 1 + include/configs/lsxl.h| 14 +++--- 3 files changed, 5 insertions(+), 11 deletions(-) diff

[PATCH 11/22] board: lsxl: automatically select CONFIG_MISC_INIT_R

2022-08-17 Thread Michael Walle
The board code needs this to be set. Otherwise, the recovery mechanism doesn't work. Therefore, select this option automatically with the board. Signed-off-by: Michael Walle --- arch/arm/mach-kirkwood/Kconfig | 1 + board/buffalo/lsxl/lsxl.c | 2 -- configs/lschlv2_defconfig | 1

[PATCH 10/22] board: lsxl: remove unused header files

2022-08-17 Thread Michael Walle
Cleanup the included header files in the board code. These are all leftovers from earlier days. Signed-off-by: Michael Walle --- board/buffalo/lsxl/lsxl.c | 5 - 1 file changed, 5 deletions(-) diff --git a/board/buffalo/lsxl/lsxl.c b/board/buffalo/lsxl/lsxl.c index 106d46d436..42221eef3a

[PATCH 09/22] board: lsxl: remove CONFIG_ENV_OVERWRITE

2022-08-17 Thread Michael Walle
This is not needed. The user can force setting the variables with "setenv -f". Signed-off-by: Michael Walle --- board/buffalo/lsxl/lsxl.c | 4 configs/lschlv2_defconfig | 1 - configs/lsxhl_defconfig | 1 - 3 files changed, 6 deletions(-) diff --git a/board/buffalo/lsxl/lsxl

[PATCH 07/22] board: lsxl: remove unused features

2022-08-17 Thread Michael Walle
Make the binary smaller by removing unused features. Signed-off-by: Michael Walle --- configs/lschlv2_defconfig | 3 +-- configs/lsxhl_defconfig | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/configs/lschlv2_defconfig b/configs/lschlv2_defconfig index cabedeb460

[PATCH 08/22] board: lsxl: remove eraseenv script

2022-08-17 Thread Michael Walle
This is not needed. The user can do a "env default -f -a". Signed-off-by: Michael Walle --- include/configs/lsxl.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h index e1108619f2..db5f7a93f9 100644 --- a/include/configs/lsxl.h +++

  1   2   3   4   5   6   7   8   9   10   >