Re: [PATCH] net: wget: Avoid packet queue overflow

- Ursprüngliche Mail - > Von: "Tom Rini" > An: "richard" > CC: "u-boot" , "Joe Hershberger" > , "Ramon Fried" > Gesendet: Donnerstag, 31. August 2023 18:27:03 > Betreff: Re: [PATCH] net: wget: Avoid packet queue over

Re: [PATCH] net: wget: Avoid packet queue overflow

> Make sure to stay within bounds, as a misbehaving HTTP server > can trigger a buffer overflow if not properly handled. > > Cc: Joe Hershberger > Cc: Ramon Fried > Signed-off-by: Richard Weinberger > --- > net/wget.c | 10 +- > 1 file changed, 9 insert

[PATCH] net: wget: Avoid packet queue overflow

Make sure to stay within bounds, as a misbehaving HTTP server can trigger a buffer overflow if not properly handled. Cc: Joe Hershberger Cc: Ramon Fried Signed-off-by: Richard Weinberger --- net/wget.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/wget.c b

Re: [PATCH] Fix corner case in bad block table handling.

1] |= val >> rbits; > + pos[1] |= val >> (bits_per_block - rbits); Looks good to me. Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND devices") Reviewed-by: Richard Weinberger -- Thanks, //richard

Re: Issue with 'ubi part' ubi_io_read: error -74 (ECC error)

On Sun, May 17, 2020 at 1:28 PM Jupiter wrote: > > Sorry for a bit recalcitrant with the issue of calling 'ubi part" > error -74 -EBADMSG, is it MTD issue or u-boot issue? > > I used Linux kernel 4.19 to flash UBIFS volume images ubi.img to > imx6ull NAND using following command in Linux: > >

Re: [U-Boot] UBI fixable bit-flip issue

Mark, Am Donnerstag, 12. Juli 2018, 16:03:43 CEST schrieb Mark Spieth: > >Mark, can you please file a patch and send it to linux-mtd mailing > >list? > >Such a change needs to go through Linux and then to u-boot. > >But first we need to think about and discuss it in detail. > > Will do. Did you

Re: [U-Boot] [Bug & Question] ubifs does not understand ".." in file path ?

Marek, Am Freitag, 13. Juli 2018, 10:53:48 CEST schrieb Marek Vasut: > On 07/13/2018 10:15 AM, Richard Weinberger wrote: > > Am Freitag, 13. Juli 2018, 10:00:23 CEST schrieb Marek Vasut: > >> CCing Richard, btw ubifs in U-Boot is completely broken. > > > > BTW: Can

Re: [U-Boot] [Bug & Question] ubifs does not understand ".." in file path ?

Am Freitag, 13. Juli 2018, 10:00:23 CEST schrieb Marek Vasut: > CCing Richard, btw ubifs in U-Boot is completely broken. BTW: Can you please define "completely broken"? Last week it used to work here. ;) Thanks, //richard ___ U-Boot mailing list

Re: [U-Boot] [Bug & Question] ubifs does not understand ".." in file path ?

Am Freitag, 13. Juli 2018, 10:00:23 CEST schrieb Marek Vasut: > On 07/13/2018 09:44 AM, Heiko Schocher wrote: > > Hello Masahiro, > > > > Am 13.07.2018 um 06:44 schrieb Masahiro Yamada: > >> Hi. > >> > >> > >> I was playing around with the ditro-boot on NAND + UBI. > >> > >> I was hit by a

Re: [U-Boot] UBI fixable bit-flip issue

Mark, Am Donnerstag, 12. Juli 2018, 07:22:13 CEST schrieb Heiko Schocher: > Hello Mark, > > added Richard Weinberger to cc... > > Am 12.07.2018 um 02:28 schrieb Mark Spieth: > > Hi > > > > In the process of investigating a boot failure on one of our devices, t

Re: [U-Boot] [PATCH] ubifs: avoid memory corruption during ubifsmount

Patrice, Am Dienstag, 26. Juni 2018, 15:01:14 CEST schrieb Patrice CHOTARD: > Following your remark, Christophe and i relaunched our test setup to go > deeper in the analysis of the issue we saw. Unfortunately we can't > reproduced it. We have now some doubt. Ok. > > > >> By checking ubifs

Re: [U-Boot] [PATCH] ubifs: avoid memory corruption during ubifsmount

Patrice, Am Montag, 25. Juni 2018, 13:54:12 CEST schrieb Patrice Chotard: > Sometimes, at boot time, following issue appears: > Error reading superblock on volume 'ubi0:boot' errno=-22! > > This error is coming from wrong ubi_num and wrong ubi_id in the superblock. > (ubi_num = -1 and vol_id =

Re: [U-Boot] [RFC PATCH 00/20] SPI-NAND support

Am Montag, 25. Juni 2018, 16:27:45 CEST schrieb Jagan Teki: > I understand the new MTD dm abstraction in U-Boot is not possible for > direct syncing from Linux, but we really want the u-boot way of > handling drivers and trying to copy code from Linux by removing > __UBOOT__ or any Linux specific

Re: [U-Boot] [RFC PATCH 00/20] SPI-NAND support

Am Montag, 25. Juni 2018, 11:09:41 CEST schrieb Boris Brezillon: > +Richard to comment on the MTD abstraction stuff and how uboot port > of UBI might be impacted by some changes requested here. > > Hi Jagan, > > On Mon, 25 Jun 2018 13:59:37 +0530 > Jagan Teki wrote: > > > > > I've looked the

Re: [U-Boot] [PATCH v1] ubifs: avoid assert failed in ubifs.c

Am Dienstag, 22. Mai 2018, 12:56:48 CEST schrieb Marek Vasut: > On 05/10/2018 10:57 PM, Marek Vasut wrote: > > On 04/27/2018 03:51 PM, Patrice Chotard wrote: > >> This patch solves assert failed displayed in the console during a boot. > >> The root cause is that the ubifs_inode is not already

Re: [U-Boot] UBI: regression since "mtd: ubi: Fix worker handling"

Am Dienstag, 22. Mai 2018, 08:30:45 CEST schrieb Heiko Schocher: > Hello Richard, > > Am 21.05.2018 um 21:31 schrieb Richard Weinberger: > > Patrice, > > > > Am Montag, 21. Mai 2018, 16:07:41 CEST schrieb Richard Weinberger: > >>> e->p

Re: [U-Boot] UBIFS Problems with U-boot 2018.1 & 4.14 Linux

Otto, Am Dienstag, 22. Mai 2018, 03:30:04 CEST schrieb Otto Blom: > Hi Richard ! > > To summarize the observations from the last few days. > > * Linux 4.9 & U-boot 2018 behave the same when attempting to read from > a ubifs file system > * Whenever Linux 4.14 writes to a ubifs there is some

Re: [U-Boot] UBI: regression since "mtd: ubi: Fix worker handling"

Patrice, Am Montag, 21. Mai 2018, 16:07:41 CEST schrieb Richard Weinberger: > > e->pnum = aeb->pnum; > > e->ec = aeb->ec; > > ubi->lookuptbl[e->pnum] = e; > > + ubi->thread_enabled = 1; > >

Re: [U-Boot] UBI: regression since "mtd: ubi: Fix worker handling"

Patrice, Am Montag, 21. Mai 2018, 15:38:57 CEST schrieb Patrice CHOTARD: > Hi Richard, Heiko > > Since f82290afc847 ("mtd: ubi: Fix worker handling"), > when booting from NAND, on a fresh NAND just after being flashed (and > only in this case), we got the following log: > > ubi0: default

Re: [U-Boot] UBIFS Problems with U-boot 2018.1 & 4.14 Linux

Am Samstag, 19. Mai 2018, 01:56:33 CEST schrieb Otto Blom: > UBIFS error (ubi0:0 pid 0): crypto_comp_decompress: cannot decompress > 2801 bytes, compressor lzo, error -6 LZO_E_LOOKBEHIND_OVERRUN... > UBIFS error (ubi0:0 pid 0): ubifs_decompress: cannot decompress 2801 > bytes, compressor lzo,

Re: [U-Boot] UBIFS Problems with U-boot 2018.1 & 4.14 Linux

Otto, Am Freitag, 18. Mai 2018, 23:02:17 CEST schrieb Otto Blom: > Hallo Heiko & Richard ! > > Turns out the len and out_len do not match, much like you suspected. > Out_len is 2 bytes short (4094 vs 4096) See log below > > UBIFS DBG tnc: search key (5725, data, 124) > UBIFS DBG tnc: found 1,

Re: [U-Boot] UBIFS Problems with U-boot 2018.1 & 4.14 Linux

Otto, Heiko, Am Freitag, 18. Mai 2018, 10:44:43 CEST schrieb Heiko Schocher: > Hello Otto, > > Am 17.05.2018 um 23:12 schrieb Otto Blom: > > Hi There ! > > > > I'm seeing a strange problem with u-boot 2018.1 and Linux 4.14 (Xilinx > > Petalinux 2018.1). > > If I write a ubifs image to flash

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

ing a kernel without Fastmap support. B-) > > For Linux I suggest this fix: > > > > From 48287459cf8717cffac5aed423937cd7ba4360ab Mon Sep 17 00:00:00 2001 > > From: Richard Weinberger <rich...@nod.at> > > Date: Tue, 16 Jan 2018 14:12:46 +0100 > > Subject: [

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

upon detach. Martin, can you please explain what corruption you see? From reading the code I'd assume that you miss volumes but a full scan would recover everything. For Linux I suggest this fix: From 48287459cf8717cffac5aed423937cd7ba4360ab Mon Sep 17 00:00:00 2001 From: Richard Weinberger <

Re: [U-Boot] Older u-boot mangles UBI from ubinize 1.5.2

Hi! On Thu, Aug 11, 2016 at 4:26 AM, J Mo wrote: > I tried re-flashing my UBI and tftpbooting my kernel before u-boot could > ever get a chance to mangle it, and now I get much further, though I'm still > not able to mount my rootfs for unknown reasons: > > [3.772502]

Re: [U-Boot] [LEDE-DEV] Older u-boot mangles UBI from ubinize 1.5.2

Am 11.08.2016 um 13:49 schrieb Daniel Golle: > Hi! > > On Thu, Aug 11, 2016 at 04:28:47AM -0700, J Mo wrote: >> >> I got that good old feeling... like I just jumped onto a bag of flaming poo. >> Ha ha >> >> >> >> On 08/11/2016 03:40 AM, Daniel Golle wrote: >>> >>> Understandable. However, we also

Re: [U-Boot] Porting Linux's MTD/NAND changes into U-Boot

Am 26.04.2016 um 07:17 schrieb Heiko Schocher: > Also, as the UBI/UIFS case may show, it is not always a trivial job > to do such a sync, as concepts in Linux changes ... While we are at it, how do you QA? Did you ever port port UBI or MTD tests to u-boot and let them run? Maybe there are more

Re: [U-Boot] [PATCH] mtd, ubi: set free_count to zero before walking through erase list

Am 25.04.2016 um 07:46 schrieb Heiko Schocher: > Hello Boris, > > Am 22.04.2016 um 14:21 schrieb Boris Brezillon: >> On Fri, 22 Apr 2016 13:53:00 +0200 >> Heiko Schocher wrote: >> >>> An alternative approach would be not executing work directly while scheduling it but in

Re: [U-Boot] [PATCH] mtd, ubi: set free_count to zero before walking through erase list

Heiko, Am 22.04.2016 um 12:20 schrieb Heiko Schocher: >> Think of places where work is scheduled but the caller blocked >> the worker because the work has to be done later. >> Fastmap is one of these use cases but AFAIK it won't matter >> as no CPU scheduler is involved and will interrupt

Re: [U-Boot] [PATCH] mtd, ubi: set free_count to zero before walking through erase list

Am 21.04.2016 um 14:14 schrieb Boris Brezillon: No idea, if the correct fix not would be to move this erase_worker call after the attach phase ended, as Richard suggested, or if this fix is also valid ... >>> >>> I discussed that with Richard, and I think moving the ->free_count >>>

Re: [U-Boot] [PATCH] mtd, ubi: set free_count to zero before walking through erase list

Am 02.02.2016 um 11:54 schrieb Heiko Schocher: > Set free_count to zero before walking through ai->erase list > in wl_init(). > > As U-Boot has no workqueue/threads, it immediately calls > erase_worker(), which increase for each erased block > free_count. Without this patch, free_count gets after

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Am 20.10.2015 um 06:00 schrieb Heiko Schocher: > Hello Richard > > Am 19.10.2015 um 23:48 schrieb Richard Weinberger: >> Am 19.10.2015 um 23:40 schrieb Ezequiel Garcia: >>> On 19 October 2015 at 17:22, Richard Weinberger <rich...@nod.at> wrote: >>>> Am 1

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Am 19.10.2015 um 15:47 schrieb Ezequiel Garcia: > After some further investigation, printing the counters as Richard suggested > I found it was a bug on my side :-( The Linux partition and the U-Boot > partition > had different size (i.e. PEB count) and so Fastmap complained :-( > > We trimmed

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Am 19.10.2015 um 23:40 schrieb Ezequiel Garcia: > On 19 October 2015 at 17:22, Richard Weinberger <rich...@nod.at> wrote: >> Am 19.10.2015 um 15:47 schrieb Ezequiel Garcia: >>> After some further investigation, printing the counters as Richard suggested >>>

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Am 17.10.2015 um 20:07 schrieb Ezequiel Garcia: > However, I'm still seeing the same warning I had before, when my partition > is attached: > > ubi0: default fastmap pool size: 200 > ubi0: default fastmap WL pool size: 100 > ubi0: attaching mtd1 > WARNING in drivers/mtd/ubi/fastmap.c line 846 >

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Hi! Am 08.10.2015 um 14:51 schrieb Heiko Schocher: > Hello Ezequiel, Richard, > > Am 02.10.2015 um 18:27 schrieb Ezequiel Garcia: >> Hello Heiko, >> >> According to Richard Weinberger, UBI fastmap is broken in U-Boot. >> There are plenty >> of fixes in Lin

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Am 08.10.2015 um 16:58 schrieb Hans de Goede: >> Compiling stops, as it is an "error" ... renaming this var, and error >> go away ... > > I believe that in certain configs free is a #define on u-boot, which is > likely causing this problem. Ahhh! As soon you #define something the symbol is

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Hi! Am 03.10.2015 um 06:27 schrieb Heiko Schocher: >>> According to Richard Weinberger, UBI fastmap is broken in U-Boot. >>> There are plenty >>> of fixes in Linux that we should pull in U-Boot to fix it. > > Thanks for pointing! > >> BTW: it is not

Re: [U-Boot] Porting UBI fixes (specially fastmap's) to U-Boot

Hi! Am 02.10.2015 um 18:27 schrieb Ezequiel Garcia: > Hello Heiko, > > According to Richard Weinberger, UBI fastmap is broken in U-Boot. > There are plenty > of fixes in Linux that we should pull in U-Boot to fix it. BTW: it is not broken in terms of you broke it. It is just

Re: [U-Boot] [patch 2/2] spl: Lightweight UBI and UBI fastmap support

Am 05.07.2014 11:48, schrieb Thomas Gleixner: +/** + * ubi_calc_fm_size - calculates the fastmap size in bytes for an UBI device. + * @ubi: UBI device description object + */ +static size_t ubi_calc_fm_size(struct ubi_scan_info *ubi) +{ + size_t size; + + size = sizeof(struct

Re: [U-Boot] BUG: fastmap and u-boot's ubi write command

Hi! Am 25.09.2013 12:59, schrieb Richard Genoud: [CC u-boot ML since it may not be a kernel only related bug(s)] Hi Richard, Artem, I'm still playing with fastmap and I ran into something. It's involving u-boot's ubi write command and fastmap. What I'm doing is: - Flashing a mtd

Re: [U-Boot] BUG: fastmap and u-boot's ubi write command

Am 25.09.2013 14:13, schrieb Richard Genoud: Before we waste time, please ensure that you have all recent UBI fixes applied. UBI: Fix PEB leak in wear_leveling_worker() (Merged into 3.12-rc1, on it's way to -stable) UBI: Fix invalidate_fastmap() (Merged into 3.12-rc1) UBI: Fix

Re: [U-Boot] BUG: fastmap and u-boot's ubi write command

Am 25.09.2013 15:39, schrieb Richard Genoud: 2013/9/25 Richard Weinberger rich...@nod.at: Am 25.09.2013 14:13, schrieb Richard Genoud: Before we waste time, please ensure that you have all recent UBI fixes applied. UBI: Fix PEB leak in wear_leveling_worker() (Merged into 3.12-rc1, on it's