On 9/11/20 8:46 PM, Patrick DELAUNAY wrote:
> Hi Jaehoon
>
>> From: Jaehoon Chung
>> Sent: vendredi 11 septembre 2020 09:50
>>
>> On 9/10/20 6:54 AM, Alexandru Gagniuc wrote:
>>> mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of
>>> struct mmc_config from devicetree.
>>> The same
Hi Jaehoon
> From: Jaehoon Chung
> Sent: vendredi 11 septembre 2020 09:50
>
> On 9/10/20 6:54 AM, Alexandru Gagniuc wrote:
> > mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of
> > struct mmc_config from devicetree.
> > The same logic is duplicated in stm32_sdmmc2_probe(). Use
>
Hi Alex,
> From: Alex G.
> Sent: jeudi 10 septembre 2020 22:10
>
> On 9/10/20 11:04 AM, Patrick DELAUNAY wrote:
> > Hi Alexandru,
>
> Hi
>
> [snip]
>
> >> + cfg->f_max = 5200;
> >> + mmc_of_parse(dev, cfg);
> >
> > Result of mmc_of_parse is not tested ?
> >
> > I proposed:
> >
> > +
On 9/10/20 6:54 AM, Alexandru Gagniuc wrote:
> mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of
> struct mmc_config from devicetree.
> The same logic is duplicated in stm32_sdmmc2_probe(). Use
> mmc_of_parse(), which is more generic.
>
> Signed-off-by: Alexandru Gagniuc
> ---
>
On 9/10/20 11:04 AM, Patrick DELAUNAY wrote:
Hi Alexandru,
Hi
[snip]
+ cfg->f_max = 5200;
+ mmc_of_parse(dev, cfg);
Result of mmc_of_parse is not tested ?
I proposed:
+ ret = mmc_of_parse(dev, cfg);
+ if (ret)
+ return ret;
You're right. I'll
Hi Alexandru,
> Sent: mercredi 9 septembre 2020 23:54
> To: uboot-st...@st-md-mailman.stormreply.com
> Cc: Alexandru Gagniuc ; Patrick DELAUNAY
> ; Patrice CHOTARD ; Peng
> Fan ; u-boot@lists.denx.de
> Subject: [PATCH] mmc: stm32_sdmmc2: Use mmc_of_parse() to read host
> capa
Hi Alexandru
On 9/9/20 11:54 PM, Alexandru Gagniuc wrote:
> mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of
> struct mmc_config from devicetree.
> The same logic is duplicated in stm32_sdmmc2_probe(). Use
> mmc_of_parse(), which is more generic.
>
> Signed-off-by: Alexandru
mmc_of_parse() can populate the 'f_max' and 'host_caps' fields of
struct mmc_config from devicetree.
The same logic is duplicated in stm32_sdmmc2_probe(). Use
mmc_of_parse(), which is more generic.
Signed-off-by: Alexandru Gagniuc
---
drivers/mmc/stm32_sdmmc2.c | 18 ++
1 file
8 matches
Mail list logo