Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-18 Thread Bin Meng
On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt wrote: > > The kendryte PLL code uses nop as barrier. The macro is not defined for > the sandbox on x86 but is defined on RISC-V. > > Signed-off-by: Heinrich Schuchardt > --- > include/kendryte/pll.h | 5 + > 1 file changed, 5

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-15 Thread Sean Anderson
On 8/15/20 3:53 AM, Heinrich Schuchardt wrote: > On 8/5/20 2:19 PM, Heinrich Schuchardt wrote: >> On 05.08.20 13:45, Sean Anderson wrote: >>> On 8/3/20 2:20 PM, Heinrich Schuchardt wrote: On 03.08.20 16:08, Sean Anderson wrote: > Maybe. Because we are configuring the PLL, the CPU clock is

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-15 Thread Heinrich Schuchardt
On 8/5/20 2:19 PM, Heinrich Schuchardt wrote: > On 05.08.20 13:45, Sean Anderson wrote: >> On 8/3/20 2:20 PM, Heinrich Schuchardt wrote: >>> On 03.08.20 16:08, Sean Anderson wrote: Maybe. Because we are configuring the PLL, the CPU clock is temporarily set to the in0 oscillator, so the

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-05 Thread Heinrich Schuchardt
On 05.08.20 13:45, Sean Anderson wrote: > On 8/3/20 2:20 PM, Heinrich Schuchardt wrote: >> On 03.08.20 16:08, Sean Anderson wrote: >>> Maybe. Because we are configuring the PLL, the CPU clock is temporarily >>> set to the in0 oscillator, so the timer would give an incorrect delay. >>> However, it

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-05 Thread Sean Anderson
On 8/3/20 2:20 PM, Heinrich Schuchardt wrote: > On 03.08.20 16:08, Sean Anderson wrote: >> Maybe. Because we are configuring the PLL, the CPU clock is temporarily >> set to the in0 oscillator, so the timer would give an incorrect delay. >> However, it would probably be fine even if incorrect. The

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-03 Thread Heinrich Schuchardt
On 03.08.20 16:08, Sean Anderson wrote: > On 8/3/20 9:59 AM, Heinrich Schuchardt wrote: >> On 03.08.20 12:10, Sean Anderson wrote: >>> On 8/2/20 11:29 PM, Bin Meng wrote: On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt wrote: > > The kendryte PLL code uses nop as barrier.

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-03 Thread Sean Anderson
On 8/3/20 9:59 AM, Heinrich Schuchardt wrote: > On 03.08.20 12:10, Sean Anderson wrote: >> On 8/2/20 11:29 PM, Bin Meng wrote: >>> On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt >>> wrote: The kendryte PLL code uses nop as barrier. The macro is not defined for the sandbox on

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-03 Thread Heinrich Schuchardt
On 03.08.20 12:10, Sean Anderson wrote: > On 8/2/20 11:29 PM, Bin Meng wrote: >> On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt >> wrote: >>> >>> The kendryte PLL code uses nop as barrier. The macro is not defined for >>> the sandbox on x86 but is defined on RISC-V. >> >> Is this kendryte

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-03 Thread Sean Anderson
On 8/2/20 11:29 PM, Bin Meng wrote: > On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt > wrote: >> >> The kendryte PLL code uses nop as barrier. The macro is not defined for >> the sandbox on x86 but is defined on RISC-V. > > Is this kendryte PLL driver built for Sandbox? Yes. I added a

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-08-02 Thread Bin Meng
On Tue, Jul 28, 2020 at 11:52 PM Heinrich Schuchardt wrote: > > The kendryte PLL code uses nop as barrier. The macro is not defined for > the sandbox on x86 but is defined on RISC-V. Is this kendryte PLL driver built for Sandbox? > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-07-28 Thread Sean Anderson
On 7/28/20 11:52 AM, Heinrich Schuchardt wrote: > The kendryte PLL code uses nop as barrier. The macro is not defined for > the sandbox on x86 but is defined on RISC-V. > > Signed-off-by: Heinrich Schuchardt > --- > include/kendryte/pll.h | 5 + > 1 file changed, 5 insertions(+) > > diff

[PATCH 1/1] clk: kendryte/pll.h: do not redefine nop()

2020-07-28 Thread Heinrich Schuchardt
The kendryte PLL code uses nop as barrier. The macro is not defined for the sandbox on x86 but is defined on RISC-V. Signed-off-by: Heinrich Schuchardt --- include/kendryte/pll.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/kendryte/pll.h b/include/kendryte/pll.h index