Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-16 Thread Francesco Dolcini
On Tue, Jan 16, 2024 at 02:01:02AM +0100, Marek Vasut wrote: > On 1/15/24 16:44, Francesco Dolcini wrote: > > On Sat, Jan 13, 2024 at 07:33:17PM +0100, Marek Vasut wrote: > > 0059, V1.1A and V1.1B, use a 20MHz oscillator > > 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20Mhz oscillator > > Do you

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-15 Thread Marek Vasut
On 1/15/24 16:44, Francesco Dolcini wrote: On Sat, Jan 13, 2024 at 07:33:17PM +0100, Marek Vasut wrote: The older i.MX8M Mini Verdin SoMs before rev. 1.1C came with 20 MHz SPI CAN controller oscillator, the newer SoMs use 40 MHz oscillator. Handle both by overriding the oscillator frequency

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-15 Thread Francesco Dolcini
On Sat, Jan 13, 2024 at 07:33:17PM +0100, Marek Vasut wrote: > The older i.MX8M Mini Verdin SoMs before rev. 1.1C came with 20 MHz SPI CAN > controller oscillator, the newer SoMs use 40 MHz oscillator. Handle both by > overriding the oscillator frequency just before booting the kernel. > >

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-14 Thread Marcel Ziswiler
Hi Guys On Sat, 2024-01-13 at 21:45 +0100, Francesco Dolcini wrote: > On Sat, Jan 13, 2024 at 06:40:19PM +, Marcel Ziswiler wrote: > > Hi Marek > > > > Thanks, seems like a decent idea. I guess we just did not do it as those > > previous revisions were just > > samples > > but with this

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Fabio Estevam
On Sat, Jan 13, 2024 at 5:45 PM Francesco Dolcini wrote: > Fabio, you were too fast ... please revert it. I have dropped this patch from u-boot-imx master-next.

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Francesco Dolcini
On Sat, Jan 13, 2024 at 09:45:42PM +0100, Francesco Dolcini wrote: > On Sat, Jan 13, 2024 at 06:40:19PM +, Marcel Ziswiler wrote: > > Hi Marek > > > > Thanks, seems like a decent idea. I guess we just did not do it as those > > previous revisions were just samples > > but with this change

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Francesco Dolcini
On Sat, Jan 13, 2024 at 06:40:19PM +, Marcel Ziswiler wrote: > Hi Marek > > Thanks, seems like a decent idea. I guess we just did not do it as those > previous revisions were just samples > but with this change can still be used much easier (e.g. without requiring > manual intervention). >

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Fabio Estevam
On Sat, Jan 13, 2024 at 3:34 PM Marek Vasut wrote: > > The older i.MX8M Mini Verdin SoMs before rev. 1.1C came with 20 MHz SPI CAN > controller oscillator, the newer SoMs use 40 MHz oscillator. Handle both by > overriding the oscillator frequency just before booting the kernel. > > Signed-off-by:

Re: [RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Marcel Ziswiler
Hi Marek Thanks, seems like a decent idea. I guess we just did not do it as those previous revisions were just samples but with this change can still be used much easier (e.g. without requiring manual intervention). On Sat, 2024-01-13 at 19:33 +0100, Marek Vasut wrote: > The older i.MX8M Mini

[RFC][PATCH] ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model

2024-01-13 Thread Marek Vasut
The older i.MX8M Mini Verdin SoMs before rev. 1.1C came with 20 MHz SPI CAN controller oscillator, the newer SoMs use 40 MHz oscillator. Handle both by overriding the oscillator frequency just before booting the kernel. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam