Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-22 Thread Prafulla Wadaskar
-Original Message- From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] Sent: Friday, July 22, 2011 10:08 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs Hi Prafulla, Thank you so much for

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-22 Thread Ajay Bhargav
Hi Prafulla, I don't mind if you merge these two patches, any future support will add gpio.h Let them be separate easy to track changes :) I will be sending updated patches. Regards, Ajay Bhargav ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Lei Wen
Hi Ajay, On Thu, Jul 21, 2011 at 1:39 PM, Ajay Bhargav ajay.bhar...@einfochips.com wrote: This patch adds generic GPIO driver framework support for Marvell SoCs. To enable GPIO driver define CONFIG_MV_GPIO and for GPIO commands define CONFIG_CMD_GPIO in your board configuration file.

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Ajay Bhargav
- Lei Wen adrian.w...@gmail.com wrote: Hi Ajay, Please put this get_gpio_base into arch's self directory, since different soc may have different number of banks. For example, mmp3 has 6 banks. Best regards, Lei was out of my mind... I think having a macro for this would be

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Ajay Bhargav
Hi Lei, Please put this get_gpio_base into arch's self directory, since different soc may have different number of banks. For example, mmp3 has 6 banks. Can I declare get_gpio_base in arch's gpio.h file as static inline? so other archs can have their own version in their respective gpio.h

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Lei Wen
Hi Ajay, On Thu, Jul 21, 2011 at 8:34 PM, Ajay Bhargav ajay.bhar...@einfochips.com wrote: Hi Lei, Please put this get_gpio_base into arch's self directory, since different soc may have different number of banks. For example, mmp3 has 6 banks. Can I declare get_gpio_base in arch's gpio.h

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Prafulla Wadaskar
-Original Message- From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] Sent: Thursday, July 21, 2011 11:10 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ajay Bhargav Subject: [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs This patch adds generic GPIO

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Prafulla Wadaskar
-Original Message- From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com] Sent: Thursday, July 21, 2011 11:10 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ajay Bhargav Subject: [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs This patch adds generic GPIO

Re: [U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-21 Thread Ajay Bhargav
Hi Prafulla, Thank you so much for feedback. In this case mvgpio.c is enabling support for gpio framework that will be interfaced using asm/gpio.h. 1. You can split stuff in mvgpio.h to asm/arch/gpio.h and/or mvgpio.c 2. you can move it to drivers/gpio/ I would recommend first option.

[U-Boot] [PATCH 1/2] gpio: Add GPIO driver framework for Marvell SoCs

2011-07-20 Thread Ajay Bhargav
This patch adds generic GPIO driver framework support for Marvell SoCs. To enable GPIO driver define CONFIG_MV_GPIO and for GPIO commands define CONFIG_CMD_GPIO in your board configuration file. Signed-off-by: Ajay Bhargav ajay.bhar...@einfochips.com --- drivers/gpio/Makefile |1 +