Hi Prafulla,
Any comments on the GPIO patches? Is there any modifications you suggest?
Regards,
Ajay Bhargav
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
- Prafulla Wadaskar prafu...@marvell.com wrote:
The main objective of having mvgpio.c is to share/reuse a driver code
across several SoCs.
If most of the SoCs (what we know) have similar register definition,
it makes sense to keep them in mvgpio.c
What may differ for each SOC is
This patch adds support for generic GPIO driver framework for Marvell
SoC Armada100.
Signed-off-by: Ajay Bhargav ajay.bhar...@einfochips.com
---
arch/arm/include/asm/arch-armada100/armada100.h |4 +
arch/arm/include/asm/arch-armada100/gpio.h | 95 +++
2 files
Hi Ajay,
On Fri, Jul 22, 2011 at 3:16 PM, Ajay Bhargav
ajay.bhar...@einfochips.com wrote:
This patch adds support for generic GPIO driver framework for Marvell
SoC Armada100.
Signed-off-by: Ajay Bhargav ajay.bhar...@einfochips.com
---
arch/arm/include/asm/arch-armada100/armada100.h | 4
Hi Lei,
Why not put this structure into driver file?
I think this register is not easy to change, and put this into arch
.h
would make the work duplicated,
as each arch need to redefine the same structure again.
Other architectures may/may not have the same structure. One can redefine
On Fri, Jul 22, 2011 at 3:27 PM, Ajay Bhargav
ajay.bhar...@einfochips.com wrote:
Hi Lei,
Why not put this structure into driver file?
I think this register is not easy to change, and put this into arch
.h
would make the work duplicated,
as each arch need to redefine the same structure
Hi Ajay,
On Fri, Jul 22, 2011 at 4:57 PM, Ajay Bhargav
ajay.bhar...@einfochips.com wrote:
Hi Lei,
I think if have no such same structure, the gpio driver may need to be
rewrite,
since the meaning of the register may also change.
so should this be changed back to Armada100 gpio? How bout
Hi Lei,
Thank you for confirming.
What do you mean by changed back to Armada100 gpio?
Well just incase GPIO register set is different for different archs
this current driver need to be renamed as armada100 gpio.
So if other Marvell SoCs are having similar register set then we can
have a
-Original Message-
From: Ajay Bhargav [mailto:ajay.bhar...@einfochips.com]
Sent: Friday, July 22, 2011 3:34 PM
To: Lei Wen
Cc: Prafulla Wadaskar; u-boot@lists.denx.de
Subject: Re: [U-Boot] [PATCH v2 2/2] gpio: Add GPIO driver for Marvell
SoC Armada100
Hi Lei,
Thank you
9 matches
Mail list logo