Re: [PATCH 1/1] riscv: sifive: fu540: redundant initialization

2020-08-04 Thread Rick Chen
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Tuesday, August 04, 2020 5:10 AM > To: Rick Jian-Zhi Chen(陳建志) > Cc: Pragnesh Patel; Bin Meng; u-boot@lists.denx.de; Heinrich Schuchardt > Subject: [PATCH 1/1] riscv: sifive: fu540: redundant initialization > > We should not

RE: [PATCH 1/1] riscv: sifive: fu540: redundant initialization

2020-08-03 Thread Pragnesh Patel
>-Original Message- >From: Heinrich Schuchardt >Sent: 04 August 2020 02:40 >To: Rick Chen >Cc: Pragnesh Patel ; Bin Meng >; u-boot@lists.denx.de; Heinrich Schuchardt > >Subject: [PATCH 1/1] riscv: sifive: fu540: redundant initialization > >[External Email] Do not click links or

Re: [PATCH 1/1] riscv: sifive: fu540: redundant initialization

2020-08-03 Thread Bin Meng
On Tue, Aug 4, 2020 at 5:10 AM Heinrich Schuchardt wrote: > > We should not initialize a variable if the value is overwritten before > being read. > > Signed-off-by: Heinrich Schuchardt > --- > arch/riscv/cpu/fu540/cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: