** Changed in: netplan
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Expose link offload options
To manage notifications about this bug go
This bug was mostly about exposing the offload options in general. But
indeed the tristate should be handled properly.
Let's continue that discussion in LP: #1956264
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Upon further investigation, I see that the systemd networkd settings
have similar documentation only listing true and unset. But the systemd
NEWS file explicitly talks about disabling and the settings are parsed
in networkd using config_parse_tristate, so I think networkd properly
handles =0 on
This change does NOT fix the issue from the [Impact] statement. The
[Impact] talks about disabling offload, but the test case talks about
enabling offload. The patch only implements enabling offload, not
disabling it.
** Changed in: netplan
Status: Fix Committed => Confirmed
--
You
This bug was fixed in the package netplan.io - 0.103-0ubuntu5~20.04.3
---
netplan.io (0.103-0ubuntu5~20.04.3) focal; urgency=medium
[ Nicolas Bock ]
* d/p/0001-Add-support-for-additional-Link-options-225-LP-17717.patch:
- Add offload configuration options.
(LP:
This bug was fixed in the package netplan.io - 0.103-0ubuntu5~21.04.3
---
netplan.io (0.103-0ubuntu5~21.04.3) hirsute; urgency=medium
[ Nicolas Bock ]
* d/p/0001-Add-support-for-additional-Link-options-225-LP-17717.patch:
- Add offload configuration options.
(LP:
This bug was fixed in the package netplan.io - 0.103-0ubuntu7.1
---
netplan.io (0.103-0ubuntu7.1) impish; urgency=medium
[ Nicolas Bock ]
* d/p/0001-Add-support-for-additional-Link-options-225-LP-17717.patch:
- Add offload configuration options.
(LP: #1771740)
* Add
I've tested netplan.io 0.103-0ubuntu5~20.04.3 from focal-proposed.
The netplan generator command was run successfully, producing correct
*Offload=1 settings for networkd.
root@sru-ff:~# dpkg -l | grep netplan
ii libnetplan0:amd64 0.103-0ubuntu5~20.04.3 amd64 YAML network configuration
I've tested netplan.io 0.103-0ubuntu5~21.04.3 from hirsute-proposed.
The netplan generator command was run successfully, producing correct
*Offload=1 settings for networkd.
root@sru-hh:~# dpkg -l | grep netplan
ii libnetplan0:amd64 0.103-0ubuntu5~21.04.3 amd64 YAML network configuration
I've tested netplan.io 0.103-0ubuntu7.1 from impish-proposed and
attached the autopkgtest logs to the bug description, according to
https://wiki.ubuntu.com/NetplanUpdates.
The netplan generator command was run successfully, producing correct
*Offload=1 settings for networkd.
root@sru-ii:~# dpkg
** Description changed:
[Impact]
- * On virtualization hosts disable GRO and LRO, otherwise, with
-receive offload on, the guests will receive packets that are
-larger than the MTU. This can cause issues in certain scenarios,
-e.g. when the guest is a VPN server that needs to
I no longer have the network card in question and don't have a suitable
environment to test, sorry.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Expose link offload options
To
Hello Ryan, or anyone else affected,
Accepted netplan.io into hirsute-proposed. The package will build now
and be available at
https://launchpad.net/ubuntu/+source/netplan.io/0.103-0ubuntu5~21.04.3
in a few hours, and then in the -proposed repository.
Please help us by testing this new package.
Hello Ryan, or anyone else affected,
Accepted netplan.io into focal-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/netplan.io/0.103-0ubuntu5~20.04.3
in a few hours, and then in the -proposed repository.
Please help us by testing this new package.
** Description changed:
[Impact]
- * On virtualization hosts disable GRO and LRO, otherwise, with
- receive offload on, the guests will receive packets that are
- larger than the MTU. This can cause issues in certain scenarios,
- e.g. when the guest is a VPN server that needs to
This bug was fixed in the package netplan.io - 0.103-0ubuntu8
---
netplan.io (0.103-0ubuntu8) jammy; urgency=medium
* d/p/0001-Add-support-for-additional-Link-options-225-LP-17717.patch:
- Add offload configuration options.
(LP: #1771740)
* Add
** Description changed:
- Impact]
+ [Impact]
* On virtualization hosts disable GRO and LRO, otherwise, with
-receive offload on, the guests will receive packets that are
-larger than the MTU. This can cause issues in certain scenarios,
-e.g. when the guest is a VPN server that
Some more smaller remarks:
* We can drop the bundled
"Implement-YAML-state-tracking-and-use-it-in-the-DBus.patch" from the Hirsute
and Focal debdiffs (it has already been SRUed in the meantime).
* We need to fix the version strings
** Changed in: netplan.io (Ubuntu Jammy)
Status: New => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Expose link offload options
To manage notifications about
Thank you Nicolas,
I cleaned up some fuzz and whitespace around the "activation_mode" field
in src/parse.h but other than that the patch looks like I wanted it to
be (wrt. ABI compatibility).
I've uploaded it to Jammy. Let's see how that works out wrt.
autopkgtests. If everything is good and
** Also affects: netplan.io (Ubuntu Jammy)
Importance: Wishlist
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Expose link offload options
To manage
** Patch added: "Updated impish debdiff"
https://bugs.launchpad.net/netplan/+bug/1771740/+attachment/5534968/+files/impish.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Hi Lukas and Dan,
I applied a partial patch to the three packages (Focal, Hirsute, and
Impish) and uploaded the new debdiffs. Please review.
Thanks!
Nick
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Patch added: "Updated hirsute debdiff"
https://bugs.launchpad.net/netplan/+bug/1771740/+attachment/5534967/+files/hirsute.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
** Patch added: "Updated focal debdiff"
https://bugs.launchpad.net/netplan/+bug/1771740/+attachment/5534966/+files/focal.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Hi Nicolas,
yes I meant to simply add it to the struct at the correct (upstream)
location, so that the data structure won't change (only append new
fields) when we release the next upstream version.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
** Patch added: "netplan-impish.debdiff"
https://bugs.launchpad.net/netplan/+bug/1771740/+attachment/5531800/+files/netplan-impish.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
** Patch added: "netplan-hirsute.debdiff"
https://bugs.launchpad.net/netplan/+bug/1771740/+attachment/5531799/+files/netplan-hirsute.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Hi Lukas,
When you write "inject" that field, do you mean to simply add it to the
struct or also apply the commit you cite?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1771740
Title:
Expose link
** Description changed:
- [Impact]
+ Impact]
- * An explanation of the effects of the bug on users and
-
- * justification for backporting the fix to the stable release.
-
- * In addition, it is helpful, but not required, to include an
-explanation of how the upload fixes this bug.
+
I am generally +1 with SRUing this, BUT this is a special in a few ways:
1/ In order to land this in Focal, we first need to apply it to Impish
and Hirsute (according to SRU process), as ddstreet mentioned.
2/ We are already post Feature Freeze for Impish and this is adding new
functionality IMO
@nicolasbock before sponsoring, can you cover a few of the steps in the
SRU process:
1) The SRU template in the description isn't actually filled in, I think
you simply copy-n-pasted the actual template text in...it does need to
be actually filled out
2) This is marked as affecting f/h/i, but
** Changed in: netplan.io (Ubuntu Focal)
Importance: Undecided => Wishlist
** Changed in: netplan.io (Ubuntu Hirsute)
Importance: Undecided => Wishlist
** Changed in: netplan.io (Ubuntu Impish)
Importance: Undecided => Wishlist
--
You received this bug notification because you are a
The attachment "focal.debdiff" seems to be a debdiff. The ubuntu-
sponsors team has been subscribed to the bug report so that they can
review and hopefully sponsor the debdiff. If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you
** Also affects: netplan.io (Ubuntu)
Importance: Undecided
Status: New
** Also affects: netplan.io (Ubuntu Impish)
Importance: Undecided
Status: New
** Also affects: netplan.io (Ubuntu Focal)
Importance: Undecided
Status: New
** Also affects: netplan.io (Ubuntu
35 matches
Mail list logo
