[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-16 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-release-upgrader - 1:21.04.9 --- ubuntu-release-upgrader (1:21.04.9) hirsute; urgency=medium [ Dave Jones ] * DistUpgrade/DistUpgradeQuirks.py: Add quirk to rewrite references to fkms overlay in Raspberry Pi boot configuration to kms

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-15 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~waveform/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/401234 ** Merge proposal linked: https://code.launchpad.net/~waveform/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/401236 -- You received this bug

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~waveform/ubuntu/+source/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/401157 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Dave Jones
Hmm, config.txt is fairly wide ranging, dealing with things the user generally shouldn't change (which kernel to boot, which initramfs to load) to things they're very likely to change (whether the camera firmware is enabled, overlays to load for things like the fan-shim). Unfortunately the lines

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Brian Murray
Finally, would adding more information to config.txt about why the changes were made help? I'm thinking either link to the bug, to the release notes, or include the code comment in config.txt. That being said I don't know what all is in config.txt so that may not be appropriate. -- You received

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Dave Jones
Ahh, good point -- I had naively assumed it was an arch all package but you're absolutely right it's arm{hf,64} (and besides, it'd be good practice to use a .get there anyway). On the distUpgrade, should all references be replaced with "do-release- upgrade"? I'm particularly thinking of things

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Brian Murray
I also think changing "distUpgrade" to something slightly more informative, like do-release-upgrade, might help people who run into an error. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1923673

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Brian Murray
I think this is going to crash on amd64 (and other architectures) given that the package you are looking for won't be in the cache. +if cache['ubuntu-desktop-raspi'].is_installed: +self._replace_fkms_overlay() -- You received this bug notification because you are a member of

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1923673 Title: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image To manage notifications about this bug go to:

[Bug 1923673] Re: Rewrite fkms overlay to kms overlay on upgrade of desktop pi image

2021-04-14 Thread Dave Jones
Attaching debdiff against current version (21.04.8) which implements this fix. Test package is built in the following PPA: https://launchpad.net/~waveform/+archive/ubuntu/ubuntu-release- upgrader/+packages ** Patch added: "1-1923673.debdiff"