[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-28 Thread Launchpad Bug Tracker
This bug was fixed in the package containerd - 1.5.9-0ubuntu3 --- containerd (1.5.9-0ubuntu3) jammy; urgency=medium * d/p/build-with-go1.18.patch: fix FTBFS with Go 1.18 (LP: #1965157). In Go 1.17 the module graph has been changed to enable pruning and lazy loading, some

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-24 Thread Lucas Kanashiro
Thanks for confirming that William. I already uploaded the fix. ** Changed in: containerd (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965157

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-24 Thread William Wilson
Lucas, this is working great! golang-defaults has now migrated. Would you like me to sponsor this or would you rather do the upload? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965157 Title:

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-23 Thread Lucas Kanashiro
Yep, the structure of go.mod and some other files need to be changed to support Go 1.17. I updated the needed files running the following commands: $ go mod tidy -go=1.17 $ go mod vendor With that, I created the attached debdiff which fixes the FTBFS. Could you confirm if everything is fine with

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-22 Thread William Wilson
Lucas, Changing go.mod to rely on Go 1.17 does actually cause it to FTBFS. The errors are related to vendored modules not being explicitly required in go.mod. Is this something we should tackle now? Here is a full failed build log: https://launchpadlibrarian.net/592301054/buildlog_ubuntu-jammy-

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-17 Thread Lucas Kanashiro
Hi William, Thanks for working on it. I took a look at what upstream is doing regarding that and I believe it is OK to remove the empty module, but I'll suggest an extra change based on the upstream discussions. We should replace "go 1.16" in go.mod to "go 1.17" to have this feature which should

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-16 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965157 Title: containerd is FTBFS with Go 1.18 To manage notifications about this bug go to:

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-16 Thread William Wilson
Successful build against Go 1.18 in my PPA: https://launchpad.net/~jawn- smith/+archive/ubuntu/golang-118-released-rebuilds/+build/23247900 Successful build against Go 1.17 in my PPA: https://launchpad.net/~jawn- smith/+archive/ubuntu/golang-base-rebuilds/+build/23247918 -- You received this

[Bug 1965157] Re: containerd is FTBFS with Go 1.18

2022-03-16 Thread William Wilson
** Patch added: "lp1965157.debdiff" https://bugs.launchpad.net/ubuntu/+source/containerd/+bug/1965157/+attachment/5569713/+files/lp1965157.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.