[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-06 Thread David Henningsson
On 11/05/2012 07:13 PM, Tanu Kaskinen wrote: On Sun, 2012-11-04 at 23:09 +0100, David Henningsson wrote: On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: Returning NULL seems to be the right thing to do here, even if gnome-control-center

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-06 Thread Tanu Kaskinen
On Tue, 2012-11-06 at 08:36 +0100, David Henningsson wrote: On 11/05/2012 07:13 PM, Tanu Kaskinen wrote: On Sun, 2012-11-04 at 23:09 +0100, David Henningsson wrote: On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: Returning NULL

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-05 Thread Tanu Kaskinen
On Sun, 2012-11-04 at 23:09 +0100, David Henningsson wrote: On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: Returning NULL seems to be the right thing to do here, even if gnome-control-center does not handle that very well IIRC. So we

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-04 Thread Tanu Kaskinen
On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: 2012-11-03 17:19, Colin Guthrie skrev: 'Twas brillig, and Tanu Kaskinen at 05/10/12 13:58 did gyre and gimble: On Wed, 2012-10-03 at 08:50 +0200, David Henningsson wrote: On 10/02/2012 10:38 PM, Tanu Kaskinen wrote: On Mon,

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-04 Thread David Henningsson
On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: 2012-11-03 17:19, Colin Guthrie skrev: 'Twas brillig, and Tanu Kaskinen at 05/10/12 13:58 did gyre and gimble: On Wed, 2012-10-03 at 08:50 +0200, David Henningsson wrote: On 10/02/2012

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-10-05 Thread Tanu Kaskinen
On Wed, 2012-10-03 at 08:50 +0200, David Henningsson wrote: On 10/02/2012 10:38 PM, Tanu Kaskinen wrote: On Mon, 2012-10-01 at 17:06 +0200, David Henningsson wrote: If there is no silence memblock and no data, pa_memblockq_peek can return NULL. In this case, do not crash on an assertion in

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-10-03 Thread David Henningsson
On 10/02/2012 10:38 PM, Tanu Kaskinen wrote: On Mon, 2012-10-01 at 17:06 +0200, David Henningsson wrote: If there is no silence memblock and no data, pa_memblockq_peek can return NULL. In this case, do not crash on an assertion in pa_memblock_acquire, but instead return a proper error to the

[Bug 1058200] Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-10-02 Thread Tanu Kaskinen
On Mon, 2012-10-01 at 17:06 +0200, David Henningsson wrote: If there is no silence memblock and no data, pa_memblockq_peek can return NULL. In this case, do not crash on an assertion in pa_memblock_acquire, but instead return a proper error to the client. If there is no data in the buffer,