[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Mitchell Dzurick
I'll do a bit of git archaeology tomorrow to try and find out why the quote macros were added. Otherwise, my vote is to go with the bash invocation in the sub-process so that way we can keep the quote macros. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Dominic
I agree, I also do not know the potential risks of removing ${quote:} from tainted variables, so this needs further research before implementation. Or we go with yours. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Mitchell Dzurick
With this said, I have reservations about removing a quote macro without research. It does more than just quote wrap a variable, it also escapes quotes and other special characters from the variable To be honest, I'm no expert in this source code, but if the variables $sender_host_address or

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Mitchell Dzurick
Nice catch, I like that updated version better. This also leads more credence to an issue with parsing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Dominic
Hi Mitchell, Your version works for me as well. In the interim I have been successfully using the following configuration. Would this be potentially useful, or are there issues with removing ${quote:} from --ip and --identity? condition = ${run{/usr/bin/spfquery.mail-spf-perl \

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-30 Thread Mitchell Dzurick
I think I have found a fix for this issue. My hunch is there is something buggy about the run{} command when invoking programs directly. I wrapped the contents of run with an explicit shell invocation, e.g. condition = ${run{/usr/bin/spfquery.mail-spf-perl \

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-29 Thread Mitchell Dzurick
I have reproduced this issue on a live noble server running exim4. Digging deeper now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-28 Thread Mitchell Dzurick
Apologies for the delay, I'm picking this back up today. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't work To manage notifications

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-20 Thread Athos Ribeiro
** Changed in: exim4 (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't work To manage

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-17 Thread Dominic
Re-marking as new since I've supplied all requested information. ** Changed in: exim4 (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title:

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-09 Thread Mitchell Dzurick
Hi, just want to add a quick comment that I’m on vacation until the end of the week so don’t expect a reply from me until then. Also will be attending the Canonical sprint next week so might not be able to update this next week either. Feel free to take a stab at this if you are triaging this bug

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-06 Thread Dominic
(and comment #6) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't work To manage notifications about this bug go to:

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-06 Thread Dominic
No, you should be seeing a header. Are the steps you followed the same as that which I wrote in comment #5 of this report? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-06 Thread Mitchell Dzurick
That could be a possibility. On a side note, I tried to setup a testbed to reproduce this (and start working on a dep8 test) and can't seem to get the setup working correctly. I followed the steps in bug #1998678, see the mail in `/var/mail/ubuntu` but don't see any Received-SPF headers at all,

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-06 Thread Dominic
No errors in /var/log/exim4/mainlog, just normal mail flow logs. I suspect some sort of error was introduced in the code for the #1998678 fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-05 Thread Mitchell Dzurick
I was looking into bug #1998678 as a potential reason, do you see any concerning logs in your /var/log/exim4/mainlog (or wherever your logs are)? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-04 Thread Dominic
Possibly related to: https://bugs.launchpad.net/ubuntu/+source/exim4/+bug/1998678 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-03 Thread Dominic
It was a clean install of Noble, for some reason the spf check always returns "none". It is very easily reproducible, as per my comment #5. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-03 Thread Mitchell Dzurick
Dominic, did you upgrade to mantic and start seeing this failure, or did you make a new mantic install and set things up from scratch? I wonder if some logic elsewhere was changed in Debian that we missed, or has this always been broken? This scenario would also be a nice thing to have a dep8

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-02 Thread Dominic
Still an issue in noble / 24.04. "Received-SPF: none" is reported in the headers of received mail for senders known to have an spf record configured. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-05-02 Thread Dominic
Also, this should not be marked as "incomplete" as I have supplied all the required information. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-15 Thread Dominic
I get the correct result when running spfquery.mail-spf-perl manually. $ /usr/bin/spfquery.mail-spf-perl --ip 40.92.113.65 --scope mfrom --identity exam...@outlook.com pass outlook.com: Sender is authorized to use 'exam...@outlook.com' in 'mfrom' identity (mechanism

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-15 Thread Paride Legovini
Hello Dominic, The fact that you get that Received-SPF: none headers means that spf-tools-perl gets called by exim4. What I suggest to debug this is to manually call spfquery.mail-spf-per with the relevant parameters (see the spfquery.mail-spf-perl manpage), and check if what kind of reply

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-13 Thread Dominic
According to the exim4 changelog, the spf logic was modified in Aug 2023. exim4 (4.96-17ubuntu1) mantic; urgency=medium * Merge with Debian unstable (LP: #2030098). Remaining changes: - Disable external SPF support to avoid Build-Depends on libspf2-dev (only available in universe).

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-13 Thread Dominic
I'm using exim4-daemon-heavy. $ apt list --installed | grep exim4 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. exim4-base/mantic-updates,mantic-security,now 4.96-17ubuntu2.2 amd64 [installed,automatic] exim4-config/mantic-updates,mantic-security,now

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-13 Thread Athos Ribeiro
Hi Dominic, Thanks for the additional information. Are you using exim4-daemon-heavy or exim4-daemon-light? In case you are using the light version, could you try it with the heavy one as well and report it back here? -- You received this bug notification because you are a member of Ubuntu

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-12 Thread Dominic
Also: `update-exim4.conf` and restart exim before sending mail to yourself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with CHECK_RCPT_SPF doesn't work To

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-12 Thread Dominic
exim4.conf.template is completely unmodified from stock mantic. Bug can be replicated by: 1. Installing mantic 2. Installing exim4 and spf-tools-perl 3. `dpkg-reconfigure exim4-config` and make it accept mail 4. Adding CHECK_RCPT_SPF = true to /etc/exim4/exim4.conf.localmacros 5. Sending

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-12 Thread Lucas Kanashiro
Could you provide your config file? Also state if you applied any customization in your set up? Those things would be useful to reproduce what you described locally. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-11 Thread Dominic
Hi Mitchell, I am setting CHECK_RCPT_SPF = true in /etc/exim4/exim4.conf.localmacros where local macros are typically set. I have run `update-exim4.conf` and `systemctl restart exim4`. Then I send myself an email from an outlook.com account, which has SPF enabled, and the headers report:

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-11 Thread Mitchell Dzurick
Hi Dominic, Thanks for taking the time to submit this bug report and make Ubuntu better! Where are you setting the variable CHECK_RCPT_SPF = true ? Doing a quick google search I found[0] which looks like it may be useful. It says to do the following - 1) Add `CHECK_RCPT_SPF = true` to the top

[Bug 2056372] Re: Enabling SPF checks with CHECK_RCPT_SPF doesn't work

2024-03-07 Thread Dominic
Note: this bug relates to inbound IPv4 addresses. IPv6 addresses are affected by a separate bug: #2056443 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056372 Title: Enabling SPF checks with