Re: PMML version in MLLib

2015-11-08 Thread Vincenzo Selvaggio
Hi, I confirm the models are exported for PMML version 4.2, in fact you can see in the generated xml PMML xmlns="http://www.dmg.org/PMML-4_2; This is the default version when using https://github.com/jpmml/jpmml-model/tree/1.1.X. I didn't realize the attribute version of the PMML root element

Re: PMML version in MLLib

2015-11-08 Thread Fazlan Nazeem
Hi Vincenzo/Owen, I have sent a pull request[1] with necessary changes to add the pmml version attribute to the root node. I have also linked the issue under the PMML improvement umbrella[2] as you suggested. [1] https://github.com/apache/spark/pull/9558 [2]

Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
Thanks Owen. Will do it On Wed, Nov 4, 2015 at 5:22 PM, Sean Owen wrote: > I'm pretty sure that attribute is required. I am not sure what PMML > version the code has been written for but would assume 4.2.1. Feel > free to open a PR to add this version to all the output. > >

Re: PMML version in MLLib

2015-11-04 Thread Sean Owen
I'm pretty sure that attribute is required. I am not sure what PMML version the code has been written for but would assume 4.2.1. Feel free to open a PR to add this version to all the output. On Wed, Nov 4, 2015 at 11:42 AM, Fazlan Nazeem wrote: > [adding dev] > > On Wed, Nov

Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
[adding dev] On Wed, Nov 4, 2015 at 2:27 PM, Fazlan Nazeem wrote: > I just went through all specifications, and they expect the version > attribute. This should be addressed very soon because if we cannot use the > PMML model without the version attribute, there is no use of

Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
Hi Stefano, Although the intention for my question wasn't as you expected, what you say makes sense. The standard[1] for PMML 4.1 specifies that "*For PMML 4.1 the attribute version must have the value 4.1". *I'm not sure whether that means that other PMML versions do not need that attribute to

Re: PMML version in MLLib

2015-11-04 Thread Stefano Baghino
I used KNIME, which internally uses the org.dmg.pmml library. On Wed, Nov 4, 2015 at 9:45 AM, Fazlan Nazeem wrote: > Hi Stefano, > > Although the intention for my question wasn't as you expected, what you > say makes sense. The standard[1] for PMML 4.1 specifies that "*For

Re: PMML version in MLLib

2015-11-04 Thread Fazlan Nazeem
I just went through all specifications, and they expect the version attribute. This should be addressed very soon because if we cannot use the PMML model without the version attribute, there is no use of generating one without it. On Wed, Nov 4, 2015 at 2:17 PM, Stefano Baghino <

Re: PMML version in MLLib

2015-11-04 Thread Stefano Baghino
Hi Fazian, I actually had a problem with an invalid PMML produced by Spark 1.5.1 due to the missing "version" attribute in the "PMML" tag. Is this your case too? I've briefly checked the PMML standard and that attribute is required, so this may be an issue that should be addressed. I'll happily

PMML version in MLLib

2015-11-03 Thread Fazlan Nazeem
Hi, Can I know which version of PMML is used in MLLIb's PMML export functionality for Spark 1.4.1 and Spark 1.5.1? I couldn't find this information within the documentation. If present in documentation please provide me the source. Thanks & Regards, Fazlan Nazeem *Software Engineer* *WSO2