[uml-devel] [PATCH] uml: Fix build with recent glibc

2018-02-28 Thread Andi Kleen
From: Andi Kleen <a...@linux.intel.com> Newer glibc did some include namespace "cleanups" and removed struct ucontext and friends. This already broke a lot of software, and UML seems to be the latest victim. Use the typedefs which are still available. They also work on older gli

Re: [uml-devel] [PATCH 1/6] base: Valgrind headers and Kconfig

2008-09-01 Thread Andi Kleen
Steve VanDeBogart [EMAIL PROTECTED] writes: Kconfig option for Valgrind. Suppression file, for known non-issues. Valgrind header files (svn 8534) that define the client request mechanism used to annotate programs plus a couple lines to integrate with Kconfig. Couldn't you just get the

Re: [uml-devel] [PATCH 1/6] base: Valgrind headers and Kconfig

2008-09-01 Thread Andi Kleen
On Mon, Sep 01, 2008 at 10:06:18AM -0400, Jeff Dike wrote: On Mon, Sep 01, 2008 at 11:32:00AM +0200, Andi Kleen wrote: Steve VanDeBogart [EMAIL PROTECTED] writes: Kconfig option for Valgrind. Suppression file, for known non-issues. Valgrind header files (svn 8534) that define the client

Re: [uml-devel] uml and -regparm=3

2008-01-09 Thread Andi Kleen
Miklos Szeredi [EMAIL PROTECTED] writes: FASTCALL is defined empty in -mm, but UML is not compiled with -mregparm=3 and so this breaks things (I noticed problems with rwsem_down_write_failed). Tried recompiling UML with -mregparm=3, but that resulted in a strange failure immediately after

Re: [uml-devel] uml and -regparm=3

2008-01-09 Thread Andi Kleen
On Wed, Jan 09, 2008 at 10:20:49PM +0100, Miklos Szeredi wrote: Miklos Szeredi [EMAIL PROTECTED] writes: FASTCALL is defined empty in -mm, but UML is not compiled with -mregparm=3 and so this breaks things (I noticed problems with rwsem_down_write_failed). Tried recompiling UML

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-23 Thread Andi Kleen
Ingo Molnar [EMAIL PROTECTED] writes: the 'fastcall removal' changes to paravirt.c were over-eager: they removed fastcall annotations from functions that are (or might be) implemented in assembly. So if someone changes the compiler model, such as -pg which disables regparm, the kernel breaks

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-23 Thread Andi Kleen
Ingo Molnar [EMAIL PROTECTED] writes: * Andi Kleen [EMAIL PROTECTED] wrote: so this patch adds back fastcall annotations. This serves as documentation for assembly calling-convention dependencies as well. You should rename it then to asmcall or something. if then that should

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-23 Thread Andi Kleen
On Tue, Oct 23, 2007 at 04:20:06PM +0200, Ingo Molnar wrote: * Andi Kleen [EMAIL PROTECTED] wrote: You should rename it then to asmcall or something. if then that should be a separate renaming patch. Well you're asking for the ugly hacks for out of tree code. [...] nice word

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-23 Thread Andi Kleen
On Tue, Oct 23, 2007 at 05:44:17PM +0200, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: [...] -pg should in theory work with -mregparms. last i checked it didnt work - i'll re-check that. earlier gcc versions had problems with -mregparm and with -pg. I just Which

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-17 Thread Andi Kleen
Jeff Dike [EMAIL PROTECTED] writes: [ This is both 2.6.24 and -stable material ] SuSE seems to require that binaries have a .note.SuSE section. Without it, UML segfaults if any parameters are passed on the command line. This doesn't make any sense. You must have misanalyzed this. -Andi

Re: [uml-devel] [PATCH 2/6] Create asm-i386/cmpxchg.h

2007-05-02 Thread Andi Kleen
On Tuesday 01 May 2007 20:21:57 Jeff Dike wrote: Rearrange the i386 cmpxchg code to allow atomic.h to get it without needing to include system.h. This kills warnings in the UML build from atomic.h about implicit declarations of cmpxchg symbols. The i386 build presumably isn't seeing this

Re: [uml-devel] [PATCH 02/14] uml: revert wrong patch

2006-10-05 Thread Andi Kleen
On Thursday 05 October 2006 23:38, Paolo 'Blaisorblade' Giarrusso wrote: Andi Kleen pointed out that -mcmodel=kernel does not make sense for userspace code and would stop everything from working, did it work at all with it? -Andi

Re: [uml-devel] [PATCH 1/3] uml: use -mcmodel=kernel for x86_64

2006-08-08 Thread Andi Kleen
Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] writes: From: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] We have never used this flag and recently one user experienced a complaining warning about this (there was a symbol in the positive half of the address space IIRC). So fix it.

Re: [uml-devel] [PATCH 3/9] UML - Remove pte_mkexec

2006-06-29 Thread Andi Kleen
On Thursday 29 June 2006 23:36, Jeff Dike wrote: Andi is making pte_mkexec go away, and UML had one of the last uses. Actually not go away, but do the correct thing on i386/x86-64. Just relying on its side effects of setting _USER was bad. Thanks, -Andi Using Tomcat but need to do more? Need

Re: [uml-devel] [PATCH] uml: fix signal code x86-64 [for 2.6.15]

2006-06-05 Thread Andi Kleen
It isn't yet perfect, because we don't yet save floating point context. But that will come later. Additionally, there's a potential problem since RED zones will alternate stacks are used, unlike x86_64, so more stack space (128 bytes more) is used. But this shouldn't be a problem. Instead,

[uml-devel] Re: [discuss] [RFC] [PATCH] Double syscall exit traces on x86_64

2006-05-26 Thread Andi Kleen
twice int_ret_from_syscall already does syscall exit tracing, so no need to do it again in the caller. This caused problems for UML and some other special programs doing syscall interception. Signed-off-by: Andi Kleen [EMAIL PROTECTED] Index: linux/arch/x86_64/kernel/entry.S

[uml-devel] Re: [PATCH 6/6] x86_64: enable xchg optimization for x86_64

2005-10-25 Thread Andi Kleen
On Wednesday 26 October 2005 00:13, Paolo 'Blaisorblade' Giarrusso wrote: I.e. the implementation was written, is present in the tree, but due to this: #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK #include linux/rwsem-spinlock.h /* use a generic implementation */ #else #include asm/rwsem.h /* use

[uml-devel] Re: [PATCH 4/6] x86_64: fix L1_CACHE_SHIFT_MAX for Intel EM64T [for 2.6.14?]

2005-10-25 Thread Andi Kleen
On Wednesday 26 October 2005 00:44, Blaisorblade wrote: For what I see, that's based on the tradeoff between space and contention - for instance there are few zones only, so there's no big waste. If space is precious it shouldn't be padded at all. In practice, interpreting !X86_GENERIC as I

[uml-devel] Re: [PATCH 4/9] UML - Mark SMP on UML/x86_64 as broken

2005-08-30 Thread Andi Kleen
Jeff Dike [EMAIL PROTECTED] writes: Noticed by Al Viro - SMP on x86_64 is fundamentally broken due to UML's reuse of the host arch's percpu stuff. This is OK on x86, but the x86_64 pda stuff just won't work for UML. The generic one should work too, it's just less efficient. So you can

[uml-devel] Re: [RFC] (How to) Let idle CPUs sleep

2005-05-08 Thread Andi Kleen
Arjan van de Ven [EMAIL PROTECTED] writes: On Sun, 2005-05-08 at 13:50 +1000, Rusty Russell wrote: My preference would be the second: fix the scheduler so it doesn't rely on regular polling. However, as long as the UP case runs with no timer interrupts when idle, many people will be happy

[uml-devel] Re: [RFC] (How to) Let idle CPUs sleep

2005-05-08 Thread Andi Kleen
On Sun, May 08, 2005 at 03:44:14PM +0200, Arjan van de Ven wrote: But it has to be *really* lightweight because these transistion can happen a lot (consider a CPU that very often goes to sleep for a short time) lightweight is good of course. But even if it's medium weight.. it just means

[uml-devel] Re: [patch 1/1] x86_64: make string func definition work as intended

2005-05-02 Thread Andi Kleen
I agree this can be a bit kludgy, so if you want add another solution. Patch is ok for me, but you have a good chance of having broken other archs too due to the string.c changes. Probably needs some testing. -Andi --- This SF.Net email is

[uml-devel] Re: [patch 1/1] Uml: kludgy compilation fixes for x86-64 subarch modules support [for -mm]

2005-05-02 Thread Andi Kleen
On Sun, May 01, 2005 at 08:45:15PM +0200, [EMAIL PROTECTED] wrote: From: Paolo 'Blaisorblade' Giarrusso [EMAIL PROTECTED] Cc: Andi Kleen [EMAIL PROTECTED] These are some trivial fixes for the x86-64 subarch module support. The only potential problem is that I have to modify arch/x86_64