Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-20 Thread Martin Grotzke
What about using the @StatelessComponent (moving it from devutils into wicket) as an indicator, that pages are intended to be stateless (_must_ be stateless)? Or introduce a new annotation @StatelessPage? When a page that is intented to be stateless turns to be stateful, it's always an issue

Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-13 Thread Martin Grotzke
Hi, just submitted this as https://issues.apache.org/jira/browse/WICKET-2782 I tried incrementing the pageId when the page's numericId is first accessed, but soon realized, that this does happen rather often (also e.g. to construct bookmarkable page links) ;-) Seems to be not as easy as I

Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-13 Thread Matej Knopp
I'm not sure about all this. If the session has not been bound the page id will always be 0. If the session has been bound, I don't think we shouldn't increment page Id. Stateless page can became stateful any time, not incrementing the id can have sideeffects. -Matej On Sat, Mar 13, 2010 at

Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-13 Thread Martin Grotzke
There are cases where pages are intended to be stateless (and might get annotated with @StatelessComponent). At least for these pages the page id should not be incremented, even if the session already has been bound. Cheers, Martin On Sat, 2010-03-13 at 22:58 +0100, Matej Knopp wrote: I'm not

AW: Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-11 Thread martin . grotzke
the Session.pageIdCounter for stateless pages? Von: Igor Vaynberg igor.vaynb...@gmail.com Datum: 10.03.2010 17:50 i think we can do this in 1.5 i would rather not mess with 1.4 because i think there is a lot of code there that depends on the fact that the id is available right away. please create

Re: Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-11 Thread Igor Vaynberg
to create a patch for it to see if this works. Cheers, Martin -- Urspr. Mitt. -- Betreff: Re: Don't increment the Session.pageIdCounter for stateless pages? Von: Igor Vaynberg igor.vaynb...@gmail.com Datum: 10.03.2010 17:50 i think we can do this in 1.5 i would rather not mess with 1.4 because

Re: Don't increment the Session.pageIdCounter for stateless pages?

2010-03-10 Thread Igor Vaynberg
i think we can do this in 1.5 i would rather not mess with 1.4 because i think there is a lot of code there that depends on the fact that the id is available right away. please create a jira issue for this -igor On Mon, Mar 8, 2010 at 4:30 PM, Martin Grotzke martin.grot...@javakaffee.de wrote:

Don't increment the Session.pageIdCounter for stateless pages?

2010-03-08 Thread Martin Grotzke
Hi, the Page.init(PageMap) invokes setNextAvailableId(), which invokes getSession().nextPageId() if isPageIdUniquePerSession is set. getSession().nextPageId() modifies the Session.pageIdCounter. When I have a session and afterwards access a stateless page, the Session.pageIdCounter is the only