Late LGTM
http://codereview.chromium.org/2036007/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
ARM: Remove LoadConditionAndSpill and VisitAndSpill.
Please review this at http://codereview.chromium.org/2414001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm-inl.h
M
LGTM
http://codereview.chromium.org/2414001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 4753
Author: erik.co...@gmail.com
Date: Mon May 31 01:52:57 2010
Log: ARM: Remove LoadConditionAndSpill and VisitAndSpill.
Review URL: http://codereview.chromium.org/2414001
http://code.google.com/p/v8/source/detail?r=4753
Modified:
/branches/bleeding_edge/src/arm/codegen-arm-inl.h
Reviewers: Søren Gjesse,
Message:
In addition to the new entries I converted tabs to spaces in ChangeLog for
the
last push to trunk.
Description:
Prepare push to trunk. Now working on version 2.2.14.
Please review this at http://codereview.chromium.org/2417001/show
SVN Base:
Thanks for cleaning up my tabs. This changelog has a mix of tenses.
On Mon, May 31, 2010 at 11:13 AM, ri...@chromium.org wrote:
Reviewers: Søren Gjesse,
Message:
In addition to the new entries I converted tabs to spaces in ChangeLog for
the
last push to trunk.
Description:
Prepare push
Reviewers: Søren Gjesse,
Description:
Fix AddBlock invocations in CpuProfilesCollection.
It was a bad idea not to check the count of numbers to add.
Also fix a rollover: the comment in platform-linux.
Please review this at http://codereview.chromium.org/2418001/show
Affected files:
M
LGTM
http://codereview.chromium.org/2418001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I have extended the megamorphic case to handle non-string keys. Now it
starts
with looking up monomorphic cache (this still works pretty good in many
cases),
but if it misses it calls the KeyedCallIC_Generic stub to get the function
in
the fastest possible way. This does not regress usual
Revision: 4754
Author: mikhail.naga...@gmail.com
Date: Mon May 31 03:09:07 2010
Log: Fix AddBlock invocations in CpuProfilesCollection.
It was a bad idea not to check the count of numbers to add.
Also fix a rollover: the comment in platform-linux.
Review URL:
LGTM
http://codereview.chromium.org/2417001/diff/3001/4001
File ChangeLog (right):
http://codereview.chromium.org/2417001/diff/3001/4001#newcode8
ChangeLog:8: Add new scons flag --simulatorunalignedaccesses for arm
simulator.
The flag is ended up being called unalignedaccesses, and is valid
http://codereview.chromium.org/2417001/diff/3001/4001
File ChangeLog (right):
http://codereview.chromium.org/2417001/diff/3001/4001#newcode8
ChangeLog:8: Add new scons flag --simulatorunalignedaccesses for arm
simulator.
On 2010/05/31 10:11:29, Søren Gjesse wrote:
The flag is ended up being
Revision: 4755
Author: ri...@chromium.org
Date: Mon May 31 03:13:11 2010
Log: Prepare push to trunk. Now working on version 2.2.14.
Review URL: http://codereview.chromium.org/2417001
http://code.google.com/p/v8/source/detail?r=4755
Modified:
/branches/bleeding_edge/ChangeLog
http://codereview.chromium.org/2310003/diff/8001/9002
File src/isolate.cc (right):
http://codereview.chromium.org/2310003/diff/8001/9002#newcode45
src/isolate.cc:45: static Isolate* gTempGlobalIsolate = NULL;
Drive-by: please use lower-case and underscores for variable names:
global_isolate.
Revision: 4757
Author: ri...@chromium.org
Date: Mon May 31 03:41:12 2010
Log: Tagging version 2.2.13
http://code.google.com/p/v8/source/detail?r=4757
Added:
/tags/2.2.13
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
Moving TearDown-related stuff there seems like a logical next step.
Thanks,
Vitaly
http://codereview.chromium.org/2310003/diff/19001/18004
File src/isolate.h (right):
http://codereview.chromium.org/2310003/diff/19001/18004#newcode58
src/isolate.h:58: bool CreateInternal(Deserializer*
Revision: 4758
Author: lukezarko
Date: Mon May 31 05:47:33 2010
Log: Create a new class v8::internal::Isolate in isolate.h/isolate.cc.
Add isolate.cc to the build system.
Move code from v8::internal::V8::Initialize to Isolate::Initialize.
V8::Initialize now calls Isolate::Initialize to do almost
That looks mostly LGTM. But I really would like to see tons of tests for
various transitions.
http://codereview.chromium.org/2280007/diff/20001/21005
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/2280007/diff/20001/21005#newcode5953
src/ia32/codegen-ia32.cc:5953:
This is getting there.
http://codereview.chromium.org/2280007/diff/20001/21011
File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/2280007/diff/20001/21011#newcode1116
src/ia32/ic-ia32.cc:1116: CallIC::GenerateNormal(masm, argc, call_mode,
false);
Normal here means normalized
Revision: 4759
Author: whe...@chromium.org
Date: Mon May 31 06:26:12 2010
Log: Change the interface of LoadIC on the x64 platform to take its
arguments in registers.
Review URL: http://codereview.chromium.org/2330003
http://code.google.com/p/v8/source/detail?r=4759
Modified:
Reviewers: Vitaly,
Description:
Merge bleeding_edge revisions 4734:4758 into experimental/isolates.
Please review this at http://codereview.chromium.org/2433001/show
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M ChangeLog
M SConstruct
M
Rubberstamp LGTM.
http://codereview.chromium.org/2433001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/2435001/diff/1/28
File src/heap.cc (right):
http://codereview.chromium.org/2435001/diff/1/28#newcode2163
src/heap.cc:2163: Object* value =
HEAP-single_character_string_cache()-get(code);
THIS?
http://codereview.chromium.org/2435001/diff/1/28#newcode2171
http://codereview.chromium.org/2435001/diff/1/36
File src/isolate.cc (right):
http://codereview.chromium.org/2435001/diff/1/36#newcode78
src/isolate.cc:78: global_isolate = this;
This is the code that will never be correct.
Should it be just ASSERT(global_isolate == this) for now?
Announcement:
http://my.opera.com/desktopteam/blog/2010/05/31/opera-10-60-alpha-1
According to various blogs, a few of the major changes are that this build
scores dramatically higher (50-100%) than Opera 10.50 on Peacekeeper, and
that per-tab Aero Peek has been disabled by default, for the same
https://groups.google.com/a/google.com/group/v8-team/browse_thread/thread/a4396db3ce1c6c1b/09a7a00e64762387?lnk=stq=v8-team+10.60#09a7a00e64762387
yours,
anton.
On Mon, May 31, 2010 at 9:23 PM, Peter Kasting pkast...@google.com wrote:
Announcement:
http://codereview.chromium.org/2435001/diff/1/36
File src/isolate.cc (right):
http://codereview.chromium.org/2435001/diff/1/36#newcode78
src/isolate.cc:78: global_isolate = this;
On 2010/05/31 15:36:43, Dmitry Titov wrote:
This is the code that will never be correct.
Should it be just
On Mon, May 31, 2010 at 10:23 AM, Peter Kasting pkast...@google.com wrote:
Announcement: http://my.opera.com/desktopteam/blog/2010/05/31/opera-10-60-alpha-1
According to various blogs, a few of the major changes are that this build
scores dramatically higher (50-100%) than Opera 10.50 on
On Mon, May 31, 2010 at 12:59 PM, Brett Wilson bre...@google.com wrote:
On Mon, May 31, 2010 at 10:23 AM, Peter Kasting pkast...@google.com
wrote:
per-tab Aero Peek has been disabled by default, for the same reason we
disabled it: it's horrible for anyone with very many tabs.
The
29 matches
Mail list logo
