lgtm.
I had to add another change in objects.h to make it compile though.
https://codereview.chromium.org/25108007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 17025
Author: yang...@chromium.org
Date: Tue Oct 1 07:53:37 2013 UTC
Log: Fixed debuggersupport=off build after r16521
BUG=
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/25108007
Patch from Weiliang Lin weiliang@intel.com.
Committed patchset #1 manually as r17025.
https://codereview.chromium.org/25108007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: mvstanton,
Description:
Prepare push to trunk. Now working on version 3.22.6.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/25462003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -1 lines):
M ChangeLog
M
lgtm
https://codereview.chromium.org/25462003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 17026
Author: jkumme...@chromium.org
Date: Tue Oct 1 08:09:05 2013 UTC
Log: Prepare push to trunk. Now working on version 3.22.6.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/25462003
http://code.google.com/p/v8/source/detail?r=17026
Modified:
Committed patchset #1 manually as r17026 (presubmit successful).
https://codereview.chromium.org/25462003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #2 manually as r17027 (presubmit successful).
https://codereview.chromium.org/25273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17027
Author: mvstan...@chromium.org
Date: Tue Oct 1 08:14:38 2013 UTC
Log: Print out how many AllocationMementos were found on a scavenge of
new
space. This is useful because the unrooted mementos affect heap
decisions like pretenuring mode, and helps to gauge the
Committed patchset #2 manually as r17028 (presubmit successful).
https://codereview.chromium.org/25146007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17028
Author: mvstan...@chromium.org
Date: Tue Oct 1 08:22:01 2013 UTC
Log: In crankshafted code, we were creating allocation mementos for
shallow
SMI array literals when we shouldn't. The idea is that we should have
learned
by this point what type of array we'll end up
Revision: 17030
Author: jkumme...@chromium.org
Date: Tue Oct 1 08:22:26 2013 UTC
Log: Tagging version 3.22.5
http://code.google.com/p/v8/source/detail?r=17030
Added:
/tags/3.22.5
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 17029
Author: jkumme...@chromium.org
Date: Tue Oct 1 08:21:50 2013 UTC
Log: Version 3.22.5
Disabled externalization of sliced/cons strings in old pointer space
(Chromium issue 276357).
Turned on handle zapping for release builds
Performance and stability improvements
Reviewers: dcarney,
Message:
This relands a previous CL together with a fix. Review instructions:
- Patch set #1: Dupe of https://codereview.chromium.org/25164003/
- Patch set #2: Fix for failures in layout tests.
Description:
Defer allocation of native function literals.
Reviewers: Jakob, danno,
Message:
PTAL.
Description:
Remove unnecessary MarkAsDeferredCalling when changing a tagged value to
double
Please review this at https://codereview.chromium.org/25373003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -4
LGTM.
https://codereview.chromium.org/25037002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://chromiumcodereview.appspot.com/25090002/diff/4001/src/ic.h
File src/ic.h (right):
https://chromiumcodereview.appspot.com/25090002/diff/4001/src/ic.h#newcode544
src/ic.h:544: if (strict_mode() == kStrictMode) {
Let's use strict_mode_ to be consistent with other places or change
LGTM
https://codereview.chromium.org/25279002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 17031
Author: yang...@chromium.org
Date: Tue Oct 1 08:40:33 2013 UTC
Log: Initialize flag before usage.
This fixes a crash when running with --concurrent-osr.
R=u...@chromium.org, dslo...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25279002
LGTM
https://chromiumcodereview.appspot.com/25238002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
LGTM
https://codereview.chromium.org/25231005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://chromiumcodereview.appspot.com/25228005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://chromiumcodereview.appspot.com/25253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://chromiumcodereview.appspot.com/24104006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/25473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Yang,
Message:
PTAL.
Description:
Refactor translation opcode a little in the deoptimization
Please review this at https://codereview.chromium.org/25480003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+29, -57 lines):
M src/deoptimizer.h
M
Revision: 17032
Author: ma...@chromium.org
Date: Tue Oct 1 09:24:13 2013 UTC
Log: Refactor PropertyCallbackInfo FunctionCallbackInfo, part 3.
This CL starts using positive array indices instead of negative array
indices
for the PropertyCallbackInfo and FunctionCallbackInfo fields.
Committed patchset #4 manually as r17032 (presubmit successful).
https://codereview.chromium.org/24488006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r17033 (presubmit successful).
https://codereview.chromium.org/24104006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17033
Author: mstarzin...@chromium.org
Date: Tue Oct 1 09:27:03 2013 UTC
Log: Limit entry points into the parser API.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/24104006
http://code.google.com/p/v8/source/detail?r=17033
Modified:
Revision: 17034
Author: verwa...@chromium.org
Date: Tue Oct 1 09:30:07 2013 UTC
Log: Reduce code duplication in IC updating.
BUG=
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25033003
http://code.google.com/p/v8/source/detail?r=17034
Modified:
Committed patchset #1 manually as r17034 (presubmit successful).
https://chromiumcodereview.appspot.com/25033003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #2 manually as r17035 (presubmit successful).
https://chromiumcodereview.appspot.com/25090002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17035
Author: verwa...@chromium.org
Date: Tue Oct 1 09:36:34 2013 UTC
Log: Make strict_mode a flag on StoreIC.
BUG=
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25090002
http://code.google.com/p/v8/source/detail?r=17035
Modified:
lgtm
https://chromiumcodereview.appspot.com/25001005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Revision: 17036
Author: verwa...@chromium.org
Date: Tue Oct 1 09:44:35 2013 UTC
Log: Cleanup in IC patching.
BUG=
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25001005
http://code.google.com/p/v8/source/detail?r=17036
Modified:
Committed patchset #1 manually as r17036 (presubmit successful).
https://chromiumcodereview.appspot.com/25001005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17037
Author: verwa...@chromium.org
Date: Tue Oct 1 09:47:18 2013 UTC
Log: Always cache the original target in a handle on the IC.
This requires us to always open a handle-scope in the miss handlers.
BUG=
R=u...@chromium.org
Review URL:
Committed patchset #3 manually as r17037 (presubmit successful).
https://chromiumcodereview.appspot.com/25238002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17038
Author: mstarzin...@chromium.org
Date: Tue Oct 1 09:47:37 2013 UTC
Log: Defer allocation of native function literals.
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/25473002
http://code.google.com/p/v8/source/detail?r=17038
Modified:
Committed patchset #2 manually as r17038 (presubmit successful).
https://codereview.chromium.org/25473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17039
Author: verwa...@chromium.org
Date: Tue Oct 1 09:52:24 2013 UTC
Log: Encapsulate IC::State into the IC.
BUG=
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25228005
http://code.google.com/p/v8/source/detail?r=17039
Modified:
Committed patchset #2 manually as r17039 (presubmit successful).
https://chromiumcodereview.appspot.com/25228005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 manually as r17040 (presubmit successful).
https://chromiumcodereview.appspot.com/25253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17040
Author: verwa...@chromium.org
Date: Tue Oct 1 09:55:15 2013 UTC
Log: Move TryRemoveInvalidPrototypeDependentStub onto the IC class.
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25253002
http://code.google.com/p/v8/source/detail?r=17040
Revision: 17041
Author: dcar...@chromium.org
Date: Tue Oct 1 09:56:04 2013 UTC
Log: remove Isolate::Current from ScriptData and Script
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/25037002
http://code.google.com/p/v8/source/detail?r=17041
Modified:
Committed patchset #2 manually as r17041 (presubmit successful).
https://codereview.chromium.org/25037002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: ulan,
Message:
Re-upload since rolling this CL back didn't fix failures.
Webkit failure seems unrelated as well.
Description:
Allow code to be cached in shared maps.
BUG=
Please review this at https://chromiumcodereview.appspot.com/25486002/
SVN Base:
Please take another look. This is a bigger re-write that moves all the logic
into Hydrogen and unifies a bunch of unreachable code handling with deopt
block
handling.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
Revision: 17042
Author: rodolph.perfe...@gmail.com
Date: Tue Oct 1 10:44:00 2013 UTC
Log: ARM: Tweak LoadKeyed.
Avoid corrupting its input.
BUG=none
TEST=none
R=u...@chromium.org
Review URL: https://codereview.chromium.org/25231005
http://code.google.com/p/v8/source/detail?r=17042
Committed patchset #1 manually as r17042 (presubmit successful).
https://codereview.chromium.org/25231005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2013/10/01 09:23:46, haitao.feng wrote:
PTAL.
lgtm.
https://codereview.chromium.org/25480003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
LMBTMN (looks much better to me now; that implies LGTM). Another round of
nits.
https://codereview.chromium.org/22876009/diff/71027/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/22876009/diff/71027/src/flag-definitions.h#newcode297
Committed patchset #1 manually as r17043 (presubmit successful).
https://codereview.chromium.org/25480003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17043
Author: haitao.f...@intel.com
Date: Tue Oct 1 11:18:30 2013 UTC
Log: Refactor translation opcode a little in the deoptimization
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/25480003
http://code.google.com/p/v8/source/detail?r=17043
Modified:
Reviewers: Hannes Payer,
Message:
Hey Hannes,
Here's the fix for the Date.now() Windows issue. PTAL
-- Benedikt
Description:
Always use timeGetTime() for TimeTicks::Now() on Windows.
This way, we also ensure that timeGetTime() is used for Time::Now(),
and thereby Date.now() even if
Comment #8 on issue 2744 by gli...@chromium.org: Meta-Bug: TSAN finds many
data races in V8
http://code.google.com/p/v8/issues/detail?id=2744
I've reran the tests for r17043 of the bleeding edge. Here's the result of
`cat log | sort | uniq -c | sort -nr`:
352 SUMMARY:
lgtm
https://codereview.chromium.org/23530066/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r17044 (presubmit successful).
https://codereview.chromium.org/23530066/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17044
Author: bmeu...@chromium.org
Date: Tue Oct 1 11:56:42 2013 UTC
Log: Lazily save double registers for HCallRuntime instructions within
Hydrogen code stubs.
Right now we eagerly save all allocatable double registers upon
entry to every Hydrogen code stub that uses
LGTM with comments.
https://codereview.chromium.org/22876009/diff/71027/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/arm/lithium-arm.cc#newcode872
src/arm/lithium-arm.cc:872: new(zone())
Reviewers: titzer,
Description:
Improve queuing for concurrent OSR.
Specifically, this includes:
- Encapsulating data structure for osr buffer into CyclicBuffer
- Use the new CyclicQueue instead of UnboundedQueue to queue new jobs.
We can enqueue and dequeue a CyclicQueue on both ends in
lgtm
https://chromiumcodereview.appspot.com/25486002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://chromiumcodereview.appspot.com/25260002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Yang,
Description:
Handlify JSObject::LookupAccessor method.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/25508002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+44, -29 lines):
M src/objects.h
M src/objects.cc
lgtm
https://chromiumcodereview.appspot.com/25263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Yang,
Description:
Remove obsolete AssertNoContextChangeWithHandleScope.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/25513002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+24, -43 lines):
M src/isolate.h
M
LGTM, thx.
https://codereview.chromium.org/25053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
On 2013/10/01 12:26:18, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/25508002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
Already looking good...
https://codereview.chromium.org/23477061/diff/25002/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/23477061/diff/25002/src/heap.h#newcode1889
src/heap.h:1889:
What about?
- Making weak_object_to_code, weak_object_to_code_address, and
Revision: 17045
Author: verwa...@chromium.org
Date: Tue Oct 1 13:13:39 2013 UTC
Log: Allow code to be cached in shared maps.
BUG=
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25486002
http://code.google.com/p/v8/source/detail?r=17045
Modified:
Committed patchset #1 manually as r17045 (presubmit successful).
https://chromiumcodereview.appspot.com/25486002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 manually as r17046 (presubmit successful).
https://chromiumcodereview.appspot.com/25263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17046
Author: verwa...@chromium.org
Date: Tue Oct 1 13:17:04 2013 UTC
Log: Encapsulate extra_ic_state in CallICs.
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25263002
http://code.google.com/p/v8/source/detail?r=17046
Modified:
I've re-structured the if/else branch to be more in line with my original
intention (as Jakob said, there the 2GB check I was doing was
effectively a
= 4GB check since there is not many systems with memory between 2-4GB.
PTAL.
Reviewers: Michael Starzinger,
Description:
Handlify Runtime_GetPrototype and Runtime_GetOwnProperty.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/25478003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+65, -46
On 2013/10/01 13:41:14, Yang wrote:
First baby steps at handlifying stuff. More to follow.
https://codereview.chromium.org/25478003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: ulan,
Message:
PTAL
Description:
Cleanup map deprecation handling in the ICs
Please review this at https://chromiumcodereview.appspot.com/25529002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+61, -89 lines):
M src/ic.cc
--
--
v8-dev mailing
Committed patchset #2 manually as r17047 (presubmit successful).
https://codereview.chromium.org/25053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17047
Author: yu...@chromium.org
Date: Tue Oct 1 13:54:53 2013 UTC
Log: Fix threading problems in test-api when running on simulator
Sampler can retrieve current simulator for profiled isolate from its
ThreadLocalTop without calls to Isolate::FindPerThreadDataForThread
lgtm
https://codereview.chromium.org/24978006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/24999002/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/24999002/diff/1/src/isolate.h#newcode1254
src/isolate.h:1254: bool is_default_isolate_;
nit: Let's move this down to the other boolean flags around line 1316,
easier
Committed patchset #1 manually as r17048 (presubmit successful).
https://codereview.chromium.org/25508002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17048
Author: mstarzin...@chromium.org
Date: Tue Oct 1 14:26:15 2013 UTC
Log: Handlify JSObject::LookupAccessor method.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/25508002
http://code.google.com/p/v8/source/detail?r=17048
Modified:
Committed patchset #2 manually as r17049 (presubmit successful).
https://codereview.chromium.org/24999002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17049
Author: dcar...@chromium.org
Date: Tue Oct 1 14:26:53 2013 UTC
Log: lazy instantiation of the default isolate
this cl also moves all accesses to the default isolate behind
EnsureDefaultIsolate
R=mstarzin...@chromium.org
BUG=
Review URL:
Updates:
Status: Fixed
Comment #11 on issue 2874 by yu...@chromium.org: Threading problems in
test-api
http://code.google.com/p/v8/issues/detail?id=2874
Fix landed in r17047.
--
You received this message because this project is configured to send all
issue notifications to this
LGTM with nits.
https://codereview.chromium.org/25478003/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/25478003/diff/1/src/isolate.h#newcode757
src/isolate.h:757: bool MayNamedAccessWrapper(HandleJSObject receiver,
At some point we want these functions to be
Thank you, addressed comments.
https://codereview.chromium.org/23477061/diff/25002/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/23477061/diff/25002/src/heap.h#newcode1889
src/heap.h:1889:
On 2013/10/01 13:13:50, Hannes Payer wrote:
What about?
- Making
Committed patchset #3 manually as r17050 (presubmit successful).
https://codereview.chromium.org/25513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17050
Author: mstarzin...@chromium.org
Date: Tue Oct 1 14:53:45 2013 UTC
Log: Remove obsolete AssertNoContextChangeWithHandleScope.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/25513002
http://code.google.com/p/v8/source/detail?r=17050
Modified:
Reviewers: Hannes Payer,
Description:
Turn Heap::AllowedToBeMigrated checks into asserts.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/25544002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -9 lines):
M src/heap.cc
M
LGTM
https://codereview.chromium.org/25544002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #1 manually as r17051 (presubmit successful).
https://codereview.chromium.org/25544002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17051
Author: mstarzin...@chromium.org
Date: Tue Oct 1 15:06:59 2013 UTC
Log: Turn Heap::AllowedToBeMigrated checks into asserts.
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/25544002
http://code.google.com/p/v8/source/detail?r=17051
Modified:
Committed patchset #6 manually as r17052 (presubmit successful).
https://codereview.chromium.org/24072013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/25453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Remove deprecated JSObject::GetLocalPropertyType method.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/25453003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -28 lines):
M
On 2013/10/01 14:46:18, Michael Starzinger wrote:
LGTM with nits.
https://codereview.chromium.org/25478003/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/25478003/diff/1/src/isolate.h#newcode757
src/isolate.h:757: bool MayNamedAccessWrapper(HandleJSObject
Reviewers: danno, Jakob, marja, Paul Lind, kisg, palfia,
Description:
MIPS: Refactor PropertyCallbackInfo FunctionCallbackInfo, part 3.
Port r17032 (3bdce1d)
Original commit message:
This CL starts using positive array indices instead of negative array
indices
for the PropertyCallbackInfo
1 - 100 of 132 matches
Mail list logo
