[v8-dev] Re: Issue 3024 in v8: TryCatch::Exception Crashing on Access after Checks.

2013-11-26 Thread codesite-noreply
Updates: Status: PendingFurtherInfo Comment #6 on issue 3024 by svenpa...@chromium.org: TryCatch::Exception Crashing on Access after Checks. http://code.google.com/p/v8/issues/detail?id=3024 We can't debug other people's code, so if you want somebody to look at a problem, please

[v8-dev] Re: Issue 3024 in v8: TryCatch::Exception Crashing on Access after Checks.

2013-11-26 Thread codesite-noreply
Comment #7 on issue 3024 by ghla...@gmail.com: TryCatch::Exception Crashing on Access after Checks. http://code.google.com/p/v8/issues/detail?id=3024 I'll have one shortly, have to gut a major amount of the code. -- You received this message because this project is configured to send all

[v8-dev] Re: Issue 3008 in v8: Performance regression in Browsermark2.0 array-blur due to Literal array creation change

2013-11-26 Thread codesite-noreply
Updates: Status: Fixed Comment #3 on issue 3008 by mvstan...@chromium.org: Performance regression in Browsermark2.0 array-blur due to Literal array creation change http://code.google.com/p/v8/issues/detail?id=3008 As reported by weiliang@intel.com. 7-8% of the regression

[v8-dev] Re: Fix generate_trig_table build target. (issue 85893002)

2013-11-26 Thread yangguo
Committed patchset #1 manually as r18067. https://codereview.chromium.org/85893002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r18067 committed - Fix generate_trig_table build target....

2013-11-26 Thread codesite-noreply
Revision: 18067 Author: yang...@chromium.org Date: Tue Nov 26 08:50:15 2013 UTC Log: Fix generate_trig_table build target. It now closely resembles the js2c target, so that we only have one platform to run it on (either 'host' or 'target'). This way we do not run into warnings when

[v8-dev] Re: Add Isolate* parameter to static API methods that don't take one. (issue 84833006)

2013-11-26 Thread svenpanne
LGTM with a nit. Furthermore (as discussed offline), we might consider changing all those class Foo { static LocalFoo New(Isolate*, ...); } to class Isolate { LocalFoo NewFoo(...); } This has pros and cons, but at least keep the possibility in mind.

[v8-dev] Re: Issue 3001 in v8: Provide support for defining custom, per-Isolate memory allocators

2013-11-26 Thread codesite-noreply
Comment #8 on issue 3001 by svenpa...@chromium.org: Provide support for defining custom, per-Isolate memory allocators http://code.google.com/p/v8/issues/detail?id=3001 I am not 100% sure what the tool measures in detail, but as was already stated above, the dominating source of malloc is

[v8-dev] Re: Add Isolate* parameter to static API methods that don't take one. (issue 84833006)

2013-11-26 Thread dcarney
On 2013/11/26 08:57:39, Sven Panne wrote: LGTM with a nit. Furthermore (as discussed offline), we might consider changing all those class Foo { static LocalFoo New(Isolate*, ...); } to class Isolate { LocalFoo NewFoo(...); } This has pros and cons, but

[v8-dev] Re: Issue 3024 in v8: TryCatch::Exception Crashing on Access after Checks.

2013-11-26 Thread codesite-noreply
Comment #8 on issue 3024 by ghla...@gmail.com: TryCatch::Exception Crashing on Access after Checks. http://code.google.com/p/v8/issues/detail?id=3024 https://dl.dropboxusercontent.com/u/6638/V8Error3024.rar VS2012 sln, pre-compiled debug build, two test files with roughly the same

[v8-dev] Re: Add Isolate* parameter to static API methods that don't take one. (issue 84833006)

2013-11-26 Thread jochen
Committed patchset #3 manually as r18068. https://codereview.chromium.org/84833006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r18068 committed - Add Isolate* parameter to static API methods that don't take one....

2013-11-26 Thread codesite-noreply
Revision: 18068 Author: joc...@chromium.org Date: Tue Nov 26 09:45:17 2013 UTC Log: Add Isolate* parameter to static API methods that don't take one. We cannot yet deprecate the versions that don't take one, because there's too much test code in v8 using them. To keep this CL small

[v8-dev] Re: Issue 3001 in v8: Provide support for defining custom, per-Isolate memory allocators

2013-11-26 Thread codesite-noreply
Comment #9 on issue 3001 by the.lightman: Provide support for defining custom, per-Isolate memory allocators http://code.google.com/p/v8/issues/detail?id=3001 The tool keeps a counter of the memory of bytes allocated via malloc(), and another for the peak value. Calls to memory-related

[v8-dev] Re: Issue 3001 in v8: Provide support for defining custom, per-Isolate memory allocators

2013-11-26 Thread codesite-noreply
Comment #10 on issue 3001 by yang...@chromium.org: Provide support for defining custom, per-Isolate memory allocators http://code.google.com/p/v8/issues/detail?id=3001 Liked previously mentioned, not all memory in V8 is allocated with malloc. Most prominently, the javascript heap is not.

[v8-dev] Re: Make some ARM test cases faster. (issue 85473004)

2013-11-26 Thread yangguo
Committed patchset #1 manually as r18069 (presubmit successful). https://codereview.chromium.org/85473004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18069 committed - Make some ARM test cases faster....

2013-11-26 Thread codesite-noreply
Revision: 18069 Author: yang...@chromium.org Date: Tue Nov 26 10:43:44 2013 UTC Log: Make some ARM test cases faster. R=ish...@chromium.org Review URL: https://codereview.chromium.org/85473004 http://code.google.com/p/v8/source/detail?r=18069 Modified:

[v8-dev] Re: Issue 3001 in v8: Provide support for defining custom, per-Isolate memory allocators

2013-11-26 Thread codesite-noreply
Updates: Status: WorkingAsIntended Comment #11 on issue 3001 by jkumme...@chromium.org: Provide support for defining custom, per-Isolate memory allocators http://code.google.com/p/v8/issues/detail?id=3001 What Sven said. You're measuring mostly Zone memory. That looks like C++ heap

[v8-dev] Re: Provide freeBuffer() primitive for testing under ASan. (issue 85883002)

2013-11-26 Thread machenbach
Where are free-buffer-extension.*? https://codereview.chromium.org/85883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Split Persistent into Persistent and UniquePersistent (issue 88013002)

2013-11-26 Thread dcarney
Reviewers: Sven Panne, Message: ptal the UniquePersistent code is taken from https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/scoped_ptr.hq=scoped_ptrsq=package:chromiumtype=cs we may need a few extra features such as swap() and PassAs() to be able to replace

[v8-dev] [v8] r18070 committed - Speed up long-running test cases....

2013-11-26 Thread codesite-noreply
Revision: 18070 Author: yang...@chromium.org Date: Tue Nov 26 11:32:39 2013 UTC Log: Speed up long-running test cases. R=ish...@chromium.org Review URL: https://codereview.chromium.org/85163003 http://code.google.com/p/v8/source/detail?r=18070 Modified:

[v8-dev] Re: Speed up long-running test cases. (issue 85163003)

2013-11-26 Thread yangguo
Committed patchset #1 manually as r18070 (presubmit successful). https://codereview.chromium.org/85163003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Split Persistent into Persistent and UniquePersistent (issue 88013002)

2013-11-26 Thread haraken
On 2013/11/26 11:28:43, dcarney wrote: ptal the UniquePersistent code is taken from https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/scoped_ptr.hq=scoped_ptrsq=package:chromiumtype=cs we may need a few extra features such as swap() and PassAs() to be able to replace

[v8-dev] Implement Math.ceil via Math.floor. (issue 88053002)

2013-11-26 Thread svenpanne
Reviewers: Jakob, Description: Implement Math.ceil via Math.floor. This way we get all the Crankshaft goodness and avoid always going through the runtime: Less code + even some small speedup in Kraken. Please review this at https://codereview.chromium.org/88053002/ SVN Base:

[v8-dev] Disable load elimination. (issue 88073002)

2013-11-26 Thread titzer
Reviewers: Yang, Description: Disable load elimination. BUG= Please review this at https://codereview.chromium.org/88073002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/flag-definitions.h Index: src/flag-definitions.h diff --git

[v8-dev] Re: Disable load elimination. (issue 88073002)

2013-11-26 Thread titzer
Committed patchset #1 manually as r18071 (presubmit successful). https://codereview.chromium.org/88073002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Disable load elimination. (issue 88073002)

2013-11-26 Thread yangguo
On 2013/11/26 12:15:11, titzer wrote: LGTM. Thanks! https://codereview.chromium.org/88073002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe

[v8-dev] [v8] r18071 committed - Disable load elimination....

2013-11-26 Thread codesite-noreply
Revision: 18071 Author: tit...@chromium.org Date: Tue Nov 26 12:18:27 2013 UTC Log: Disable load elimination. BUG= R=yang...@chromium.org Review URL: https://codereview.chromium.org/88073002 http://code.google.com/p/v8/source/detail?r=18071 Modified:

[v8-dev] Re: Implement Math.ceil via Math.floor. (issue 88053002)

2013-11-26 Thread jkummerow
LGTM. You're lucky this works out for -0 ;-) https://codereview.chromium.org/88053002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: Implement Math.ceil via Math.floor. (issue 88053002)

2013-11-26 Thread svenpanne
On 2013/11/26 12:26:32, Jakob wrote: LGTM. You're lucky this works out for -0 ;-) That's not luck, that's the spec: ;-) 15.8.2.6 ceil (x) [...] The value of Math.ceil(x) is the same as the value of -Math.floor(-x). https://codereview.chromium.org/88053002/ -- -- v8-dev mailing

[v8-dev] [v8] r18072 committed - Implement Math.ceil via Math.floor....

2013-11-26 Thread codesite-noreply
Revision: 18072 Author: svenpa...@chromium.org Date: Tue Nov 26 12:29:47 2013 UTC Log: Implement Math.ceil via Math.floor. This way we get all the Crankshaft goodness and avoid always going through the runtime: Less code + even some small speedup in Kraken. R=jkumme...@chromium.org

[v8-dev] Re: Implement Math.ceil via Math.floor. (issue 88053002)

2013-11-26 Thread svenpanne
Committed patchset #1 manually as r18072 (presubmit successful). https://codereview.chromium.org/88053002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Removed dead ceiling function. (issue 88133002)

2013-11-26 Thread svenpanne
Reviewers: Benedikt Meurer, Description: Removed dead ceiling function. Please review this at https://codereview.chromium.org/88133002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+0, -12 lines): src/platform-posix.cc src/platform-win32.cc

[v8-dev] Flatten cons string for single character substrings. (issue 88143002)

2013-11-26 Thread yangguo
Reviewers: Benedikt Meurer, Description: Flatten cons string for single character substrings. For substrings of non-flat cons strings, we bail out to runtime. For single character substrings, we forget to flatten it. This causes successive bailouts. R=bmeu...@chromium.org BUG=323041 Please

[v8-dev] Re: Removed dead ceiling function. (issue 88133002)

2013-11-26 Thread bmeurer
lgtm https://chromiumcodereview.appspot.com/88133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] Flatten cons string for single character substrings. (issue 88173002)

2013-11-26 Thread yangguo
Reviewers: Benedikt Meurer, Message: please take a look. Description: Flatten cons string for single character substrings. For substrings of non-flat cons strings, we bail out to runtime. For single character substrings, we forget to flatten it. This causes successive bailouts.

[v8-dev] Re: Flatten cons string for single character substrings. (issue 88173002)

2013-11-26 Thread bmeurer
LGTM https://codereview.chromium.org/88173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Range info propagation through HBoundsCheck. (issue 86233002)

2013-11-26 Thread titzer
lgtm https://codereview.chromium.org/86233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread ulan
https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc File src/lexer/experimental-scanner.cc (right): https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc#newcode36 src/lexer/experimental-scanner.cc:36: if (!scanners_) Either one

[v8-dev] Re: Implement global check elimination using the HFlowEngine. (issue 46883009)

2013-11-26 Thread titzer
On 2013/10/31 11:16:13, mvstanton wrote: Hi Ben, Looking pretty cool. Some comments around kChangesMaps and stat reporting. --Michael https://codereview.chromium.org/46883009/diff/1/src/hydrogen-check-elimination.cc File src/hydrogen-check-elimination.cc (right):

[v8-dev] Re: Harmony promises (issue 64223010)

2013-11-26 Thread rossberg
https://codereview.chromium.org/64223010/diff/1/src/object-observe.js File src/object-observe.js (right): https://codereview.chromium.org/64223010/diff/1/src/object-observe.js#newcode387 src/object-observe.js:387: %SetMicrotasksPending(true); On 2013/11/14 21:08:46, rafaelw wrote: nit: All of

[v8-dev] Re: Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread dcarney
the source string needs to be flattened https://codereview.chromium.org/88203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group

[v8-dev] Re: Issue 3019 in v8: Need a better way to stringify functions in error messages

2013-11-26 Thread codesite-noreply
Comment #1 on issue 3019 by yang...@chromium.org: Need a better way to stringify functions in error messages http://code.google.com/p/v8/issues/detail?id=3019 I propose cutting off the string at a certain length and using ellipsis (...). -- You received this message because this project

[v8-dev] Re: Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread marja
Reviewers: ulan, Message: - and added a check that the string is flat when ExperimentalScanner gets it. https://codereview.chromium.org/88203002/diff/20001/src/lexer/experimental-scanner.cc File src/lexer/experimental-scanner.cc (right):

[v8-dev] [v8] r18073 committed - Experimental scanner += API which takes HandleString....

2013-11-26 Thread codesite-noreply
Revision: 18073 Author: ma...@chromium.org Date: Tue Nov 26 13:37:30 2013 UTC Log: Experimental scanner += API which takes HandleString. R=u...@chromium.org BUG= Review URL: https://codereview.chromium.org/88203002 http://code.google.com/p/v8/source/detail?r=18073 Added:

[v8-dev] Re: Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread marja
Committed patchset #3 manually as r18073. https://codereview.chromium.org/88203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Re: Provide freeBuffer() primitive for testing under ASan. (issue 85883002)

2013-11-26 Thread dslomov
On 2013/11/26 11:20:08, machenbach wrote: Where are free-buffer-extension.*? Oops, sorry. Added. https://codereview.chromium.org/85883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the

[v8-dev] Re: Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread dcarney
https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h File src/lexer/experimental-scanner.h (right): https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h#newcode276 src/lexer/experimental-scanner.h:276: YYCTYPE yych; yych should be

[v8-dev] Re: Experimental scanner += API which takes HandleString. (issue 88203002)

2013-11-26 Thread ulan
LGTM https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h File src/lexer/experimental-scanner.h (right): https://codereview.chromium.org/88203002/diff/40001/src/lexer/experimental-scanner.h#newcode245 src/lexer/experimental-scanner.h:245:

[v8-dev] Increase test runner speed. (issue 88343002)

2013-11-26 Thread machenbach
Reviewers: Yang, Message: PTAL Description: Increase test runner speed. Let the test runner preserve the order of test suites to let suites with long running tests run first. Mark some tests as slow that can now be skipped via --slow-tests=skip. BUG= Please review this at

[v8-dev] Experimental parser: cleanup. (issue 88353002)

2013-11-26 Thread marja
Reviewers: dcarney, Message: Committed patchset #1 manually as r18074. Description: Experimental parser: cleanup. BUG= TBR=dcar...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18074 Please review this at https://codereview.chromium.org/88353002/ SVN Base:

[v8-dev] [v8] r18074 committed - Experimental parser: cleanup....

2013-11-26 Thread codesite-noreply
Revision: 18074 Author: ma...@chromium.org Date: Tue Nov 26 13:46:57 2013 UTC Log: Experimental parser: cleanup. BUG= TBR=dcar...@chromium.org Review URL: https://codereview.chromium.org/88353002 http://code.google.com/p/v8/source/detail?r=18074 Modified:

[v8-dev] Prepare push to trunk. Now working on version 3.23.13. (issue 88363002)

2013-11-26 Thread machenbach
Reviewers: Yang, Description: Prepare push to trunk. Now working on version 3.23.13. R=yang...@chromium.org Please review this at https://codereview.chromium.org/88363002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+6, -1 lines): M ChangeLog M

[v8-dev] Re: Prepare push to trunk. Now working on version 3.23.13. (issue 88363002)

2013-11-26 Thread yangguo
On 2013/11/26 13:48:37, machenbach wrote: LGTM. https://codereview.chromium.org/88363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] Re: Prepare push to trunk. Now working on version 3.23.13. (issue 88363002)

2013-11-26 Thread machenbach
Committed patchset #1 manually as r18075 (presubmit successful). https://codereview.chromium.org/88363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18075 committed - Prepare push to trunk. Now working on version 3.23.13....

2013-11-26 Thread codesite-noreply
Revision: 18075 Author: machenb...@chromium.org Date: Tue Nov 26 13:50:16 2013 UTC Log: Prepare push to trunk. Now working on version 3.23.13. R=yang...@chromium.org Review URL: https://codereview.chromium.org/88363002 http://code.google.com/p/v8/source/detail?r=18075 Modified:

[v8-dev] Re: Range info propagation through HBoundsCheck. (issue 86233002)

2013-11-26 Thread ishell
Committed patchset #1 manually as r18078 (presubmit successful). https://codereview.chromium.org/86233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18077 committed - Tagging version 3.23.12

2013-11-26 Thread codesite-noreply
Revision: 18077 Author: machenb...@chromium.org Date: Tue Nov 26 13:51:26 2013 UTC Log: Tagging version 3.23.12 http://code.google.com/p/v8/source/detail?r=18077 Added: /tags/3.23.12 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] [v8] r18078 committed - Range info propagation through HBoundsCheck....

2013-11-26 Thread codesite-noreply
Revision: 18078 Author: ish...@chromium.org Date: Tue Nov 26 13:52:44 2013 UTC Log: Range info propagation through HBoundsCheck. R=tit...@chromium.org Review URL: https://codereview.chromium.org/86233002 http://code.google.com/p/v8/source/detail?r=18078 Modified:

[v8-dev] [v8] r18079 committed - Removed dead ceiling function....

2013-11-26 Thread codesite-noreply
Revision: 18079 Author: svenpa...@chromium.org Date: Tue Nov 26 13:55:06 2013 UTC Log: Removed dead ceiling function. R=bmeu...@chromium.org Review URL: https://codereview.chromium.org/88133002 http://code.google.com/p/v8/source/detail?r=18079 Modified:

[v8-dev] Re: Removed dead ceiling function. (issue 88133002)

2013-11-26 Thread svenpanne
Committed patchset #1 manually as r18079 (presubmit successful). https://codereview.chromium.org/88133002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] ARM: Optimize Integer32ToSmi (issue 88383002)

2013-11-26 Thread m . m . capewell
Reviewers: ulan, danno, Description: ARM: Optimize Integer32ToSmi Optimize register constraints and code generated for Integer32ToSmi Lithium instruction. TEST=none BUG= Please review this at https://codereview.chromium.org/88383002/ SVN Base:

[v8-dev] Shorten autogenerated error message. (issue 88393002)

2013-11-26 Thread yangguo
Reviewers: rossberg, Description: Shorten autogenerated error message. R=rossb...@chromium.org BUG=v8:3019 Please review this at https://codereview.chromium.org/88393002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+31, -8 lines): M src/messages.js A +

[v8-dev] [v8] r18080 committed - Experimental parser: rename YYCTYPE...

2013-11-26 Thread codesite-noreply
Revision: 18080 Author: dcar...@chromium.org Date: Tue Nov 26 14:07:28 2013 UTC Log: Experimental parser: rename YYCTYPE TBR=ma...@chromium.org BUG= Review URL: https://codereview.chromium.org/88383003 http://code.google.com/p/v8/source/detail?r=18080 Modified:

[v8-dev] Experimental parser: rename YYCTYPE (issue 88383003)

2013-11-26 Thread dcarney
Reviewers: marja, Message: Committed patchset #1 manually as r18080 (presubmit successful). Description: Experimental parser: rename YYCTYPE TBR=ma...@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18080 Please review this at

[v8-dev] Re: Issue 3019 in v8: Need a better way to stringify functions in error messages

2013-11-26 Thread codesite-noreply
Updates: Status: Accepted Owner: yang...@chromium.org Comment #2 on issue 3019 by yang...@chromium.org: Need a better way to stringify functions in error messages http://code.google.com/p/v8/issues/detail?id=3019 Proposed fix: https://codereview.chromium.org/88393002/ -- You

[v8-dev] Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry (issue 88043002)

2013-11-26 Thread rmcilroy
Reviewers: ulan, Message: Ulan, please review this change. JFB, Rodolph and Benedikt, FYI (or review too if you would like to). Description: Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry Third stage of implementing an out-of-line constant pool for

Re: [v8-dev] ARM: Optimize Integer32ToSmi (issue 88383002)

2013-11-26 Thread ulan
LGTM https://codereview.chromium.org/88383002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Shorten autogenerated error message. (issue 88393002)

2013-11-26 Thread yangguo
On 2013/11/26 14:06:49, Yang wrote: I did make sure that webkit layout tests are fine with this change. https://codereview.chromium.org/88393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to

[v8-dev] Re: Flatten cons string for single character substrings. (issue 88173002)

2013-11-26 Thread yangguo
Committed patchset #1 manually as r18081 (presubmit successful). https://codereview.chromium.org/88173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18081 committed - Flatten cons string for single character substrings....

2013-11-26 Thread codesite-noreply
Revision: 18081 Author: yang...@chromium.org Date: Tue Nov 26 14:21:46 2013 UTC Log: Flatten cons string for single character substrings. For substrings of non-flat cons strings, we bail out to runtime. For single character substrings, we forget to flatten it. This causes successive

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Updates: Status: WorkingAsIntended Comment #1 on issue 3025 by yang...@chromium.org: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 I think it's not an issue with toString. 0x8800 should be 9223372036854777856,

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Comment #2 on issue 3025 by jkumme...@chromium.org: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 Works fine on ia32.release :-) The behavior you describe happens on ia32.debug as well as x64.{release,debug}. This may be WAI.

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Updates: Status: New Comment #3 on issue 3025 by yang...@chromium.org: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 Hm... after thinking for a bit, I'd like to retract my position. 0x8800 does fit exactly in a

[v8-dev] Re: Provide freeBuffer() primitive for testing under ASan. (issue 85883002)

2013-11-26 Thread machenbach
Could you add a test case that exercises this extension? https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc#newcode44 src/bootstrapper.cc:44: #include

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Comment #4 on issue 3025 by l...@google.com: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 Yes, the number is exactly representable as a double (and it's, not by coincidence, the first such that isn't an int64_t and that also

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Comment #5 on issue 3025 by yang...@chromium.org: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 This only happens on x64, since ia32's fmod (at least with GCC) uses extended precision. -- You received this message because this

[v8-dev] Re: Provide freeBuffer() primitive for testing under ASan. (issue 85883002)

2013-11-26 Thread dslomov
The test for this extension should be a part of chromium's tool sanity tests. https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc#newcode44 src/bootstrapper.cc:44:

[v8-dev] Make optimized debug builds compile with all optimizations. (issue 88563002)

2013-11-26 Thread machenbach
Reviewers: Yang, Message: PTAL Description: Make optimized debug builds compile with all optimizations. This results in a speed-up of around 30% on all architectures. For local developer builds only. The bots will continue to use level 1 for now. BUG= Please review this at

[v8-dev] Re: Make optimized debug builds compile with all optimizations. (issue 88563002)

2013-11-26 Thread yangguo
On 2013/11/26 15:26:24, machenbach wrote: PTAL LGTM. https://codereview.chromium.org/88563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe

[v8-dev] Re: Issue 3025 in v8: number.toString(5) doesn't generate the correct result.

2013-11-26 Thread codesite-noreply
Comment #6 on issue 3025 by yang...@chromium.org: number.toString(5) doesn't generate the correct result. http://code.google.com/p/v8/issues/detail?id=3025 Jakobs proposed fix solves the issue. I'll upload a CL for this. -- You received this message because this project is configured to

[v8-dev] Increase precision for base conversion for large integers. (issue 88583002)

2013-11-26 Thread yangguo
Reviewers: Jakob, Description: Increase precision for base conversion for large integers. R=jkumme...@chromium.org BUG=v8:3025 LOG=Y Please review this at https://codereview.chromium.org/88583002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+8, -6 lines):

[v8-dev] Re: Increase precision for base conversion for large integers. (issue 88583002)

2013-11-26 Thread jkummerow
lgtm https://codereview.chromium.org/88583002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Increase precision for base conversion for large integers. (issue 88583002)

2013-11-26 Thread yangguo
Committed patchset #1 manually as r18082 (presubmit successful). https://codereview.chromium.org/88583002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18082 committed - Increase precision for base conversion for large integers....

2013-11-26 Thread codesite-noreply
Revision: 18082 Author: yang...@chromium.org Date: Tue Nov 26 15:48:13 2013 UTC Log: Increase precision for base conversion for large integers. R=jkumme...@chromium.org BUG=v8:3025 LOG=Y Review URL: https://codereview.chromium.org/88583002

[v8-dev] Re: Increase test runner speed. (issue 88343002)

2013-11-26 Thread yangguo
LGTM with comment. https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/88343002/diff/1/test/cctest/cctest.status#newcode67 test/cctest/cctest.status:67: 'test-api/Threading4': [PASS, ['mode == debug',

[v8-dev] Experimental scanner: Add RegExp scanning funcs. (issue 88593002)

2013-11-26 Thread ulan
LGTM https://codereview.chromium.org/88593002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] [v8] r18083 committed - Experimental scanner: Add RegExp scanning funcs....

2013-11-26 Thread codesite-noreply
Revision: 18083 Author: ma...@chromium.org Date: Tue Nov 26 15:58:36 2013 UTC Log: Experimental scanner: Add RegExp scanning funcs. (I.e., copy them over from Scanner.) BUG= R=u...@chromium.org Review URL: https://codereview.chromium.org/88593002

[v8-dev] Re: Experimental scanner: Add RegExp scanning funcs. (issue 88593002)

2013-11-26 Thread marja
Reviewers: ulan, Message: Committed patchset #2 manually as r18083. Description: Experimental scanner: Add RegExp scanning funcs. (I.e., copy them over from Scanner.) BUG= R=u...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18083 Please review this at

Re: [v8-dev] ARM: Optimize Integer32ToSmi (issue 88383002)

2013-11-26 Thread m . m . capewell
Committed patchset #1 manually as r18084 (presubmit successful). https://codereview.chromium.org/88383002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18084 committed - ARM: Optimize Integer32ToSmi...

2013-11-26 Thread codesite-noreply
Revision: 18084 Author: m.m.capew...@googlemail.com Date: Tue Nov 26 16:34:13 2013 UTC Log: ARM: Optimize Integer32ToSmi Optimize register constraints and code generated for Integer32ToSmi Lithium instruction. TEST=none BUG= R=u...@chromium.org Review URL:

[v8-dev] Re: Provide freeBuffer() primitive for testing under ASan. (issue 85883002)

2013-11-26 Thread machenbach
LGTM https://codereview.chromium.org/85883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Make optimized debug builds compile with all optimizations. (issue 88563002)

2013-11-26 Thread machenbach
Committed patchset #1 manually as r18085 (presubmit successful). https://codereview.chromium.org/88563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r18085 committed - Make optimized debug builds compile with all optimizations....

2013-11-26 Thread codesite-noreply
Revision: 18085 Author: machenb...@chromium.org Date: Tue Nov 26 16:48:55 2013 UTC Log: Make optimized debug builds compile with all optimizations. This results in a speed-up of around 30% on all architectures. For local developer builds only. The bots will continue to use level 1

[v8-dev] Re: Increase test runner speed. (issue 88343002)

2013-11-26 Thread machenbach
Committed patchset #2 manually as r18086 (presubmit successful). https://codereview.chromium.org/88343002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Increase test runner speed. (issue 88343002)

2013-11-26 Thread machenbach
I marked them all. https://codereview.chromium.org/88343002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] [v8] r18086 committed - Increase test runner speed....

2013-11-26 Thread codesite-noreply
Revision: 18086 Author: machenb...@chromium.org Date: Tue Nov 26 16:53:04 2013 UTC Log: Increase test runner speed. Let the test runner preserve the order of test suites to let suites with long running tests run first. Mark some tests as slow that can now be skipped via

[v8-dev] Re: Out-of-line constant pool on Arm: Stage 3 - Set Constant Pool Pointer on Function Entry (issue 88043002)

2013-11-26 Thread jfb
Could you re-upload? Only the unified diff worked, not the side-by-side, it's much easier to read :-) https://codereview.chromium.org/88043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to

[v8-dev] [v8] r18087 committed - ExperimentalScanner += SeekForward....

2013-11-26 Thread codesite-noreply
Revision: 18087 Author: ma...@chromium.org Date: Tue Nov 26 17:52:31 2013 UTC Log: ExperimentalScanner += SeekForward. TBR=dcar...@chromium.org BUG= Review URL: https://codereview.chromium.org/88823004 http://code.google.com/p/v8/source/detail?r=18087 Modified:

[v8-dev] ExperimentalScanner += SeekForward. (issue 88823004)

2013-11-26 Thread marja
Reviewers: dcarney, Message: Committed patchset #1 manually as r18087. Description: ExperimentalScanner += SeekForward. TBR=dcar...@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18087 Please review this at https://codereview.chromium.org/88823004/ SVN Base:

[v8-dev] Experimental scanner, fixing the previous commit (issue 88783003)

2013-11-26 Thread marja
Reviewers: dcarney, Message: Committed patchset #1 manually as r18088. Description: Experimental scanner, fixing the previous commit TBR=dcar...@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18088 Please review this at https://codereview.chromium.org/88783003/

[v8-dev] [v8] r18088 committed - Experimental scanner, fixing the previous commit...

2013-11-26 Thread codesite-noreply
Revision: 18088 Author: ma...@chromium.org Date: Tue Nov 26 17:56:14 2013 UTC Log: Experimental scanner, fixing the previous commit TBR=dcar...@chromium.org BUG= Review URL: https://codereview.chromium.org/88783003 http://code.google.com/p/v8/source/detail?r=18088 Modified:

  1   2   >