Reviewers: danno,
Message:
Danno: PTAL.
Paul: FYI.
I don't see a convenient way to test this change, so I suggest to test it in
production :-)
Description:
Add per-file OWNERS for MIPS-specific cctests
Please review this at https://codereview.chromium.org/148923003/
SVN Base:
Reviewers: Dmitry Lomov (chromium),
Message:
PTAL.
Description:
Fix in array instance type initialization.
Please review this at https://codereview.chromium.org/134713004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -3 lines):
M src/hydrogen.cc
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc
File test/cctest/test-mementos.cc (right):
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc#newcode45
test/cctest/test-mementos.cc:45: CompileRun(var a = [];);
This is rather
Committed patchset #1 manually as r19047 (presubmit successful).
https://codereview.chromium.org/135153007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19047
Author: svenpa...@chromium.org
Date: Tue Feb 4 08:30:35 2014 UTC
Log: Dispose Isolate at end of cctest.
No measurable change in test running time, we clean up only trivial
known things at disposal time and do not walk the heap, run real
finalizers, etc.
https://codereview.chromium.org/137403009/diff/820001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/137403009/diff/820001/src/arm/code-stubs-arm.cc#newcode3020
src/arm/code-stubs-arm.cc:3020: // Cache the called function in a global
property
Reviewers: marja,
Message:
Committed patchset #2 manually as r19048 (tree was closed).
Description:
Experimental parser: always add all subtrees
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19048
Please review this at
Revision: 19048
Author: dcar...@chromium.org
Date: Tue Feb 4 08:58:24 2014 UTC
Log: Experimental parser: always add all subtrees
TBR=ma...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/141083011
http://code.google.com/p/v8/source/detail?r=19048
Modified:
lgtm, a couple comments.
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc
File test/cctest/test-mementos.cc (right):
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc#newcode45
test/cctest/test-mementos.cc:45: CompileRun(var a =
lgtm. Thanks!
https://codereview.chromium.org/134713004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Igor Sheludko,
Description:
Just initialize elements pointer in fast literal when pre-tenuring.
BUG=
Please review this at https://codereview.chromium.org/148253004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -6 lines):
M src/hydrogen.cc
lgtm
https://codereview.chromium.org/140543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/148253004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/148923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Addressed comments, ptal again
https://codereview.chromium.org/152863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Jakob,
Description:
Check the offset argument of TypedArray.set for fitting into Smi.
R=jkumme...@chromium.org
BUG=340125
LOG=Y
Please review this at https://codereview.chromium.org/145623009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -10
Revision: 19049
Author: svenpa...@chromium.org
Date: Tue Feb 4 09:41:21 2014 UTC
Log: Revert Dispose Isolate at end of cctest.
Things work locally, only the waterfall is unhappy for some arcane reason.
Investigating...
TBR=bmeu...@chromium.org
Review URL:
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 manually as r19049 (tree was closed).
Description:
Revert Dispose Isolate at end of cctest.
Things work locally, only the waterfall is unhappy for some arcane reason.
Investigating...
TBR=bmeu...@chromium.org
Committed:
lgtm
https://codereview.chromium.org/143343006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/143343006/diff/70001/test/cctest/test-heap-profiler.cc#newcode2397
test/cctest/test-heap-profiler.cc:2397: CHECK_EQ(1,
Committed patchset #6 manually as r19050 (presubmit successful).
https://codereview.chromium.org/140543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19050
Author: ma...@chromium.org
Date: Tue Feb 4 09:47:30 2014 UTC
Log: Tests for (pre)parse errors when eval and arguments are found
in inappropriate places.
In addition:
- Fix a bug in parser discovered by the tests (prefix and postfix confused
in an
error
lgtm
https://codereview.chromium.org/145623009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r19051 (presubmit successful).
https://codereview.chromium.org/145623009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19051
Author: dslo...@chromium.org
Date: Tue Feb 4 09:53:05 2014 UTC
Log: Check the offset argument of TypedArray.set for fitting into Smi.
R=jkumme...@chromium.org
BUG=340125
LOG=Y
Review URL: https://codereview.chromium.org/145623009
Committed patchset #1 manually as r19052 (presubmit successful).
https://codereview.chromium.org/148923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19052
Author: jkumme...@chromium.org
Date: Tue Feb 4 09:53:26 2014 UTC
Log: Add per-file OWNERS for MIPS-specific cctests
R=da...@chromium.org
Review URL: https://codereview.chromium.org/148923003
http://code.google.com/p/v8/source/detail?r=19052
Added:
Reviewers: ulan,
Message:
Committed patchset #1 manually as r19053 (tree was closed).
Description:
Revert Tests for (pre)parse errors when eval and arguments are found in
inappropriate places.
Reason: The fixed error message broke some tests.
This reverts r19050.
BUG=
TBR=u...@chromium.org
Revision: 19053
Author: ma...@chromium.org
Date: Tue Feb 4 10:00:36 2014 UTC
Log: Revert Tests for (pre)parse errors when eval and arguments
are found in inappropriate places.
Reason: The fixed error message broke some tests.
This reverts r19050.
BUG=
TBR=u...@chromium.org
lgtm
https://codereview.chromium.org/149063010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM
https://codereview.chromium.org/148943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Benedikt Meurer,
Description:
Remove unused AllocationSpace paramenter from CollectGarbage.
BUG=
Please review this at https://codereview.chromium.org/148943004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -6 lines):
M src/heap-inl.h
M
Revision: 19054
Author: hpa...@chromium.org
Date: Tue Feb 4 10:30:36 2014 UTC
Log: Remove unused AllocationSpace paramenter from CollectGarbage.
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/148943004
http://code.google.com/p/v8/source/detail?r=19054
Committed patchset #1 manually as r19054.
https://codereview.chromium.org/148943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 19055
Author: dcar...@chromium.org
Date: Tue Feb 4 10:36:32 2014 UTC
Log: Experimental parser: cleanup NfaBuilder a bit
TBR=ma...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/144643008
http://code.google.com/p/v8/source/detail?r=19055
Modified:
Reviewers: marja,
Message:
Committed patchset #4 manually as r19055 (presubmit successful).
Description:
Experimental parser: cleanup NfaBuilder a bit
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19055
Please review this at
Committed patchset #1 manually as r19056 (presubmit successful).
https://codereview.chromium.org/148253004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19056
Author: hpa...@chromium.org
Date: Tue Feb 4 10:41:16 2014 UTC
Log: Just initialize elements pointer in fast literal when
pre-tenuring.
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/148253004
Committed patchset #7 manually as r19057 (presubmit successful).
https://codereview.chromium.org/149063010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19057
Author: ish...@chromium.org
Date: Tue Feb 4 10:48:49 2014 UTC
Log: Remake of the load elimination fix made earlier (r18884).
R=tit...@chromium.org, verwa...@chromium.org
Review URL: https://codereview.chromium.org/149063010
Committed patchset #2 manually as r19058 (presubmit successful).
https://codereview.chromium.org/134713004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19058
Author: ish...@chromium.org
Date: Tue Feb 4 10:59:40 2014 UTC
Log: Fix in array instance type initialization.
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/134713004
http://code.google.com/p/v8/source/detail?r=19058
Modified:
Reviewers: m.m.capewell,
Description:
A64: Pregenerate the CEntryStub when saving FP registers.
Please review this at https://codereview.chromium.org/153723002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+3, -4 lines):
M src/a64/code-stubs-a64.cc
Reviewers: baptiste.afsa1, Alexandre Rames,
Description:
A64: Add V8_FINAL and V8_OVERRIDE to Lithium instructions
BUG=
Please review this at https://codereview.chromium.org/153733002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+248, -225 lines):
M
lgtm
https://codereview.chromium.org/153723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 19059
Author: alexandre.ra...@arm.com
Date: Tue Feb 4 11:10:50 2014 UTC
Log: A64: Pregenerate the CEntryStub when saving FP registers.
R=m.m.capew...@googlemail.com
Review URL: https://codereview.chromium.org/153723002
http://code.google.com/p/v8/source/detail?r=19059
Committed patchset #1 manually as r19059 (presubmit successful).
https://codereview.chromium.org/153723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/151603008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: m.m.capewell, Rodolph Perfetta (ARM),
Description:
A64: Synchronize with r16599.
This brings experimental/a64 up to 2013-09-09, and introduces the new
OSR entry point mechanism.
BUG=none
Please review this at https://codereview.chromium.org/151603008/
SVN Base:
lgtm
https://codereview.chromium.org/153733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/151603008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r19060 (presubmit successful).
https://codereview.chromium.org/151603008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r19061 (presubmit successful).
https://codereview.chromium.org/153733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19061
Author: m.m.capew...@googlemail.com
Date: Tue Feb 4 11:24:25 2014 UTC
Log: A64: Add V8_FINAL and V8_OVERRIDE to Lithium instructions
BUG=
R=baptiste.a...@arm.com
Review URL: https://codereview.chromium.org/153733002
http://code.google.com/p/v8/source/detail?r=19061
lgtm
https://codereview.chromium.org/153693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 19062
Author: ma...@chromium.org
Date: Tue Feb 4 11:26:19 2014 UTC
Log: Tests for (pre)parse errors when eval and arguments are found
in inappropriate places.
In addition:
- Fix a bug in parser discovered by the tests (prefix and postfix confused
in an
error message);
Reviewers: ulan,
Message:
Committed patchset #1 manually as r19062 (presubmit successful).
Description:
Tests for (pre)parse errors when eval and arguments are found in
inappropriate places.
In addition:
- Fix a bug in parser discovered by the tests (prefix and postfix confused
in an
error
Committed patchset #5 manually as r19063 (presubmit successful).
https://codereview.chromium.org/143343006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19063
Author: a...@chromium.org
Date: Tue Feb 4 11:43:19 2014 UTC
Log: Add Box object to heap profiler.
LOG=Y
R=u...@chromium.org, yu...@chromium.org
Review URL: https://codereview.chromium.org/143343006
http://code.google.com/p/v8/source/detail?r=19063
Modified:
Status: New
Owner:
New issue 3127 by shee...@gmail.com: Math.random RNG bias
http://code.google.com/p/v8/issues/detail?id=3127
Tried this repeatedly in d8 [version 3.21.17], nodejs 0.10.25 and various
versions of google chrome:
d8 Array.apply(null, Array(1)).reduce(function(a){
Revision: 19064
Author: dcar...@chromium.org
Date: Tue Feb 4 11:58:53 2014 UTC
Log: Experimental parser: support subgraph inlining
TBR=ma...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/138973007
http://code.google.com/p/v8/source/detail?r=19064
Deleted:
Reviewers: marja,
Message:
Committed patchset #1 manually as r19064 (presubmit successful).
Description:
Experimental parser: support subgraph inlining
TBR=ma...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19064
Please review this at
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc
File test/cctest/test-mementos.cc (right):
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc#newcode45
test/cctest/test-mementos.cc:45: CompileRun(var a = [];);
On 2014/02/04
LGTM
https://codereview.chromium.org/152813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: ulan,
Message:
ulan, ptal
Description:
Tests and fixes for (pre)parse errors related to strict reserved words.
This contains the following fixes:
- We had strict_reserved_word and unexpected_strict_reserved, which one to
use
was totally mixed in Parser and PreParser. Removed
https://codereview.chromium.org/146973005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: ulan,
Description:
Don't access stack-allocated variable when it is out of scope. Enable
Isolate
cleanup in cctests again.
Please review this at https://codereview.chromium.org/146973005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -5
Revision: 19065
Author: machenb...@chromium.org
Date: Tue Feb 4 12:09:22 2014 UTC
Log: Edited wiki page UsingGit through web user interface.
http://code.google.com/p/v8/source/detail?r=19065
Modified:
/wiki/UsingGit.wiki
===
---
Committed patchset #3 manually as r19066 (presubmit successful).
https://codereview.chromium.org/152813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19066
Author: hpa...@chromium.org
Date: Tue Feb 4 12:10:30 2014 UTC
Log: Added a test which installs a poisonous memento right after the
new space top pointer.
BUG=
R=bmeu...@chromium.org, mvstan...@chromium.org
Review URL: https://codereview.chromium.org/152813003
lgtm
https://codereview.chromium.org/149253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r19067 (presubmit successful).
https://codereview.chromium.org/149253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19067
Author: ma...@chromium.org
Date: Tue Feb 4 12:19:53 2014 UTC
Log: Tests and fixes for (pre)parse errors related to strict reserved
words.
This contains the following fixes:
- We had strict_reserved_word and unexpected_strict_reserved, which one to
use
was
lgtm
https://codereview.chromium.org/146973005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/152863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 19068
Author: svenpa...@chromium.org
Date: Tue Feb 4 12:23:30 2014 UTC
Log: Don't access stack-allocated variable when it is out of scope.
Enable Isolate cleanup in cctests again.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/146973005
Committed patchset #1 manually as r19068 (presubmit successful).
https://codereview.chromium.org/146973005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19069
Author: verwa...@chromium.org
Date: Tue Feb 4 12:44:15 2014 UTC
Log: Use Type* in crankshaft rather than HeapType.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/152863002
http://code.google.com/p/v8/source/detail?r=19069
Modified:
Committed patchset #2 manually as r19069 (presubmit successful).
https://codereview.chromium.org/152863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Comment #2 on issue 2913 by sanxiyn: debuggersupport=off, broken again
(error: no type named 'Socket' in namespace 'v8::internal')
http://code.google.com/p/v8/issues/detail?id=2913
This seems fixed.
--
You received this message because this project is configured to send all
issue
Reviewers: m.m.capewell, Alexandre Rames, baptiste.afsa1, Rodolph Perfetta
(ARM),
Description:
A64: Synchronize with r16679.
This brings experimental/a64 up to 2013-09-12.
This patch also fixes some misplaced V8_FINAL markers.
BUG=none
Please review this at
lgtm
https://codereview.chromium.org/153773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r19070 (presubmit successful).
https://codereview.chromium.org/153773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Hi Benedikt, hi Danno,
I've responded per our several conversations. Thanks for the help!
--Michael
https://codereview.chromium.org/137403009/diff/820001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
Reviewers: ulan,
Message:
ulan, ptal. This one is less complex than the previous ones.
Description:
Tests and fixes for (pre)parse errors related to future reserved words.
This contains the following fixes:
- PreParser was using an error reserved_word which doesn't exist in
messages.js.
https://codereview.chromium.org/141653009/diff/80001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/141653009/diff/80001/src/hydrogen-check-elimination.cc#newcode189
src/hydrogen-check-elimination.cc:189: HCheckTable*
https://codereview.chromium.org/146023004/diff/140001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/146023004/diff/140001/src/hydrogen.cc#newcode7610
src/hydrogen.cc:7610: HValue * receiver,
Remove space between HValue and *
lgtm
https://codereview.chromium.org/152863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r19071 (presubmit successful).
Description:
Temporarily mark reserved-words-as-property as possibly failing.
V8 is changing an error message and Blink will disable this test
temporarily,
too. This CL will keep the tree green
Revision: 19071
Author: ma...@chromium.org
Date: Tue Feb 4 13:37:34 2014 UTC
Log: Temporarily mark reserved-words-as-property as possibly failing.
V8 is changing an error message and Blink will disable this test
temporarily,
too. This CL will keep the tree green until Blink is
Reviewers: Sven Panne,
Message:
PTAL.
Description:
Cleanup: Unify CodeGenerator class across platforms
Please review this at https://codereview.chromium.org/134643026/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+43, -163 lines):
M src/arm/codegen-arm.h
lgtm
https://codereview.chromium.org/131413008/diff/80001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/131413008/diff/80001/src/promise.js#newcode185
src/promise.js:185: function HandlePromise(value, handler, deferred) {
Nit: call this PromiseHandle for
Revision: 19072
Author: jkumme...@chromium.org
Date: Tue Feb 4 13:53:41 2014 UTC
Log: Cleanup: Unify CodeGenerator class across platforms
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/134643026
http://code.google.com/p/v8/source/detail?r=19072
Modified:
lgtm
https://codereview.chromium.org/134643026/diff/1/src/codegen.h
File src/codegen.h (right):
https://codereview.chromium.org/134643026/diff/1/src/codegen.h#newcode90
src/codegen.h:90: class CodeGenerator {
Hmmm, basically this is now just a namespace and should be refactored
further, but
Committed patchset #1 manually as r19072 (presubmit successful).
https://codereview.chromium.org/134643026/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 19073
Author: pal...@homejinni.com
Date: Tue Feb 4 14:05:46 2014 UTC
Log: MIPS: Fix test-assembler-mips/MIPS10 test.
cvt_l_d() and cvt_d_l() instructions are replaced to cvt_w_d() and
ctv_d_w() because kernel FPU emulator generates illegal instruction for
double - long
Committed as r19073.
https://codereview.chromium.org/133363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: dcarney,
Message:
Please take a look.
Description:
Correctly recognize external strings.
Since r15906, cons strings in old pointer space that are made external
remain cons strings, and point to a newly-allocated external string. This
is because external strings are not allow in the
Updates:
Status: Fixed
Comment #3 on issue 2913 by jkumme...@chromium.org: debuggersupport=off,
broken again (error: no type named 'Socket' in namespace 'v8::internal')
http://code.google.com/p/v8/issues/detail?id=2913
Right, should be fixed in r17025.
--
You received this message
Revision: 19074
Author: joc...@chromium.org
Date: Tue Feb 4 14:36:09 2014 UTC
Log: Add a test for ArgumentsAccessStub::GenerateNewNonStrictSlow
BUG=none
R=u...@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/150543005
http://code.google.com/p/v8/source/detail?r=19074
1 - 100 of 170 matches
Mail list logo
