[v8-dev] Re: ARM64: Refactor instruction selection unit tests. (issue 475823002 by rodolph.perfe...@arm.com)

2014-08-14 Thread bmeurer
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85 test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85: TEST_P(LogicalTest, Parameter) { My understanding was that the name will be concatenated

[v8-dev] Re: ARM64: Refactor instruction selection unit tests. (issue 475823002 by rodolph.perfe...@arm.com)

2014-08-14 Thread bmeurer
On 2014/08/14 at 18:31:07, Benedikt Meurer wrote: https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85 test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85: TEST_P(LogicalTest, Parameter) { My

[v8-dev] [v8] r23133 committed - Tagging version 3.28.72

2014-08-14 Thread codesite-noreply via v8-dev
Revision: 23133 Author: machenb...@chromium.org Date: Thu Aug 14 18:39:17 2014 UTC Log: Tagging version 3.28.72 http://code.google.com/p/v8/source/detail?r=23133 Added: /tags/3.28.72 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Removed DCHECK to allow external code to check if v8 platform is initialized. (issue 476913002 by vitalyb...@chromium.org)

2014-08-14 Thread vitalybuka
Reviewers: Michael Achenbach (OOO), Yang, Description: Removed DCHECK to allow external code to check if v8 platform is initialized. DCHECK is not nessesary here, becase any V8::GetCurrentPlatform()- would crash anyway. BUG=403851 Please review this at

[v8-dev] Re: Issue 3266 in v8: Numeric issues in hyperbolic functions

2014-08-14 Thread codesite-noreply via v8-dev
Comment #9 on issue 3266 by r...@chromium.org: Numeric issues in hyperbolic functions http://code.google.com/p/v8/issues/detail?id=3266 For the inverse hyperbolics, see the following for fdlibm implementations: https://code.google.com/p/v8/issues/detail?id=3496

[v8-dev] Issue 3512 in v8: Inconsistent printing of denormal floats

2014-08-14 Thread codesite-noreply via v8-dev
Status: New Owner: New issue 3512 by r...@chromium.org: Inconsistent printing of denormal floats http://code.google.com/p/v8/issues/detail?id=3512 First, consider the following utility functions: function _DoubleHi(f) { // Return the most significant 32 bits of a double float

[v8-dev] Re: Issue 2589 in v8: line and column property for syntax errors

2014-08-14 Thread codesite-noreply via v8-dev
Comment #4 on issue 2589 by apatte...@gmail.com: line and column property for syntax errors http://code.google.com/p/v8/issues/detail?id=2589 Consider exposing all the information available through the V8::Message class, not just line and column. I would particularly like to see

[v8-dev] Issue 3513 in v8: Test runner does not work with new Test262 format

2014-08-14 Thread codesite-noreply via v8-dev
Status: New Owner: New issue 3513 by sam.mi...@gmail.com: Test runner does not work with new Test262 format http://code.google.com/p/v8/issues/detail?id=3513 Test262 test frontmatter format has changed, see https://github.com/tc39/test262/pull/51 Current code in

[v8-dev] Re: Issue 3513 in v8: Test runner does not work with new Test262 format

2014-08-14 Thread codesite-noreply via v8-dev
Comment #1 on issue 3513 by sam.mi...@gmail.com: Test runner does not work with new Test262 format http://code.google.com/p/v8/issues/detail?id=3513 Current status: can run test262 tests on Windows 7 using ActivePython. Many errors due to 'runTestCase is not defined' (i.e., includes do

[v8-dev] Re: Extend CPU profiler with mapping ticks to source lines (issue 424973004 by weiliang....@intel.com)

2014-08-14 Thread denis . pravdin
On 2014/08/13 08:55:39, Weiliang wrote: rebased + addressed comments PTAL Please take a look at the patch. Thanks. https://codereview.chromium.org/424973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Issue 3514 in v8: Message::GetLineNumber() returns 0 when it's called at the first time

2014-08-14 Thread codesite-noreply via v8-dev
Status: New Owner: CC: hara...@chromium.org, dcar...@chromium.org, joc...@chromium.org Labels: Type-Bug Priority-Medium New issue 3514 by hara...@chromium.org: Message::GetLineNumber() returns 0 when it's called at the first time http://code.google.com/p/v8/issues/detail?id=3514

[v8-dev] Re: Issue 3514 in v8: Message::GetLineNumber() returns 0 when it's called at the first time

2014-08-14 Thread codesite-noreply via v8-dev
Comment #1 on issue 3514 by hara...@chromium.org: Message::GetLineNumber() returns 0 when it's called at the first time http://code.google.com/p/v8/issues/detail?id=3514 See this CL (https://codereview.chromium.org/469253004/) for a concrete example. Correct URL is this one:

<    1   2