lgtm
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
LGTM, no performance impact.
https://codereview.chromium.org/1323993004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1328003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1320893002/diff/1/src/heap/heap.cc#newcode6540
src/heap/heap.cc:6540: if (concurrent_unmaping_tasks_active_ 0) {
On 2015/08/27 11:37:41, Michael Lippautz wrote:
We
Reviewers: Michael Lippautz,
Description:
Synchronize on concurrent slot buffer entries during migration.
BUG=chromium:524425
LOG=n
Please review this at https://codereview.chromium.org/1314133004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+76, -13 lines):
lgtm
https://codereview.chromium.org/1305163007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
I am not a big fan of the involved complexity, but the alternatives are
also not
great. So LGTM.
Please describe in detail what the semantics are and what may happen in
different situation involving incremental marking, scavenges, full gc...
lgtm (rubber-stamped)
https://codereview.chromium.org/1314383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
cool, lgtm
https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc
File test/cctest/test-spaces.cc (right):
https://codereview.chromium.org/1322523004/diff/1/test/cctest/test-spaces.cc#newcode444
test/cctest/test-spaces.cc:444: TEST(CompactionSpaceUsingExternal) {
https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h#newcode1231
src/heap/heap.h:1231: void public_set_code_stub_context(Object* value) {
On 2015/08/27 09:27:48, Michael Starzinger
lgtm, after beautifying the names
https://codereview.chromium.org/1320843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
LGTM
https://codereview.chromium.org/1314493007/diff/80001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1314493007/diff/80001/src/heap/spaces.cc#newcode1004
src/heap/spaces.cc:1004: void
PagedSpace::MergeCompactionSpace(CompactionSpace* other) {
Nice!
Reviewers: Michael Lippautz,
Description:
Wait for concurrent unmapping tasks in GC prologue.
BUG=chromium:525372
LOG=n
Please review this at https://codereview.chromium.org/1320893002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+19, -8 lines):
M
https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1320843002/diff/1/src/heap/heap.h#newcode1231
src/heap/heap.h:1231: void public_set_code_stub_context(Object* value) {
These are not real setters. Hence, they should
lgtm
https://codereview.chromium.org/1314433004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc#newcode4510
src/heap/mark-compact.cc:4510: (object-IsHeapObject()
heap-InNewSpace(object)) ||
On
This code is tricky! Small fix.
https://codereview.chromium.org/1313383005/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1313383005/diff/40001/src/heap/mark-compact.cc#newcode4533
src/heap/mark-compact.cc:4533:
lgtm, one test nit
https://codereview.chromium.org/1314953004/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1314953004/diff/20001/test/cctest/test-heap.cc#newcode710
test/cctest/test-heap.cc:710: i::FLAG_always_compact = true;
The
I am a bit worried about the complexity of the current approach.
In principle, we could have to pairs of flags in heap
scavenge_gc_callback_flags and scavenge_gc_flags (set when scavenge is
performed)
mark_compact_gc_callback_flags and mark_compact_gc_flags (set when
incremental
marking is
https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1314433004/diff/1/src/heap/heap.cc#newcode480
src/heap/heap.cc:480: void Heap::ClearAllKeyedStoreICs() {
I do not like that heap owns this method. It has no heap
-InNewSpace(object)) ||
+!Page::FromAddress(reinterpret_castAddress(object))
+ -IsEvacuationCandidate() ||
!heap-mark_compact_collector()-IsSlotInLiveObject(
reinterpret_castAddress(slot))) {
+ // TODO(hpayer): Instead of replacing
Reviewers: Michael Lippautz,
Description:
Don't explicitly tear down code range in cctest/test-alloc/CodeRange to
avoid
double-free.
BUG=v8:4141
LOG=n
Please review this at https://codereview.chromium.org/1312213007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
done
https://codereview.chromium.org/1312213007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
Synchronize on concurrent store buffer entries.
BUG=chromium:524425
LOG=n
Please review this at https://codereview.chromium.org/1313313002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+33, -3 lines):
M
MarkCompactCollector::ClearMarkbits() {
}
+class MarkCompactCollector::CompactionTask : public v8::Task {
+ public:
+ explicit CompactionTask(Heap* heap) : heap_(heap) {}
+
+ virtual ~CompactionTask() {}
+
+ private:
+ // v8::Task overrides.
+ void Run() override {
+// TODO(hpayer
lgtm
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1314863003/diff/40001/src/heap/heap.cc#newcode825
src/heap/heap.cc:825: Heap::kMakeHeapIterableMask |
Heap::kReduceMemoryFootprintMask,
Let's rename this
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/1/src/heap/heap.h#newcode1399
src/heap/heap.h:1399: void StartIncrementalMarking(int gc_flags,
Can we make change the int gc_flags to an enum, you can
lgtm
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1313023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm, one nit
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1314853002/diff/60001/src/heap/heap.h#newcode1681
src/heap/heap.h:1681:
The local variable is just used within heap. The getter/setter are not
rubber-stamped LGTM
https://codereview.chromium.org/1307413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: Michael Lippautz,
Description:
Allow more scavenges during idle times by pushing down the idle new space
limit.
BUG=
Please review this at https://codereview.chromium.org/1313083002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+33, -17 lines):
LGTM, one nit
https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):
https://codereview.chromium.org/1312503004/diff/20001/src/heap/gc-tracer.cc#newcode475
src/heap/gc-tracer.cc:475: PrintF(promoted=% V8_PTR_PREFIX d ,
lgtm
https://codereview.chromium.org/130005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
Re-land Concurrently unmap free pages.
BUG=
Please review this at https://codereview.chromium.org/1306183003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+126, -30 lines):
M src/heap/heap.h
M src/heap/heap.cc
M
lgtm
https://codereview.chromium.org/1314603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1306183003/diff/60001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1306183003/diff/60001/src/heap/spaces.cc#newcode80
src/heap/spaces.cc:80: code_range_(NULL),
On 2015/08/24 13:43:12, Michael Lippautz wrote:
add
Cool, a ton of more work left...
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24
super awesome! can we add some comment sections c.f.
compiler/code-generator.h ?
https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1312503004/diff/1/src/heap/heap.h#newcode1232
src/heap/heap.h:1232: #ifdef
lgtm
https://codereview.chromium.org/1301963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
Concurrently unmap free pages.
BUG=
Please review this at https://codereview.chromium.org/1303263002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+56, -5 lines):
M src/heap/heap.h
M src/heap/heap.cc
M
https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1303263002/diff/20001/src/heap/heap.cc#newcode6664
src/heap/heap.cc:6664:
On 2015/08/21 12:28:58, Michael Lippautz wrote:
-line
Done.
lgtm
https://codereview.chromium.org/1306053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1309733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1300333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm, with one comment
https://codereview.chromium.org/1302273002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1302273002/diff/20001/src/heap/heap.cc#newcode743
src/heap/heap.cc:743: CollectAllGarbage(Heap::kNoGCFlags, GC
interrupt,
Pass current
Reviewers: Michael Lippautz,
Description:
Record slots in large objects.
BUG=
Please review this at https://codereview.chromium.org/1296713007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+47, -28 lines):
M src/heap/gc-tracer.h
M src/heap/gc-tracer.cc
M
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h
File test/cctest/cctest.h (right):
https://codereview.chromium.org/1296713007/diff/40001/test/cctest/cctest.h#newcode559
test/cctest/cctest.h:559: bool complete = true) {
On 2015/08/20 11:14:39, Michael Lippautz wrote:
Reviewers: Michael Lippautz,
Description:
Large objects do not require special handling anymore when they are freed.
Invalid slots in large objects can only occur when large objects became
dead.
These slots are filtered out already after marking.
BUG=
Please review this at
lgtm
https://codereview.chromium.org/1292963006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz,
Description:
Don't filter store buffer after sweeping.
Additionally, this CL moves a bit of code around to free up more memory
before
compaction starts.
BUG=
Please review this at https://codereview.chromium.org/1305733003/
Base URL:
heap: lgtm
https://codereview.chromium.org/1294513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1303443005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm, nits attached
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
We
lgtm
https://codereview.chromium.org/1292583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
heap: lgtm
https://codereview.chromium.org/1297273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1298113003/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1298113003/diff/40001/include/v8.h#newcode4963
include/v8.h:4963: kGCTypeIncremental = 1 2,
kGCTypeIncrementalMarking maybe?
Reviewers: Michael Lippautz,
Description:
Untangle slots buffer part 1: Make invalid slots filtering part of
MarkCompactCollector.
BUG=
Please review this at https://codereview.chromium.org/1295713004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+65, -75
lgtm
https://codereview.chromium.org/1293113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):
https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#oldcode287
src/heap/mark-compact.cc:287: void
lgtm
https://codereview.chromium.org/1290883004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h#newcode210
src/heap/mark-compact.h:210: INLINE(bool PushBlack(HeapObject* object))
{
On 2015/08/14
lgtm after fixing build error.
Moreover, set BUG= to BUG=chromium:507137
https://codereview.chromium.org/1284413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h#newcode765
src/heap/mark-compact.h:765: friend class MarkCompactMarkingVisitor;
Since you are
Reviewers: Michael Lippautz,
Description:
Only evacuation candidate pages have a slots buffer, just visit these pages
when
filtering slots.
BUG=
Please review this at https://codereview.chromium.org/1299623003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
CheckDetachedContextsAfterGC();
@@ -1307,9 +1290,6 @@ class Isolate {
unibrow::Mappingunibrow::Ecma262Canonicalize
interp_canonicalize_mapping_;
CallInterfaceDescriptorData* call_descriptor_data_;
base::RandomNumberGenerator* random_number_generator_;
- // TODO(hpayer): Remove the following store buffer
lgtm
https://codereview.chromium.org/1290403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc#newcode1410
src/heap/spaces.cc:1410:
heap()-incremental_marking()-Step(bytes_allocated,
On 2015/08/14 15:26:18,
lgtm
https://codereview.chromium.org/1294093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Filter out slot buffer slots, that point to SMIs in dead objects.
The following situation may happen which reproduces this bug:
(1) We allocate JSObject A on an evacuation candidate.
(2) We allocate JSObject B on a non-evacuation candidate.
(3) Incremental marking
lgtm
https://codereview.chromium.org/1288413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/14 12:44:36, Michael Lippautz wrote:
lgtm, I like it. Let's wait for Hannes.
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
On 2015/08/13 07:35:46, Benedikt Meurer wrote:
Committed patchset #1 (id:1) manually as
2c5b69d85124021a39849d98960a39bdf1cece47.
The idea of owner files is getting owner reviews, so that failed already on
that
level.
https://codereview.chromium.org/1293453002/
--
--
v8-dev mailing list
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h#newcode208
src/heap/mark-compact.h:208: void DecrementLiveBytes(HeapObject*
object);
This method does not
On 2015/08/13 14:41:56, rmcilroy wrote:
On 2015/08/13 13:59:32, rmcilroy wrote:
lgtm.
Hannes: could you stamp for OWNERS please?
Lgtm
https://codereview.chromium.org/1288893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc#newcode1410
src/heap/spaces.cc:1410:
heap()-incremental_marking()-Step(bytes_allocated,
Calling step is is a no-op in this
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (left):
https://codereview.chromium.org/1284853003/diff/20001/src/heap/spaces.h#oldcode2655
src/heap/spaces.h:2655: // Creates an old space object with a given
maximum capacity.
On 2015/08/11
lgtm
https://codereview.chromium.org/1282503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Lippautz, Michael Starzinger,
Description:
Respect old generation limit in large object space allocations.
Also remove unused max_capcity_ field in old spaces.
BUG=chromium:518028,chromium:504854
Please review this at https://codereview.chromium.org/1284853003/
Base URL:
Awesome! LGTM
https://codereview.chromium.org/1272933004/diff/1/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/1272933004/diff/1/src/objects.cc#oldcode30
src/objects.cc:30: #include src/heap/objects-visiting-inl.h
yey!
https://codereview.chromium.org/1272933004/
https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1284853003/diff/40001/src/heap/spaces.cc#newcode2848
src/heap/spaces.cc:2848: heap()-incremental_marking()-IsStopped()
We cannot allow incremental marking
This is great! LGTM!
https://codereview.chromium.org/1281233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM
https://codereview.chromium.org/1278413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/40001/src/interpreter/interpreter.cc#newcode43
src/interpreter/interpreter.cc:43: if (initialized_) return;
What is
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1278413002/diff/60001/src/interpreter/interpreter.cc#newcode41
src/interpreter/interpreter.cc:41: void Interpreter::Initialize(bool
lgtm
https://codereview.chromium.org/1281923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1285543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1277943003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc#newcode3615
src/heap/mark-compact.cc:3615: if (!p-IsEvacuationCandidate()
On 2015/08/04 07:45:57,
On 2015/08/07 12:56:14, Michael Starzinger wrote:
Dead code is being dead.
Lgtm lol
https://codereview.chromium.org/1278113004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
On 2015/08/07 13:02:01, titzer wrote:
On 2015/08/07 13:00:08, Michael Starzinger wrote:
Dead code is being dead.
lgtm
Lgtm
https://codereview.chromium.org/1281903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
On 2015/08/07 13:02:01, titzer wrote:
On 2015/08/07 13:00:08, Michael Starzinger wrote:
Dead code is being dead.
lgtm
Lgtm
https://codereview.chromium.org/1281903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM. There is more clean-up work left...
https://codereview.chromium.org/1279043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
LGTM
https://codereview.chromium.org/1280703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#newcode2239
src/heap/mark-compact.cc:2239: IncrementalMarking* incremental_marking =
https://codereview.chromium.org/1273953004/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1273953004/diff/40001/src/heap/mark-compact.cc#newcode816
src/heap/mark-compact.cc:816: heap()-incremental_marking()-Stop();
in that case, stop
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#oldcode2245
src/heap/mark-compact.cc:2245: incremental_marking-Stop();
stop is now not called for
On 2015/08/07 11:40:20, Michael Starzinger wrote:
Lgtm :)
https://codereview.chromium.org/1269313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2015/08/07 12:22:42, ulan wrote:
LGTM, good catch!
Lgtm
https://codereview.chromium.org/1270393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
1 - 100 of 2121 matches
Mail list logo
