[v8-dev] Re: Fix sourceURL sourceMapURL handling in case of background parsing (issue 821723002 by serg...@chromium.org)

2014-12-24 Thread sergeyv
https://codereview.chromium.org/821723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: Fix sourceURL sourceMapURL handling in case of background parsing (issue 821723002 by serg...@chromium.org)

2014-12-23 Thread sergeyv
Reviewers: yurys, Message: On 2014/12/23 12:32:22, yurys wrote: Looks fine but needs a test. Tests were added Description: Fix sourceURL sourceMapURL handling in case of background parsing BUG= Please review this at https://codereview.chromium.org/821723002/ Base URL:

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread sergeyv
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170 include/v8-debug.h:170: // Check if a debugger break is scheduled in the given isolate On 2014/08/17 21:38:16,

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-18 Thread sergeyv
On 2014/08/18 12:25:41, Yang wrote: On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote: No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star

[v8-dev] Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-14 Thread sergeyv
Reviewers: vsevik, yurys, aandrey, Description: Expose function CheckDebugBreak in the debugger api It is needed by blink change: https://codereview.chromium.org/473923002 BUG= Please review this at https://codereview.chromium.org/473913002/ SVN Base:

[v8-dev] Re: Expose function CheckDebugBreak in the debugger api (issue 473913002 by serg...@chromium.org)

2014-08-14 Thread sergeyv
+yangguo, Please take a look https://codereview.chromium.org/473913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop