re-refactored ;-)
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #4 manually as 23188 (presubmit successful).
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Ok, I've looked into this again, and I think you are right. We can avoid the
possible name collision using an anonymous namespace, i.e.
namespace {
class MyTest : public InstructionSelectorTestWithParamParamType {};
TEST_P(MyTest, A) {...}
TEST_P(MyTest, B) {...}
}
On 2014/08/18 06:38:20, Benedikt Meurer wrote:
Ok, I've looked into this again, and I think you are right. We can avoid
the
possible name collision using an anonymous namespace, i.e.
namespace {
class MyTest : public InstructionSelectorTestWithParamParamType {};
TEST_P(MyTest, A)
LGTM
You can land TF changes even while the tree is throttled.
https://codereview.chromium.org/475823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
File
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc
(right):
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85:
TEST_P(LogicalTest, Parameter) {
My understanding was that the name will be concatenated
On 2014/08/14 at 18:31:07, Benedikt Meurer wrote:
https://codereview.chromium.org/475823002/diff/1/test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc#newcode85
test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc:85:
TEST_P(LogicalTest, Parameter) {
My
11 matches
Mail list logo
