Committed patchset #2 manually as 23227 (presubmit successful).
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/08/17 17:38:16, aandrey wrote:
lgtm
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
File include/v8-debug.h (right):
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
include/v8-debug.h:170: // Check if a debugger break is scheduled
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
File include/v8-debug.h (right):
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
include/v8-debug.h:170: // Check if a debugger break is scheduled in the
given isolate
On 2014/08/17 21:38:16,
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/serg...@chromium.org/473913002/20001
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See
On 2014/08/18 12:25:41, Yang wrote:
On 2014/08/18 12:24:44, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star
lgtm
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h
File include/v8-debug.h (right):
https://codereview.chromium.org/473913002/diff/1/include/v8-debug.h#newcode170
include/v8-debug.h:170: // Check if a debugger break is scheduled in the
given isolate
nit: dot at the end
lgtm
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
+yangguo, Please take a look
https://codereview.chromium.org/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://chromiumcodereview.appspot.com/473913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
11 matches
Mail list logo
