Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-13 Thread Robie Basak
On Tue, Jun 13, 2017 at 03:18:27PM +0100, Ian Jackson wrote: > Robie Basak writes ("Re: "git ubuntu" wrappers [was: What to do with .git > directories in source package uploads?]"): > > I disagree here. We don't need to "hope". I don't expect the build to > > see the importer's git history. It

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-13 Thread Robie Basak
On Tue, Jun 13, 2017 at 03:04:46PM +0100, Robie Basak wrote: > 1. The imported git trees are defined to escape /^\.git.*/ by > prepending a '.'. It just occurred to me that this would also escape '.gitignore' to '..gitignore', which personally I'd like, but others might find surprising. So

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-13 Thread Ian Jackson
Robie Basak writes ("Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]"): > I disagree here. We don't need to "hope". I don't expect the build to > see the importer's git history. It should be invisible to the build > process, and I intend to make our

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-12 Thread Robie Basak
On Mon, Jun 12, 2017 at 05:46:14PM +0100, Ian Jackson wrote: > Again, I don't follow why `fail' occurs. You seem to be suggesting > that importing a .dsc containing a .git would generate ..git. Correct. I'm suggesting "fail" for the round-tripping - for "git ubuntu build-source" to "unescape"

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-12 Thread Ian Jackson
Robie Basak writes ("Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]"): > I don't really follow what you're saying. Are you saying that wrapping > these types of things in general is bad, or that having a wrapper for > the specific case of unescaping

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-12 Thread Robie Basak
On Mon, Jun 12, 2017 at 04:57:06PM +0100, Ian Jackson wrote: > `dgit clone' disables these .gitattributes; provides a separate verb > for disabling them in other trees; and `dgit fetch' warns about them > if it finds them. So...you have a wrapper? I don't really follow what you're saying. Are

Re: "git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-12 Thread Ian Jackson
Robie Basak writes (""git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]"): > Some examples: > > Upstreams that ship .gitignore confuses distribution developers (IMHO) > who want to see *everything* that has changed. I'd like to work with git > upstream in

"git ubuntu" wrappers [was: What to do with .git directories in source package uploads?]

2017-06-12 Thread Robie Basak
On Mon, Jun 12, 2017 at 04:31:48PM +0100, Ian Jackson wrote: > Robie Basak writes ("Re: What to do with .git directories in source package > uploads?"): > > In mitigation, we have "build" and "build-source" wrappers that could > > always do the correct unescaping here. Then you'd only fall into