Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Edward Warnicke
Neale, Could this be hitting the same /32 issue I'm in the process of fixing with https://gerrit.fd.io/r/c/vpp/+/33495 ? If the interface has an IPv6 /32 assigned... it would be IPv6 enabled, but fib_sas would fail to get its source address, ND would fail, and we'd hit the SEGV we are seeing on

[vpp-dev] BFD developers on VPP

2021-08-20 Thread satish amara
Hi, I see VPP supports BFD on VPP. Any plans when multi-hop is supported. I would like to have a BFD session with a remote peer that could be multiple hops away. FD.io VPP: BFD module "Bidirectional Forwarding Detection in VPP currently

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Edward Warnicke
Got it. That makes sense :) Ed On Fri, Aug 20, 2021 at 9:58 AM Neale Ranns wrote: > Hi Ed, > > > > When creating an adjacency for the first time we send out a probe packet > (ARP/ND) to see if the peer will resolve it. > > > > /neale > > > > *From: *Ed Warnicke > *Date: *Friday, 20 August

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Neale Ranns
Hi Ed, When creating an adjacency for the first time we send out a probe packet (ARP/ND) to see if the peer will resolve it. /neale From: Ed Warnicke Date: Friday, 20 August 2021 at 16:54 To: Neale Ranns Cc: zsta...@gmail.com , Artem Glazychev , vpp-dev Subject: Re: [vpp-dev] Adding new

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Edward Warnicke
Neale, Question... looking at the trace it looks like we are having an issue with fib_sas6_get ... could you help me understand why we are calling fib_sas6_get in this situation? Ed On Fri, Aug 20, 2021 at 9:49 AM Neale Ranns wrote: > > > Hi Ed, > > > > It does. But in this case the command

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Neale Ranns
Hi Ed, It does. But in this case the command is adding a route through an interface, which is not the same as configuring a prefix on an interface (nor ip6 enabling it). /neale From: Ed Warnicke Date: Friday, 20 August 2021 at 16:40 To: Neale Ranns Cc: zsta...@gmail.com , Artem Glazychev

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Edward Warnicke
Neale, I'm a bit confused... I had previously thought that *adding* an IPv6 address to a link *did* IPv6 enable it... Ed On Fri, Aug 20, 2021 at 9:20 AM Neale Ranns wrote: > Hi Artem, Stanislav, > > > > I agree graceful handling is needed, return false if there is no link > local. > > > > If

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Neale Ranns
Hi Stanislav, Excellent, thank you! /neale From: Stanislav Zaikin Date: Friday, 20 August 2021 at 16:38 To: Neale Ranns Cc: Artem Glazychev , vpp-dev Subject: Re: [vpp-dev] Adding new route via ipv6 link-local Hi Neale, If there are no volunteers, there's the patch:

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Stanislav Zaikin
Hi Neale, If there are no volunteers, there's the patch: https://gerrit.fd.io/r/c/vpp/+/33558 On Fri, 20 Aug 2021 at 16:20, Neale Ranns wrote: > Hi Artem, Stanislav, > > > > I agree graceful handling is needed, return false if there is no link > local. > > > > If you enabled ip6 on the link

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Neale Ranns
Hi Artem, Stanislav, I agree graceful handling is needed, return false if there is no link local. If you enabled ip6 on the link first, this wouldn’t be a problem. The link will need to be ip6 enabled if you want something to reply. /neale From: vpp-dev@lists.fd.io on behalf of Stanislav

Re: [vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Stanislav Zaikin
Hello Artem, Looks like we need (at least) to add a check for nullptr. DBGvpp# create tap tap0 DBGvpp# set interface state tap0 up DBGvpp# ip route add fa::1/120 via fe80::1 tap0 Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault. 0x7774ba90 in ip6_address_copy

[vpp-dev] Adding new route via ipv6 link-local

2021-08-20 Thread Artem Glazychev
Hello, Found a crash: if we add the route via fe80:: *after* the interface upping - vpp crashes. For example: DBGvpp# create tap tap0 DBGvpp# set int state tap0 up DBGvpp# ip route add fa::1/120 via fe80::1 tap0 make: *** [Makefile:537: run] Aborted If we swap *set ... up* and *ip route