Re: [vpp-dev] assert in pool_elt_at_index

2021-10-21 Thread Benoit Ganne (bganne) via lists.fd.io
Hi Stanilas, Yes there is a constant stream of fixes for AddressSanitizer as it is not in CI/CD yet. I'd suggest you try to reproduce your issue with VPP master instead, because the initial crash you reported might have been fixed in master. If it is fixed, you can then git bisect to find the

Re: [vpp-dev] assert in pool_elt_at_index

2021-10-21 Thread Stanislav Zaikin
Hi Benoit, I've tried but got this crash. Maybe some fixes were merged to handle this issue? (I'm using 21.01 + additional patches from the master) Program received signal SIGSEGV, Segmentation fault. 0x0042c037 in __asan::FakeStack::AddrIsInFakeStack(unsigned long, unsigned long*,

Re: [vpp-dev]: SIGSEV in mpls_tunnel_collect_forwarding

2021-10-21 Thread Rajith PR via lists.fd.io
Thanks Neale and Stanislav. I verified the patch provided, there is no crash now. On Thu, Oct 21, 2021 at 10:08 PM Neale Ranns wrote: > Hi Rajith, > > > > Can you try this: > > https://gerrit.fd.io/r/c/vpp/+/34200 > > > > I think Stanislav’s solution would also work, but it would mean a

Re: [vpp-dev]: SIGSEV in mpls_tunnel_collect_forwarding

2021-10-21 Thread Neale Ranns
Hi Rajith, Can you try this: https://gerrit.fd.io/r/c/vpp/+/34200 I think Stanislav’s solution would also work, but it would mean a no-op restack for the tunnel. Not walking the new child is more efficient. /neale From: vpp-dev@lists.fd.io on behalf of Stanislav Zaikin via lists.fd.io

Re: [vpp-dev]: SIGSEV in mpls_tunnel_collect_forwarding

2021-10-21 Thread Stanislav Zaikin
Hi Rajith, Looks like each tunnel uses the same path-list (and different path extensions), and when the path has more than FIB_PATH_LIST_POPULAR (64) children - it updates all the children with that "popular" flag. And at that point there are no path extensions yet on the last child. So, I