Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-26 Thread Daniel Stone
Hi Jasper, On Thu, 26 Jul 2018 at 03:53, Jasper St. Pierre wrote: > From IRC conversations with krh a long time ago, this is indeed intentional > and the cursor surface should "lose its role" in modern parlance. > > The original intention was to prevent glitching of the cursor surface. e.g. >

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-25 Thread Jasper St. Pierre
Hi, >From IRC conversations with krh a long time ago, this is indeed intentional and the cursor surface should "lose its role" in modern parlance. The original intention was to prevent glitching of the cursor surface. e.g. If the left side of the surface has a resize left cursor, you leave, and

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-24 Thread Daniel Stone
Hey, On Tue, 24 Jul 2018 at 22:45, Derek Foreman wrote: > On 2018-07-22 05:55 AM, Daniel Stone wrote: > > I take it the problem is that the client sets a particular surface as > > the pointer surface, loses focus, sets the same surface as the pointer > > surface on re-enter after not changing

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-24 Thread Derek Foreman
On 2018-07-22 05:55 AM, Daniel Stone wrote: > Hey Derek, > > On Thu, 22 Feb 2018 at 22:16, Derek Foreman wrote: >> Keep track of what cusor image buffer is attached to the cursor >> surface and avoid re-attaching it if we don't have to. >> >> This isn't just an obviously pointless optimization,

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-22 Thread Daniel Stone
Hey Derek, On Thu, 22 Feb 2018 at 22:16, Derek Foreman wrote: > Keep track of what cusor image buffer is attached to the cursor > surface and avoid re-attaching it if we don't have to. > > This isn't just an obviously pointless optimization, it turns all > of toy toolkit into a test case for

[RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-02-22 Thread Derek Foreman
Keep track of what cusor image buffer is attached to the cursor surface and avoid re-attaching it if we don't have to. This isn't just an obviously pointless optimization, it turns all of toy toolkit into a test case for handling this properly. Signed-off-by: Derek Foreman