Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 08a6948cfbbf41fa5168a7a53d1c7669ec5ec676
https://github.com/WebKit/WebKit/commit/08a6948cfbbf41fa5168a7a53d1c7669ec5ec676
Author: Philippe Normand <ph...@igalia.com>
Date: 2023-02-22 (Wed, 22 Feb 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp
M
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.h
Log Message:
-----------
[GStreamer][WebRTC] Fixes for disabled audio tracks
https://bugs.webkit.org/show_bug.cgi?id=252399
Reviewed by Xabier Rodriguez-Calvar.
We should not interrupt the data flow when an outgoing media track has been
disabled.
`MediaStreamTrack::enabled` is like muted, but it's a state that can be changed
by the app, in
opposition with muted. So there's no need for a valve element in outgoing
sources.
This patch also refactors silent/black samples pushing code in the
mediastreamsrc element, some of
it was previously unsafe. And we make sure that outgoing buffers always have a
valid PTS and DTS.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType):
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::RealtimeOutgoingMediaSourceGStreamer):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::~RealtimeOutgoingMediaSourceGStreamer):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::start):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::stop):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::sourceMutedChanged):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::sourceEnabledChanged):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::initializeFromTrack):
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::teardown):
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::teardown):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::startUpdatingStats):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::stopUpdatingStats):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::sourceEnabledChanged):
*
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.h:
Canonical link: https://commits.webkit.org/260669@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
