Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1606ea8ade0f444e257a9e0967faf9b57c7ec31f https://github.com/WebKit/WebKit/commit/1606ea8ade0f444e257a9e0967faf9b57c7ec31f Author: Jonathan Bedard <jbed...@apple.com> Date: 2023-03-30 (Thu, 30 Mar 2023)
Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: ----------- [ews-build.webkit.org] Allow for PRs comprised of cherry-picks to include multiple commits https://bugs.webkit.org/show_bug.cgi?id=254701 rdar://107391286 Reviewed by Aakash Jain. Since cherry-picks nessesarily come from elsewhere in the repository, each cherry-pick has already been verified to build somewhere. While the previous statement may not apply to the current branch (a commit may rely on code which does not exist on a branch), it is exceptionally rare for a cherry-pick failure to be fixed by another cherry-pick. This means that if a sequence of cherry-picks passes EWS, it is very likely that each individual component of that sequence would pass EWS in isolation. To facilitate faster repository management, merge-queue should permit patch series which are comprised entirely of cherry-picks. * Tools/CISupport/ews-build/steps.py: (ValidateSquashed.evaluateCommand): If a PR is comprised entirely of cherry-picks, allow a PR with multiple commits to be landed. Note that we need to let Canonicalize know how many commits are going to be landed, because it can no longer safely assume "1". (AddReviewerToCommitMessage.doStepIf): If a change is classified as a cherry-pick, we do not want to add reviewers. (Canonicalize.number_commits_to_canonicalize): Return the number of commits to be canonicalized. (Canonicalize.run): Use number_commits_to_canonicalize to determine how many commits to canonicalize. (Canonicalize.getResultSummary): Ditto. (UpdatePullRequest.run): Update pull-request which contains multiple commits. * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/262340@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes