Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75f3ded86715b6a6ab4c4e750a005fae5f9b8e8e https://github.com/WebKit/WebKit/commit/75f3ded86715b6a6ab4c4e750a005fae5f9b8e8e Author: Aditya Keerthi <akeer...@apple.com> Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/css/appearance-apple-pay-button-div-expected.html A LayoutTests/fast/css/appearance-apple-pay-button-div.html A LayoutTests/fast/css/appearance-apple-pay-button-inapplicable-expected.html A LayoutTests/fast/css/appearance-apple-pay-button-inapplicable.html A LayoutTests/fast/css/appearance-apple-pay-button-input-type-button-expected.html A LayoutTests/fast/css/appearance-apple-pay-button-input-type-button.html M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WebCore/rendering/RenderTheme.cpp Log Message: ----------- Exclude -apple-pay-button from applying to any element that supports appearance: auto and is not a button https://bugs.webkit.org/show_bug.cgi?id=272366 rdar://126107516 Reviewed by Tim Nguyen. `appearance: -apple-pay-button` is non-standard, and must be maintained for compatibility. However, it is not necessary for elements that already have an `auto` appearance, and are not buttons, to support the non-standard value. * LayoutTests/TestExpectations: * LayoutTests/fast/css/appearance-apple-pay-button-div-expected.html: Added. * LayoutTests/fast/css/appearance-apple-pay-button-div.html: Added. * LayoutTests/fast/css/appearance-apple-pay-button-inapplicable-expected.html: Added. * LayoutTests/fast/css/appearance-apple-pay-button-inapplicable.html: Added. * LayoutTests/fast/css/appearance-apple-pay-button-input-type-button-expected.html: Added. * LayoutTests/fast/css/appearance-apple-pay-button-input-type-button.html: Added. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustAppearanceForElement const): Ensure that `appearance: -apple-pay-button` remains supported on buttons and element's that do not have an `auto` appearance, like `<div>`. `<input>` with no `auto` appearance are excluded. This covers the `hidden`, `file`, and `image` types, which have no requirement to support `appearance: -apple-pay-button`. Canonical link: https://commits.webkit.org/277268@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes